Commit Graph
81781 Commits
Author SHA1 Message Date
Android Build Coastguard Worker cb2f63b05e Snap for 13340456 from 5e619cd675 to 25Q3-release
Change-Id: If6937e001d347cebf8f0e64d80570a2b34a179f9
2025-04-10 16:22:08 -07:00
Alex Chau 5e619cd675 Merge "Provides displayContext instead of windowContext for RotationTouchHelper" into main 2025-04-10 07:39:15 -07:00
Alex Chau e246b3273b Provides displayContext instead of windowContext for RotationTouchHelper
- Also limit usage of displayContext on getWindowCornerRadius only, any other usage causes perf regression
- Note that displayContext does not respond to configuration changes, there might be existing functionality bug already that resources are stale after configuration changes, keeping b/408988616 open to handle it in the future

Bug: 408988616
Fix: 409222870
Fix: 409252967
Test: presubmit and ABTD
Flag: EXEMPT refactor
Change-Id: I024c76326a2deb1ecc035de8319976e31887486b
2025-04-10 07:38:55 -07:00
Treehugger Robot c20a68eb4b Merge "Remove EnableHoverOfChildElementsInTaskview flag" into main 2025-04-10 06:30:38 -07:00
samcackett 68a21ed111 Remove EnableHoverOfChildElementsInTaskview flag
Fix: 409610713
Flag: EXEMPT. Flag removal
Test: N/A
Change-Id: Ifa924cb2011bb6e633ee5b79c17601be82b4a779
2025-04-10 10:59:54 +01:00
Uwais Ashraf 1fdb1dcbc0 Remove enable_use_top_visible_activity_for_exclude_from_recent_task flag
Fix: 409605610
Test: EXEMPT flag change
Flag: EXEMPT flag removal
Change-Id: I8459a4bc3345652f3b07e5dea97209e250e4f9b8
2025-04-10 02:32:12 -07:00
Sam Cackett bf69d6e6a5 Merge "Add TaskContentView wrapper to TaskThumbnailView" into main 2025-04-09 23:54:40 -07:00
Android Build Coastguard Worker b27fb7cbae Snap for 13335674 from 3726f6fe06 to 25Q3-release
Change-Id: I9404ce4f8a68a77f11b14dd98afeb82e6de1bfeb
2025-04-09 16:24:26 -07:00
Treehugger Robot b0d0d41a2a Merge "Use setLaunchedFromA11y when All Apps is launched from HomeScreen Menu." into main 2025-04-09 15:30:41 -07:00
Sebastián Franco 6f9ea0bebb Merge "Prevent non workspace items from being binded to the Workspace" into main 2025-04-09 14:55:27 -07:00
Brian Isganitis 8c6dd04740 Merge "Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher." into main 2025-04-09 13:33:40 -07:00
Anushree Ganjam bc640898aa Use setLaunchedFromA11y when All Apps is launched from HomeScreen Menu.
setLaunchedFromA11y makes keyboard not to be shown when "swipe to start search" toggle is off and we do launcher.getStateManager().goToState(ALL_APPS)

"All Apps" was added to Menu as part of A11y requirement in b/386737601, so using setLaunchedFromA11y looks right.

Video : https://b.corp.google.com/issues/407947978#comment9

Bug: 407947978
Test: Manual
Flag: EXEMPT Bugfix

Change-Id: I84162940330a74b3433f7835753151adf55857e7
2025-04-09 13:07:15 -07:00
Treehugger Robot 3726f6fe06 Merge "Reload visible task data when transitioning to Overview" into main 2025-04-09 12:05:35 -07:00
Sebastian Franco ff1936449e Prevent non workspace items from being binded to the Workspace
Bug: 407630150
Test: Manual testing, that's why the bug happen in the first place, working on adding tests, for now this fixes the issue.
Flag: EXEMPT bug fix
Change-Id: I98c9d4bb28a3f02ee6e54c66eadb54445c56aeec
2025-04-09 11:12:45 -07:00
Alex Chau abd2716fea Reload visible task data when transitioning to Overview
- When onPrepareGestureEndAnimation is called, we already know the end target is Overview, loading thumbnail at this point ensure thumbanil is loaded throughout the transition

Fix: 407525135
Flag: com.android.launcher3.enable_grid_only_overview
Test: Home/app to Overview with gesture/3button
Change-Id: Ie91d3989654ff17df94704275523ca097f786293
2025-04-09 17:39:07 +01:00
Stefan Andonian af3be84616 Merge "Match Folder Indicator Arrows according to specs." into main 2025-04-09 09:21:39 -07:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Perry Wu c5d8fbcb82 Merge "Add null check for checking intent component" into main 2025-04-09 08:29:25 -07:00
Vinay Joglekar 96590ffeb0 Merge "Fix unnecessary creation of surface transactions during setBaseSurface." into main 2025-04-09 02:50:18 -07:00
Graciela Putri 3d08afcbb9 Merge "Add displayId to back event" into main 2025-04-09 00:50:47 -07:00
vinayjoglekar 425b11fd9e Fix unnecessary creation of surface transactions during setBaseSurface.
Also swap surface only when required.

Fix: 404647629
Fix: 408937692
Test: Manual. Enter/Exit overview from home/app
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I1562ed11a14021565ec9b9560b7f0d7d2b1468c6
2025-04-09 08:24:35 +01:00
Treehugger Robot d9560b8f92 Merge "[Action Corner] Implement new LauncherProxy method in Launcher" into main 2025-04-08 23:23:05 -07:00
Treehugger Robot 1af8b49518 Merge "Use expressive dismiss when splitting tasks." into main 2025-04-08 16:27:15 -07:00
Android Build Coastguard Worker f621807c9e Snap for 13329326 from faded705d0 to 25Q3-release
Change-Id: I127c91b4d290cfa1d74750b7bd501b57a1fefbb6
2025-04-08 16:24:40 -07:00
Treehugger Robot f17d86902a Merge "Fix TaskbarSnapshot leak and ANR." into main 2025-04-08 15:44:43 -07:00
Sebastián Franco 59ae5808c7 Merge "Use LauncherActivityScenarioRule in BaseLauncherActivityTest" into main 2025-04-08 15:28:11 -07:00
Stefan Andonian fd5df85fb7 Match Folder Indicator Arrows according to specs.
Bug: 394355070
Test: Attached a screen recording of correct behavior to the bug.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I1e99c4eb9ae79b7d00dadf286689cceb2f0e706e
2025-04-08 15:16:32 -07:00
Brian Isganitis b7a5dc0017 Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher.
Flag: EXEMPT refactor
Fix: 407924023
Test: go/testedequals
Change-Id: I06344f023eb1fab697f25276bc82e1be0209e4a8
2025-04-08 17:17:15 -04:00
Pat Manning f9865debb7 Use expressive dismiss when splitting tasks.
Snap last grid task to hide clear all during scrolls as well.

Fix: 389081467
Test: TaplTestsSplitscreen
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I153b3dcacdf634358416f0793804c1c4c099a993
2025-04-08 22:07:36 +01:00
Jagrut Desai a89c52a0d1 Merge "Fix Taskbar Recents Item after unlock" into main 2025-04-08 13:29:00 -07:00
Treehugger Robot 049a8f608d Merge "Let TaskView.bind take GroupTask instead of Task" into main 2025-04-08 12:54:16 -07:00
Jon Miranda 9bc1b6687d Fix TaskbarSnapshot leak and ANR.
- Makes sure view is removed and set to null
- Makes sure draglayer is visible before trying
  to copy it to the snapshot. I wasn't able to repo
  the ANR, so will need to keep an eye on it once we
  re-enable the flag.

Test: open/close shade multiple times
      trigger launcher recreate by toggling dark theme
      no leak detected in AS
Fixes: 404331867
Bug: 408450275
Flag: com.android.launcher3.enable_taskbar_behind_shade
Change-Id: Ide375943214548b938953230e2140d4df23317df
2025-04-08 11:03:35 -07:00
Treehugger Robot faded705d0 Merge "Use DesktopModeFlags for Alt+Tab CD flags" into main 2025-04-08 10:57:16 -07:00
minch 42efd0c6cc Let TaskView.bind take GroupTask instead of Task
1. Introduce a `groupTask` property to `TaskView` and let all the
   `bind` functions take a type of `GroupTask` as the parameter
   instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
   `GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
   we can avoid the corresponding `deskId` being set to invalid
   on `removeViewInLayout` in the main thread, which might happen
   before `removeGroupTaskInternal`.

Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
2025-04-08 17:16:08 +00:00
Treehugger Robot 1f4ee92d18 Merge "Fix grammar issue with all set page subtitle" into main 2025-04-08 09:57:13 -07:00
Android Build Coastguard Worker 871b9b57f0 [coastguard skipped] Merge sparse cherrypicks from sparse-13312032-L93100030011030828 into 25Q3-release.
COASTGUARD_SKIP: I255052506e7d198b1384c15ebfe2f6f2753da1ed
COASTGUARD_SKIP: I37b462b5960a282231b937099d73ac64f589fd6d

Change-Id: I61544bf23cc0fd00e1ac8ffb07b4c24354bf1e2e
2025-04-08 09:54:02 -07:00
Android Build Coastguard Worker 6d71d9534f Merge cherrypicks of ['googleplex-android-review.googlesource.com/32899381'] into sparse-13312032-L93100030011030828.
SPARSE_CHANGE: I255052506e7d198b1384c15ebfe2f6f2753da1ed

Change-Id: I37b462b5960a282231b937099d73ac64f589fd6d
2025-04-08 09:53:06 -07:00
Sebastian Franco 81fb5d066a When updating workspace items, make sure to not process Folder icons as Workspace items.
Also, in Folder.java the DeviceProfile obtained using the activity,
in this case the Activity is TaskbarActivityContext is returning
a different DeviceProfile form the Launcher which causes the update.

So this triggers an update when is not needed but even if we make
a faulty update the workspace should be able to differentiate
between workspace item and folder items.

This issue was triggered by this flag
com.android.window.flags.enable_taskbar_recents_layout_transition .

Fix: 407630150
Test: NA
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:abcc99f01587f2185a0f49e86d34fcfc12d7b216)
Merged-In: I255052506e7d198b1384c15ebfe2f6f2753da1ed
Change-Id: I255052506e7d198b1384c15ebfe2f6f2753da1ed
2025-04-08 09:52:53 -07:00
Treehugger Robot b1e5175b76 Merge "Fix blur flash while moving from live tiles to static." into main 2025-04-08 09:50:06 -07:00
Sunny Goyal afd7e35e0d Merge "Moving IconProvider extensions to a separate subclass instead of routing via APIWrapper" into main 2025-04-08 09:46:28 -07:00
Treehugger Robot 5197cda3af Merge "Fix App Chip Menu position in RTL" into main 2025-04-08 09:42:53 -07:00
Treehugger Robot 3dd0f30ac5 Merge "Remove 5x grid from canBeDefault grids" into main 2025-04-08 09:35:20 -07:00
Jagrut Desai 065a5321a8 Fix Taskbar Recents Item after unlock
we simply fetch the icons at the same time we restore the previously show items.

Test: Manual
Bug: 407932962
Flag: EXEMPT bugfix
Change-Id: I83131ef034fe94583beee32aeeb3e908f07cfc6f
2025-04-08 09:01:59 -07:00
Ajinkya Chalke c86d27deec Use DesktopModeFlags for Alt+Tab CD flags
- Updated flags for both Alt+Tab on CD and KQS flatenning features.

Bug: 407954660
Test: m
Flag: EXEMPT only updated flag usage
Change-Id: If099138c65ae582837293c0929185f61e6f5f350
2025-04-08 15:14:42 +00:00
Schneider Victor-Tulias 02d9e5043a Fix grammar issue with all set page subtitle
Flag: EXEMPT bug fix
Fixes: 392616062
Test: launched all set page with empty and test devices names
Change-Id: I885603f64478642c825e15563f5526399114f0f2
2025-04-08 10:31:19 -04:00
Jordan Silva 1f9073a942 Fix App Chip Menu position in RTL
- Updated IconAppChipView and TaskMenuView to use `Gravity.START` when the layout is natural to launcher (i.e., not fake landscape).
- TaskMenuView updated to use Gravity.START when the layout is natural to launcher as well.
- Updated the RTL translationX for the TaskMenuView.
- Removed the reveal animation when expanding the chip. No longer necessary due to the marquee and horizontal fading.
- Fixed the reveal animation when collapsing the chip in RTL.

Fix: 409035162
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Using RTL, expand the app chip menu.
Change-Id: I9e7639a62a08133b3fd4a31a932ba65d03c65d53
2025-04-08 07:21:32 -07:00
vinayjoglekar d905645f1e Fix blur flash while moving from live tiles to static.
Fix : 406231674
Test: Manual. Dismiss live tile from Overview. Long press on live tile to invoke AiAi.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ibc4c472f9c26862a4dcf0993ab487a8e52062bcf
2025-04-08 14:42:56 +01:00
Graciela Wissen Putri b6488e052c Add displayId to back event
This will allow core to determine which display the back event was
started from.

Flag: com.android.window.flags.enable_independent_back_in_projected
Bug: 401530192
Test: atest TaskbarNavButtonControllerTest
Change-Id: I181aae3e9f5009f99e6ce21092dd45caeeae20cc
2025-04-08 13:28:02 +00:00
Treehugger Robot 75970d1567 Merge "Consider liveTileRemoteTargetHandles when deciding blur layer when launching tasks" into main 2025-04-08 05:00:55 -07:00
Alex Chau 70e22f42c3 Merge "Make HintState transparent when blur is enabled" into main 2025-04-08 02:50:48 -07:00