Commit Graph
87505 Commits
Author SHA1 Message Date
Treehugger Robot 5aac5dbde1 Merge "Convert TaskIconCache and TaskThumbnailCache to kotlin" into main 2025-01-03 06:19:35 -08:00
Treehugger Robot 5c3a0d7827 Merge "Combine RecentsViewStateController with base class" into main 2025-01-03 04:52:44 -08:00
Uwais Ashraf b6a733843c Convert TaskIconCache and TaskThumbnailCache to kotlin
Bug: 369590189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Presubmits
Change-Id: I1becdcdf2fffd2c1fe548e7f182a7fd851be3c08
2025-01-03 03:43:35 -08:00
Alex Chau e70eda424b Combine RecentsViewStateController with base class
- BaseRecentsViewStateController is only inherited by RecentsViewStateController, remove the base class to simplify code
- Also converted RecentsViewStateController to Kotlin and remove a bunch of warnings

Fix: 387267938
Test: presubmit and manual
Flag: EXEMPT refactor
Change-Id: I18e9c2b186a64a0af39230cb41e3b3f4949107d5
2025-01-03 10:37:57 +00:00
MrSluffy 38934f824f feat : Adjust page-indicator height to space workspace and hotseat
closes : #4836
2025-01-03 13:17:19 +08:00
Treehugger Robot c7ce8d588a Merge "Remove Widget Resize Border on Accessibility delete" into main 2025-01-02 18:25:19 -08:00
Ats Jenk 048d2e5605 Increase bubble bar tap timeout
We were using only 100ms for bubble bar tap timeout. That made it
difficult to tap to expand the bubble bar.
The constant we were using, per javadoc, is for distinguishing scroll vs
tap.
Updating the timeout constant to long-press timeout value. If the tap is
shorter than the long-press timeout (400ms by default), it is considered
a tap.
This should make it easier to tap the bar.
Also fixing the long-press to drag timeout on the bubble bar. We were
using only half of the long-press timeout constant.

Bug: 385928447
Test: tap on bubble bar to expand it, long-press on bubble bar to move
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I2df51a3caaa19ceb5b013d9377ebedd611ef84f3
2025-01-02 18:04:06 -08:00
Stefan Andonian d3d62de59a Remove Widget Resize Border on Accessibility delete
Bug: 384446998
Test: Verified locally that this works as designed.
Flag: EXEMPT bug fix
Change-Id: Ib93e4d574ee5584b955b973005008708ca986ac6
2025-01-02 16:33:50 -08:00
Treehugger Robot fca7701858 Merge "WidgetResizeFrame doesn't disappear during Accessibility Widget Resize" into main 2025-01-02 16:31:18 -08:00
MrSluffy 24ba4752ce reload icons upon reset 2025-01-03 08:14:08 +08:00
MrSluffy bd119f5b4b fixed saved scroll position 2025-01-03 08:05:49 +08:00
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Bill Yi bc10021468 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id232e97de49ea623ca1257573d66875f8a71e467
2025-01-02 15:56:34 -08:00
Stefan Andonian f1791fe5f0 WidgetResizeFrame doesn't disappear during Accessibility Widget Resize
Bug: 384446925
Test: Verified this works locally after reproducing it.
Flag: EXEMPT bug fix
Change-Id: If5db895358f05b24cb67f7b23d78aada6c79a80a
2025-01-02 14:33:21 -08:00
Treehugger Robot d4bfadf263 Merge "Fixing low res folder icon when preview changes" into main 2025-01-02 10:11:27 -08:00
Charlie Anderson cd1ba919cb Merge "Add new utility method for setting ImageTest workspace icon Component" into main 2025-01-02 09:52:32 -08:00
Sebastián Franco ef414988cc Merge "Fix Widgets in portrait being restricted by landscape grid and vice-versa" into main 2025-01-02 09:50:02 -08:00
Treehugger Robot 36dd91d125 Merge "Revert "Adding screen record for for the case when quick switch gesture doesn't do anything"" into main 2025-01-02 09:13:38 -08:00
MrSluffy 1e9b73707d feat : implementation pause apps 2025-01-01 14:45:23 +08:00
MrSluffy 8b35a95523 Disable themed icons by default
- Themed icons are now disabled by default since most users do not have a third-party themed icon pack installed by default.
2025-01-01 10:47:19 +08:00
MrSluffy b684505009 fixed 3p themed icons not applying
- closes : #4799
- closes : #4752
- closes : #4267
- closes : #4248
- closes : #4179
- closes : #4157
- closes : #3960
- closes : #3943
- closes : #3408
- closes : #2882
2025-01-01 09:56:15 +08:00
Treehugger Robot c3b0330292 Merge "Fix for bug where Talkback announce Folder:null" into main 2024-12-30 16:09:01 -08:00
Sunny Goyal 04b50a08f6 Fixing low res folder icon when preview changes
Also removing legacy for drawable sharing between folder-content and folder-icon, since preview now always creates new drawables

Flag: EXEMPT bugfix
Bug: 386842651
Test: atest PreviewItemManagerTest
Change-Id: Ib8e4b4d5be4fb0c9601b9d8e3cef8a29d6c77651
2024-12-30 15:47:17 -08:00
Treehugger Robot 7482e5cbe2 Merge "Fixing prediction ring color not getting updated if the icon changes while the slot animation is running" into main 2024-12-30 14:27:50 -08:00
Stefan Andonian 25283f0f45 Fix for bug where Talkback announce Folder:null
Bug: 385046797
Test: Verified this works locally.
Flag: EXEMPT bug fix
Change-Id: I9ad23f351df078b6bd40ff861e13b9109bfa8993
2024-12-30 14:01:28 -08:00
Sunny Goyal ad61173ca2 Converting DesktopVisibilityController to a singleton
This avoids a persistant connection to TouchInteractionService from WMProxy,
which keeps the service alive all the time

Bug: 384896306
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Id6fe59471c8c3f9874514f71126631f217ab610c
2024-12-30 12:54:19 -08:00
Vadim Tryshev 565e6afc48 Revert "Adding screen record for for the case when quick switch gesture doesn't do anything"
This reverts commit 6999ed124d.

Reason for revert: Bug doesn't repro

Change-Id: I3a9c3e68c140b7f25a7f7a13a453b9441706ade0
2024-12-30 12:44:44 -08:00
Sebastian Franco 5a9280203b Fix Widgets in portrait being restricted by landscape grid and vice-versa
Fix: 380049023
Test: Verified locally
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie06a7eaa059d5b8e675a16da80dc03803d28ea2f
2024-12-30 14:42:37 -06:00
Charlie Anderson 0415a35168 Add new utility method for setting ImageTest workspace icon Component
Bug: 350758155
Test: ArchivedAppImageTest
Flag: TEST_ONLY
Change-Id: I3f88c64528abeab68d03ba81ebb8e34b5d0e5dad
2024-12-30 09:57:08 -08:00
Treehugger Robot bf5e7e867f Merge "Moving trackpad device tracking to a separate class" into main 2024-12-30 09:52:58 -08:00
Treehugger Robot bf7a0cb976 Merge "Flip set subtraction to produce correct list of tasks to remove." into main 2024-12-30 08:36:52 -08:00
Uwais Ashraf 39682e308f Flip set subtraction to produce correct list of tasks to remove.
Fix: 380067701
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Change-Id: I26933614241e622a11a440829e89023822c8041b
2024-12-30 14:45:33 +00:00
Uwais Ashraf 7b2c441d45 Store scopeToCancel.
Without this the scope that gets cancelled can be the new one after re-attaching. This results in no flows working - hence blank thumbnails.

Fix: 369590189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - visually verified
Change-Id: Ie930d890095c30c4be8e87c795a06383ac06ea9e
2024-12-30 08:34:07 +00:00
MrSluffy 31dfcc8fe6 fixed style 2024-12-30 12:59:30 +08:00
MrSluffy eb536c182b fixed adaptive-icon not applying 2024-12-30 12:07:17 +08:00
MrSluffy aa8dd44d6a Fix widget configuration for two-step process
- closes : #5124

Bug: java.lang.IllegalArgumentException: Bad widget id 2367
2024-12-30 08:32:28 +08:00
Pun Butrach 45c8552319 Reimplement catch RemoteAnimationTarget.rotationChange (#5126)
* Update QuickstepTransitionManager.java

Signed-off-by: Pun Butrach <pun.butrach@gmail.com>

* Update AbsSwipeUpHandler.java

Signed-off-by: Pun Butrach <pun.butrach@gmail.com>

---------

Signed-off-by: Pun Butrach <pun.butrach@gmail.com>
2024-12-30 03:56:18 +08:00
Lawnchair BotandCrowdin Bot 5421b45235 New Crowdin translations by GitHub Action (#5123)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2024-12-29 03:56:35 +03:30
MrSluffy 4ad2e73075 Fix NullPointerException in WidgetSizes.updateWidgetSizeRangesAsync
This commit addresses a NullPointerException that occurs when updating
widget options in the WidgetSizes class. The fix includes:

- Adding null checks for sizeOptions and currentOptions
- Comparing new sizes with current sizes before updating
- Catching and logging exceptions during widget option updates
- Returning null from getWidgetSizeOptions if it fails to create a valid Bundle

These changes should resolve the "Attempt to invoke virtual method 'void
android.os.Bundle.putAll(android.os.Bundle)' on a null object reference" error
and improve the robustness of widget size updates.

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.putAll(android.os.Bundle)' on a null object reference
at android.os.Parcel.createExceptionOrNull(Parcel.java:3075)
at android.os.Parcel.createException(Parcel.java:3053)
at android.os.Parcel.readException(Parcel.java:3036)
at android.os.Parcel.readException(Parcel.java:2978)
at com.android.internal.appwidget.IAppWidgetService$Stub$Proxy.updateAppWidgetOptions(IAppWidgetService.java:1017)
at android.appwidget.AppWidgetManager.updateAppWidgetOptions(AppWidgetManager.java:727)
at com.android.launcher3.widget.util.WidgetSizes.lambda$updateWidgetSizeRangesAsync$0(Unknown Source:31)
at com.android.launcher3.widget.util.WidgetSizes.a(Unknown Source:0)
at ba.a.run(Unknown Source:10)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.appwidget.AppWidgetServiceImpl.updateAppWidgetOptions(AppWidgetServiceImpl.java:2193)
at com.android.internal.appwidget.IAppWidgetService$Stub.onTransact(IAppWidgetService.java:500)
at android.os.Binder.execTransactInternal(Binder.java:1375)
at android.os.Binder.execTransact(Binder.java:1311)
2024-12-28 09:31:58 +08:00
MrSluffy d401ba32fd Fix widget-related crash in LauncherWidgetHolder
- Adding null checks before calling methods on mWidgetHost
- Ensuring the listening flag is always updated, even if an exception occurs

This should resolve the "java.lang.NullPointerException: Attempt to read from
field 'com.android.server.appwidget.AppWidgetServiceImpl$ProviderId'" error
and improve overall stability when dealing with widgets

error: Uncaught exception

java.lang.RuntimeException: Unable to stop activity {app.lawnchair.nightly/app.lawnchair.LawnchairLauncher}: java.lang.NullPointerException: Attempt to read from field 'com.android.server.appwidget.AppWidgetServiceImpl$ProviderId com.android.server.appwidget.AppWidgetServiceImpl$Provider.id' on a null object reference in method 'android.util.SparseArray com.android.server.appwidget.AppWidgetServiceImpl$Host.getWidgetUids()'
at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:5484)
at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:5456)
at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5525)
at android.app.servertransaction.StopActivityItem.execute(StopActivityItem.java:43)
at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2423)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:233)
at android.os.Looper.loop(Looper.java:334)
at android.app.ActivityThread.main(ActivityThread.java:8348)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:582)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1065)
Caused by: java.lang.NullPointerException: Attempt to read from field 'com.android.server.appwidget.AppWidgetServiceImpl$ProviderId com.android.server.appwidget.AppWidgetServiceImpl$Provider.id' on a null object reference in method 'android.util.SparseArray com.android.server.appwidget.AppWidgetServiceImpl$Host.getWidgetUids()'
at android.os.Parcel.createExceptionOrNull(Parcel.java:2446)
at android.os.Parcel.createException(Parcel.java:2424)
at android.os.Parcel.readException(Parcel.java:2407)
at android.os.Parcel.readException(Parcel.java:2349)
at com.android.internal.appwidget.IAppWidgetService$Stub$Proxy.stopListening(IAppWidgetService.java:792)
at android.appwidget.AppWidgetHost.stopListening(AppWidgetHost.java:274)
at com.android.launcher3.widget.LauncherWidgetHolder.stopListening(Unknown Source:2)
at com.android.launcher3.widget.LauncherWidgetHolder.setShouldListenFlag(Unknown Source:40)
at com.android.launcher3.widget.LauncherWidgetHolder.setActivityStarted(Unknown Source:1)
at com.android.launcher3.Launcher.onStop(Unknown Source:25)
at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1496)
at android.app.Activity.performStop(Activity.java:8599)
at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:5476)
... 14 more
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.appwidget.AppWidgetServiceImpl$Host.getWidgetUids(AppWidgetServiceImpl.java:4444)
at com.android.server.appwidget.AppWidgetServiceImpl.stopListening(AppWidgetServiceImpl.java:866)
at com.android.internal.appwidget.IAppWidgetService$Stub.onTransact(IAppWidgetService.java:311)
at android.os.Binder.execTransactInternal(Binder.java:1179)
at android.os.Binder.execTransact(Binder.java:1143)
2024-12-28 09:24:35 +08:00
Treehugger Robot 70e443cde8 Merge "Removing unnecessary baseContext usage in InputConsumerUtils" into main 2024-12-27 12:04:39 -08:00
Treehugger Robot cdfec1a942 Merge "Replacing custom parcelables with platform types for test APIs" into main 2024-12-27 10:39:19 -08:00
Sunny Goyal 5bf0742fc5 Fixing prediction ring color not getting updated if the icon changes
while the slot animation is running

Slot animation is only trigerred through prediction update and it sets
final ring color at that point as part of the animation. If the icon
and the color change due to some other reason (like high-res icon or
a package-update), that color is overriden by the ongoing slot animation.

Bug: 381897614
Test: Verified manually by slowing down animation
Flag: EXEMPT bugfix
Change-Id: Ia3b86330afdb91ba6ff3366e3c8057bd7ec34e5d
2024-12-27 02:54:21 -08:00
MrSluffy 99b65be3c2 Fixed crashes on android 8 2024-12-27 15:46:16 +08:00
MrSluffy 4667f30028 Fixed crash on api 28
- closes : #5076
2024-12-27 14:41:11 +08:00
Sunny Goyal dff42e04b7 Removing unnecessary baseContext usage in InputConsumerUtils
Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ie1ceb513205028e12acefc6bcf8dbf628ce15bc4
2024-12-26 20:43:56 -08:00
Sunny Goyal 4d3683fbfe Moving trackpad device tracking to a separate class
This would eventually lead to breaking apart TIS into smaller classes,
which can be injected using dagger.
This is needed to migrate DisplayController to dagger

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger refactor
Change-Id: Ic15386136bf1705e76c08536cc0790f51e19ab73
2024-12-26 20:32:30 -08:00
Sunny Goyal c2639e464f Replacing some fixed lookup flags with specific constant flag
This would make it easier to customize flags used on desktop icons

Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: I0f3f04ddbe73abea207a5b58a65714ff172b2726
2024-12-26 20:19:02 -08:00
MrSluffy 7169349f02 properly check for archiving support 2024-12-27 10:44:48 +08:00
MrSluffy a7c80d909b fixed method privateSpaceSettingsIntent not found 2024-12-27 09:56:03 +08:00