Commit Graph
87505 Commits
Author SHA1 Message Date
Pun Butrach e207787df5 Fix translation (#5144) 2025-01-09 06:42:22 +08:00
Ats Jenk f67cfbe6ac Use bubble count for checking if bubble bar has bubbles
hasBubbles() was checking if there is a selected bubble. If there was one, it returned true.
Update it to return true when bubble bar has bubble views.
This aligns it with the name of the method and the javadoc.

Bug: 385928447
Change-Id: If3dafb7608f71b8600dbac064b08a7f7114a361f
Test: check that bubble bar is tappable
Test: check that bubble bar is shown next to QSB on foldable
Test: check bubble bar position with 3 button nav
Flag: com.android.wm.shell.enable_bubble_bar
2025-01-08 14:27:27 -08:00
Stefan Andonian 2c2e24f38d Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder
Bug: 383917141
Test: Passes Presubmit
Flag: EXEMPT flaky test investigation
Change-Id: Icf045821c42fdf9f8e60ae45d0d98ff2bc25e927
2025-01-08 14:17:02 -08:00
fbaron a94ecdfac0 Move all db calls for grid migration inside a SQLiteTransaction
Bug: 388564911
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I22a373ea5b71a0713eeba37e8d09e09130eae525
2025-01-08 13:44:34 -08:00
Stefan Andonian 8295c92e8e Add ScreenRecord annotation to flaky test RequestPinItem
Bug: 386243192
Test: Test runs fine with annotation.
Flag: EXEMPT unit test bug investigation
Change-Id: I27f8dc0fb55521ed37b743a0149dbe2ac60ad7ff
2025-01-08 12:53:08 -08:00
Treehugger Robot 13cb405ff0 Merge "Remove no longer meaningful upstream: true flag." into main 2025-01-08 12:29:51 -08:00
Sebastian Franco a8e1984852 Promote ReorderAlgorithmUnitTest since it's not failing anymore
Fix: 332527963
Flag: TEST_ONLY
Test: ReorderAlgorithmUnitTest
Change-Id: I69257ff8a267f6f2e94f8d0c3c5e0c662ec5efb9
2025-01-08 12:20:13 -08:00
minch ef86780cda Reland "Introduce mTaskViewCount inside the RecentsView"
Manually reland ag/30692743 without the part of change inside
PagedView. The related crash has been handled by ag/31218694.

Flag: EXEMPT as relanding
Bug: 385612978
Test: Manual
Change-Id: Ic571a506bea025ff7d1f2e964300c27a935302a3
2025-01-08 18:59:05 +00:00
Treehugger Robot b3a6b8c33d Merge "Fixing local atest runs of Launcher tests" into main 2025-01-08 10:44:53 -08:00
minch a69673de08 Run the given callback only inside runOnPageScrollsInitialized
Let `PagedView.runOnPageScrollsInitialized` run the given callback only
instead of running all the current existing callbacks inside
`mOnPageScrollsInitializedCallbacks` once `mPageScrolls` has been
initialized.
All the existing callbacks will be run by
`PagedView.onPageScrollsInitialized` instead.
By doing this, we can avoid some unexpected crash while running
the pending callbacks in some scenarios. E.g., removeAllViews.

Flag: EXEMPT fix a regression
Bug: 385612978
Test: Manual
Change-Id: I0877cff752aabd1569dd54a9d04001687f90a5f6
2025-01-08 18:44:40 +00:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Rex Hoffman 74fa77e564 Removing Dead Flag
Test: CI
Bug: 386652866

Change-Id: I04537140ccd2526df4630c8cca6abbd327a7ca7f
Merged-In: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
2025-01-08 10:13:56 -08:00
Rex Hoffman 2c1c08a1ac Remove no longer meaningful upstream: true flag.
This used to direct robolectric tests to /external/robolectric rather than the older/unmaintained /external/robolectric-shadows, that has since been deleted.

Change-Id: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
Flag: TEST_ONLY
Test: CI
Bug: 386652866
2025-01-08 10:13:04 -08:00
Alex Chau a2857a9940 Add test to open Desktop with fullsreen live tile
Fix: 388266322
Test: TaplTestsOverviewDesktop#enterDesktopViaOverviewMenu
Flag: EXEMPT test only
Change-Id: I6d581671a81289abe362c42c8d4e826da59b7c70
2025-01-08 18:09:42 +00:00
Treehugger Robot 569e032b24 Merge "Add debug logs to SpringAnimationRunner.onUpdate" into main 2025-01-08 09:40:13 -08:00
George Lin a1037f63a7 Merge "Return list of one default option when shape not enabled (1/2)" into main 2025-01-08 09:13:47 -08:00
Treehugger Robot 6c45afc3d8 Merge "Migrate TopTaskTracker instance to DaggerSingletonObject" into main 2025-01-08 09:10:02 -08:00
Schneider Victor-tulias e6079bfa01 Merge "Fix test Dagger initialization deadlock in RecentsDisplayModel" into main 2025-01-08 07:16:41 -08:00
samcackett 288bdd9d56 Use system configured font weight
Fix: 379643698
Test: Enable Bold text (Settings > Accessibility > Display size and
text) and check the emoty recents view text is bold
Flag: EXEMPT bugfix

Change-Id: I8f4d2f61247b168c777b751a3b3dd12299e7011f
2025-01-08 15:05:06 +00:00
Will Osborn 68ef02ca44 Merge "Move recents dependency destruction to onDestroy from onDetachedWindow" into main 2025-01-08 06:57:23 -08:00
John Andrew Camu 3a1e1389a2 feat : wallpaper pop-up carousel (#5143) 2025-01-08 19:04:28 +08:00
Alex Chau 679d6a5240 Merge "Revert "Introduce mTaskViewCount inside the RecentsView"" into main 2025-01-08 02:28:37 -08:00
Zongle Wangandrenovate[bot] a463fe905a Tweak Ktlint rules (#5141)
* Revert "Fix style"

This reverts commit 7a4d119afa.

* Revert "Spotless 7.0.0"

This reverts commit 3398fce454.

* Tweak rules

* Bump Spotless to 7.0.1

* Reformat again

* Update plugin com.diffplug.spotless to v7.0.1

* Fix by ktlnt cli

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-01-08 09:50:43 +00:00
tgex0andZongle Wang 2ee7af8ab7 Fix style in SettingInfo (#5140)
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
2025-01-08 17:38:14 +08:00
samcackett bc3e644652 Migrate TopTaskTracker instance to DaggerSingletonObject
Fix: 371377451
Test: Manual
Flag: EXEMPT Dagger integration
Change-Id: I0b51fb7973a89e9d6f59d4c2c8544fdd0ccbf74e
2025-01-08 08:15:13 +00:00
Sunny Goyal 4016e11e58 Moving overview preloading to a separate utility class
Bug: 386288280
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I6779e22c1990b0a901a4190d9272066958e86331
2025-01-08 00:14:49 -08:00
Goooler 7a4d119afa Fix style 2025-01-08 13:16:24 +08:00
Vadim Tryshev ef95aa29fa Fixing local atest runs of Launcher tests
When running tests locally on CF, installing test apk either fails or returns INSTALL_FAILED_VERIFICATION_FAILURE.

Somehow this doesn’t happen when running on ATP.

For local runs, fixing by disabling verification.

Bug: 378782502
Test: local atest; presubmit
Flag: NONE Test change
Change-Id: I31b6d14587dbfed129ae3ddeef5e86f3c60432e9
2025-01-07 19:07:01 -08:00
Android Build Coastguard Worker c90efa255a Merge cherrypicks of ['googleplex-android-review.googlesource.com/31156270'] into 25Q1-release.
Change-Id: Ib824b4ca7856560c829ea11fd71c1c6003fd62fe
2025-01-07 17:34:31 -08:00
Treehugger Robot 2dbb255975 Merge "Maintain Talkback / Voice Access / etc. focus after moving item in Workspace." into main 2025-01-07 17:32:54 -08:00
Hyunyoung Song 59781fe109 Prevent CtS invocation in fake landscape mode
Bug: 383421642
Test: manual, atest ContextualSearchInvokerTest
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:299576a77761e2a9db11ef50d7e0072d079e381c)
Merged-In: I71ff453c54ade4583494ae9a6b44560d59b010d8
Change-Id: I71ff453c54ade4583494ae9a6b44560d59b010d8
2025-01-07 17:29:53 -08:00
Stefan Andonian 8a0f9b7f15 Merge "Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere." into main 2025-01-07 16:22:10 -08:00
Treehugger Robot 6184be660e Merge "Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController" into main 2025-01-07 15:08:25 -08:00
minch 59440da093 Revert "Introduce mTaskViewCount inside the RecentsView"
Manually revert ag/30692743 because of a performance
regression tracking at b/385612978 .

Flag: EXEMPT as reverting
Bug: 385612978
Test: Manual
Change-Id: Iadcdc07588755ee47b6d6d37db08291aa707ecfe
2025-01-07 22:12:01 +00:00
Stefan Andonian 3593b6a9e2 Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere.
Bug: 385682296
Test: Verified locally that folder behavior remained identical to before.
Flag: EXEMPT bug fix
Change-Id: I9c3ca9aa456f0ac724f4f002a8ec0385f019ee0d
2025-01-07 13:43:41 -08:00
Sebastián Franco 707bf729c9 Merge "Using pixels instead of DPI for selecting the grid size" into main 2025-01-07 13:05:52 -08:00
Sunny Goyal 56297bcd4a Merge "Removing RotationTouchHelper state management from RecentsAnimationDeviceState" into main 2025-01-07 12:47:56 -08:00
George Lin c6bdd4b181 Return list of one default option when shape not enabled (1/2)
This is to return a list of one default option (circle) if the shape
cutstomization flag is not turned on.

It resolves the issue that the selected shape option never emits.

Test: Manually tested
Fixes: 388299893
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I328efa370c1a741e8461dd9b37e37c138eb7e09f
2025-01-07 20:21:25 +00:00
Schneider Victor-Tulias ef3e18715b Fix test Dagger initialization deadlock in RecentsDisplayModel
- Fixes a deadlock created when initializing RecentsDisplayModel
- Also fixes an IllegalStateException when initializing RecentsDisplayModel before the default display has initialized

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I5d3e000d722c311e0d5431034b68635c402c8109
2025-01-07 12:19:50 -08:00
Treehugger Robot 8173c2b5a8 Merge "Revert "Dismiss recents when device goes to sleep"" into main 2025-01-07 10:54:56 -08:00
Sebastian Franco f59d3de3c6 Using pixels instead of DPI for selecting the grid size
Fix: 383132640
Bug: 386479043
Test: Screenshot test
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ic3eda69324e03cc6f049cd7d21dac7ab6a22271e
2025-01-07 10:32:07 -08:00
Treehugger Robot 5b52f8ea8e Merge "Refactor getHighestVisibleTaskIndex to return TaksView and remove requiredTaskViewAt" into main 2025-01-07 10:20:51 -08:00
Stefan Andonian 6284b233bf Maintain Talkback / Voice Access / etc. focus after moving item in Workspace.
Bug: 383456105
Test: Verified this works well manually.
Flag: EXEMPT bug fix
Change-Id: I35377443c4800a53cfa539c7061d5ef1b8b27837
2025-01-07 09:57:43 -08:00
Will Osborn 7fecb97dfb Move recents dependency destruction to onDestroy from onDetachedWindow
With Overview running in a window, this clearing up needs to move later in the  lifecycle.

Bug: 388232647
Test: ran locally on device
Flag: EXEMPT bugfix
Change-Id: Id35c7fce390c2874b453c8b14c4eb0e7220ccd94
2025-01-07 17:51:30 +00:00
Alex Chau 0a7fc448e6 Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController
- The refactoring ag/30993068 mis-use areDesktopTasksVisible() instead of areDesktopTasksVisibleAndNotInOverview()
- This causes Taskbar mode to change at wrong timing

Bug: 388266322
Test: Swipe up from fullscreen app, launch desktop task
Flag: EXEMPT bugfix
Change-Id: I75a4c7497fe7e4d03a4029d678086f859c8c55b8
2025-01-07 17:45:37 +00:00
samcackett 9e1b1cd5fa Ensure split screen cancel label doesn't wrap
Fix: 379811238
Bug: 328577545
Bug: 345128488
Test: Visual inspection of instructions view in different languages/form
factors and display densities
Flag: EXEMPT bugfix

Change-Id: Iabdb76b7a02957e1918475b8a00f395f64e96301
2025-01-07 17:27:40 +00:00
Ats Jenk c2012f23d3 Merge "Add debug logging to root cause tap issues" into main 2025-01-07 09:09:48 -08:00
Schneider Victor-Tulias 7fe128f148 Add debug logs to SpringAnimationRunner.onUpdate
Flag: com.android.launcher3.enable_additional_home_animations
Bug: 387942297
Test: checked logs
Change-Id: I3627269a7132623fd315226813fbefc856a541d6
2025-01-07 11:36:07 -05:00
Alex Chau 3aca1797ee Refactor getHighestVisibleTaskIndex to return TaksView and remove requiredTaskViewAt
- Removed last usage of requiredTaskViewAt, which is a dangerous method assuming there must be a TaskView at certain index

Bug: 379942019
Test: manually on Task rebalancing after dismiss
Flag: EXEMPT refactor
Change-Id: Ib53e0f47435d6fb9f8fd42f89b045160e75b5e54
2025-01-07 16:09:11 +00:00
Schneider Victor-tulias a4c8c7fafb Merge changes Iceb7c9cf,I1e802e67 into main
* changes:
  Fix NPE in LauncherSwipeHandlerV2Test.setup
  Update recents states sent to tests by RecentsWindowManager
2025-01-07 07:46:03 -08:00