Commit Graph
87505 Commits
Author SHA1 Message Date
Jagrut Desai 7b9af1296e Removing ScreenRecord from test
Test: Presubmit
Bug: 319501259
Flag: EXEMPT bugfix
Change-Id: If417b0f748bd4cbc1270d8e393bb787c812074de
2025-01-27 10:45:56 -08:00
Treehugger Robot e801cd88e1 Merge "Add offsetTranslationX for the AddDesktopButton" into main 2025-01-27 10:09:16 -08:00
Cole Faust 42fc2058e6 Fix errorprone warnings
https://errorprone.info/bugpattern/BadInstanceof
https://errorprone.info/bugpattern/CompareToZero

Bug: 253827323
Test: Presubmits
Flag: EXEMPT refactor
Change-Id: If28f8f7f407b5b1e58911c58bb7d1b80f08c6114
2025-01-27 09:54:02 -08:00
Jordan Silva 0580dfc0c6 Merge "Fetch icon and thumbnail for completed task to prevent stale data" into main 2025-01-27 09:47:03 -08:00
Alex Chau e880ccfa2f Rename OverviewProxyService to LauncherProxyService
- OverviewProxyService is a shared service to send information from SysUI to Launcher, only 1 method `onOverviewShown` is related to Overview, renaming this service to better reflect the nature to avoid bugs misrouted to Overview component.

Fix: 391563516
Test: presubmit
Flag: EXEMPT REFACTOR
Change-Id: I7104532daa1a4b6a7a39966f11063fbe9d15533e
2025-01-27 09:32:28 -08:00
Cosmin Băieș f0a6af1468 Merge "Rename BACK_ALT flag to BACK_DISMISS_IME" into main 2025-01-27 08:51:01 -08:00
Alex Chau 5201f78a1f Separate external display tasks in Overview
- Sort external display tasks into front of Overview to create its own sections, all external display tasks are treated as large tile
- Fixed expected position of currentPage and runningTask respectively
- Fixed Desktop and fullscreen TaskView to launch with displayId from its first available task

Bug: 391311008
Flag: com.android.launcher3.enable_separate_external_display_tasks
Test: RecentTasksListTest
Change-Id: Ida0ccab00d3e4d74513812a11241dfc908bde991
2025-01-27 16:37:08 +00:00
Thales Lima c56864e3c5 Stop intercepting QuickSwitch gesture if there are no fullscreen apps open
Bug: 345296916
Test: Launcher tests
Flag: com.android.window.flags.enable_quickswitch_desktop_split_bugfix
Change-Id: I61cb2958bb4ce3234f9b2e50474e0dad906fe90d
2025-01-27 16:25:00 +00:00
Treehugger Robot 06b49fb9b6 Merge "Fix: Use original icon drawable for TaskThumbnailView" into main 2025-01-27 08:12:11 -08:00
Jordan Silva ac49e0cb58 Fetch icon and thumbnail for completed task to prevent stale data
The data returned from getAllTaskData can sometimes replace recently fetched thumbnail and icon data with a null value due to a race condition. This occurs when getAllTaskData results are returned after, or at the same time as, the thumbnail and icon data is fetched. Consequently, the information displayed to the user is incorrect and remains so until the user re-enters Overview or scrolls. To address this issue, we propose to re-request the task data for requests that have already been completed.

Change-Id: I99ee7f38abab3c283c9f82bce7b1d069575ddc6e
Fix: 392069389
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTests
Test: TasksRepositoryTest
2025-01-27 07:14:08 -08:00
Gustav Sennton 1cce85f197 Remove old Desktop transitions flags usages
Bug: 369763947
Test: n/a
Flag: EXEMPT flags removal
Change-Id: Ie4cd157bb94477db83a1995f976c2057f78902e4
2025-01-27 14:44:22 +00:00
Jordan Silva 6b24068c47 Fix: Use original icon drawable for TaskThumbnailView
- It modifies TasksRepository to return the original icon drawable directly without mutating or replacing it, ensuring the original drawable is used.
- Moved the mutate and copy of the drawable into the TTV (View layer), to prevent mutating the source of the icon for everybody else.
This commit addresses two issues:

These changes aim to fix issues with task icons that are displayed with
zoom after being modified by TTV.

Fix: 392568687
Fix: 392583703
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: Manual
Change-Id: I29e81ba3518ecad09b96d9a5c0fa16e6931bfb39
2025-01-27 06:23:51 -08:00
Cosmin Băieș 29d67ee492 Merge "Don't show both the IME Switcher and A11Y buttons" into main 2025-01-27 03:43:21 -08:00
Treehugger Robot 9815c49644 Merge "Add bug fix flag to guard enabling start launch transition from taskbar." into main 2025-01-27 03:31:27 -08:00
Jordan Silva fe4152e608 Merge "Refactor: Remove TaskThumbnailViewModel and introduce TaskViewModel" into main 2025-01-27 03:09:37 -08:00
Cosmin Băieș d9fbdec845 Remove unused imeDownButton in taskbar
This button was originally forked off from the main back button in [1],
prior to the gesture navigation work, and it was the only back button
shown when the IME was visible.

Starting from [2], we reverted to always show the main back button
regardless of the IME visibility, and to also show the imeDownButton
when not in three button navigation (also submitted prior to the gesture
navigation work). Eventually in [3] the IME started supporting gesture
navigation with its own fork of navigation bar, which shows this button.

Later in [4], the imeDownButton was changed to only be visible in
gesture navigation mode, while the IME can draw its own navigation
buttons (specified through a syspro, defaults to true). Thus it could
only be shown when neither in gesture navigation nor in three button
navigation. However, with the navigation bar taskbar unification, this
button is essentially ignored, as it is not manually added.

In any case, as this is a fork of the main back button, all its
behaviour could (and should) be handled by the main implementation.

  [1]: I4d0ecd0bee0c519892c63eeefef45055b26d349b
  [2]: I7959d26986e546596e2436b8b5eb7668f44b55cf
  [3]: I3e7e1f83554444131e2765dc159617bb9e2337c7
  [4]: Iab8c47521ab9e561881e4ffb45142888e4c427e4

Flag: EXEMPT refactor
Bug: 366129400
Test: verify with IME shown and hidden in 3 button nav and gesture nav,
  in launcher and setup wizard
Change-Id: If337d198ddb0e0e2173167add9991f97988a3a5c
2025-01-27 10:43:29 +01:00
Cosmin Băieș 18721bf550 Rename BACK_ALT flag to BACK_DISMISS_IME
The NAVIGATION_HINT_BACK_ALT flag was originally introduced in [1],
alongside a few other flags which affected the navigation bar buttons.
The other flags were eventually removed in [2], leaving only this.
Unfortunately, the flag name is not very explicit, and it lacks clear
documentation.

This redefines the flag as BACK_DISMISS_IME, representing whether the
back button is visually adjusted to indicate that it will dismiss the
IME when pressed.

  [1]: Ie64369e3df3178178f35b56763ea96d380b6ddd4
  [2]: Ifd1f8c9f400d90542f0ca858b9a4deacabbd518a

Flag: EXEMPT refactor
Bug: 366129400
Test: n/a
Change-Id: Ida655a61b2477109e233fc62776e31d17698e2ce
2025-01-27 10:43:29 +01:00
Cosmin Băieș f90ebe5f70 Don't show both the IME Switcher and A11Y buttons
The IME Switcher shares the same spot with the accessibility button on
the navigation bar. In the previous implementation of the NavigationBar,
if the a11y button is visible, the IME Switcher button would not be.

With the recent unification of the navigation bar and the taskbar, both
buttons could be made visible at the same time. This fixes the taskbar
logic to only show the IME Switcher button when it should be visible and
the a11y button is not visible. This logic is only applied on phone
mode, the only case where the buttons overlap.

Flag: EXEMPT bugfix
Bug: 378803994
Test: switch to 3 button nav, show accessibility shortcut and dock it to
  the navigation bar, show the IME with at least two keyboard langauges,
  observe that only a11y button becomes visible
Change-Id: Ifc082d51e02d74f7dbf4516814121b67c0a6aa1a
2025-01-27 10:43:27 +01:00
Will Osborn 30b04a4bb0 Merge "Add feature flag for enable_overview_on_connected_displays" into main 2025-01-27 01:26:10 -08:00
Vania Desmonda 88c11031f9 Add bug fix flag to guard enabling start launch transition from taskbar.
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Bug: 391641359
Change-Id: Ia21f94bb28549700efce9967c79303b97224abe5
2025-01-27 06:24:50 +00:00
Lingyu Feng 9d98fb90c0 Merge "Add onDisplayRemoveSystemDecorations to TouchInteractionService" into main 2025-01-26 17:30:49 -08:00
Lawnchair BotandCrowdin Bot d4beb47a9c New Crowdin translations by GitHub Action (#5210)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2025-01-26 03:55:13 +03:30
Andy Miller 011845a06e fix: smartspacer layout (#5207)
Modified the smartspacer layout to be more like the stock At a Glance
layout by adding equal padding to both sides and clipping the pages as
they are scrolled.

Fixes #5206
2025-01-25 14:13:32 +08:00
Matthew Mourgos a83f85cf43 Add flag for mouse interaction changes
Bug: 388897603
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Change-Id: I8cc3f7711fcd378a57314a8a8070374e550b1344
2025-01-24 16:23:34 -08:00
Cosmin Băieș 1787eda528 Propagate IME back disposition state to SystemUI
Previously the navigation bar and taskbar were incorrectly using the
back dispositon state as the source of truth for the IME visibility.
While this can only be set while the IME is visible, it can (and is)
also unset despite the IME still being visible. This was fixed in [1].

While the taskbar previously did not take into account the back
dispositon state, by the IME visibility changing, the rotation of the
back button would also change, leading to an equivalent state. However,
with the fix from [1], this would no longer happen, with one scenario
being showing the IME and then the IME swithcer menu, which temporarily
unsets the back disposition mode while the menu is visible.

This propagates the back disposition state to SystemUI, so taskbar can
respond to changes in this value, rather than in the IME visibility.

  [1]: Ic57cea49f5ff49132802083b4f0c9b0e82db1cf7

Flag: EXEMPT bugfix
Test: switch to 3 button nav, show IME, show IME Switcher menu,
  observe back button rotation
  atest NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleImeSwitcherButtonVisible
  NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleImeSwitcherButtonNotVisible
  NavigationBarTest#testSetImeWindowStatusSysuiState_ImeNotVisibleImeSwitcherButtonVisible
  NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleBackDispositionAdjustNothing
Bug: 366129400
Change-Id: Ib05f9263afb754724021b5f3e48520eff5dad398
2025-01-25 01:18:11 +01:00
Cosmin Băieș e05eaa3cf0 Rename IME_SHOWN states to IME_VISIBLE
This renames the SysUI states related to the IME and IME Switcher button
visibility from "shown" to "visible", to maintain consistency.

Flag: EXEMPT refactor
Bug: 366129400
Test: n/a
Change-Id: I45219e62b633ca984de98df43f5c238604b38109
2025-01-25 01:18:11 +01:00
Cosmin Băieș c4ddddc2aa Remove redundant references to IME Switcher vis
The taskbar and bubble bar were using both the visibility of the IME and
that of the IME Switcher button to determine whether these bars should
be stashed. However, the IME Switcher button will never be visible while
the IME is not visible, so using its visibility is redundant.

This changes the stashing logic to only take into account the IME
visibility. Note, the IME is also considered visible even when a
hardware keyboard is connected, regardless of any UI being visible or
not. This visibility state determines various system behaviours.

Flag: EXEMPT refactor
Bug: 366129400
Test: open the IME and IME Switcher menu on large screen devices;
  observe taskbar behaviour
Change-Id: Ibcd16896582ca575538d8c1c3d2ab879090d075c
2025-01-25 01:18:11 +01:00
Cosmin Băieș ee04a3e0fd Remove unused FLAG_ROTATION_BUTTON_VISIBLE
The code related to this flag was removed in [1], but the flag
declaration, and two no-op usages were left over.

  [1]: I1de7fa061a6c6aba9f949a0bcf8cfced84273e3f

Flag: EXEMPT cleanup
Test: n/a
Bug: 366129400
Change-Id: If3d0751e0a9035ba8b0c66250df9339856788171
2025-01-25 01:18:11 +01:00
Andy Miller 2ffd541baf fix: smartspacer padding (#5204)
* fix: smartspacer padding

closes #4824
closes #5134

* fix style violations
2025-01-25 06:14:04 +08:00
renovate[bot] 79852e70cf chore(deps): update dependency gradle to v8.12.1 (#5203)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-01-25 06:09:47 +08:00
Treehugger Robot 1809cb6ff3 Merge "Focus on newly added app for all Accessibility use cases when adding an app to the home screen." into main 2025-01-24 14:02:44 -08:00
Eghosa Ewansiha-Vlachavas 432544a529 Merge "[2/n] Hide desktop button in overview for incompatible tasks" into main 2025-01-24 13:01:25 -08:00
Treehugger Robot 196ba82377 Merge "Removing redudntant objects from BgDataModel" into main 2025-01-24 12:00:33 -08:00
Treehugger Robot d77eed56f4 Merge "Fix for InteractionJankMonitorWrapper NPE" into main 2025-01-24 11:52:09 -08:00
Jagrut Desai 76545448dd Merge "Remove Forced Taskbar Hidden accessibility announcement and forced accessibility focus" into main 2025-01-24 11:36:52 -08:00
Jordan Silva 3bf3740891 Refactor: Remove TaskThumbnailViewModel and introduce TaskViewModel
- Remove TaskThumbnailViewModel and replace it with TaskViewModel
- Introduce TaskUiStateMapper class to map between TaskData and TaskThumbnailUiState
- Improve TaskView by introducing TaskViewModel and delegate to TaskContainer to show changes
- Refactor TaskThumbnailView to simplify its responsability and be able to receive TaskThumbnailUiState.
- Add TaskViewModel test and TaskUiStateMapper tests

Bug: 390583187
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTests
Test: TaskViewModelTest
Test: TaskUiStateMapperTest
Test: TaskThumbnailViewModelImplTest
Test: TaskThumbnailViewScreenshotTest
Change-Id: I90bb08d377d7a24ca803c552e0cf3897c8888b76
2025-01-24 11:36:22 -08:00
Shamali Patwa 51a340a3c4 Merge "Fix issue that recommendations were visible in landscape mode." into main 2025-01-24 10:35:40 -08:00
minch 9dbbd01204 Add offsetTranslationX for the AddDesktopButton
Apply the `offsetTranslationX` to the AddDesktopButton inside
`updatePageOffsets`, so the button can be set to offscreen
when needed.
This requires us to differentiate the `gridTranslationX` and
the `offsetTranslationX` for this button as well.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Fix: 389209282
Test: Manual
Change-Id: Id157c41577b2f47b220558b353f07a4ecb0ec3b5
2025-01-24 17:52:02 +00:00
Jagrut Desai defdc6c2d8 Remove Forced Taskbar Hidden accessibility announcement and forced accessibility focus
This cl also removes forced hidden annoucement and focus for Bubble Bar since they are annouced together.
we are keeping the tasksbar show annoucement and focus since it is only way to notify user of taskbar being shown on screen until we figure out proper solution with talkback team.

Test: Manual, Presubmit
Bug: 383928453
Flag: EXEMPT bugfix
Change-Id: I2c32ea393da2509af49e2fce795759a6903b0451
2025-01-24 09:20:07 -08:00
Will Osborn bd40e543dc Fix for InteractionJankMonitorWrapper NPE
Test: trigger overview locally with recents-in-window flags on
Flag: EXEMPT bugfix
Bug: 366024009
Change-Id: I013ccc93354d6789a9b2633bdc90cce89d83cdcb
2025-01-24 15:22:01 +00:00
Treehugger Robot b22158206b Merge "Introduce SingleTask and SplitTask" into main 2025-01-24 02:59:37 -08:00
Treehugger Robot b7dd013d29 [automerger skipped] Merge "Revert "Replace system_ext container with system"" into main am: e239718b4e am: b7ea931aee -s ours
am skip reason: Merged-In I92387e6d5764c750f83bd8d266f6da969e114a72 with SHA-1 da76a66353 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3464481

Change-Id: I3b5c951fbc1b1b6fcdb44aa52f4b17b733459cff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 01:38:49 -08:00
Will Osborn a015f042f6 Add feature flag for enable_overview_on_connected_displays
Test: None
Bug: 363251602
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: If5d248ff1005bf30beb259f65b5ce8ffad92489c
2025-01-24 09:15:31 +00:00
Treehugger Robot b7ea931aee Merge "Revert "Replace system_ext container with system"" into main am: e239718b4e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3464481

Change-Id: I38d87ad0be0b41c47d12f6e78e6047048e2d9392
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-01-24 01:00:50 -08:00
Treehugger Robot e239718b4e Merge "Revert "Replace system_ext container with system"" into main 2025-01-24 00:33:59 -08:00
Justin Yun 015bb86af7 Revert "Replace system_ext container with system"
This reverts commit d80efafdc0.

A system partition cannot have the aconfigs of other partitions.
Revive the system_ext container for system_ext aconfigs.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da76a663533d3ba4455ad226454a5cb7631c6f7e)
Merged-In: I92387e6d5764c750f83bd8d266f6da969e114a72
Change-Id: I92387e6d5764c750f83bd8d266f6da969e114a72
2025-01-23 22:43:20 -08:00
Treehugger Robot df8fc5ebd8 Merge changes Iaadc7e1a,I3e8d5d2f into main
* changes:
  Add flag for restoring Archived App Icons from db
  Add flag for restoring archived pinned shortcuts
2025-01-23 18:37:04 -08:00
Treehugger Robot 9bc36997c4 Merge "[CD Taskbar] [CD Taskbar] Refactor TaskbarManager dump" into main 2025-01-23 18:37:03 -08:00
Treehugger Robot 446270599c Merge "Add debugging logs to understand why taskbar root layout would be null" into main 2025-01-23 18:28:18 -08:00
Treehugger Robot f31d9b1ab7 Merge "Fix the NPE in LockedUserStateTest since mocks gets cleared before the test finishes execution." into main 2025-01-23 18:25:04 -08:00