Commit Graph
87505 Commits
Author SHA1 Message Date
Ahmed Fakhry 129a3a0097 Finally remove task1 and task2 from GroupTask
See go/refactor-group-task for details. This is the final CL
in this refactor, where `task1` and `task2` are finally removed,
and `DesktopTask` is allowed to have empty tasks.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I8af39b58138f11030981311efc2e95a77cef125b
2025-01-31 17:14:46 +00:00
Ahmed Fakhry c590a62c80 Remove GroupTask.mSplitBounds
See go/refactor-group-task for details. This CL removes `mSplitBounds`
from `GroupTask` and adds `splitBounds` to `SplitTask`. This makes its
usages more intentional.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I9a3e8ee2e96d46f9eb79a58ffcf5efc257615aac
2025-01-31 17:14:46 +00:00
Ahmed Fakhry b6ecf5889e Remove all external usages of GroupTask.task1/2 from Launcher3
See go/refactor-group-task for details. This CL removes all the usages
of `task1` and `task2` from `GroupTask` in Launcher3. Follow-up CLs will
remove it from NexusLauncher and remove the fields altogether.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I902c8135b3a0aae95acf25267b3bcbf286bd4e7d
2025-01-31 17:14:44 +00:00
samcackett 5df5144b45 Add task menu shortcut for closing apps
Fix: 383977717
Test: OverviewMenuImageTest
Flag: EXEMPT bugfix

Change-Id: I24338a821e1ec9be21d22a5d1c4295dd6e28d13d
2025-01-31 08:37:18 -08:00
Harry Cutts 496b908033 Fix button state consistency issues in TAPL event streams
Change I59b886bfb632f0f26ee58c40f82f447f5ea59b41 caused a number of
launcher and WM tests to fail because the TAPL code was producing motion
events with invalid button states, or just not sending BUTTON_PRESS and
BUTTON_RELEASE events at all. While this change does not address all
possible uses of LauncherInstrumentation#sendPointer (for example,
sending a MOVE during which a button should be held down), it fixes
consistency issues in all cases currently used by tests. A more
comprehensive fix is not worthwhile since this kind of input event
injection is deprecated and should be replaced with usage of uinput or
virtual devices anyway.

Test: $ atest \
      NexusLauncherOutOfProcTests:com.android.launcher3.appiconmenu.TaplAppIconMenuTest \
      NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplDragTest \
      NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplUninstallRemoveTest \
      NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar \
      'NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar#testOpenMenuViaRightClick' \
      'WMShellFlickerServicePlatinumTests:com.android.wm.shell.EnterSplitScreenByDragFromShortcutGesturalNavLandscape#enterSplitScreenByDragFromShortcut'
Bug: 372571823
Bug: 392150793
Flag: TEST_ONLY
Change-Id: I5c259c13d433d3010d2cf9c6fe01e08ba5990ef7
2025-01-31 14:14:54 +00:00
Treehugger Robot 815b265cf7 Merge "Move enable_taskbar_connected_displays to lse_desktop_experiences" into main 2025-01-30 22:17:28 -08:00
Treehugger Robot dfa11eb35e Merge "Not calling updateCallback in constructor as it can cause initialization error" into main 2025-01-30 20:36:38 -08:00
Charlie Anderson 6009fa94b6 Merge "Add folder shapes for corresponding icon shapes" into main 2025-01-30 19:29:51 -08:00
Treehugger Robot 94eadd7529 Merge changes from topic "tc-refactor" into main
* changes:
  Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
  Refactor TaskView to allow no TaskContainers
2025-01-30 19:22:41 -08:00
Matthew Mourgos 351ae6cd62 Stop mouse click+drag from opening all apps
This change is intended for the desktop use case.

Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ibbca58f1e98a6648be68fc7e3b6337f5c78160da
2025-01-30 19:16:43 -08:00
Sukesh Ram 65042fde52 Move enable_taskbar_connected_displays to lse_desktop_experiences
Removing launcher flag for taskbar in secondary display and adding it to lse_desktop_experiences.

Test: m
Bug: 393398093
Bug: 383634014
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ia73f31346eb1b3bd273ecb7801eb1264d92e6863
2025-01-31 00:11:02 +00:00
Federico Baron 7938a50b28 If onegrid is on we don't check if destination db is new or not
We just migrate them using the special case where everything shifts up
if we meet the criteria

Bug: 392978014
Test: GridSizeMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4efda781d6fbe6f3e1854b22685abd1b923c3dc4
2025-01-30 15:51:54 -08:00
Treehugger Robot 821572007d Merge "Revert^2 "Unifying various model update callbacks into one"" into main 2025-01-30 15:45:47 -08:00
Bill Yi 90bf368a19 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I395ce6f61ecb9e74bd8da7a6104fccb85de951d6
2025-01-30 15:24:30 -08:00
Bill Yi a11ddc12d1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0e74c003b45f48b1aada8bd1357820ab0e284ef5
2025-01-30 15:23:40 -08:00
Matthew Mourgos 5adb3b4b09 Stop mouse long press from opening workspace menu
This feature is intended for the desktop use case.

Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ifc2da01b248c7dbdbe272f4fa124b6d1182c599d
2025-01-30 14:55:10 -08:00
Sunny Goyal 430fd3104f Not calling updateCallback in constructor as it can cause initialization error
Bug: 390930809
Flag: EXEMPT bugfix
Test: atest ActiveTrackpadListTest
Change-Id: Ifb14e2949f1f399fbb8b63f493f96d0dd54cc081
2025-01-30 13:25:04 -08:00
Sunny Goyal dfbbebc9e3 Revert^2 "Unifying various model update callbacks into one"
72f9943f64

Change-Id: I38901714947a2b7926723ea25df4a2b8216303e4
2025-01-30 13:19:32 -08:00
Priyanka Advani (xWF) da2e19a821 Merge "Revert "Unifying various model update callbacks into one"" into main 2025-01-30 13:12:33 -08:00
Adnan Begovic 6a69b19389 Merge "Launcher3: Introduce lint checks for Launcher3." into main 2025-01-30 11:25:25 -08:00
Android Build Coastguard Worker d9229faff2 Merge cherrypicks of ['googleplex-android-review.googlesource.com/31516215'] into 25Q1-release.
Change-Id: Ie301dc0e65ce80dff237a9b9dc8805de115c43e2
2025-01-30 10:45:02 -08:00
Sunny Goyal a315410ea3 Fixing leaks in LauncherPreview
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
  on to the communication channel for preview.

Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:986d7cb9c09a22915c922cf8e72c03ce36883742)
Merged-In: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
2025-01-30 10:44:36 -08:00
Treehugger Robot db04d745b1 Merge "When doing the special case migration where cells shift up, only modify workspace items" into main 2025-01-30 10:28:11 -08:00
minch 353e0ed184 Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: Id00dc0769e0a38311d203f14f90a7184e0f2f6e7
2025-01-30 18:25:45 +00:00
minch dbdf49726f Refactor TaskView to allow no TaskContainers
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: I3343da2b6d73a0b0283334a37be5ae288d94f776
2025-01-30 18:23:57 +00:00
elisenlebkuch b61765ec92 Add Fennec as search provider (#5227) 2025-01-31 01:34:15 +08:00
Treehugger Robot 602213809f Merge "Fixing leaks in LauncherPreview" into main 2025-01-30 09:04:29 -08:00
Artsiom Mitrokhin 371168b5e6 Fix taskbar flickering when clicking its bottom part
Using `MAIN_EXECUTOR.execute` caused the callback to sometimes
be postponed and executed out of order of other callbacks scheduled
using `Utilities.postAsyncCallback` (which uses asynchronous
messages instead [1]).

See detailed explanation in http://b/382015083#comment7.

[1] https://developer.android.com/reference/android/os/Message#setAsynchronous(boolean)

Bug: 382015083
Flag: EXEMPT bugfix
Test: manual
Change-Id: I409cf668764ffc8f7ba19b8c5e29426464ed6142
2025-01-30 06:58:53 -08:00
Charlie Anderson 8fc63d0657 Merge "Refactor ShortcutsChangedTask to Kotlin" into main 2025-01-30 06:50:30 -08:00
MrSluffy 02207fa1d8 fixed style 2025-01-30 16:24:19 +08:00
MrSluffy f06029edc1 chore : remove unused func 2025-01-30 16:17:17 +08:00
Sunny Goyal 986d7cb9c0 Fixing leaks in LauncherPreview
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
  on to the communication channel for preview.

Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
2025-01-30 00:16:08 -08:00
John Andrew Camu 0696240e4b feat : re-implement flowerpot (#5226) 2025-01-30 15:30:33 +08:00
Federico Baron 12856a32b7 When doing the special case migration where cells shift up, only modify workspace items
Fix: 393212285
Test: Verified DB values
Flag: com.android.launcher3.one_grid_specs
Change-Id: I6cd1d520a2128925664ff3ac65ec75c86a7fb54b
2025-01-30 07:00:42 +00:00
Pechetty Sravani (xWF) 72f9943f64 Revert "Unifying various model update callbacks into one"
Revert submission 31445615-model-callbacks

Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>

Reverted changes: /q/submissionid:31445615-model-callbacks

Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
2025-01-29 22:46:55 -08:00
Eghosa Ewansiha-Vlachavas 064af3dfa7 Merge "[2/n] Include default home package in windowing exemptions check" into main 2025-01-29 21:52:45 -08:00
Treehugger Robot 4a17c7ab0d Merge "Move SimpleOrientationTouchTransformer to Dagger." into main 2025-01-29 19:42:42 -08:00
renovate[bot] 9a81ca73bd fix(deps): update dependency androidx.compose:compose-bom to v2025.01.01 (#5223)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-01-30 09:32:02 +08:00
Lingyu Feng b06120f793 Merge "Rename onDisplayReady to onDisplayAddSystemDecorations" into main 2025-01-29 17:24:01 -08:00
Treehugger Robot 1a7e8991fe Merge "Using a dedicated thread executor for MSDL haptics" into main 2025-01-29 17:21:07 -08:00
Anushree Ganjam 4597aae947 Move SimpleOrientationTouchTransformer to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I2c7adf5da76f0a60c167f4c650622ba8dfeac98d
2025-01-29 17:15:03 -08:00
Charlie Anderson 722f6f3143 Refactor ShortcutsChangedTask to Kotlin
Bug: 375414891
Test: ShortcutsChangedTaskTest
Flag: EXEMPT no functionality change
Change-Id: If80b74a80abf9bed90f1572a9fee2494d39a6829
2025-01-29 16:41:29 -08:00
Treehugger Robot 473bd5c0a0 Merge "Unifying various model update callbacks into one" into main 2025-01-29 16:05:25 -08:00
Charlie Anderson fcb3d2ec38 Add folder shapes for corresponding icon shapes
Bug: 372886883
Bug: 389329983
Test: Presubmit && IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: I46b27b391fef5f379c65d81816353c93f56f2e1d
2025-01-29 14:16:56 -08:00
Adnan Begovic a610285dfa Launcher3: Introduce lint checks for Launcher3.
As part of the initial check in, add a test to ensure
  that custom Dialogs are not utilized inside of the codebase.

Bug: 389709580
Test: DialogDetectorTest
Flag: NONE Lint checks
Change-Id: I7e3f98c729cdbf4d062419c53a209d12a23b1806
2025-01-29 13:54:27 -08:00
Anushree Ganjam dc53407678 Merge "Remove flag_check.py, we now have flag directive check in gerrit presubmit." into main 2025-01-29 13:33:25 -08:00
Treehugger Robot a804d02912 Merge "Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM" into main 2025-01-29 12:04:37 -08:00
Juan Sebastian Martinez bdb090b9fb Using a dedicated thread executor for MSDL haptics
Some interactions have been experiencing delayed hapics (see bug in this
CL) due to haptics firing if a -sometimes- busy background thread. Like
in SysUI, we can avoid this by using a newSingleThreadExector when
firing one-shot MSDL feedback.

Test: manual. Rapidly selected different wallpapers and verified haptics
  played in sync with the UI update.
Flag: com.android.launcher3.msdl_feedback
Bug: 391384092

Change-Id: I1661c85976c4744058e046c7ff8386bb99c6d50b
2025-01-29 11:15:51 -08:00
Treehugger Robot 66e62820bc Merge "Add debugging logs to understand why addView gets IllegalArgumentException" into main 2025-01-29 10:58:19 -08:00
Sunny Goyal e1e6f7a024 Merge "Using roundIconRes for loading appInfo icon if launcher's icon is round" into main 2025-01-29 10:51:09 -08:00