See go/refactor-group-task for details. This is the final CL
in this refactor, where `task1` and `task2` are finally removed,
and `DesktopTask` is allowed to have empty tasks.
Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I8af39b58138f11030981311efc2e95a77cef125b
See go/refactor-group-task for details. This CL removes `mSplitBounds`
from `GroupTask` and adds `splitBounds` to `SplitTask`. This makes its
usages more intentional.
Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I9a3e8ee2e96d46f9eb79a58ffcf5efc257615aac
See go/refactor-group-task for details. This CL removes all the usages
of `task1` and `task2` from `GroupTask` in Launcher3. Follow-up CLs will
remove it from NexusLauncher and remove the fields altogether.
Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I902c8135b3a0aae95acf25267b3bcbf286bd4e7d
Change I59b886bfb632f0f26ee58c40f82f447f5ea59b41 caused a number of
launcher and WM tests to fail because the TAPL code was producing motion
events with invalid button states, or just not sending BUTTON_PRESS and
BUTTON_RELEASE events at all. While this change does not address all
possible uses of LauncherInstrumentation#sendPointer (for example,
sending a MOVE during which a button should be held down), it fixes
consistency issues in all cases currently used by tests. A more
comprehensive fix is not worthwhile since this kind of input event
injection is deprecated and should be replaced with usage of uinput or
virtual devices anyway.
Test: $ atest \
NexusLauncherOutOfProcTests:com.android.launcher3.appiconmenu.TaplAppIconMenuTest \
NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplDragTest \
NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplUninstallRemoveTest \
NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar \
'NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar#testOpenMenuViaRightClick' \
'WMShellFlickerServicePlatinumTests:com.android.wm.shell.EnterSplitScreenByDragFromShortcutGesturalNavLandscape#enterSplitScreenByDragFromShortcut'
Bug: 372571823
Bug: 392150793
Flag: TEST_ONLY
Change-Id: I5c259c13d433d3010d2cf9c6fe01e08ba5990ef7
This change is intended for the desktop use case.
Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ibbca58f1e98a6648be68fc7e3b6337f5c78160da
Removing launcher flag for taskbar in secondary display and adding it to lse_desktop_experiences.
Test: m
Bug: 393398093
Bug: 383634014
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ia73f31346eb1b3bd273ecb7801eb1264d92e6863
We just migrate them using the special case where everything shifts up
if we meet the criteria
Bug: 392978014
Test: GridSizeMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4efda781d6fbe6f3e1854b22685abd1b923c3dc4
This feature is intended for the desktop use case.
Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ifc2da01b248c7dbdbe272f4fa124b6d1182c599d
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
on to the communication channel for preview.
Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:986d7cb9c09a22915c922cf8e72c03ce36883742)
Merged-In: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
Using `MAIN_EXECUTOR.execute` caused the callback to sometimes
be postponed and executed out of order of other callbacks scheduled
using `Utilities.postAsyncCallback` (which uses asynchronous
messages instead [1]).
See detailed explanation in http://b/382015083#comment7.
[1] https://developer.android.com/reference/android/os/Message#setAsynchronous(boolean)
Bug: 382015083
Flag: EXEMPT bugfix
Test: manual
Change-Id: I409cf668764ffc8f7ba19b8c5e29426464ed6142
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
on to the communication channel for preview.
Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
Revert submission 31445615-model-callbacks
Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>
Reverted changes: /q/submissionid:31445615-model-callbacks
Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
As part of the initial check in, add a test to ensure
that custom Dialogs are not utilized inside of the codebase.
Bug: 389709580
Test: DialogDetectorTest
Flag: NONE Lint checks
Change-Id: I7e3f98c729cdbf4d062419c53a209d12a23b1806
Some interactions have been experiencing delayed hapics (see bug in this
CL) due to haptics firing if a -sometimes- busy background thread. Like
in SysUI, we can avoid this by using a newSingleThreadExector when
firing one-shot MSDL feedback.
Test: manual. Rapidly selected different wallpapers and verified haptics
played in sync with the UI update.
Flag: com.android.launcher3.msdl_feedback
Bug: 391384092
Change-Id: I1661c85976c4744058e046c7ff8386bb99c6d50b