Commit Graph
23667 Commits
Author SHA1 Message Date
Schneider Victor-tulias 9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Treehugger Robot 5f38710c0e Merge "Only use RecentsWindowManager instances for CDs" into main 2025-05-01 22:42:17 -07:00
Ajinkya Chalke b7033ceb76 Limit LauncherTaskbarUIController to primary
- Only primary displays should use LauncherTaskbarUIController.
- This change is required for overview on connected displays to work.

Bug: 362720616
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I6945107e6072561b1904dcafd6106d4317eaba1d
2025-05-02 00:37:21 +00:00
Ajinkya Chalke d616551419 Only use RecentsWindowManager instances for CDs
Bug: 414767197
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I8f2f143ef8ca885c089b83559899746ac594400a
2025-05-02 00:13:53 +00:00
Xiaoqian Dai b9d3a5cc44 desktop-exploded-view: temporarily disable the functionality...
... to launch an individual task window from desktop tile in Overview
when multi-desks is enabled, until the fix for b/413378320 is landed.

Note the changes in
http://ag/q/topic:%22activate-window-from-exploded-view%22 is the right
implementation, however it will only work for multi-desks with the fix
for b/413378320 is in place.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413378320
Change-Id: I72914d60fb0ec2e80af6faa7441a67e743720c38
2025-05-01 23:59:05 +00:00
Bill Yi 1e52b70434 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I83194d37008b416e8b9ba57c72e68b13ad6b282e
2025-05-01 23:41:03 +00:00
Vadim Tryshev bc6b9ea148 Merge "Failures caught by launcher.checkForAnomaly did not produce screenshots." into main 2025-05-01 16:29:38 -07:00
Ajinkya Chalke 98ce0f4ccb Ignore KeyboardQuickSwitchControllerTest to fix robo failure
Bug: 413540825
Flag: EXEMPT ignoring test
Test: atest
Change-Id: I75a15563fbc8cc500df73c9b1d1e9bf2e2d378b8
2025-05-01 16:16:19 -07:00
Treehugger Robot 2d65e55681 Merge "Use DesktopExperienceFlags instead of DesktopModeFlags for enableRecentsWindowProtoLog" into main 2025-05-01 15:51:42 -07:00
Treehugger Robot c3a397b01c Merge "Skip already running check when switching in KQS" into main 2025-05-01 15:29:28 -07:00
Schneider Victor-tulias 23244b6944 Merge "Move ExtendedLongPressTimeoutRule implementation to shared sysui test library" into main 2025-05-01 15:27:41 -07:00
Brian Isganitis 3b9b36255b Merge "Use LauncherPrefs for stashed handle region dark." into main 2025-05-01 13:46:44 -07:00
Vadim Tryshev 9b0d61a803 Failures caught by launcher.checkForAnomaly did not produce screenshots.
Fix to handle failures caught by launcher.checkForAnomaly so that they
are also reported to the test watcher.

Bug: 406906811
Test: presubmit
Flag: NONE Not production code
Change-Id: I379fcf09e3cd2e6321be9f4bc3dd6f3272e9c2fd
2025-05-01 13:29:18 -07:00
Schneider Victor-Tulias 3818462d0e Fix recents window activity leak
- When we clean up the recents window, the recents view gets dettached, which causes a activity leak in tests and prod through RecentsView.mOnTaskLaunchCancelledRunnable. Fixing this leak across all uses of RecentsView, rather than just for RecentsWindowManager
- Also cleaning up a potential leak in RecentsWindowManager.callbacks

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Bug: 292269949
Test: swiped up from running app, checked leak canary and heap dump; pre/post-submit tests
Change-Id: Id95b36dad6e41e5b21d1af8ede489f84ef987e50
2025-05-01 16:07:27 -04:00
Schneider Victor-Tulias a56aa0d539 Update TAPL tests to dismiss all tasks safely
Flag: EXEMPT test refactor
Bug: 377678992
Test: pre/post-submit tests
Change-Id: I6a2225bea4f004bdc598e2c67ce26da9fd42f7a6
2025-05-01 16:04:32 -04:00
Schneider Victor-Tulias 42d6c08d41 Move ExtendedLongPressTimeoutRule implementation to shared sysui test library
Flag: EXEMPT test fix
Fixes: 396862825
Test: TaskbarExpandCollapse
Change-Id: I950ed4ede8db150234d843422982792f5b6bfd8e
2025-05-01 11:38:27 -07:00
Ats Jenk 506b2a8b35 Make sure animation is cancelled for existing flyout
When we show a new flyout, it is possible for the previous flyout to
still be there and animating out.
We were removing the existing flyout, but did not cancel the animation.
This meant that there could have been a hide animation running for the
previous flyout. Once that animation finished, it removed the current
flyout from the container. It was possible for the current flyout to
already be updated to the new one. In which case the animation for the
previous flyout hid the new flyout.

Bug: 414808503
Test: atest PlatformScenarioTests:BubbleBarTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I4229297fa999d815c12eefd9d583bdfc915ec00a
2025-05-01 10:52:41 -07:00
Xiaoqian (Daisy) Dai 8eda6e708f Merge "desktop-exploded-view: Implement the activate window behavior" into main 2025-05-01 10:41:06 -07:00
Tony Wickham 41b1c52c7f Remove IME-specific touch passthrough for Taskbar
It doesn't seem necessary anymore (and anyway, existing cases like
Taskbar being stashed while IME is showing handle this as well).
Removing the specific block fixes a bug where touches were going
to the underlying app even though Taskbar window is fullscreen
while editing a Folder name.

Fixes: 400859085
Test: TaskbarInsetsControllerTest
Flag: EXEMPT bugfix

Change-Id: If30acd0b3b9c3fd0b29b94ca963beb1c70162416
2025-05-01 16:43:31 +00:00
Ajinkya Chalke 011422cdb4 Skip already running check when switching in KQS
- In KQS existing code there is a check that returns early if a user is
  trying to switch to a running task. This check returns true for a task
  that is not running thus creating an issue when user tries to switch
  to that task using KQS.
- While the root cause of the issue will take time to fix, this
  temporary check ensures that we workaround it when flatenning
  heirarchy feature is enabled. This issue happens when multi-desk
  backend flag is true and flatenning flag will always be true when
  multi-desk is true (given how the features are timed for release).

Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Test: m
Bug: 414410702
Change-Id: Ia35d6706a1512efbb4feca0128a9d59cd930df2f
2025-05-01 15:22:28 +00:00
Jordan Silva de6ce21ed5 Reset IconAppChipView when DesktopTaskView is recycled
Bug: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I119599d575c82b6cce71ac3cbb4b709914f34bda
2025-05-01 03:07:55 -07:00
Steven Ng 84cde92450 Use grantManageKeyGesturesToRecents flag for granting recents key gesture events
Reason: Recents app can only listen to key gesture events after ag/33295605, which is gated by a read only flag, com.android.window.flags.grant_manage_key_gestures_to_recents.

Test: atest NexusLauncherTests:QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Bug: 406452076
Change-Id: I66f8c9b2f23eb65bafc986321ff971c855ce00a3
2025-05-01 02:54:17 -07:00
Treehugger Robot 21df4da217 Merge "Remove dark mode Launcher3 colors for blur." into main 2025-04-30 23:50:48 -07:00
Andy Wickham 3a282d3c28 Remove dark mode Launcher3 colors for blur.
These were intended to be placeholders for non-quickstep builds,
but it seems soong ends up using the base version instead of the
override in quickstep. So now we always use the non-night version
which gets overridden correctly (and that color resource itself
defines a dark mode variant).

Test: mp launcherd - verify light and dark mode use themed colors.
Bug: 414732288
Flag: com.android.launcher3.all_apps_blur
Change-Id: I21bf8e66bf1715a8b3532931ed64725ccc3f86b9
2025-05-01 04:23:40 +00:00
Treehugger Robot 675282b181 Merge "Revert^2 "Restrict nav mode UI checks within primary display"" into main 2025-04-30 20:53:19 -07:00
Yunfan Chen 914aae9c93 Update Insets API call due to signature change
The frameworks updated the Insets API signature to support relative
insets to make the insets system works better under desktop mode and to
support more flexible usage in the future. Update the corresponding call
to match the changed signature.

Test: InsetsStateTest InsetsPolicyTests
Test: WindowContainerTests
Flag: com.android.window.flags.relative_insets
Bug: 277292497
Change-Id: Ib0d866514dcac33b72e1715f8442b695d9e9b3a0
2025-05-01 12:50:01 +09:00
Andy Wickham 1e2e88a884 Update All Apps divider color.
Also update how theming is applied. We pass a ContextThemeWrapper
to relevant views to retrieve the updated colors.

Demos switching blur on and off with adb:
 - From top (QSB, handle, divider): https://drive.google.com/file/d/1FHNzp5bNbNtH8tM7rSjKELPr6hsETPST/view?usp=drive_link&resourcekey=0-JuiAUJoNh4Pe_xKa74h0-g
 - Scrolled down (header protection + private space): https://drive.google.com/file/d/1gb1GCH3tJHS7HzOjvXgrTxNQ9gfD59dw/view?usp=drive_link&resourcekey=0-AK58FpfN-sDfWhWkmqaEmA

Test: Manual
Flag: com.android.launcher3.all_apps_blur
Fix: 413143411
Change-Id: I5da3b7c38ea4f81dec1011b6cc15ad8b591c761b
2025-05-01 02:25:02 +00:00
Treehugger Robot 1ca1bf9c9d Merge "Apply fallback overview scrim, overviewactions and clearall in battery saver mode." into main 2025-04-30 19:13:54 -07:00
Li Lin d26a7d3979 Remove URL from image model.
We decided to pass image content instead in a follow up CL.

Test: manual
Bug: 414869782
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I05167f81ac7b887cb5e00915f1ffdec0bb2dc720
2025-04-30 15:09:24 -07:00
Brian Isganitis e1a3329c39 Use LauncherPrefs for stashed handle region dark.
Flag: EXEMPT refactor
Bug: 324485921
Test: go/testedequals
Change-Id: Ib69ba1595eadd318521c88069cd867988f66c4bc
2025-04-30 16:40:46 -04:00
Jagrut Desai 95ee12ff94 Merge "Auto-Stashing Functionality for Pinned Taskbar" into main 2025-04-30 13:30:06 -07:00
Willie Koomson e11651e93a Merge "Implement collectWidgetEvent in QuickstepWidgetHolderListener" into main 2025-04-30 13:01:36 -07:00
Treehugger Robot 2b0a1dbbb3 Merge "Fix: Prevent app chip being destroyed for DesktopTask" into main 2025-04-30 12:28:32 -07:00
Jagrut Desai f52ffc1232 Auto-Stashing Functionality for Pinned Taskbar
This cl includes :
- Refactor to remove unpinning/pinning in desktop mode with refactor of DisplayController, TaksbarPinningController, and its tests.
- Combined the auto stashing conditions under one method shouldAllowTaskbarToAutoStash() which takes in consideration isTransientTaskbar, isInDesktop, and Always Show Taskbar option is turned on/off in desktop mode.
- enabled taksbar divider popup support in desktop mode.
- Intorduced animation for pinned taksbar when autostadhing is enabled.
- Enable to onSwipeToUnstashTaskbar for TaskbarInputStashController for pinned taksbar in desktop mode.

Test: Presubmit, Unit, Manual
Bug: 381535785
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ie5ecf3a3c72bf8dfadf2d0c908269305fe5bad0b
2025-04-30 10:39:58 -07:00
Sunny Goyal dd367a2218 Merge "Converting BgDataModel to Kotlin" into main 2025-04-30 10:19:46 -07:00
Willie Koomson 086e7b1d10 Implement collectWidgetEvent in QuickstepWidgetHolderListener
This change updates QuickstepWidgetHolderListener to implement the new
AppWidgetHostListener.collectWidgetEvent API.

Bug: 364655296
Test: Manual, interact with Launcher and check that events are logged
Flag: android.appwidget.flags.engagement_metrics

Change-Id: I9bf859f18025a49ef98e57e32e4b53e6547bd84b
2025-04-30 16:55:20 +00:00
Jordan Silva 8517ba500d Fix: Prevent app chip being destroyed for DesktopTask
DesktopTask shares the same iconView between different TaskContainers. When destroying a single Task in DesktopTask should not reset this shared IconAppChip.

Fix: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I40f144c836715290eabb9db49ed0582986a11945
2025-04-30 09:46:51 -07:00
Mykola Podolian 5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00
vinayjoglekar 45cb055158 Apply fallback overview scrim, overviewactions and clearall in battery saver mode.
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
   When "updateBlurStyle" is called, individual element style's swap
   happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
   for setting the "currentBlur" value.

Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
2025-04-30 17:23:42 +01:00
Schneider Victor-tulias b4692a9ea4 Merge "Update AbstractLauncherUiTest to use recents window when possible" into main 2025-04-30 06:54:19 -07:00
Treehugger Robot f4b64aaebf Merge "Revert^2 "Store bubble bar state in sysui proxy"" into main 2025-04-29 18:11:26 -07:00
Toshiki Kikuchi d1a0e640cb Revert^2 "Restrict nav mode UI checks within primary display"
This reverts commit 9d7b814eec.

Reason for revert: Cache the taskbar primary display to reduce the number of binder calls and calm down Droidmonitor. Please check the difference between PS1 and PS2.

Bug: 414092022
Bug: 413244466
Bug: 408631713
Change-Id: I24138de2e2b9975fadcdf4a27402e06e212e4a19
2025-04-29 18:00:47 -07:00
Sebastian Franco d94fa97779 Log which active controller is handling input in the BaseDragLayer
Bug: 405042311
Test: NA only adding logs
Flag: EXEMPT bug fix
Change-Id: Ibb7aac4b9baf30b7a7052180a1c4130f9d6b7cbe
2025-04-29 16:47:14 -07:00
Ats Jenk ac16eb2d73 Revert^2 "Store bubble bar state in sysui proxy"
This reverts commit fbfec0d3e1.

Reason for revert: Per the comment in the bug, this test was still failing after the rollback: https://b.corp.google.com/issues/413593389#comment7. The real culprit was a flag which was rolled back here: https://b.corp.google.com/issues/413593389#comment10.

Change-Id: Idd516b7c8576a3668f6248d8440da89867823df2
2025-04-29 15:38:05 -07:00
Sunny Goyal 036ced4703 Converting BgDataModel to Kotlin
This will allow the use of Flows in BgDataModel

Flag: EXEMPT refactor
Bug: 390572144
Test: Presubmit
Change-Id: I8fdd1635a19ae4d75260fb1ddb9cd7ab00cd0496
2025-04-29 15:37:11 -07:00
mpodolian 9764250b60 Launcher TAPL test for dragging task bar icon to the bubble bar.
Added a test and TAPL objects to check dragging taskbar icons to the
bubble bar.

Fixes: 388910897
Test: TaplTestTaskBarIconDrag
Flag: EXEMPT test
Change-Id: I8a3e64a83c72a9f6b89b2f8a875ca6565d501701
2025-04-29 15:32:41 -07:00
Pierre Barbier de Reuille 9f23a4cb06 Merge "Enable DesktopExperienceFlags in developer option for features in teamfood" into main 2025-04-29 15:21:14 -07:00
Xiaoqian Dai 107f85d20c desktop-exploded-view: Implement the activate window behavior
Clicking on one task window in the desktop exploded view, it should
activate that task window.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437, 410888109
Change-Id: I1836bf0babcec039ef76b13ecd40f87a8ab4d822
2025-04-29 22:03:41 +00:00
Schneider Victor-Tulias b8440b75ef Update AbstractLauncherUiTest to use recents window when possible
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Id3ddc11aa9163df3f2914edba66e1db36fdde63b
2025-04-29 14:13:26 -07:00
Ats Jenk 861f887dfe Merge changes I91a3b558,Ifc9c391a,I3da2bc22,Ied187c63,I859b7359 into main
* changes:
  Store bubble bar stashed state during rotation [6/N]
  Restore bubbles without affecting bar state [5/N]
  Do not animate bubbles from initial update [4/N]
  Store and restore selected bubble and expanded state [3/N]
  Do not animate bubble bar for initial state [2/N]
2025-04-29 13:17:42 -07:00