Files
Flexera-Launcher/tests/src/com/android/launcher3/util/MultiScalePropertyTest.kt
T
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00

94 lines
2.1 KiB
Kotlin

package com.android.launcher3.util
import android.view.View
import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.filters.SmallTest
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith
/** Unit tests for [MultiScalePropertyFactory] */
@SmallTest
@RunWith(AndroidJUnit4::class)
class MultiScalePropertyTest {
private val received = mutableListOf<Float>()
private val factory =
object : MultiScalePropertyFactory<View?>("Test") {
override fun apply(obj: View?, value: Float) {
received.add(value)
}
}
private val p1 = factory.get(1)
private val p2 = factory.get(2)
private val p3 = factory.get(3)
@Test
fun set_multipleSame_bothAppliedd() {
p1.set(null, 0.5f)
p1.set(null, 0.5f)
assertThat(received).containsExactly(0.5f, 0.5f)
}
@Test
fun set_differentIndexes_oneValuesNotCounted() {
val v1 = 0.5f
val v2 = 1.0f
p1.set(null, v1)
p2.set(null, v2)
assertThat(received).containsExactly(v1, v1)
}
@Test
fun set_onlyOneSetToOne_oneApplied() {
p1.set(null, 1.0f)
assertThat(received).containsExactly(1.0f)
}
@Test
fun set_onlyOneLessThanOne_applied() {
p1.set(null, 0.5f)
assertThat(received).containsExactly(0.5f)
}
@Test
fun set_differentIndexes_boundToMin() {
val v1 = 0.5f
val v2 = 0.6f
p1.set(null, v1)
p2.set(null, v2)
assertThat(received).containsExactly(v1, v1)
}
@Test
fun set_allHigherThanOne_boundToMax() {
val v1 = 3.0f
val v2 = 2.0f
val v3 = 1.0f
p1.set(null, v1)
p2.set(null, v2)
p3.set(null, v3)
assertThat(received).containsExactly(v1, v1, v1)
}
@Test
fun set_differentIndexes_firstModified_aggregationApplied() {
val v1 = 0.5f
val v2 = 0.6f
val v3 = 4f
p1.set(null, v1)
p2.set(null, v2)
p3.set(null, v3)
assertThat(received).containsExactly(v1, v1, v1 * v2 * v3)
}
}