Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.
Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
Revert submission 17935777-lightDarkDetection
Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow
Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.
Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.
Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.
Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
- Update Info when perDisplayBounds has changed
- Add more detailed logging to displayInfo, realBounds and perDisplayBounds
- Add perDisplayBounds to dumpsys and replace supportedBounds
Bug: 233562339
Test: manual
Change-Id: I9a040e8465a8b0a2dcde61bab06c6ca1df3006da
The spec had a typo (EMPHASIZED_DECELERATE instead of
EMPHASIZED_ACCELERATE). In addition, we're now using LINEAR for the
background since the feel is smoother this way. Cleared with motion
(simonroberts@).
Bug: 232418544
Test: manual
Change-Id: I492dbe8008856d331836793177f1dd58c3265ca2
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.
Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.
Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12
Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.
Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.
Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.
Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
The functions PreviewItemManager.updatePreviewItems calls
PreviewItemManager.buildParamsForPage using mFirstPageParams and it
expects that mFirstPageParams contains the values before the reoredering
but they get updated in a previous call to updatePreviewItems(false),
so when doing the animation, the icons are animated to their current
position and nothing changes.
Fix: 233401274
Test: Add icons to a folder 1 to 5 without expanding the folder and
make sure they animate to their new position. Make sure they animate
when removing items as well.
Change-Id: Ia3e1393d8fb2b30eb107e8b2c6eefdf9e50e9f70
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall
Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization
Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.
Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9