Commit Graph
14170 Commits
Author SHA1 Message Date
TreeHugger Robot 2d674d6f03 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev am: 5069964ea2 am: 67d79af886
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18763224

Change-Id: Ic9c5e84835e0c7c714540d8c914486255dbe9dee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 03:54:09 +00:00
TreeHugger Robot 5069964ea2 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev 2022-06-22 03:23:07 +00:00
Alex Chau 485d77d6f9 Merge "Only check dbFile to decide if grid migration is needed" into tm-qpr-dev am: bd8111a049 am: ea4cd21275
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18929060

Change-Id: I03640ef87c3edf56b59037a21885748705602ced
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-21 20:51:44 +00:00
Alex Chau bd8111a049 Merge "Only check dbFile to decide if grid migration is needed" into tm-qpr-dev 2022-06-21 20:08:53 +00:00
Alex Chau aa9e4a28cf Merge "Revert "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: 61c6b580ad am: 7b695ca337
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18929971

Change-Id: I2e6be505e70730d5e9222949350e35aac0b2ed56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-21 18:52:27 +00:00
Alex Chau 49dcd16b26 Only check dbFile to decide if grid migration is needed
Fix: 234847755
Test: With a modified local build, when changing display config to swap between same grid:
- When dbFile is same but device type is different, no migration is performed
- When both dbFile and device type are different, migration is performed properly
Test: Grid migration through Wallpaper & Styles still works properly

Change-Id: Ie7429a7d59c135ba47061cae21c40b8d8af7188a
2022-06-21 12:36:50 +00:00
Sukesh Ram 521daeb05d Merge "Add app predictions to secondary display app drawer & fix tab UI." 2022-06-17 21:36:46 +00:00
Ronish Kalia 45ed73d955 Merge "Change access from private to protected for OverlayEdgeEffect vars" 2022-06-17 17:33:28 +00:00
Alex Chau b065b4b05a Revert "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit d3e8cc40b4.

Reason for revert: b/231312158 is fixed, log is no longer needed
Fix: 231851651

Change-Id: I3ea8b9d14e7eb6f8f9c794c5d15cdfc94153d392
2022-06-17 09:36:00 +00:00
Sunny Goyal bbad97e273 Unifying scroll calculation logic for both widgets and apps recycler view
Also using itemType instead of item object for widget size cache

Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
2022-06-16 16:03:37 -07:00
Sukesh Ram 9e5fe63a22 Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-06-16 22:44:24 +00:00
Sebastián Franco b4c50d485e Merge "Adding a case when there is only 1 system shortcut on the Popup Container" into tm-qpr-dev am: 2545f45a1f am: 2c102c3b73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18284907

Change-Id: I9a684963b00da3ff6a994221cfece78846dbae32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 17:39:49 +00:00
Sebastián Franco 2545f45a1f Merge "Adding a case when there is only 1 system shortcut on the Popup Container" into tm-qpr-dev 2022-06-16 17:01:10 +00:00
Luca Zuccarini c703f3a3e0 Unify the source of truth for NORMAL <> ALL_APPS transitions.
Bug: 231682175
Bug: 234812580
Test: manual
Change-Id: I5b66735474915d7a59bda337f67df37ff397908a
2022-06-16 16:40:26 +00:00
Thales Lima df50439f5e Merge "Fix QSB alignment" into tm-qpr-dev am: 85e52e2f9d am: d4b0c446b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18910227

Change-Id: I2d3e0926567e158f1f33e0427ba71fdeeb89f859
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 13:01:49 +00:00
Thales Lima 85e52e2f9d Merge "Fix QSB alignment" into tm-qpr-dev 2022-06-16 12:19:45 +00:00
Alex Chau b583f18e35 Merge "Animate inline QSB between home and apps" into tm-qpr-dev am: a5ae4c2e57 am: 7e77cda9d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18799573

Change-Id: I3dae91a244c996474f4ec31a950323c1fc5c2716
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 08:49:02 +00:00
Alex Chau a5ae4c2e57 Merge "Animate inline QSB between home and apps" into tm-qpr-dev 2022-06-16 08:00:51 +00:00
Brandon Dayauon da9e22f4e9 Merge "Fix work toggle button to be placed where it should be." into tm-qpr-dev am: 111473315d am: d7450579f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18841742

Change-Id: If171dbd8e2cf9beec7b57d3cd4b8c769027b156d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 23:16:00 +00:00
Brandon Dayauon 111473315d Merge "Fix work toggle button to be placed where it should be." into tm-qpr-dev 2022-06-15 22:05:49 +00:00
TreeHugger Robot 99180e0eb6 Merge "Fix folder preview animation when adding or removing icons." into tm-qpr-dev am: 34958f4bdf am: b67104fadb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18568370

Change-Id: I05428b0b31997e2afd042d7c3f58c5d77b5e03a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 21:59:05 +00:00
TreeHugger Robot 34958f4bdf Merge "Fix folder preview animation when adding or removing icons." into tm-qpr-dev 2022-06-15 21:20:55 +00:00
Alex Chau c1d26448c5 Animate inline QSB between home and apps
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home

Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
2022-06-15 22:12:29 +01:00
Vinit Nayak d18304ca15 Close all open views for 1P and 3P launchers
* Previously TaskView was closing task menu view, but
that got removed since launcher was doing that on
state transition.
* Only 1P launcher was doing that and not 3P launcher,
moved call to remove open views to parent class

Test: Invoking split on 3P launcher doesn't result in a crash
Bug: 199342537
Change-Id: I6afbe7640ede362a677e15a33409a7cabdb8cca9
2022-06-15 14:09:49 -07:00
Pinyao Ting e5dbb75acd Cache and reuses LauncherAppWidgetHostView when launcher resumes
Currently by design when launcher enters the background, it stops
listening to updates in widgets. This eventually causes the dilemma
for launcher when it resumes, before the update can be returned from
the system process via IPC, launcher could do one of the following
to fill the gap:
1. show a deferred widget view -- a placeholder that renders the shape
   of the widget -- to let the user know widget is being reloaded.
2. show whichever widget view that was previously displayed to the
   user that may now contain stale content.

There is a descrepancy here since in some edge cases we are showing the
former while in most other cases we are showing the later. This CL added
a short-term fix to address the descrepancy and favors the later where
possible.

Bug: 218067434
Test: manual
Change-Id: I6cd2cd704186267227e2ec47f2581843fd526fa0
2022-06-15 13:23:31 -07:00
Tony Wickham bed0d636fe Proper fix for gesture nav flicker using runOnPageScrollsInitialized()
I root caused the two areas causing the flicker:
A. If page scrolls aren't initialized when we get onActivityInit(), the first scroll even after linkRecentsViewScroll() will jump based on min scroll (due to Clear all button). Fix is to defer linking until page scrolls are initialized.
B. If page scrolls aren't initialized when the gesture starts, RecentsView can jump to the min scroll when calling showCurrentTask(), since that calls setCurrentPage(getRunningTaskIndex()) which might be out of bounds. Fix is to defer that setCurrentPage() until page scrolls are initialized.

Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Fixes: 233112195

Change-Id: I000960775f8735920d97c87942065a430c9dce0c
2022-06-15 19:08:32 +00:00
Thales Lima 616e0102a4 Fix QSB alignment
Fix: 232908328
Test: manual
Change-Id: If5516be6b8f7142577257f5ec5b5dfa8feca445d
2022-06-15 11:40:58 +01:00
Hyunyoung Song b751033f30 Merge "Remove hideKeyboard exception in the log" into tm-dev am: 5d57e3d651 am: 76e688b7c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18869544

Change-Id: I2131e1676c613f0df96d9989876632d5fa282e4b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 06:39:06 +00:00
Hyunyoung Song 79d1711d7f Merge "Remove hideKeyboard exception in the log" into tm-dev am: 5d57e3d651 am: b0ca13b68e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18869544

Change-Id: I0b7dbe20eb79511b04a23235432d840cb017a170
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 06:28:49 +00:00
Hyunyoung Song 5d57e3d651 Merge "Remove hideKeyboard exception in the log" into tm-dev 2022-06-15 05:38:16 +00:00
Tony Wickham a763a7ccd4 Merge "Revert line that could wrongly initialize RecentsView scroll" into tm-dev am: 4ee29221df am: 356eaea195
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18820561

Change-Id: I83c63625c78cc4ce8791ac6190a2e758bd7713b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 03:14:42 +00:00
Tony Wickham a18bd359f0 Merge "Revert line that could wrongly initialize RecentsView scroll" into tm-dev am: 4ee29221df am: ac013bff7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18820561

Change-Id: Ib2ede0af3fe36082f06fe22461373b992f94909d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 03:14:00 +00:00
Tony Wickham 4ee29221df Merge "Revert line that could wrongly initialize RecentsView scroll" into tm-dev 2022-06-15 02:23:13 +00:00
hyunyoungs 6677fa3cf3 Remove hideKeyboard exception in the log
Bug: 235616419
Test: no error stack trace
Change-Id: Ice5a52edaed2fb0485696a4586552792b0b5b932
2022-06-14 17:03:47 -07:00
Tony Wickham 3945f028de Revert line that could wrongly initialize RecentsView scroll
Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Bug: 233112195
Fixes: 235369468

Change-Id: Ie8b3dbea7c4826af037edf22360946105ab22134
2022-06-14 19:17:55 +00:00
Brandon Dayauon 105448abec Merge "ENABLE_HIDEHEADER_PRIVATE_IME" into tm-qpr-dev am: c40daffac5 am: 7505a90590
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18875017

Change-Id: I66ee4d73e763264e5d7a4c693dc2b33aca005d0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-14 06:38:37 +00:00
Brandon Dayauon c40daffac5 Merge "ENABLE_HIDEHEADER_PRIVATE_IME" into tm-qpr-dev 2022-06-14 05:59:49 +00:00
Brandon Dayauon 452ee1e45a ENABLE_HIDEHEADER_PRIVATE_IME
Add featureflag to have the hide header feature
Bug: 222862488
Test: Manual

Change-Id: I5e0cd0e5d40e0eb2d70e95b4981e6b2c7835cf0d
2022-06-13 14:29:17 -07:00
Hyunyoung Song 4ae74678ce Merge "Workspace should not receive touch events" into tm-dev am: 5c33ec3766 am: f30d5d1d5b am: 7ae633a89f am: d6ee774445
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18791871

Change-Id: I085e487e013cecadbb0ad900d3c78f04cbb5db5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-13 18:09:20 +00:00
Hyunyoung Song 7ae633a89f Merge "Workspace should not receive touch events" into tm-dev am: 5c33ec3766 am: f30d5d1d5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18791871

Change-Id: Ic9e5e4ed66277eded872ace970d3b20387a07bdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-13 17:16:47 +00:00
Hyunyoung Song 5c33ec3766 Merge "Workspace should not receive touch events" into tm-dev 2022-06-13 16:30:19 +00:00
ronish d7dea43c54 Change access from private to protected for OverlayEdgeEffect vars
Note: Not using getters and setters as the code seems to be be neater
this way.

Change-Id: If463b73d89c249f3f0faa746a79ef4dac413a5ea
2022-06-13 12:20:23 +00:00
Becky Qiu 88daaef37a Merge "[Toast] Add a new type fields for user visible cold status." into tm-dev am: a500cde8f2 am: 748ef6c244 am: 51f1b987a3 am: ec5a9c52f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821283

Change-Id: I806db434560fc64e3b757a42d3e3d5d8c5aee94b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 09:37:27 +00:00
Becky Qiu 51f1b987a3 Merge "[Toast] Add a new type fields for user visible cold status." into tm-dev am: a500cde8f2 am: 748ef6c244
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821283

Change-Id: I516efb76f7c79000b7018593c1883a356c376b04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 08:38:23 +00:00
Becky Qiu a500cde8f2 Merge "[Toast] Add a new type fields for user visible cold status." into tm-dev 2022-06-11 06:00:46 +00:00
Becky Qiu 88bc0c4dc2 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: ae9ab8a8bf am: 4b748464e0 am: e2331247e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: I9b744ab62644d02aa4a9fcf7788d9014dab0d26a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 03:25:22 +00:00
Becky Qiu e2331247e4 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: ae9ab8a8bf am: 4b748464e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: I32baa32d48248ecc7ed4419ec7fa9fb8de9af384
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 03:06:06 +00:00
Becky Qiu b35ca57046 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: a95e5116d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: Ie6b938fcb5faebeea986950c39a20ff0ca513259
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 02:49:54 +00:00
Becky Qiu d6d0dc3ca8 Merge "Hide keyboard when thumb scroller is visible." into tm-dev 2022-06-11 01:45:36 +00:00
Brandon Dayauon 9d87b0c317 Fix work toggle button to be placed where it should be.
Previously, the implementation used the entire screen width
within it's calculations to determine where the button should be placed.
This is wrong because allApps have it's own container which we should
take the width from. The current implementation works fine because
the width of the screen for phones is the same width as the allApps container
BUT this implemention is WRONG for tablets. With now using the
allApps width for the calculation .. it works for both tablets/phones.

Bug: 235054324
Test: Photos in bug thread
Change-Id: I4c771d310a5d33646ad618e9c241cb5662493747
2022-06-10 15:57:01 -07:00