Commit Graph
106 Commits
Author SHA1 Message Date
Vinit Nayak f40547f857 Merge "Hide back button if IME shows in SUW" into tm-qpr-dev am: 188c8916ee am: e0f012491c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004092

Change-Id: I183a0c6ba60dffdef48815a8bf22be6863394151
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 20:25:52 +00:00
Vinit Nayak 8453f86320 Merge "Add margin to SUW back button" into tm-qpr-dev am: 64510b48b0 am: 55298f9901
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004084

Change-Id: I5e43c49bd2b5fc2bd088137c3c998eec6b9eeeac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 04:29:54 +00:00
Vinit Nayak 7523b94105 Hide back button if IME shows in SUW
Fixes: 230830643
Test: Visually see no back button when IME
shows up on enter pin screen

Change-Id: Icdde92d39962c3891a56bb07de5b16a22635729e
2022-09-29 15:47:15 -07:00
Vinit Nayak c7295ee37a Add margin to SUW back button
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.

Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity

Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
Brian Isganitis 80014b118a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev am: 815018be9a am: 7fc8bf0c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040590

Change-Id: I4b1e3d676569c0f06f4963b3c83727d534fd40f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26 23:31:49 +00:00
Brian Isganitis 731ef0c301 Properly color taskbar nav buttons when slide-in view is shown.
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.

Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A

Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789

Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Winson Chung 3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Winson Chung 252ec11e4e Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Pat Manning ee1caf18c6 Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev am: e51e6446ad am: ff3accd144
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659547

Change-Id: Ie1d9cf06bf012a9ae596ff1e7cc1240ae50b7e90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 14:46:18 +00:00
Pat Manning 401f6bb0d4 Undim kids nav icons on a11y focus and click.
Fix: 241298057
Test: manual
Change-Id: I9a330bde4641a01b4d19dc83c8f25f56a69328c8
2022-09-01 12:42:04 +01:00
Vinit Nayak 2d6442c5e6 Merge "Show 3 button nav on phone in Taskbar (1/2)" into tm-qpr-dev am: 89be3a4c6d am: 72864a13db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19534821

Change-Id: Ib9ef7e0923dea9e1700208b9dbdd20ee4368b063
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 04:19:00 +00:00
Vinit Nayak 89be3a4c6d Merge "Show 3 button nav on phone in Taskbar (1/2)" into tm-qpr-dev 2022-08-10 03:06:53 +00:00
Vinit Nayak 8a3d05587e Show 3 button nav on phone in Taskbar (1/2)
* TODO: Landscape/seascape support,
        Separate nav spacing out into
        separate class/add tests

Bug: 219035565
Change-Id: I8f5c007f04ea4d6df15962772806356181d764ff
2022-08-09 13:25:50 -07:00
Pat Manning 7b0870c1d2 Merge "Skip button layout spacing call when kids nav bar is active." into tm-qpr-dev am: 80d33f35a9 am: d6142daa10
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19459614

Change-Id: I40806b87f34c23577565a326a6b8246464294650
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-06 02:25:58 +00:00
Pat Manning f3783291ec Skip button layout spacing call when kids nav bar is active.
Fix: 240530037
Test: manual.
Change-Id: Ibf777dfdaab3c81da8feed581a0297f09a62539d
2022-08-05 10:35:07 +00:00
Schneider Victor-tulias 2d1a071f16 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev am: f6003ff070 am: de490c6bb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19051009

Change-Id: I3c105a7632851acbb36be8607b51c23d9d3b2a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 19:05:19 +00:00
Schneider Victor-tulias f6003ff070 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev 2022-07-26 17:29:33 +00:00
TreeHugger Robot d33659576c Merge "Space out 3 button nav on taskbar" into tm-qpr-dev am: 5e6fe32818 am: 2a8906bfba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19272533

Change-Id: I2ea492fac54d0fabf1af92500e2ad102855c4c79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 17:21:17 +00:00
Vinit Nayak c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
Schneider Victor-tulias 3f6c473164 Fade out the taskbar icons when animating to overview in 3 button nav.
Bug: 231213105
Test: from home, opened recents, then went back home, then went back to recents, resumed an app, then went back to recents and resumed the same app (both in 3-button and gesture nav)

Change-Id: I83b1b33cafb95353f36a126b93fcaf3b536d3bf4
2022-07-19 11:35:37 -07:00
Tracy Zhou 282a504f1d Merge "Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)" into tm-qpr-dev am: 1092ccacbf am: dc8edee14d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19072234

Change-Id: I7cb11a850f9101dfb226b2bdc4ec2685572e2b1c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-29 22:32:47 +00:00
Tracy Zhou 1092ccacbf Merge "Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)" into tm-qpr-dev 2022-06-29 21:27:17 +00:00
Tracy Zhou 7d0ff06995 Merge "Perform haptic feedback on nav button key press" into tm-qpr-dev am: 6663ebba3e am: 894d75f27a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19053212

Change-Id: I71e2af12cc4f82ea936b223c266fa40be52716df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-28 01:47:31 +00:00
Tracy Zhou 6663ebba3e Merge "Perform haptic feedback on nav button key press" into tm-qpr-dev 2022-06-27 22:55:42 +00:00
Tracy Zhou 38afa9ba34 Merge "Fix ime switcher not showing for 3-button nav" into tm-qpr-dev am: f9fafe7a92 am: 03c4e3af2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19066374

Change-Id: Id04f26c0e71181cfb32a7cd5932f06c6c7cc832b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-25 07:07:25 +00:00
Tracy Zhou 849a0c4e81 Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows; and doesn't show with virtual keyboard
Change-Id: Ib9a5880eb1bd6d5b877a9f3789ce858f399c4910
2022-06-24 23:40:41 -07:00
Tracy Zhou 804feb76e7 Fix ime switcher not showing for 3-button nav
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows
Change-Id: Iabde149e8bcd1edacff8e039f956628c69341ecb
2022-06-24 11:17:40 -07:00
Tracy Zhou 0a0fcb809c Perform haptic feedback on nav button key press
Fixes: 203614307
Test: manual
Change-Id: Icaea3f5e436522f23202c20fcc7f7c5dbe309372
2022-06-23 14:29:34 -07:00
Tony Wickham 9a54d2aa43 Hide taskbar while VoiceInteractionWindow is visible
- Fade out icons (or stashed handle if stashed)
- Move background to APPLICATION_OVERLAY layer (behind VIW)
  - Only for gesture nav
- On home screen in 3 button mode, translate buttons down when assistant
  is invoked

Test: Invoke assistant, ensure it draws above taskbar background and
taskbar stops drawing icons or stashed handle
Bug: 225200928

Change-Id: I7807d30df8f358295b8231d89217c7413f32c6f9
Merged-In: I7807d30df8f358295b8231d89217c7413f32c6f9
2022-06-09 05:21:42 +00:00
Tony Wickham d127d521f1 Hide taskbar while VoiceInteractionWindow is visible
- Fade out icons (or stashed handle if stashed)
- Move background to APPLICATION_OVERLAY layer (behind VIW)
  - Only for gesture nav
- On home screen in 3 button mode, translate buttons down when assistant
  is invoked

Test: Invoke assistant, ensure it draws above taskbar background and
taskbar stops drawing icons or stashed handle
Bug: 225200928

Change-Id: I7807d30df8f358295b8231d89217c7413f32c6f9
2022-06-08 17:23:45 +00:00
Brian Isganitis a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00
Brian Isganitis 76900ac58a Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Bug: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-24 23:30:36 +00:00
TreeHugger Robot 6ad150d8a0 Merge "Remove long press on home button for kids mode." into tm-dev am: 8d5c3e91cf am: f6ccde8079
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18230546

Change-Id: I68a99489ca0d9dfe3c14fd8198ee625c01e702e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-09 22:17:43 +00:00
Vinit Nayak bb22b0994f Merge "Extend recents button hitbox on tablet" into tm-dev am: 46d95995aa am: e50b15862e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17958719

Change-Id: I14bfce27e1e9255b24c7b43293bc20f7b6833638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-09 22:01:08 +00:00
TreeHugger Robot 8d5c3e91cf Merge "Remove long press on home button for kids mode." into tm-dev 2022-05-09 19:22:11 +00:00
Pat Manning 52bb52aeb4 Remove long press on home button for kids mode.
Fix: 229961238
Test: manual
Change-Id: Idb50d4e142b1d1b0539a71b7a727d00dc76c6a68
2022-05-09 16:57:33 +01:00
Vinit Nayak b1436b0ae7 Extend recents button hitbox on tablet
* Extends hitbox when recents is tapped
when going from taskbar to overview.
* Extended region lasts for 400ms after
the animation ends.

Fixes: 225885714
Test: Manual, added unit test
Change-Id: I8766279c1a5bf6867f8d69ddd3af2aa3565deec2
2022-05-06 17:04:47 -07:00
Schneider Victor-tulias 9b6babf839 Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
Merged-In: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
(cherry picked from commit 9c1a452a1d)
2022-05-02 18:45:01 +00:00
Schneider Victor-tulias 9c1a452a1d Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
2022-04-25 14:57:13 -07:00
Tony Wickham 36c9d888d8 Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
Merged-In: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-20 19:27:48 +00:00
Tony Wickham 0a73beb65d Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-19 23:24:04 +00:00
Tracy Zhou 6bf22f786b Merge "Do not append additional delimiters" into tm-dev am: bb75f59792 am: 6811c5b8ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17528595

Change-Id: Ia11c0410168db21e7c9c9855f518225d6b2a5dce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-01 05:05:12 +00:00
Tracy Zhou 0439fcdd5c Do not append additional delimiters
Fixes: 227665358
Test: N/A
Change-Id: I6ec0bca286c0824e474f04a61b7d855858490120
2022-03-31 17:15:46 -07:00
Vinit Nayak 6996c40660 [automerge] Hide taskbar when launcher receives nav and keyguard showing 2p: c750e3d3aa 2p: ea034204db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17358924

Change-Id: I72147a61f31a62f0a33def4e275c6ff6b46210e9
2022-03-23 21:11:42 +00:00
Vinit Nayak c750e3d3aa Hide taskbar when launcher receives nav and keyguard showing
* On large screen we receive notification shade expanded
signals even on keyguard.
* Add a check to not show taskbar if keyguard is showing

Fixes: 223465924
Test: Taskbar doesn't show on 3 button nav except
on bouncer, as expected.

Change-Id: I4a7ea14422eda13ae8571793ed7ba1a1964072d6
2022-03-23 14:09:25 -07:00
Winson Chung 6fe89eafa4 Fix issue with two back buttons showing during SUW
- We should also hide the back button when the IME is
  showing during SUW

Bug: 205803355
Test: Enter SUW, show IME and verify we hide it
Change-Id: I79b8061f01754e79508d82cdd265a97f218b13cc
2022-02-15 06:46:00 +00:00
Yohei Yukawa 697ae451d4 Use config_imeDrawsImeNavBar in Launcher
With this CL, the Launcher starts checking

  config_imeDrawsImeNavBar [1]

instead of

  config_navBarInteractionMode

when determining whether the IME should render the back and IME
switcher buttons or not.

There should be no observable behavior change as long as

  config_navBarInteractionMode

is set to true when the gestural navigation is enabled.

Bug: 216118048
Test: presubmit
Change-Id: Ia8269e240e0b18e1c7b8bd550dbb197ad58a6dbc
2022-02-08 07:47:29 -08:00
TreeHugger Robot 790146d1d8 Merge "Do not translate taskbar icons in kids mode when IME present." 2022-01-28 15:05:15 +00:00
Pat Manning 05ff09c52c Do not translate taskbar icons in kids mode when IME present.
Test: manual
Bug: 203749295
Change-Id: I6958ed95f1199c1178487134b92ff3ef0f15da2e
2022-01-28 12:22:17 +00:00
Pat Manning e9a36099db Merge "Animate icon dimming in taskbar when force showing in immersive mode." 2022-01-28 10:24:07 +00:00