Commit Graph
78507 Commits
Author SHA1 Message Date
Jeremy Sim 635815666c Fix 2 bugs involving split staging task translation am: 978b0021a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546

Change-Id: Iffca62d17d40b168ff53c5624dc09dda2fbe4fec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 01:23:06 +00:00
Jeremy Sim 978b0021a9 Fix 2 bugs involving split staging task translation
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.

Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().

Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
Thales Lima 517cafff18 Check for view measurement before animating
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.

Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
2022-09-30 16:04:42 +01:00
Android Build Coastguard Worker 6b7accb4c2 Snap for 9121707 from 888f745490 to tm-qpr1-release
Change-Id: I162b782d4cfcfb01e57a05d524eec980de8fc1b9
2022-09-29 23:26:05 +00:00
Vinit Nayak 7523b94105 Hide back button if IME shows in SUW
Fixes: 230830643
Test: Visually see no back button when IME
shows up on enter pin screen

Change-Id: Icdde92d39962c3891a56bb07de5b16a22635729e
2022-09-29 15:47:15 -07:00
Vinit Nayak c7295ee37a Add margin to SUW back button
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.

Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity

Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
Brian Isganitis 222efcd6ff Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd am: 00f9389e4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647

Change-Id: I3bc1c036de3d27af1113b118e13236c913dcca33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 22:13:43 +00:00
Andy Wickham 2091a2e0a0 Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev am: 7f31d4c0ec am: d74a679987
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040589

Change-Id: I6786cbcc32af51cffb2a4882b904b54b0b62d2bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 22:12:43 +00:00
Brian Isganitis 00f9389e4e Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647

Change-Id: Ie484ca3d0918573c7e706ddea23823ea82cc9f1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 21:41:47 +00:00
Andy Wickham d74a679987 Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev am: 7f31d4c0ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040589

Change-Id: I3ec33607bb9d2ac702b4b0dc608538a4fd31b022
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 21:41:25 +00:00
Brian Isganitis f733a716fd Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev 2022-09-29 21:13:59 +00:00
Andy Wickham 7f31d4c0ec Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev 2022-09-29 21:08:20 +00:00
Andy Wickham 4c96814b1c Fix layout for multi-element rows (e.g. Screenshots).
Demo with standard 3 element row and overflowing 2 element row:
https://drive.google.com/drive/folders/1o1gvD3mOxFmVW2vqjn3D1Gukz-ie_kmW?resourcekey=0-bHRsdqpUWITEUo39tAMJDg&usp=sharing

Test: Manually with 1, 2, 3, and 4 length rows of 3 screenshots
and putting web suggestions into 2 columns.
Fix: 247837336
Bug: 239927522

Change-Id: I391beb7a24f189b5e55cb7b65c5ffc8349c83cfc
2022-09-29 10:38:20 -07:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets.
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
2022-09-29 11:12:31 +01:00
Tracy Zhou c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Android Build Coastguard Worker 18f61028dd Snap for 9117328 from 5317efb7fc to udc-release
Change-Id: I81646c208c9db574d682a83f071fbd2c8eed9edc
2022-09-29 01:25:35 +00:00
Android Build Coastguard Worker 53bac7c6b3 Snap for 9115816 from 0c7d83bb14 to tm-qpr1-release
Change-Id: Id1c0e87a0a7ae4b3e857277809aa876cd1de3082
2022-09-28 23:26:13 +00:00
Federico Baron 0602e93426 Fix the entry animation for delightful pagination in folders
Here we fix the animation that was broken in earlier CL's for delightful pagination, now the page indicator has the same smooth entry animation as the dots

Bug: 247561880
Test: manual
Change-Id: I3e2099ba4f5ccfdbc9b4dfe5b48a1c44dbdeda1e
2022-09-28 16:17:51 -07:00
Vinit Nayak 5317efb7fc Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490 am: 64e8d014a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375

Change-Id: I7984e13e5169750ba8aedffdbf4bc485dc4a00ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 19:41:32 +00:00
Vinit Nayak 64e8d014a0 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375

Change-Id: I897b8dde1e1691f4fc2c9ca632dcf7579f186b3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 18:58:35 +00:00
Vinit Nayak 888f745490 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-28 18:30:16 +00:00
Android Build Coastguard Worker 46c385888c Snap for 9112360 from 977cad62e0 to udc-release
Change-Id: I6479de0646815b8f59024ae856dee77ce4565692
2022-09-28 02:36:04 +00:00
Arthur Hung 401b9b6614 Refactor back navigation animtion (2/2)
Use IBackAnimationRunner to receive the animation leashes.
Use IRemoteAnimationFinishedCallback to callback when animation finished.

Bug: 241808055
Test: atest BackNavigationControllerTests BackAnimationControllerTest
Change-Id: I315df5079b30159fc0f6da2b568af334d14b32a0
2022-09-28 02:27:23 +00:00
Holly Jiuyu Sun a81200b8ee Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev am: 0c7d83bb14 am: 770e65305f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029264

Change-Id: Id17b7fdb1c66e8b317df1c77e0c49da3a1197aab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 01:21:57 +00:00
Holly Jiuyu Sun 770e65305f Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev am: 0c7d83bb14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029264

Change-Id: I6d3b94b50bc2747df873413216b84cacb34ba87d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 00:25:54 +00:00
Holly Jiuyu Sun 0c7d83bb14 Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev 2022-09-27 23:49:53 +00:00
Brian Isganitis c7c2e8d7e6 Avoid syncing voice interaction background window for skipAnim=true.
Test: Manual
Fix: 236924161
Change-Id: Iaf95221678d36f9b5782fd8c4bda626b946565a9
2022-09-27 23:36:24 +00:00
Android Build Coastguard Worker 1cde8ddd7b Snap for 9111705 from d8b78523ca to tm-qpr1-release
Change-Id: I0b2665d83be388ec57face595d0b3126846d029c
2022-09-27 23:25:18 +00:00
Sebastian Franco fa37a0ad9b Fix repeated empty workspaces after changing the grid size.
There are specific scenarios when you can force an extra empty
workspace after changing the grid, fortunately there is a
function that removes empty workspaces.

Fix:229349287
Test: Add a widget in a new empty workspace page, change the
grid then remove the widget in the new grid size then return
to the previous grid and it shouldn't have an empty workspace.

Change-Id: I7b73ae2ca058bc84b3b361930e3dc856c045281b
2022-09-27 21:51:17 +00:00
Bill Yi 977cad62e0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 93105ebf75 -s ours am: 5fb4baf917 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Iec61180bf7cd3f65efce08a024509dc5bad15b03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:54:33 +00:00
Bill Yi c858d86156 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 986c1a40ca -s ours am: d3902030d6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I782e895263a1fd9559122b9ba04933675f3aad90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:36:38 +00:00
Bill Yi 5fb4baf917 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 93105ebf75 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I4fef08f335458efbe510bffdabab4af00905d76e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:17:33 +00:00
Automerger Merge Worker bd2fbf3be1 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 30604f70f0 -s ours am: 9d7aff403e -s ours am: 7172f1d73f -s ours" 2022-09-27 19:05:25 +00:00
Bill Yi 92adaf7d4c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 30604f70f0 -s ours am: 9d7aff403e -s ours am: 7172f1d73f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I1a89f23342fc8d3430456abb88a765d9441696c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 19:00:23 +00:00
Bill Yi 9ee2e12d3d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 52d61325cc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Ie6fa64cc6cadc374ce49fabed791e01bed662660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:58:13 +00:00
Bill Yi d3902030d6 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours am: 986c1a40ca -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Ie8b591e60baed84b9942e5fd6a93b5ab1e97a42b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:56:31 +00:00
Bill Yi 7172f1d73f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 30604f70f0 -s ours am: 9d7aff403e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Id0fcc0eb2fd1d7310e371864fa6ab0db642740ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:46:11 +00:00
Bill Yi 986c1a40ca [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Id8ad16f13213048b22241af3e2a8b251f4199dc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:36:37 +00:00
Bill Yi 93105ebf75 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 0f57d8fb0c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I276a147555bf8b2c8ecc22aa1621fdd37eb3b071
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:33:45 +00:00
Bill Yi 9d7aff403e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours am: 30604f70f0 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I2da259684f97348f0f89c52d02377b0d639ff6e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 18:25:10 +00:00
Bill Yi 30604f70f0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I7bc8861adc55d5788de051b3bac3270ad31907ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 17:58:38 +00:00
Bill Yi 0f57d8fb0c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: Ie3d12f728b291d1c51645379ffef763ab1a3578c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 17:57:40 +00:00
Bill Yi 52d61325cc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4eec0f689d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20037742

Change-Id: I869278347ab0d6b2f097ea2092098c831a873f25
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 17:57:39 +00:00
Saumya Prakash 96bed75d9f Updated overview exit animation for 3 button navigation
Changed overview exit animation so that tiles don't slide off and only fade/scale in place for 3 button navigation. Previously, tiles would slide off when exiting for both gesture navigation and 3 button navigation. Now 3 button navigation exits with tiles staying in place.

Test: Manual
Fix: 245745939
Change-Id: I4144ed7e3ff29419df7fb13b6417ccc0a1f9dd45
2022-09-27 15:46:05 +00:00
Jeremy Sim ba7324e2b8 Update animations for phones: Overview > OverviewSplitSelect transition
This change updates the animation for initiating a split from the Overview screen on phones. Includes new timings and interpolators, and extends timing data classes related to SplitAnimationTimings.

Fixes a noticeable issue where the split animation appeared slow on phones.

Outstanding issues (fixes in progress):
- Repeated invocations of split on phones cause an erroneous animation to play. (b/249154347)
- Thumbnail corners do not match placeholder corners; the transition between the two is slightly janky. (b/236761794)
- Placeholder icons should be 72dp. (b/236761794)

Bug: 236761794
Test: Manual
Change-Id: Ibb97ef54498b0aa9556df531d8084799259c06e2
2022-09-27 11:45:02 -04:00
Sebastian Franco a44d255c8f Fix ReorderWidgets by removing faulty 4x4 cases
Fix: 242323136
Test: atest ReorderWidgets (the device has to be cf_x86_64_phone-userdebug)
Change-Id: Ic545409ecc20420be6c7377513c704822dbaf75e
2022-09-27 09:37:54 -05:00
Federico Baron 810fd0cee7 Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev am: d8b78523ca am: b4388e3ef2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017949

Change-Id: I8c8743f8e88c26fa75b120a4e75249219fe5d4d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 04:25:55 +00:00
Federico Baron b4388e3ef2 Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev am: d8b78523ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017949

Change-Id: I3e3a3afb0f5e2733d77e653e706eb579cb3c2a51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 04:01:32 +00:00
Federico Baron d8b78523ca Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev 2022-09-27 03:31:09 +00:00
Android Build Coastguard Worker 2dce40cb6c Snap for 9108299 from 36c0389d67 to udc-release
Change-Id: I94bd366c4664b956ef12b5485e08a99f71326850
2022-09-27 01:26:05 +00:00