Commit Graph
78507 Commits
Author SHA1 Message Date
James O'Leary 74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
android-build-team Robot 72b4b22443 Merge cherrypicks of [8828839, 8824129, 8828883, 8828885, 8828888, 8828891, 8829076, 8828998, 8828999, 8828607, 8828957] into qt-release
Change-Id: I529b9190a4c234124cd5f32cf4b1ddabebda18cd
2019-07-25 04:12:49 +00:00
Jon Miranda 55ab9851a4 Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
(cherry picked from commit e734efba8d)
2019-07-25 04:12:12 +00:00
Winson Chung 497f437908 Copy resume callbacks list prior to making callbacks
- Starting a deferred activity can trigger a new callback to be added
  to the list while we are iterating it

Bug: 136613192
Change-Id: I6690ab0695bb73f11bf343fb41e9fc86b4afec1b
Merged-In: I6690ab0695bb73f11bf343fb41e9fc86b4afec1b
(cherry picked from commit 940b0ac015)
(cherry picked from commit a8971c1462)
2019-07-25 04:12:06 +00:00
Jon Miranda 208729c3d9 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: 7ccf4a70a8 am: de9ca40004
am: 723eff5532

Change-Id: I76a743256fdd42a122922ec2f38afea4ce8da74f
2019-07-24 20:25:04 -07:00
Jon Miranda 2c5c9b0be0 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: b6ce5eb1de am: 0aeff344ee
am: 3505290a16

Change-Id: I95d0ff8a4902efcce579ccc20dbfd2a2aa6721ef
2019-07-24 20:23:56 -07:00
Jon Miranda 3728c7cba7 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: b6ce5eb1de am: e51220cd3a
am: b4a28867d3

Change-Id: Ia090e4660c4e36de24f1fb3653743b1ad31fe093
2019-07-24 20:22:59 -07:00
android-build-team Robot 9fbbe8cd1c Snap for 5753328 from 4f68901b5b to qt-c2f2-release
Change-Id: I0c16b8a401b4b682b34624769c2890a6cce906b3
2019-07-25 03:15:53 +00:00
android-build-team Robot bbdfed24ad Snap for 5753167 from 0353d124db to rvc-release
Change-Id: I8b9cd04317f3f8795e2c5c7b1c8f6c20cf663f96
2019-07-25 03:09:51 +00:00
android-build-team Robot 11bb40a8ca Snap for 5752705 from 4f68901b5b to qt-qpr1-release
Change-Id: I1d82d1ba3d9cccd645c602a655abba4f8ae344a7
2019-07-25 03:08:20 +00:00
Jon Miranda 723eff5532 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: 7ccf4a70a8
am: de9ca40004

Change-Id: Ifd8aa55513dea180f9b0438ed2126403b3d00c18
2019-07-24 19:54:54 -07:00
Jon Miranda 3505290a16 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: b6ce5eb1de
am: 0aeff344ee

Change-Id: I3492687fc075e182ad4032452b779b677992c808
2019-07-24 19:54:36 -07:00
Jon Miranda b4a28867d3 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa am: b6ce5eb1de
am: e51220cd3a

Change-Id: I4eddd506b463a11aaafb8147158b3842952aaff3
2019-07-24 19:50:21 -07:00
Jon Miranda de9ca40004 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa
am: 7ccf4a70a8

Change-Id: I827dd3b99e3d7a24a5c9b885615738d045016d94
2019-07-24 19:33:09 -07:00
Jon Miranda 0aeff344ee Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa
am: b6ce5eb1de

Change-Id: I140700571960df4c57d5d4dcc436c9527a4ba66b
2019-07-24 19:32:23 -07:00
Jon Miranda e51220cd3a Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev am: 95bc50fafa
am: b6ce5eb1de

Change-Id: I5a52771d7d886f568d63601b22722b4976efee46
2019-07-24 19:32:20 -07:00
Jon Miranda 7ccf4a70a8 Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev
am: 95bc50fafa

Change-Id: Id0d54ce7b849737af948c29297fbdda0a31ed30d
2019-07-24 19:16:38 -07:00
Jon Miranda b6ce5eb1de Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev
am: 95bc50fafa

Change-Id: Ia00ea7d1298a6f46c1ff779f13a3bf015ec5cd8a
2019-07-24 19:16:18 -07:00
TreeHugger Robot 95bc50fafa Merge "Fix bug where rounded corners were being set despite being disabled." into qt-dev 2019-07-25 00:56:24 +00:00
Hyunyoung Song 0832d47781 Folder text should show dark highlight when longpressed
Broken only on dark theme + super bright wallpaper
Bug: 138245847

Change-Id: Ib8627ebd49ac2b31bbd747c15ae6b55eb22efffa
2019-07-24 17:20:18 -07:00
Winson Chung 0353d124db [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 am: e5e34a7c91 -s ours am: 1db88426aa -s ours
am: 5f25789be2 -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 a8971c1462 is in history

Change-Id: I74b188b7b293b6f0f81fcfec4ccf7288839592a3
2019-07-24 13:46:14 -07:00
Winson Chung 5ee542e401 [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours am: 4f68901b5b -s ours am: 17f8e0789a -s ours
am: e16c5689e6 -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 a8971c1462 is in history

Change-Id: I4a61442c6ef037ad7afe9f083b0f6524b5b1fc95
2019-07-24 13:45:34 -07:00
Winson Chung 45ba8def63 [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours am: 4f68901b5b -s ours am: 964ade1871 -s ours
am: 113dd9d24e -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 940b0ac015 is in history

Change-Id: Ie808071c47748982751d12581a2eaf96797365c4
2019-07-24 13:43:23 -07:00
Winson Chung 5f25789be2 [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 am: e5e34a7c91 -s ours
am: 1db88426aa -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 a8971c1462 is in history

Change-Id: Ifca05638fc67ae4be8630f638b150c3abf6c4f60
2019-07-24 13:19:41 -07:00
Winson Chung e16c5689e6 [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours am: 4f68901b5b -s ours
am: 17f8e0789a -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 a8971c1462 is in history

Change-Id: Ic70ca9ebe3ed21b59b92da0cb262872b1ea5881d
2019-07-24 13:17:35 -07:00
Winson Chung 113dd9d24e [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours am: 4f68901b5b -s ours
am: 964ade1871 -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 940b0ac015 is in history

Change-Id: Ie74d0866695182c416c26239778da0f9c7a08c32
2019-07-24 13:11:56 -07:00
Winson Chung 1db88426aa [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462
am: e5e34a7c91 -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 a8971c1462 is in history

Change-Id: I3f11474a4ead11a1f5fad70e467f06e154309e97
2019-07-24 12:57:59 -07:00
Tony Wickham 503575a9e4 Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev
am: cfbdb91a7f

Change-Id: Id41c02c6543a4b0a12fc364e5c8e41dd6ccf9fc1
2019-07-24 12:57:34 -07:00
Winson Chung 964ade1871 [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours
am: 4f68901b5b -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 940b0ac015 is in history

Change-Id: Ic5baabefa693fd8fd68b314553500f2e849d6ff4
2019-07-24 12:57:21 -07:00
Winson Chung 17f8e0789a [automerger skipped] Copy resume callbacks list prior to making callbacks am: a8971c1462 -s ours
am: 4f68901b5b -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 940b0ac015 is in history

Change-Id: Icb8fe150df095ba9ade4f48adcab5c752cb7eed0
2019-07-24 12:57:21 -07:00
Sunny Goyal 6d9eed757f Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev
am: b7094fcf36

Change-Id: Icd4e52b33b33718cb91b2fd082d85637e820390f
2019-07-24 12:57:15 -07:00
Winson Chung 123448aff7 Merge "Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69 am: 33e8612e8c" into qt-qpr1-dev-plus-aosp
am: 760edb9905

Change-Id: I248bab5497d8271cee233b0572833142bb57b6ea
2019-07-24 12:49:01 -07:00
Winson Chung e5e34a7c91 Copy resume callbacks list prior to making callbacks
am: a8971c1462

Change-Id: I182892451b8268b0b6fed0983af7c15ae3174000
2019-07-24 12:47:19 -07:00
Winson Chung 4f68901b5b [automerger skipped] Copy resume callbacks list prior to making callbacks
am: a8971c1462 -s ours
am skip reason: change_id I6690ab0695bb73f11bf343fb41e9fc86b4afec1b with SHA1 940b0ac015 is in history

Change-Id: I117ae34040aea49e0438441b933da7561a06c414
2019-07-24 12:47:18 -07:00
Winson Chung 854b259fe6 Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69 am: 008145f0a8
am: 844a6f7e90

Change-Id: I24353fef93b8d57be5b13c74b1e71974578547e6
2019-07-24 12:47:17 -07:00
Tony Wickham cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
Android Build Merger (Role) 760edb9905 Merge "Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69 am: 33e8612e8c" into qt-qpr1-dev-plus-aosp 2019-07-24 19:39:02 +00:00
Winson Chung 80da0bdce1 Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69
am: 33e8612e8c

Change-Id: I075b9d5647a9263696fd0ba03111c7ec2297c924
2019-07-24 12:38:15 -07:00
Winson Chung 844a6f7e90 Merging ub-launcher3-qt-r1-dev, build 5749827 am: 3fc9a1cf69
am: 008145f0a8

Change-Id: Id4ac8dd58f2c7dd03c479af5a7c5a2dcf54b0ce3
2019-07-24 12:38:14 -07:00
TreeHugger Robot b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Winson Chung 008145f0a8 Merging ub-launcher3-qt-r1-dev, build 5749827
am: 3fc9a1cf69

Change-Id: Ia73d517059270c0a5b089413c2b0aae7b1cbcb43
2019-07-24 12:27:16 -07:00
Winson Chung 33e8612e8c Merging ub-launcher3-qt-r1-dev, build 5749827
am: 3fc9a1cf69

Change-Id: Id05a484ba74b5ef29c22992e7997eabf3c523011
2019-07-24 12:27:16 -07:00
Jon Miranda e734efba8d Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-24 17:15:13 +00:00
Sunny Goyal 4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Winson Chung 3fc9a1cf69 Merging ub-launcher3-qt-r1-dev, build 5749827
Test: Manual

Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:137129923 P1 Pixel launcher is leaking memory
Bug:137161198 P1 Unable to pull notification panel down with a swipe on home screen
Bug:137253043 P1 "Pixel Launcher keeps stopping" when scrolling through recent apps
Bug:137487381 P1 Overview goes back to fullscreen when swiping up during transition
Bug:137836033 P4 Fail to stop music due to "Swipe failed to receive an event for the swipe end"
Bug:138152531 P2 [Android Q][04713598] Launcher test cases are failed
Bug:138236583 P1 Icon scale is wrong when dragging from all apps or folders
Bug:138251824 P1 Flake: want to switch from background to overview; Swipe failed to receive an event for the swipe end
Bug:138252347 P1 qt-r1-dev Pixel Launcher flag ENABLE_HINTS_IN_OVERVIEW is Disable by Default
Change-Id: Idd0e987d26e1ffc75cdb9f90e9c08c26bb8c6503
2019-07-23 20:54:13 -07:00
Vadim Tryshev a1db23c0a7 Merge "Checking Launcher internal integrity from tests" into ub-launcher3-qt-r1-dev
am: 7b0520afe4

Change-Id: Iffeb718669a22e99c7fe90989dee51b4d229dd51
2019-07-23 18:49:16 -07:00
Winson Chung a8971c1462 Copy resume callbacks list prior to making callbacks
- Starting a deferred activity can trigger a new callback to be added
  to the list while we are iterating it

Bug: 136613192
Change-Id: I6690ab0695bb73f11bf343fb41e9fc86b4afec1b
Merged-In: I6690ab0695bb73f11bf343fb41e9fc86b4afec1b
(cherry picked from commit 940b0ac015)
2019-07-24 01:40:55 +00:00
Vadim Tryshev 7b0520afe4 Merge "Checking Launcher internal integrity from tests" into ub-launcher3-qt-r1-dev 2019-07-24 01:30:06 +00:00
vadimt 0dd1c782f0 Checking Launcher internal integrity from tests
In particular, we check that the stable Launcher state equals its
current state. This can help detect Launcher being in a corrupted state
as in b/133867119.

The check gets called by tests when the Launcher is not transitioning
from state to state.

Bug: 137307838
Change-Id: I3d36edff35e42d14be6b9a52351bd6f709be75e8
2019-07-23 18:07:25 -07:00
Anna Wasewicz d186820db0 Changing ENABLE_HINTS_IN_OVERVIEW flag to be true in qt-r1-dev. It should be false in qt-dev and true in qt-r1-dev.
am: 064cba4560

Change-Id: I674f00fb043223b67eef64df9956e62c384b453a
2019-07-23 18:04:09 -07:00