Commit Graph
1254 Commits
Author SHA1 Message Date
Tracy Zhou 86bd1dce8d Clear command queue of OverviewCommandHelper on home tap
Fixes: 194934483
Test: manual
Change-Id: Id83b341245793c38c305e6ada5581ac4e49527a7
2021-07-29 17:23:01 +00:00
Lucas Dupin 6d80cafc68 Merge "Add depth to -1 screen" into sc-v2-dev 2021-07-28 21:40:42 +00:00
Lucas Dupin 87d752062e Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
2021-07-28 12:36:31 -07:00
Tony Wickham 27ab9d96eb Let TaskbarDragView scale up before switching to system drag view
Test: Long press taskbar icons, ensure they aniamte the scale up
Fixes: 182981908
Change-Id: I573fe66c93ebf995b3f56f2c003dee987687b6a7
2021-07-28 08:03:14 -10:00
Lucas Dupin d9713b2665 Merge "Request early wake-up when zooming" into sc-v2-dev 2021-07-26 22:09:01 +00:00
TreeHugger Robot f7602976e2 Merge "Only set property state after back button instantiated" into sc-v2-dev 2021-07-26 20:55:08 +00:00
Vinit Nayak 1b3078258f Only set property state after back button instantiated
Fixes: 194374924
Test: Repro steps don't cause crash
Change-Id: I5ece220469f420d59698a56816057e248306fd32
2021-07-26 11:50:02 -07:00
Lucas Dupin 4a7acaed37 Request early wake-up when zooming
This way we'll be less likely to jank on 120Hz devices.

Test: manual
Fixes: 194680560
Change-Id: Ieff93f234701649514f8905c20c19cef231c816b
2021-07-26 11:19:39 -07:00
Alex Chau 646f804627 Add overviewShowAsGrid to DeviceProfile
- Simplified a lot of dp.isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() usage

Bug: 194194694
Test: manual
Change-Id: Idfb0ad192048106bbe6f8e2a28fa5613b86e5208
2021-07-26 11:59:34 +01:00
TreeHugger Robot 61eb1fe0ac Merge "Hide taskbar on lockscreen" into sc-v2-dev 2021-07-23 19:01:26 +00:00
Vinit Nayak 2f4b18bada Hide taskbar on lockscreen
Add new animated float to disable taskbar
background value when keyguard is visible.

Fixes: 191857724
Test: Tested w/ and w/o bouncer for gesture + 3 button
Tested w/ IME pw on lock screen.

Change-Id: I2e1696fd25f4c170bfb2bc0694ccd644e453b1fe
2021-07-22 13:14:51 -07:00
Vinit Nayak 7903758d08 Animate SplitPlaceholderView when entering split from overview
Bugs tracked in b/181704764

Bug: 181704764
Test: Tested on phone and large screen in multiple orientations

Change-Id: I07509006ae3d1f4425dc5119d0c8ed52b41a3bc2
2021-07-22 20:12:26 +00:00
Evan Rosky 2102a89ef6 Merge "Part of fixing Splashcreen cts tests" into sc-v2-dev 2021-07-21 18:01:09 +00:00
Lucas Dupin f82c463672 Merge "Revert "Apply depth even when surface is null"" into sc-dev am: 8d43e46261
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15341690

Change-Id: I9faebe44fd95ed907376e93a3729bbdc3634b5ec
2021-07-21 00:36:24 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Evan Rosky 8fb6c2156b Part of fixing Splashcreen cts tests
This passes the launcher component name into the transition filter
so that it only matches if the launcher is the current home activity

Bug: 194112093
Test: atest SplashscreenTests
Change-Id: Ie2185545a5bef8b317e104b6ac878f6cde0d7350
2021-07-20 14:23:55 -07:00
Lucas Dupin ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Tony Wickham 5eb1045cee Merge "Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash" into sc-v2-dev 2021-07-20 02:44:28 +00:00
Tony Wickham 8a2c1cbc5a Add taskbar stashing feedforward, i.e. hint at upcoming stash/unstash
Also fix unstashing not working in 3P launchers by moving the unstash call from LauncherTaskbarUIController to TaskbarActivityContext

Test: long press taskbar background and stashed handle, watch it hint towards the new stashed/unstashed state respectively and then complete the animation when the long press is triggered
Fixes: 193926311
Fixes: 192926350
Change-Id: I0e538be9129bf5c600d07f360b8106d7077862ad
2021-07-19 14:09:33 -10:00
Jonathan Miranda 70e8c0b022 Merge "Fix notification dot not always being up to date." into sc-dev am: 8e095ccb05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302020

Change-Id: I73d52b726f120029edc345a4154e36e734a6ea32
2021-07-19 18:00:49 +00:00
Alex Chau 0841e93a34 Merge "Don't allow stashing in tests for now" into sc-v2-dev 2021-07-19 12:15:43 +00:00
Jon Miranda f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
Tony Wickham 9c84d7f3c3 Don't allow stashing in tests for now
Test: TaplTestsQuickstep#testOverviewActions (arbirarily)
Bug: 193521974
Change-Id: Ic2c5c5f9f37ed3f035ec932b4c96fb51598cf899
2021-07-16 12:27:40 -10:00
Thales Lima 2e15dde6b7 Merge "launcher: enable swipe down to open focused app" into sc-v2-dev 2021-07-16 13:23:32 +00:00
Thales Lima fb5ba04c6a launcher: enable swipe down to open focused app
Fixes 192437421
Test: manual testing

Change-Id: Ife8e53cf4d7542525736e7b93ac92f9a2ddcd068
2021-07-16 10:55:38 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
TreeHugger Robot 6224eaea29 Merge "Notify System UI about taskbar state" into sc-v2-dev 2021-07-14 10:59:26 +00:00
Alex Chau 4e3460b866 Remove debug logs for b/193125090
Bug: 193125090
Test: manual
Change-Id: I7758347d7b775e8d8b0926e8f0d8723c7af2c942
2021-07-12 18:48:34 +01:00
Alex Chau 1e767a6ecc Refine logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables
- The failure is not reproducible locally, thus requires adding logs and check ATP result
- Removed some redundant logs
- Changed to log at VERBOSE
- Added extensive logging to all visibility/enable/alpha setter of ActionsView

Bug: 193125090
Test: Manual
Change-Id: I5b449a7f86ea4cef65e0e46de4b389deef9f53f3
2021-07-09 13:32:49 +01:00
Vinit Nayak 80aa4dbec0 Merge "Re-try binding to TouchInteractionService if service is killed" into sc-v2-dev 2021-07-08 22:09:51 +00:00
Vinit Nayak 297d2cdd44 Re-try binding to TouchInteractionService if service is killed
For problem explanation, see b/190339338#comment26.
When the binding dies, this attempts to retry
binding to the service with a backoff duration of
(1000 * 2^N)ms where N is # of attempts.

Bug: 190339338
Test: Taskbar seems interactable more consistently.
Manually failed the binding a couple times to see
retry mechanism and verified by logging locally.

Change-Id: Ia76207d0b2ef30b425ee1d7c66d7dee453bca7d8
2021-07-08 13:05:38 -07:00
Vinit Nayak a102bd896f Merge "Show back and IME switcher for gesture nav (1/2)" into sc-v2-dev 2021-07-07 18:02:17 +00:00
Lucas Dupin 1f5a4c9522 Merge "Use launcher surface when removing launch target" into sc-dev am: e55878cedf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193282

Change-Id: If0f2f60cae7d7d00ab5cf386b32f00247af887d6
2021-07-03 17:29:49 +00:00
Lucas Dupin 20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Alex Chau 60cacdf373 Notify System UI about taskbar state
We want to move the rotation suggestion button to the middle
of the taskbar when it is visible and not stashed.
To do this we need to update System UI about the current
state of the taskbar.

Test: manual
Fixes: 187410455
Change-Id: Id918e10a44631362f7c3a8a8bb624ee80bdd3c8b
2021-07-02 10:48:04 +01:00
Tracy Zhou 1fe5fda3d8 Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou d09ebe660f Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Jonathan Miranda e6f0509d1d Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770

Change-Id: I38ace4adec4591e9259a8859ed547e1b951b922c
2021-07-01 18:36:20 +00:00
Jonathan Miranda 3334c32120 Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev 2021-07-01 18:34:47 +00:00
Jon Miranda 17cc821c28 Fix bug where app icon is gone for first frame on cold start.
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).

Bug: 192366079
Test: slow down window animations
      check no empty frame on cold start app launch
      check no empty frame on warm start app launch

Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Yogisha Dixit ba28286260 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit 658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Lucas Dupin 3fb19d41b6 Merge "Decouple zooms and blurs on app launch" into sc-dev am: c2ef0363af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15145970

Change-Id: Idadf9a85d4de92e584a524ff48856cca5c81d664
2021-06-30 00:25:43 +00:00
Lucas Dupin 0f00c35268 Decouple zooms and blurs on app launch
We'd like to be able to disable blurs during app launch, but without
disabling zooms as well. The previous sysprop would set the depth of
BackgroundAppState to 0, when what we want is to conserve wallpaper
zoom.

Bug: 191969790
Test: adb shell setprop ro.launcher.blur.appLaunch false
Change-Id: Ie4b26096f6ac723c3981bba2829557e6cc6c733b
2021-06-29 13:02:12 -07:00
Lucas Dupin 820b0987bd Merge "Reset DEPTH at the end of launch animations" into sc-dev am: 789f01af7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15130116

Change-Id: I5d4b3c70bf2201831ed25405083eaf6de1bdf92f
2021-06-28 22:28:34 +00:00
Lucas Dupin 789f01af7e Merge "Reset DEPTH at the end of launch animations" into sc-dev 2021-06-28 22:15:21 +00:00
Lucas Dupin 9d8580bd2a Reset DEPTH at the end of launch animations
This way the wallpaper won't be zoomed out if an app crashes.

Test: adb am crash <some test app>
Fixes: 191979512
Change-Id: I7576798f736d63c3e46bbac1b983b9d1a437647d
2021-06-28 11:45:14 -07:00