Commit Graph
4810 Commits
Author SHA1 Message Date
Treehugger Robot eaf5bbd496 Merge "Reset stashed in Taskbar All Apps for gestures instead of IME insets." into main 2024-03-12 20:58:43 +00:00
Vinit Nayak 872d6953a1 Merge "Update Launcher state anim duration for pinned & transient taskbar" into main 2024-03-12 17:25:54 +00:00
Brian Isganitis 1956246b6e Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
2024-03-11 20:30:32 -04:00
Vinit Nayak 9a3c48468b Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-11 16:53:39 -07:00
Saumya Prakash 50ae58df57 Merge "Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"" into main 2024-03-11 17:36:24 +00:00
Ats Jenk d573fde5bf Merge "Remove line between bubble bar and arrow" into main 2024-03-08 21:31:08 +00:00
Federico Baron f9aa2a4a47 Merge "Remove logspam for resolved bug" into main 2024-03-08 16:29:17 +00:00
Ats Jenk a8e77927b4 Remove line between bubble bar and arrow
Bubble bar background is a drawable that consists of a rounded rect and
a pointer arrow.
In light theme, the rounded rect has a 1 pixel wide border around it.
When drawing the arrow just above the rounded rect, the border is
visible as a line between the background rounded rect and the arrow.
Shifting the arrow down by 1 pixel to ensure that there is no visible
arrow between bubble bar and arrow.

Other option could be to draw the entire background as a single path.
This path can combine the rounded rect background and arrow. But we need
to control the alpha of the arrow separately from the background. This
we can't do with a single path.

Bug: 324442574
Flag: NA
Test: manual
Change-Id: Iaa58ae4700ed9ad43051cd386f03381e0c14e72c
2024-03-07 23:37:49 -08:00
Jagrut Desai 754f171a98 Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"
This reverts commit 40fc6eb323.

Reason for revert: <b/328182219>

Change-Id: I5b846919823d696933b7d9f4220c1797409fc8b8
2024-03-07 20:55:48 +00:00
Ats Jenk 60101ae7fc Merge changes from topic "bubble-bar-drag" into main
* changes:
  Fix bubble bar arrow visibility during animation
  Animate bubble bar location changes
  Introduce bubble bar location that is driven by shell
2024-03-07 19:42:17 +00:00
fbaron 7e5d855886 Remove logspam for resolved bug
b/318394698 was fixed so we can now remove these logs.

Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
2024-03-07 11:11:36 -08:00
Ats Jenk 4186cf1b96 Fix bubble bar arrow visibility during animation
Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
2024-03-06 15:06:05 -08:00
Ats Jenk 77b6225d91 Animate bubble bar location changes
When it is not the initial bubble data, animate bubble bar location
change.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual, move expanded view from one side to the other, observe the
  location change animates

Change-Id: I52117a31d02e7160ca1d3dc3e724bda2e38f6cbf
2024-03-06 15:03:57 -08:00
Ats Jenk cd0f35383f Introduce bubble bar location that is driven by shell
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT

Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
2024-03-06 10:17:11 -08:00
Fengjiang Li f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00
Fengjiang Li cc1c582d89 [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
Fix: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: Iab1de455bf23d73b34f4a0d60f7e7a143bd028d1
2024-03-05 14:02:53 -08:00
Fengjiang Li 9280a68bbd [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I0c6585e6374db9412c8399ce3fdaf57348043d36
2024-03-05 14:02:53 -08:00
Fengjiang Li cad1f13d27 [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.

Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
2024-03-05 14:02:45 -08:00
Jeremy Sim e874bd603d Merge "Remove finished TODO" into main 2024-03-05 19:59:40 +00:00
Sunny Goyal 28ade08654 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into main 2024-03-05 19:07:46 +00:00
Jeremy Sim aa8b7b9a02 Remove finished TODO
Finished in ag/25945753.

Test: N/A
Flag: N/A
Change-Id: I7d86a62c5a84d7d68b89ef9f2fa6548df21588aa
2024-03-04 16:09:15 -08:00
Andy Wickham 929005440e Merge "Add custom extra width to trigger LPNH" into main 2024-03-04 22:46:22 +00:00
Andy Wickham e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Sunny Goyal f584b32811 Using fractions in MultiValueUpdateListener instead of absolute durations
This ensures that any global animation scale applies properly

Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
2024-03-04 09:15:11 -08:00
Jagrut Desai 3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Saumya Prakash 3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Saumya Prakash ba04c0c1dc Remove the tint from taskbar themed icons for dark mode.
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.

Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A

Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
2024-02-28 23:07:07 +00:00
Jagrut Desai 07959348e6 Merge "Fixing taskbar unstashing after unfolding" into main 2024-02-28 15:21:40 +00:00
Vinit Nayak 0edcfa4979 Merge "Update animation timing for split dismiss animation" into main 2024-02-28 04:14:28 +00:00
Jagrut Desai e424570af1 Fixing taskbar unstashing after unfolding
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: Iddd10df6e40ee2de4ef08eb18df88d48b7468035
2024-02-27 14:44:26 -08:00
Vinit Nayak 9c29c1e1c4 Update animation timing for split dismiss animation
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well

Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754

Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
2024-02-27 12:10:44 -08:00
Treehugger Robot 287e981ce9 Merge "Fix bouncing of task view when dragged past dismiss threshold." into main 2024-02-27 16:41:59 +00:00
Uwais Ashraf dddafae44e Fix bouncing of task view when dragged past dismiss threshold.
Before: https://screenshot.googleplex.com/56AHSMFkNwC76BV
After: https://screenshot.googleplex.com/AjuWqZaSNxmNYn8

Other cases after:
https://screenshot.googleplex.com/oaNotdg79v7LGUA
https://screenshot.googleplex.com/8SVtzpokbvmAzpv
https://screenshot.googleplex.com/87uRqmEAasBMQz2

Fix: 319577620
Flag: NA
Test: Manual (animation), analyse setPlayFraction log - see screenshots
Change-Id: Ib1f24182b8fc0f6ea1ff07125f25dbfc206ae5c2
2024-02-27 14:15:48 +00:00
Luca Zuccarini 0547036143 Merge "Move remote animation utils to the Animation lib." into main 2024-02-27 13:53:59 +00:00
Helen Cheuk 96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00
Jeremy Sim 70b3131393 Merge "Improve app pairs disabled state" into main 2024-02-27 06:49:52 +00:00
Jeremy Sim 3c1ee0dad4 Improve app pairs disabled state
This CL fixes 2 issues with app pairs:
- When an app pair is incompatible with the screen size due to a non-resizeable app (e.g. Camera), the app pair will now be properly disabled and display an error message. If the user is on a foldable, it will prompt the user to unfold their phone.
- The app pair icon will now properly redraw with lower opacity when it is disabled.

Fixes: 323088270
Test: Manually paused and unpaused apps, created Camera app pairs and tested with foldable
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I66514c96bc19f480c9788661e4dffaa5b1cdc2ca
2024-02-26 14:29:57 -08:00
Orhan Uysal 410b2d7497 Merge "Make taskbar visibilty change only in desktop." into main 2024-02-26 10:47:00 +00:00
Fengjiang Li e98d88ef2f Merge "Opt-in predicitive back before register the back button" into main 2024-02-24 04:40:57 +00:00
Saumya Prakash 4314d726c0 Merge "Fix jump in app launch when quick switching from Home" into main 2024-02-24 00:06:43 +00:00
William Leshner 0c2b98e876 Merge "Tweak WidgetPickerActivity size filtering." into main 2024-02-23 23:22:16 +00:00
Saumya Prakash b3b4cc6edb Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into main 2024-02-23 22:59:57 +00:00
Fengjiang Li e52fee8b8f Opt-in predicitive back before register the back button
The predictive back infra checks the opt-in status when a callback is registered, and drops the registration if the Application / Activity is not opted-in

Fix: 326627953
Test: manual
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Change-Id: I8f2e2378d0bf966b3784cf08c12045509b6d5682
2024-02-23 14:58:55 -08:00
Johannes Gallmann 1a9cff800f Merge "Transfer coordinate into new Rect instead of in-place" into main 2024-02-23 21:20:24 +00:00
Saumya Prakash 5983ac77d8 Fix jump in app launch when quick switching from Home
This change addresses a recent regression that caused quick switch to not scale up to full screen during the launch animation.

Fix: 326625526
Test: Launch quick switch from home and ensure it is a smooth transition
Flag: N/A
Change-Id: Id94d5d3eae0625225f880897e1e5f3cf9e4fea6c
2024-02-23 20:13:18 +00:00
Schneider Victor-tulias bdc846448c Merge "Update KQS launch task callbacks" into main 2024-02-23 19:54:44 +00:00
Saumya Prakash 40fc6eb323 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A

Change-Id: I3ee14ffc84d72512acdb750d0f614acacefc7639
2024-02-23 19:15:44 +00:00
Johannes Gallmann f3fe3b47a4 Merge "Fix flickers when invoking overview transition during predictive back-to-home" into main 2024-02-23 17:15:46 +00:00
Johannes Gallmann c71b48c658 Transfer coordinate into new Rect instead of in-place
Other parts of the animation rely on currentRectF to remain stable, therefore we shouldn't modify the RectF object in place.

Bug: 323628523
Flag: NONE
Test: Manual, i.e. verifying that widget close (and app close) animation animates correctly regardless of device orientation
Change-Id: I48e9ed047b956db654192eef39e5d94fbac53553
2024-02-23 12:30:46 +01:00
Johannes Gallmann 0ccdb91990 Fix flickers when invoking overview transition during predictive back-to-home
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
2024-02-23 10:29:26 +01:00