Commit Graph
7167 Commits
Author SHA1 Message Date
Schneider Victor-tulias 77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
Schneider Victor-tulias abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Mykola Podolian 1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Eghosa Ewansiha-Vlachavas 0c338f3055 Merge "Check RecentsView is not null before use in AbsSwipeUpHandler" into main 2024-04-19 20:25:21 +00:00
Eghosa Ewansiha-Vlachavas 47e0a61f29 Check RecentsView is not null before use in AbsSwipeUpHandler
Prevents NullPointerException

Flag: NONE
Test: Presubmit
Fixes: 335485976
Change-Id: Ia91f95dc4839c9d4c00c7aeed6cc9cebdafa33ee
2024-04-19 18:18:51 +00:00
Vinit Nayak c0a1fbe872 Merge "Revert^2 "Launch split tasks at beginning of animation instead of the end"" into main 2024-04-19 17:00:37 +00:00
mpodolian 73b07e2024 Updated pointer to match visual specification.
Updated bubble bar view pointer to have rounded tip.

Test: BubbleBarViewAnimatorTest
Fixes: 333546362
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I7875426b06a330bc355a833c51849335f831317e
2024-04-19 15:32:26 +01:00
Luca Zuccarini 62535f1fab Merge "Settle without jumping at the end of the home transition." into main 2024-04-19 09:50:38 +00:00
Vinit Nayak a6bf5a0014 Revert^2 "Launch split tasks at beginning of animation instead of the end"
This reverts commit fb092a9a6c.

Reason for revert: b/333937249

Change-Id: I77bd6c0d2fbe2f2dad074e8e0e741b50d4d7c204
2024-04-19 00:18:16 +00:00
Eghosa Ewansiha-Vlachavas f6ea0a3a2b Merge "Gate new desktop task menu button with device config check" into main 2024-04-18 15:02:52 +00:00
Eghosa Ewansiha-Vlachavas e885e54d90 Gate new desktop task menu button with device config check
Desktop windowing is enabled only when the desktop windowing flag is
enabled and the device is supported through setting a device config
flag. Add this device config check to the desktop task menu button so it
does not appear if the device is not compatible.

Flag: NONE
Fixes: 335178869
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: Ia2559c1ff57bb7921867e69a47d868c03eae57e7
2024-04-18 11:47:55 +00:00
Treehugger Robot f7d105bf5c Merge "Adds AssistStateManager#supportsShowWhenLocked." into main 2024-04-17 20:46:50 +00:00
Luca Zuccarini 840e67c17d Settle without jumping at the end of the home transition.
We dynamically target the actual position of the icon during the
animation, instead of the final position. This way, whenever we catch up
we can swap to the actual icon seamlessly. If we don't do this, the
spring ends before the scale and the is a snap from the final position
to the currently scaling position.

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: see videos in b/298089923#comment9
Change-Id: I36f19416552d4981b3d9f62a6eb387a08432dd4f
2024-04-17 14:33:01 +00:00
Luca Zuccarini 2fb15b12d5 Merge "Fix a bug where the status bar scrim doesn't animate." into main 2024-04-17 14:06:34 +00:00
Holly Jiuyu Sun 66a112a67d Merge "[omni] Enable CUSTOM_LPH_THRESHOLDS." into main 2024-04-17 00:52:41 +00:00
Holly Jiuyu Sun 5388adb001 Merge "[omni] Make AssistStateManager SafeCloseable." into main 2024-04-17 00:20:23 +00:00
Treehugger Robot 3a230921ba Merge "Reland slow gesture callback handling" into main 2024-04-16 22:54:19 +00:00
Holly Sun 4b377edb8f [omni] Enable CUSTOM_LPH_THRESHOLDS.
This will make our experiment setup easier. See https://docs.google.com/document/d/1GFMqkgVDgFYQnI_JMb7nARuKDwFy1SSVN00YOFKhY1Y/edit?resourcekey=0-JApoPZTfjxke-Cf82RSD_A&tab=t.0#bookmark=id.25pwwrhh1h8q

Bug: 331800576
Test: manual
Flag: legacy CUSTOM_LPH_THRESHOLDS enabled
Change-Id: I4b4fad79151ce6c91ca2895bcff534acae5e340c
2024-04-16 15:25:40 -07:00
Schneider Victor-tulias f3f0e28762 Reland slow gesture callback handling
Now that b/329324086 has been fixed, we can be more certain that launcher always gets a signal to clean up from WM.

- Relanding original fix for b/285636175 with some additional error checking
- We will now check whether the recents animation start is pending on ACTION_UP
- We will now block entire swipes to prevent sending additional inputs an input consumer while the recents animation start is pending
- We will now only stop blocking inputs on ACTION_DOWN

Flag: LEGACY ENABLE_HANDLE_DELAYED_GESTURE_CALLBACKS TEAMFOOD
Bug: 329324927
Fixes: 285636175
Test: added a delay in RecentsAnimationCallbacks.onAnimationStart and attempted several rapid gestures
Change-Id: I9805114da34bf44e6b28c2a8a665e4cca88904c2
2024-04-16 17:16:40 -04:00
Hongwei Wang 915d732782 Merge "Add debugging information on PiP content overlay" into main 2024-04-16 18:40:17 +00:00
Riddle Hsu d2ce88d594 Merge "Ensure that the recents start time is non-zero" into main 2024-04-16 16:53:12 +00:00
Winson Chung ad82df4d37 Merge "Migrate WorkspaceItemInfo non-resizeable flag to runtime status flag" into main 2024-04-16 16:41:42 +00:00
Ivan Tkachenko e993f92719 Merge "Desktop windowing wallpaper" into main 2024-04-16 15:20:38 +00:00
Ivan Tkachenko cd1dced953 Desktop windowing wallpaper
* Remove Launcher state manipulation from `DesktopVisibilityController`
* Remove Taskbar state updates for desktop mode in
  `LauncherTaskbarUIController`
* Update app widget animation for Home transision
* Update `RemoteTargetGluer` remote targets setup for Dekstop mode

Bug: 309014605
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_wallpaper_activity DEVELOPMENT
Test: manual
Change-Id: Ie2a7ad214a4d4e7e642d1236f2375ba6d17f3781
2024-04-16 10:59:30 +00:00
Stefan Andonian 0d2cc9e87c Merge "Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-04-16 02:42:04 +00:00
Vinit Nayak e8609736f4 Merge "Revert "Launch split tasks at beginning of animation instead of the end"" into main 2024-04-16 01:11:05 +00:00
Hongwei Wang 59fc94684a Add debugging information on PiP content overlay
Added the reason for creating the overlay. Updated
SwipePipToHomeAnimator constructor also due to the fact the source rect
hint from Builder class is never empty.

Bug: 330488822
Test: manually, follow the reproduce path
Flag: NA
Change-Id: Id98ce799d7c96fff3279c0df0fa49084a49d563a
2024-04-15 17:02:21 -07:00
Vinit Nayak fb092a9a6c Revert "Launch split tasks at beginning of animation instead of the end"
This reverts commit 26c11f2c49.

Reason for revert: b/333937249

Change-Id: Ide851596f5be7cea28df18dc27701b3cc0104bf1
2024-04-15 20:39:00 +00:00
Stefan Andonian 1a626d2d05 Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit a80997d9eb.

Bug: 324670265
Test: Locally tested this, as well as ran it through post-submit via go/abdt with the fix.
Flag: NA
Reason for revert: Root-caused the issue with this, and will push the fix along with this revert.

Change-Id: I4bda53d94dfdb865883fef6ceec9dacd0b87f015
2024-04-15 18:28:25 +00:00
Holly Sun ad7ac2943b [omni] Make AssistStateManager SafeCloseable.
Saw presubmit error: https://paste.googleplex.com/6266943744507904#l=76
which is thrown at https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/util/MainThreadInitializedObject.java;l=147-148;drc=1ce67a612220e7c9bd576d867cddf0fb74ccb866

Bug: 311356563
Bug: 330444720
Flag: legacy CUSTOM_LPH_THRESHOLDS disabled
Test: manual
Change-Id: I5fd28161756f10f0ec893f38c0abd51621fd36bc
2024-04-15 10:53:43 -07:00
Gustav Sennton e8c920967a Merge "Implement IRecentTasksListener.onRunningTaskChanged()" into main 2024-04-14 21:30:00 +00:00
Winson Chung 6a6de2dfc3 Migrate WorkspaceItemInfo non-resizeable flag to runtime status flag
- This aligns with other app-level state that is read at runtime

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: I1e29583d1c0302646718473c8958d604c1a202a5
2024-04-14 06:20:54 +00:00
Schneider Victor-tulias a9721fd344 Merge "Add debug logs to AbsSwipeUpHandler" into main 2024-04-12 20:39:51 +00:00
Luca Zuccarini a0e2a878f4 Fix a bug where the status bar scrim doesn't animate.
Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: manual
Change-Id: I8b624cf3e0b42572c122d04e2e7df6e7a6106b89
2024-04-12 18:55:49 +00:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Schneider Victor-tulias 9622927c8d Add debug logs to AbsSwipeUpHandler
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: Ic5245416df624b722819a3dcf1008ca0196d3161
2024-04-12 13:34:31 -04:00
Riddle Hsu 90ed0f9b32 Ensure that the recents start time is non-zero
It was only assigned when using gesture navigation.

When using non-gesture navigation, the calculation below in
ActivityMetricsLogger will be (uptime - 0) which could be several
hours or days.
 mSourceEventDelayMs = (int) (TimeUnit.NANOSECONDS.toMillis(
     launchingState.mStartUptimeNs) - sourceInfo.eventTimeMs);

Because the start time was set right after GestureState is created,
it can be simply set as the creation time of GestureState.
So non-gesture navigation can provide the timestamp when handling
OverviewCommandHelper.TYPE_TOGGLE.

Bug: 206872204
Test: Use 3-button navigation to enter recent.
      The value of LatencyTracker should not be unexpected large.
Change-Id: Ie661222822912e287d1ac295ccaf49e2086d909e
2024-04-12 11:10:07 +00:00
Gustav Sennton 2744acfbf4 Implement IRecentTasksListener.onRunningTaskChanged()
Bug: 332504528
Test: N/A
Flag: NA
Change-Id: I7c98eb524bb7544a715f5b8226d3c28d05f72913
2024-04-11 16:58:42 +00:00
Randy Pfohl 819b835519 Revert "Revert "abtracting Activity from recentsView through rec..."
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Reason for revert: Fix for issue has been found and will be included in this revert.

Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
2024-04-11 08:58:08 -07:00
Luca Zuccarini 926a10a3b0 Create a stubbed IRemoteTransition implementation.
Bug: 323863002
Flag: NA
Test: NA, new method is unused (still builds)
Change-Id: Ibc4187f469e41b2db91bef368c710ffbdcd33faf
2024-04-11 09:15:41 +00:00
Vinit Nayak 20c0b2f647 Merge "Add placeholder divider view when starting split tasks" into main 2024-04-11 05:10:35 +00:00
Vinit Nayak cdaabc6199 Add placeholder divider view when starting split tasks
* This prevents launcher underneath from peaking through
while the split apps are loading

Bug: 299640096
Test: Launched from recents, home and all apps
Doesn't seem to affect small screen since recents scrolls
away and the scrim is only left

Change-Id: I32e394a0bc361489473ee657161c8f3bcbf1e422
2024-04-11 05:09:49 +00:00
Tracy Zhou f5299f3168 Merge "Move AbstractFloatingView for stage split layering above all apps" into main 2024-04-11 05:05:01 +00:00
Tracy Zhou 3158bf7e43 Move AbstractFloatingView for stage split layering above all apps
- We don't need to worry about if it's in Overview. Only overview has task menus, so if there is no task menu, we place it at the top.

Fixes: 332465429
Test: Launch stage split using keyboard shortcuts with all apps open. Make sure it's above all apps.
Change-Id: Ic950d2897fe80ef407038dd840b86fc92d6d6287
2024-04-10 19:42:50 -07:00
Priyanka Advani 1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
2024-04-10 23:58:09 +00:00
Sunny Goyal 63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka Advani 3c71346147 Revert "abtracting Activity from recentsView through recentsview..."
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
2024-04-10 21:31:07 +00:00
Vinit Nayak 24f88860de Merge "Launch split tasks at beginning of animation instead of the end" into main 2024-04-10 20:16:08 +00:00
randypfohl 547d6fc472 abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
This change will let us move from activity to other parent views for recent views.

Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.

Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.

Bug: 292269949

Flag: NONE

Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
2024-04-10 09:14:28 -07:00
Holly Jiuyu Sun c2ee3f5001 Merge "[omni] Implement 2-stage for LPNH." into main 2024-04-10 15:35:54 +00:00