Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
- Add a blur layer to the Scaling Workspace Reveal to have a smooth
blur transition during animation
- As part of this, disable blur from DepthController (but still
use it for depth to match workspace scale)
- This mirrors the approach in LauncherBackAnimationController
- Use a snappier interpolator for the blur portion (666ms, emphasized)
- Reduce the alpha of floating view during animation, to reduce the
blur effect during the morph
- Increase the cross fade duration of the App Widget to App reveal
Demo video with various widgets and apps:
https://drive.google.com/file/d/1fYJc-TPAEltqParM957NMYbRe2Gn5OgJ/view?usp=sharing&resourcekey=0-AGiL7sqLNXDcNsY-qOzzYQ
Note: this is sort of a different approach to ag/33537973 without the
underlying refactor necessary.
Bug: 417269110
Test: Manual (see video)
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I2bb6c0114d42af7ed802fbcae03655befe19aa7e
I think this animation was broken, and my previous CL accidentally
fixed it, so that blur was actually applied during app launch. This
caused some app launch performance regressions, so we will at least
disable it whenever the All Apps blur flag is enabled.
Test: presubmit, forrest
Bug: 416476673
Flag: com.android.launcher3.all_apps_blur
Change-Id: I4c7001dc84f67dbef02fbc255613b94347df91b8
Particularly with predictive back in cases that the app doesn't
support peeking the home screen, there was a thrashing animation
due to a secondary blur animation being applied. So in some cases,
it would rapidly alternate between 0 blur and the correct animation
blur. This wasn't necessarily user-visible, but likely contributed
to some performance jank.
Also ensure the scaling workspace blur uses the correct starting
depth and duration.
Demo: https://drive.google.com/file/d/1AffSvzlXycg8Yl4ULpctKADO6IdvvO3m/view?usp=drive_link&resourcekey=0--zqQ341w7U3MhRBwSYrsyA
Bug: 407534544
Test: Manual (predictive back, back without predictive peek, home)
Flag: com.android.launcher3.predictive_back_to_home_blur
Flag: com.android.launcher3.all_apps_blur
Change-Id: I76ed59e99aaef5bd44e8f5b0290f01763a8d4b0f
- Ignore blur changes smaller than 1dp unless going to/from 0.
- Don't apply depth animation during app launch from blurred
All Apps.
- Use DepthController directly rather than creating a new one
for other app launch animaitons. Avoids extraneous memory and
performance overhead.
Bug: 411292920
Bug: 410973453
Bug: 408284263
Test: forrest perf tests
Flag: com.android.launcher3.all_apps_blur
Change-Id: Id5c8e71b19ebb8f1c1b82f8c5c76785e001017af
This way if you go to a different state like All Apps, that
existing animation can be cancelled.
This is essentially the same as b/405836159, but for exiting an app
via predictive back rather than standard home gesture.
Demo: https://drive.google.com/file/d/1x66LHDMQLArZX7sO3RBcI-M-vWW_icRg/view?usp=drive_link&resourcekey=0-_0FYAfonv7YC9u8mCmm07Q
Fix: 412562139
Flag: com.android.launcher3.all_apps_blur
Test: Open app from homescreen, go back, swipe to All Apps quickly.
Change-Id: I83973df5702b271853149dbea5baa1781358c207
This measures the delay from when the user closes or minimizes
the last open window in desktop mode until the animation to exit
desktop mode draws its first frame.
Flag: EXEMPT metric change
Bug: 390544490
Test: Run `statsd_testdrive 306` and ensure that latency metric is
reported.
Change-Id: If4923b50feade20ba74560ed7b8d14ea2bb6f71e
Introduce FLAG_IGNORE_IN_APP to prevent taskbar from stashing
prematurely due to HomeTransitionListener signal.
Fixes leak by adding event callback to clear runnable when launcher is
destroyed.
Bug: 319162553
Test: Launch an app, note the two animations are synced
Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: I684c714bb84fb1717b0e26620f2aa938671eb19a
Since developers have been relying on detecting leaks from studio build
and this exception can cause rest of on destroy to not run, to avoid
false positives, we could just rely on Log.e instead.
See bug for more details.
Bug: 400793700
Flag: EXEMPT BUGFIX
Test: Leak canary and studio heap dump
Change-Id: Ieea35ecfcc4b0f048b47c204809bbbf39e367b06
This Cl includes
- addition of entry/exit callback methods in DesktopVisibilityController.
- taskbar manager now listens to desktop mode changes.
- TaskbarBackrgroundRedererer can now individually animation backgrounds for transient and persistent taskbars
- new channel for taskbar icon alpha added to TaskbarViewController
- new animated float to handle background alpha while we are recreating taskbar with animation.
Solution:
we use the callabck we get from DekstopVisibilty for entry/exit to first change logic of when we are considered inDesktopMode. Upon entry/exit we notify display controller for info change.
we also at notify taskbar manager who is now a listener to the desktop mode change and start the recreate process. TaskbarManager first animates existing taskbar out of user view and then follows the original recreate flow.
Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib827564cacd194f499e7d9b1965e2bb13e3548ab
This cl include: Allows user to click on lottie animation views to play and pause animations. If user have choosen to remove animations we will honor it and not play the animation from begaining.
Test: Manual, Presubmit
Bug: 378980835
Flag: EXEMPT bugfix
Change-Id: Ieaaf771bc307837f042f6e59d8f02fefb2e8286a
Pass the TransitionInfo of the merging recents-transition through to
TransformParams to allow setting the corner radius of desktop tasks to
zero during the second part of a recents transition.
Bug: 378657004
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Test: swipe up from fullscreen app to overview, then tap desktop tile
Change-Id: I08f87aa1b9a2feca9e9f8bed2c55279e0ddc1edb
Move the CUJ to where the actual animation is taking place, so we can
target the correct surface/leash.
Bug: 374214290
Flag: NONE jank logging
Test: manual
Change-Id: Iccb30ff7ceee84b68428606575e1b8588eeb8aa9
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: com.android.launcher3.predictive_back_to_home_polish
Change-Id: I092a74ab2340828e18067ca15c7019c44d30f40b
This reverts commit 09603bfb39.
Reason for revert: Launcher icons are sometimes not visible during the back-to-home animation when immediately swiping back after opening the app.
Change-Id: I13869cf755160986e323365a460f6ebe128008a9
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: EXEMPT bugfix
Change-Id: Iece001b6b9edd9ca7a909e3ccbe8ebdff2e71d9f
The transitions changes are bug fixes / polish, so use bugfix flags
for these changes.
An existing non-bugfix flag cannot be changed into a bugfix flag, so
instead we create new flags with the bugfix type.
Bug: 380224768
Bug: 380225486
Bug: 380224832
Test: manual - disable main flags, use bugfix flags
Flag: com.android.window.flags.enable_desktop_windowing_enter_transition_bugfix
Change-Id: I1c9ea635a362db741f4a632e6360aee87c12750e
When using a 3P Launcher, i.e. when the ROLE_HOME is not held by QuickstepLauncher, there should be no back callback registered with SystemUI.
Bug: 374882166
Flag: EXEMPT bugfix
Test: Manual, i.e. verified back-callback registration updates in SystemUI and also verified that back-to-home navigations in Nova Launcher are responsive.
Change-Id: I03187f80a4c3c893a6529f0a22613f6fdfe7b7b3
This cl includes
- making pinned taskbar animate slide in/out animation from bottom of screen.
- no icon aligment with hotseat when taksbar is pinned
The solution
- upon state change applied on TaskbarLauncherStateController. offset taskbar background and icons to bottom of screeen and animate with slide in/out effects.
Test: manual, presubmit
Bug: 314279101
Flag: EXEMPT bugfix
Change-Id: Ife336ebd57eb2f60c2bc33ed6a4527c42111808f
The main changes are:
1. the amount to move the window horizontally (much less for Desktop
Mode), and
2. the timing for when the alpha animation is applied - we remove the
25ms delay for freeform windows.
Bug: 378675987
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_exit_transitions
Change-Id: Ieeb6b827eee2e6314ea9c79213cdf401f48d3c85
This affects app launches and returns to home. When launching
immediately after returning to home (before the return animation is
complete), the two animations could overlap, causing the two property
setters to conflict.
Bug: 367591368
Flag: com.android.launcher3.coordinate_workspace_scale
Test: tested with flag off and on, see before and after in the bug
Change-Id: Ie1483fa0bf589caee315ae298e9e68ca361709d8
Update the hotseat and Qsb placement according to the 3 nav buttons bar.
Test: Manual.
Set navigation mode to 3 buttons.
On launcher home screen move the bubble bar from one side to another.
Observe that the Hotseat and Qsb moving together with the navigation
bar.
Once moved the bubble bar, expand the bubble bar and collapse it.
Observe how the Hotseat is stashing and un-stashing.
After bubble bar changes position hit the recent apps button, observe
the transition.
On launcher home screen start application with the hotseat icon and exit
opened application. Observe that flying icon comes back to the correct
position in the hotseat.
Video with the above scenarios:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/blTYrKopTyufOcRoPuVpYK
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Change-Id: Ic8c6acdffbbb111cbe4f3fd6bc60195578d7035d
> Looking up views during back instead of holding the reference
This allows back animation even if Launcher restarts
> Fixing back animation not working with progressive back
> Fixing container animation overriding Launcher cookie used be gestureNav
Bug: 365866488
Test: Verified manually by enabling flag
Flag: com.android.launcher3.enable_container_return_animations
Change-Id: Ic235b238cca6a31e9a5502200ff6b07c72b4e4d7
This allows better matching of items who do not have a fixed id
Bug: 364363493
Flag: EXEMPT bug fix
Test: Manual- Verified app launch and back animation
Change-Id: I4f9deba89399b89974686b64226b99f91a3d46be
- The shell transit flag is already hardcoded to true in Launcher
so we can remove the non-shell transit paths
- The minimized split was from legacy splitscreen where launcher would
show in a minimized state, which is no longer the case
Flag: EXEMPT bugfix
Bug: 359608026
Test: atest NexusLauncherTests
Change-Id: Idea46fc065485233b9e508dae3ebc4ee87c29ba6
Signed-off-by: Winson Chung <winsonc@google.com>