Commit Graph
3928 Commits
Author SHA1 Message Date
Sebastián Franco e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF) 1bec329180 Merge "Revert "Moving DeviceProfile properties into DeviceProperties da..."" into main 2025-05-23 14:03:53 -07:00
Priyanka Advani (xWF) 7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Sebastián Franco b80423b1b7 Merge "Moving DeviceProfile properties into DeviceProperties data class" into main 2025-05-23 13:17:32 -07:00
Li Lin 9f40588951 Merge "Add a auto hide flag for Growth Framework nudge." into main 2025-05-23 10:44:24 -07:00
Sebastian Franco e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Pierre Barbier de Reuille 06ed9c93d4 Merge "Use the developer-option flag for pin to taskbar" into main 2025-05-22 15:01:03 -07:00
Pierre Barbier de Reuille b8c5350c07 Use the developer-option flag for pin to taskbar
Test: Manual
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Bug: 375648361
Change-Id: I2c26ae6a5f42fd01860d7534b86ff5ca11e7f7fc
2025-05-22 03:29:34 -07:00
Lucas Dupin 66923a912c Merge "Add recents position callback to SystemUiProxy" into main 2025-05-21 23:11:59 -07:00
Lucas Dupin 02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
Cosmin Băieș cba51f4023 Merge "Remove canImeRenderGesturalNavButtons and sysprop" into main 2025-05-20 03:41:58 -07:00
Mykola Podolian 9e4b44afcd Merge changes from topic "remove_ipc" into main
* changes:
  [5/5] Removed unused IPC call.
  [4/5] Cover DragToBubbleController with tests.
  [3/5] Implement DragToBubbleController.
  [2/5] Hook up DragToBubbleController and prepare launcher to use it.
  [1/5] Added DragToBubbleController
2025-05-16 16:01:03 -07:00
Mykola Podolian bbd1e2e6ad Merge "Fixed issue with expanded view incorrect position." into main 2025-05-16 15:33:33 -07:00
mpodolian 8499319bc2 [4/5] Cover DragToBubbleController with tests.
Implement tests that check DragToBubbleController public API

Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: DragToBubbleController.kt
Change-Id: I48fe5f45921fbedbe0f1921dfd21e9ecb14406bc
2025-05-16 11:33:52 -07:00
mpodolian 5b80c31380 [3/5] Implement DragToBubbleController.
Implement DragToBubbleController internal logic that utilises
DropTargetManager to show drop targets for the bubble bar drop zones.

Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to overview screen and drag app icons from the taskbar
over the bubble bar

Change-Id: I844151c5e11f237c475d8a26a7784c5662dad658
2025-05-16 10:35:05 -07:00
mpodolian 86f7a230f8 [2/5] Hook up DragToBubbleController and prepare launcher to use it.
Updated DragController logic to set touch event XY coordinates if there
is no view returned by the DropTarget. Added wait call for all drop
targets views removed to the
TaskbarActivityContext#onDragEndOrViewRemoved() method.

Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: build launcher
Change-Id: Ie97b08f22ae8dc34bd9f4e3738704e4fc90345bb
2025-05-16 10:34:55 -07:00
mpodolian 77859d0c89 Fixed issue with expanded view incorrect position.
The expanded view was misplaced due to a race condition. This occurred
because the BubbleBarController.onBubbleBarBoundsChanged() method was
invoked while
LauncherTaskbarUIController.onTaskbarInAppDisplayProgressUpdate() was in
progress (e.g. inAppDisplayOverrideProgress value was slightly higher
than 0). The latter method is also used to shift the three navigation
buttons for IME open/collapse events.

This concurrent execution led to an incorrect bubbleBarTranslationY
value being used in the BubbleBarView.getTopToScreenBottom() method,
ultimately causing the misplacement of the expanded view.

Fixes: 416158567
Flag: EXEMPT bugfix
Test: Manual.
- Long Press Chrome icon select "bubble" adds
- Press search bar inside Chrome app bubble to show IME
- Hide IME
- Press Chrome bubble
- Press search bar inside Chrome app bubble to show IME
- Hide IME

Change-Id: I44431f0eb47c3e9e0bea0274624e5b1db0aa15c9
2025-05-16 10:05:01 -07:00
Treehugger Robot 242f038d09 Merge "Don't trigger getRecentTasks() calls when waiting for an old call" into main 2025-05-16 02:25:05 -07:00
Treehugger Robot 6bc72676ed Merge "Recreate DP for CD when displayInfo changes" into main 2025-05-15 18:07:54 -07:00
Treehugger Robot bee486a7da Merge "Use desktop mode autostashing on desktop devices" into main 2025-05-15 17:33:29 -07:00
Ajinkya Chalke 1fd6090eb7 Recreate DP for CD when displayInfo changes
- Only IDP is updated when displayInfo changes but DPs of CD don't. As
  a result taskbars on CD end up reusing the old config DPs. For
  example, when user changes display size, displayInfo updates but
  taskbars on CD continue using old DP resources.
- So, update DP for CD when DisplayInfo changes.
- Also added using supplied context with dpToPx for calculating radius
  for taskbar roundedness at the ends.

Fix: 414933860
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays

Change-Id: I7d8ed3c5ba69b755a58d3462a5da9ed7fd404198
2025-05-15 22:42:09 +00:00
Gustav Sennton ffa5c2ad83 Don't trigger getRecentTasks() calls when waiting for an old call
TaskbarRecentAppsController#reloadRecentTasksIfNeeded() triggers a call
to fetch Recents tasks, that call is expensive as it goes through WM
Shell and the system server. If we trigger reloadRecentTasksIfNeeded()
multiple times we're queueing up multiple calls to fetch Recents tasks.

With this CL we avoid queueing up multiple calls, and instead just make
one new call when the old one finishes. That way we can only ever have
one call getRecentTasks() call triggered through
reloadRecentTasksIfNeeded() posted at any one time.

Bug: 415090968
Flag: com.android.window.flags.enable_taskbar_recent_tasks_throttle_bugfix
Test: TaskbarRecentAppsControllerTest
Change-Id: I58b66e4564af4e64837317a9de7be398395d8568
2025-05-15 20:18:21 +00:00
Surbhi Kadam 550dbb0021 Merge "Launcher3: send token with early wakeup request to SurfaceFlinger" into main 2025-05-15 10:28:36 -07:00
Ebru Kurnaz 6ddc86dc7e Merge "Use wm callbacks for sys decor in Launcher instead of command queue." into main 2025-05-15 09:44:19 -07:00
Mykola Podolian 4703fef886 Merge "Reset -1 page progress when leaving it" into main 2025-05-15 09:37:10 -07:00
Tony Wickham cb535f5330 Merge "Call updateOverivewDragState when mIsAnimatingToLauncher changes" into main 2025-05-15 08:11:56 -07:00
Ebru Kurnaz 88185ac745 Use wm callbacks for sys decor in Launcher instead of command queue.
Bug: 412615955
Test: DisplayRepositoryTest
Flag: com.android.window.flags.enable_sys_decors_callbacks_via_wm
Change-Id: I42865b2b9169e99e35e09e239f6a1b3e455b7894
2025-05-15 13:39:33 +00:00
Mykola Podolian 12d5eae670 Merge "Clear bubble bar saved states if bubble bar controllers not present." into main 2025-05-14 17:38:07 -07:00
mpodolian dbd42b6f05 [1/5] Added DragToBubbleController
Added controller that would handles drags of launcher icons to the
bubble bar, displaying drop targets and creating application bubbles.

Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: build launcher
Change-Id: I593222d86f50248ceb2909ae73ccc021ef515e28
2025-05-14 17:29:11 -07:00
mpodolian ae8047b5c3 Reset -1 page progress when leaving it
Reset in-app display override progress when transitioning from home -1
page. In order to come back to the -1 page user has to swipe left from
home again so in-app display override progress will be updated again.

Fixes: 416163737
Flag: EXEMPT - bugfix
Test: Manual. enable 3 buttons navigation mode. Have bubble bar with
bubbles. Swipe to -1 page. Click recent apps button. Click home.

Change-Id: Ibc67f6e024f5c89efb7f80f420fc859aaa9d3e33
2025-05-14 17:16:28 -07:00
Treehugger Robot a882e236bb Merge "Add shadow to KQS view" into main 2025-05-14 11:53:24 -07:00
Surbhi Kadam e4b9306c59 Launcher3: send token with early wakeup request to SurfaceFlinger
Passes a binder token to SurfaceFlinger and adds tracing for debugging

Bug: 323292798
Bug: 409740673
Test: presubmit
Flag: EXEMPT log only update; bugfix

Change-Id: I0bc6df0a55cf747203b24b43596bed6ce5ebe76a
2025-05-14 08:07:43 -07:00
Toni Barzic 2cf0d817a3 Use desktop mode autostashing on desktop devices
Updates few autostashing related conditions to use
`isTaskbarShowingDesktopApps()` instead of `isInDesktopMode()`, as the
former covers the case where the desktop flavour taskbar is shown
consistently (on desktop devices).

Bug: 390665752
Bug: 415991381
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: On desktop device, verify that "Always show taskbar" is shown on
      home/in overview/in app outside desktop mode, and verify that the popup
      value shown is consistent with the value in desktop mode. Verify
      that taskbar does not get auto-stashed on home, even if "Always
      show Taskbar" value is false.
Change-Id: I4edfe20f5526210fdf767231d0906875fe04f806
2025-05-14 05:53:51 +00:00
Tony Wickham 10615f8ef3 Call updateOverivewDragState when mIsAnimatingToLauncher changes
- updateOverviewDragState depends on mIsAnimatingToLauncher, so
  this change ensures it is always updated to reflect the latest.

Flag: EXEMPT bugfix
Fixes: 391266003
Test: swipe from an app to home, immediately swipe to All Apps
during the transition and verify that Taskbar logs show that
mDisallowLongClick=false and mIsAnimatingToLauncher=false; also
verify that long press on Taskbar icons works after launching
an app from All Apps.

Change-Id: Id18a3d4fba9357273dbeddd9220bac325b2e9b73
2025-05-13 22:54:51 +00:00
helencheuk d681164fe3 [Action Corner] Handle go home action
Handle go home and go back to previous screen for overview, split and full screen task

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.systemui.shared.cursor_hot_corner
Change-Id: Ia928f102df6908058c02949db02a73430cea5ef1
2025-05-13 17:03:12 +00:00
Jagrut Desai ac309032ac Merge "Fix NavButton Position when in RTL and Lanscape" into main 2025-05-13 08:35:32 -07:00
Treehugger Robot 61962ec222 Merge "Better null handling for OverviewComponentObserver.getContainerInterface" into main 2025-05-13 05:26:16 -07:00
Will Osborn 807d0f9ecf Better null handling for OverviewComponentObserver.getContainerInterface
Bug: 413634484
Test: local + unit tests
Flag: EXEMPT bugfix
Change-Id: I249cd1925ac416e9861be9d0c3c451e2b6cdff43
2025-05-13 09:28:29 +00:00
Johannes Gallmann 3a9aac8358 Merge "Remove haptics for long presses in 3-button-nav" into main 2025-05-13 01:21:00 -07:00
Treehugger Robot cd4e664701 Merge "Prevent unnecessary DisplayInfo refreshment" into main 2025-05-12 18:11:49 -07:00
mpodolian ae6322b4b5 Clear bubble bar saved states if bubble bar controllers not present.
Added logic to clear bubble bar related portion of the shared state to
prevent bubble bar being expanded after device unfolded back. If sysui
restores the expanded view, there is no harm in clearing the saved
state, but if it fails to restore, we would at least have the bubble bar
in the not-expanded state.

Bug: 416297086
Test: Manual. Create any bubble and expanded when device is unfolded.
Fold the device and unfold it back. Observe expanded bubble is closed.
Test: Manual. Be folded, expand bubbles unfold bubbles remain expanded
Flag: EXEMPT - bug fix

Change-Id: I13448c48137cc944ec506bdd48ec630634ed120c
2025-05-12 17:01:20 -07:00
Jagrut Desai 7c2a76b499 Merge "Fix TaskbarAllApps Icon" into main 2025-05-12 16:58:46 -07:00
Jagrut Desai 10faea6c76 Fix NavButton Position when in RTL and Lanscape
This cl changes the order of adding nav button to contrianer, so upon user rotating phone to landscape more while in RTL will not cause buttons to switch positions.

Test: Manual
Bug: 396135895
Flag: EXEMPT bugfix
Change-Id: If5512cbdac06bc65f10c8d1e326ae6b786de98ba
2025-05-12 16:57:01 -07:00
Mykola Podolian 21fbcbcf84 Merge "Only update handle alpha on system UI flag update." into main 2025-05-12 16:39:50 -07:00
Mykola Podolian 37437bafc5 Merge "Restore taskbar stashed state on the overview screen." into main 2025-05-12 14:27:29 -07:00
Treehugger Robot d89bd8d886 Merge "Split BlurStyle and BlurFallbackStyle for All Apps and Overview." into main 2025-05-12 14:02:09 -07:00
mpodolian 810bfb755d Only update handle alpha on system UI flag update.
Added logic to check if handle view alpha should be updated during SysUi
flag updates.

Fixes: 417125892
Test: Manual. Create a new bubble on the home screen, observe the stash
handle is not visible.
Have stashed bubble bar and multiple system languages.
Go to settings (or ane other apps that has input fields). Click on
search to trigger keyboard pop up. Observe that stash handle is hidden.
Collapse the keyboard and observe that stash handle is shown again.
Flag: EXEMPT bug-fix

Change-Id: I0976f37ca24ba816ee5eed6d4f1b4e6999b54c29
2025-05-12 11:26:42 -07:00
Jagrut Desai bc28b98b8f Fix TaskbarAllApps Icon
Test: Manual, UX
Bug: 415836854
Flag: EXEMPT bugfix
Change-Id: I8b305ce35e0a6b73559f73083a0ca9b025043e8c
2025-05-12 10:46:57 -07:00
mpodolian a4d2e5aa19 Restore taskbar stashed state on the overview screen.
Added logic to preserve overview screen state on the taskbar.

Fixes: 416418164
Test: Manual. Go to overview with the bubble bar. Expand bubble bar.
Rotate device. Observe the taskbar remains stashed.
Flag: EXEMPT bug-fix

Change-Id: I197c1b7f20b23a6b2a343b18b4da0aa45beb8c52
2025-05-12 10:01:23 -07:00
Johannes Gallmann 76621e0972 Remove haptics for long presses in 3-button-nav
This CL removes haptics for long presses on 3-button-nav buttons, except
when the long press triggers a user visible action.

This means that for example the haptics for long pressing the recents
button are removed, whereas haptics for long pressing the home button
remain active since that launches circle-to-search.

Bug: 408968370
Test: Manual, i.e. verified that no haptic feedback is played when
      long pressing the recents button
Flag: EXEMPT bugfix
Change-Id: Icfeade8a659a8aa4882ef139696c66f410980303
2025-05-12 15:35:57 +00:00