Commit Graph
11163 Commits
Author SHA1 Message Date
Jeremy Sim 5d2a1f47c0 Merge "Fix placement bug with split staging icon in RtL" into tm-dev 2022-04-10 01:48:53 +00:00
Jeremy Sim e15927eec7 Merge "Implement splitting from Taskbar long-press" into tm-dev 2022-04-09 01:21:14 +00:00
Jeremy Sim 43c79704ed Fix placement bug with split staging icon in RtL
Fixes a bug where switching the phone to RtL caused Overview's split staging icon to be placed incorrectly.

The bug was caused by the fact that FrameLayout margins were not working consistently in RtL. This may be another bug; more investigation required (b/201920967).

This fix makes it so that the icon is positioned using setX and setY rather than margins.

Fixes: 227372971
Test: Manual
Change-Id: I6e5371d20e8e2e4e6f41ba93d0dfa36ed085c103
2022-04-08 18:05:05 -07:00
Shikha Malhotra 6d6f62c462 Merge "Added provision to switch the PageIndicator in specific Launchers" into tm-dev 2022-04-08 20:17:44 +00:00
Jeremy Sim abdf25d226 Implement splitting from Taskbar long-press
Implements the ability to split the screen by long-pressing a Taskbar icon.

Bug: 217964720
Test: Manual
Change-Id: I5d324d8ca912c10cc3c3de21cae98fad546b85ac
2022-04-08 12:15:16 -07:00
Brian Isganitis d3d6f0d6db Merge "Add separate AFV type for options popup dialog." into tm-dev 2022-04-08 17:46:07 +00:00
Luca Zuccarini 45c43c7058 Merge "[Toast] Polish the layout of the QSB, tabs and header protection." into tm-dev 2022-04-08 17:21:32 +00:00
Stefan Andonian 24125503c1 Merge "Simplify AbstractFloatingView.closeOpenViews usage." into tm-dev 2022-04-08 16:06:26 +00:00
Shikha Malhotra 0f2e1b6714 Added provision to switch the PageIndicator in specific Launchers
Please see the related CL in LauncherLilyGoogle where pagination is
implemented as persistent dots.

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: Ic20aa92249b1bbe3c4ab7810683b54648a181722
2022-04-08 11:47:46 +00:00
Brian Isganitis 7ef4fe42cb Add separate AFV type for options popup dialog.
Now that we close all non rebind safe AFVs onResume, the options popup dialog is getting closed. This dialog is rebind safe, but currently using TYPE_OPTIONS_POPUP which isn't.

Test: Dialog stays open on activity recreate. Also ran affected tests.
Bug: 227142635
Change-Id: Ibbac925ce5dd2de5c7770cb8f5bd8c5e438449cf
2022-04-07 16:29:44 -07:00
Stefan Andonian d123fbd15d Simplify AbstractFloatingView.closeOpenViews usage.
This is a follow-up code review to ag/1754638 to address a comment that was missed before the CR was pushed.

Bug: 227142635
Test: Folders still close when launcher is paused.
Change-Id: Ib6724dc3a6ba49e259ba7de655f6810d6a692d16
2022-04-07 22:19:26 +00:00
Sebastián Franco 608b5cd5d8 Merge "Make the text for the drop target buttons fit if it's too long." into tm-dev 2022-04-07 22:14:07 +00:00
TreeHugger Robot b26c5b9741 Merge "Removing line submited by mistake." into tm-dev 2022-04-07 21:57:05 +00:00
Sebastián Franco c2d37e042d Merge "Make the widget option on the PopupContainer full width" into tm-dev 2022-04-07 21:49:35 +00:00
Schneider Victor-tulias 2ff0a66b8e Merge "Add logging to debug incorrect taskbar states caught by flaky tests." into tm-dev 2022-04-07 21:05:39 +00:00
Stefan Andonian 52eaebead4 Merge "Close open folders when pausing launcher." into tm-dev 2022-04-07 18:53:45 +00:00
Sebastian Franco dfa88d55f5 Make the widget option on the PopupContainer full width
The width of the PopupContainer grows if there are multiple
SystemShortcuts and we where not updating the width of all the
options.

Fix: 227538975
Test: Long press an app like Google Maps on the HomeScreen to see
the menu. All the options should have the same width.

Change-Id: I25310d74aa1af17be37b53c27d2334f86bef325a
2022-04-07 10:00:30 -07:00
Luca Zuccarini a5e95419f5 [Toast] Polish the layout of the QSB, tabs and header protection.
Specs and screenshot in the bug.

Fixes: b/227902759
Test: manual
Change-Id: Ia713c923a71207cfaab7068f20c8606d816f8b43
2022-04-07 16:53:53 +00:00
Sebastian Franco d2d8e97a65 Make the text for the drop target buttons fit if it's too long.
The text "Don't suggest app" is too long when the device language
is GE or JA, or if you make the text bigger in settings.

Before truncating the text completely we are going to try to make
the text smaller until it gets to a predefined value
(button_drop_target_min_text_size).

Test: Change the language to German (Deutch) and install a new app and drag it to the workspace to see the button "App nicht vorschlagen"
Test: Also, a nice way to test is to go to SecondaryDropTarget#setupUi and hardcode the option to always show "Don't suggest app"
Fix: 221480721
Change-Id: I99def4e23cd17109a297aecaa620cef7a0d137e7
2022-04-07 16:39:29 +00:00
TreeHugger Robot 833c210550 Merge "Clone mInsets when copying DeviceProfile to taskbar" into tm-dev 2022-04-07 13:44:14 +00:00
Alex Chau 9e9dd8fa43 Merge "Make AllApps bottom sheet follow finger and snap after 30% progress" into tm-dev 2022-04-07 09:50:04 +00:00
TreeHugger Robot e633cca3bc Merge "Adding finish signal to GestureNavContract." into tm-dev 2022-04-07 03:24:01 +00:00
Thiru Ramasamy aa49200100 Merge "Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event." into tm-dev 2022-04-07 01:07:28 +00:00
Sebastian Franco dac0769af1 Removing line submited by mistake.
Fix: 228327426
Test: Click the Notification dots
Change-Id: I3712e07eee5d4e5194b86de4fa1d45e1ef511dae
2022-04-06 15:25:34 -07:00
Stefan Andonian 253c23b2e8 Close open folders when pausing launcher.
Previously, folders wouldn't close after launching an app and quickly navigating back the launcher.
This is because the onStop state which contains a call to AbstractFloatingView.closeViews() wasn't being called.
This change adds an additional call to specifically close any open folders when the Launcher enters a paused state.

Bug: 227142635
Test: Verified that the issue is fixed after code change.
I logged the Launcher's lifecycle state to ensure my manual testing was reliable.

Change-Id: I838f992f83afdd754672ebbe85d0eb2a7e894417
2022-04-06 21:47:35 +00:00
Thiru Ramasamy d66f433cde Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event.
Test: Manual - wwdebug && wwlogcat - http://gpaste/5690465669087232
Bug: 210792253
Change-Id: Ibe0c762a9e40e1af85a4d18051ba2a74e9f6106a
2022-04-06 14:32:34 -07:00
Schneider Victor-tulias 1823bdba6e Add logging to debug incorrect taskbar states caught by flaky tests.
- Various TAPL tasts are flaking because the taskbar is present when navigating home. Several TAPL taskbar tests are also flaking because the taskbar is missing when opening an app. Adding logging to catch when FLAG_IN_APP is being set and why it isn't being applied.

Bug: 227657604
Bug: 225205246
Test: manual
Change-Id: Ia976bb0a6c7764e571fab3ac98ee21ff22ef7674
2022-04-06 14:26:47 -07:00
Sunny Goyal 5c20fdd73f Adding finish signal to GestureNavContract.
Also fixing also-closing behavior for FloatingSurfaceView for Android S

Bug: 228260232
Test: Verified manually on device
Change-Id: I83f6417a756c1459533294d681e83abba6ea58aa
2022-04-06 13:42:59 -07:00
Brandon Dayauon e3589debfd Merge "Change work_app_edu to be like T spec: https://screenshot.googleplex.com/43ThiCnqrAqAQgE" into tm-dev 2022-04-06 20:41:24 +00:00
Alex Chau e0227551cf Clone mInsets when copying DeviceProfile to taskbar
- Set mInsets with windowBounds.insets when initialized, and set windowBounds.insets when cloning DeviceProfile
- Added more bottom sheet / all apps in DeviceProfile dump
- Also dump taskbar's device profile in dumpsys

Fix: 226968237
Test: Taskbar AllApps should have correct top padding
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: I7739c699fb16544b92dc820354a643f745694c25
2022-04-06 19:44:43 +01:00
Stefan Andonian 510a818521 Show an 'Undo' snackbar when users dismiss a predicted hotseat item.
Bug: 200841778
Test: Hard-coded the flag to be true, and verified that the snack bar
is shown with the correct text. Also verified that talkback announces
"Item Removed" properly and that the correct log event is produced by
the AppEventProducer which AiAi needs to process the user action.

Change-Id: Ifbb9cf7aecf26cd4bcebf48d4fb07fb3d5af46bb
2022-04-06 17:22:40 +00:00
Alex Chau c83ea5f8fb Make AllApps bottom sheet follow finger and snap after 30% progress
Bug: 220336617
Test: manual
Change-Id: I0b6296cf5abf0f0a5f34fc2a0b5be93dc93ebf3f
2022-04-06 13:30:41 +01:00
Pat Manning 08610ca583 Adjust workspace grid and cellLayout paddings.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: Ia49e48f336bcca906aae6b014d88f10421b83d0c
2022-04-06 13:10:50 +01:00
Pat Manning de25c0db36 Adjust edit state drop targets and workspace scaling per device type and orientation.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: I0a642f932afd75e47ce11a2c1ee94643d1a67e0c
2022-04-05 20:56:03 +00:00
Brandon Dayauon d20011be15 Change work_app_edu to be like T spec: https://screenshot.googleplex.com/43ThiCnqrAqAQgE
Fixed the button to show on Portrait mode..streamline added for work_mode_fab.
Took out unneccessary attributes such as textColor for the button and took out background.

How it looks in landscape: https://screenshot.googleplex.com/AVaUEztqsXYA28N
How it looks in portrait: https://screenshot.googleplex.com/3oTG3j7yZLCxkLz
Apk: https://drive.google.com/file/d/1qLeiJSF3lHf7tZzoHWwBHGxDgbveTIYX/view?usp=sharing

Test: Manual - Tested on local Pixel device (Raven)
Bug: 224731116
Bug: 224731300
Change-Id: If1392806adecf1ce02723d20686ca6bf524f6464
2022-04-05 11:50:18 -07:00
Alex Chau f9aa367324 Merge "Override statusBar top inset in Launcher" into tm-dev 2022-04-05 10:19:26 +00:00
Stefan Andonian bae4a72d30 Merge "Show correct drop targets for All-apps predicted item drags." into tm-dev 2022-04-04 20:13:29 +00:00
Brian Isganitis 9417012064 Merge "Add utility for isWallpaperSupported." into tm-dev 2022-04-04 19:57:25 +00:00
Stefan Andonian c62a4dae5f Show correct drop targets for All-apps predicted item drags.
This change fixes a bug where, after a user drags and drops a
predicted app from the all apps page once, dragging that item again
results in the "Remove" drop target being shown rather than the
"Do Not Suggest" drop target.

Bug: 221057278
Test: Verified correct drop down targets were present after fix when
dropping all apps prediction item on workspace multiple times in a row.

Change-Id: I95940eeebbd547861fcdfbb5d02769b82446184d
2022-04-04 17:32:32 +00:00
Alex Chau 20af9304cb Override statusBar top inset in Launcher
Fix: 227600170
Test: manual on small and large screen devices
Change-Id: I1b0dacaf555db966d1e2a837310d9cebe3e60d7a
2022-04-04 17:39:31 +01:00
Sunny Goyal 59c535bb71 Merge "Adding a feature flag to disable icon overrides" into tm-dev 2022-04-01 17:26:09 +00:00
Pat Manning 5575dfeaad Merge "Revert "Adjust edit state drop targets, workspace scaling, and m..."" into tm-dev 2022-04-01 02:05:41 +00:00
Vinit Nayak c8b2fdbc6a Merge "Add metrics for taskbar 3 button nav" into tm-dev 2022-03-31 23:22:33 +00:00
Vinit Nayak 26b6b577b9 Add metrics for taskbar 3 button nav
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard

Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
Merged-In: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
2022-03-31 19:36:47 +00:00
Jon Miranda 39055bebc9 Merge "Avoid closing PopUpContainer immediately after view is clicked." into tm-dev 2022-03-31 17:08:33 +00:00
Sebastián Franco 89804c42d4 Merge "Fix widget drop animation in 4x5 grid" into tm-dev 2022-03-31 17:05:16 +00:00
Alex Chau 5f8386cf26 Merge "Using the WindowMetrics API instead of display.getRealSize" into tm-dev 2022-03-31 10:58:40 +00:00
Thales Lima c1ea50a43d Merge "Make inline qsb part of grid attrs" into tm-dev 2022-03-31 08:30:10 +00:00
Vinit Nayak 254c77e279 Merge "Fix translation for secondary split thumbnail in RTL" into tm-dev 2022-03-31 04:19:42 +00:00
Jerry Chang 8eba01dca3 Merge "Fix wrong split percentage after split layout been pushed up" into tm-dev 2022-03-31 04:07:15 +00:00