Commit Graph
14625 Commits
Author SHA1 Message Date
TreeHugger Robot dd683ab6c5 Merge changes from topic "revert-20479526-revert-20427045-258023561-BPDASTWITO-FBDWZBDEFC" into tm-qpr-dev am: 691c6e511f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20487426

Change-Id: I186279c0d3a7c8c3a92d83984c298e4687aae60b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 21:37:34 +00:00
TreeHugger Robot 691c6e511f Merge changes from topic "revert-20479526-revert-20427045-258023561-BPDASTWITO-FBDWZBDEFC" into tm-qpr-dev
* changes:
  Fixing the revert by not continuing the reorder if the solution is null.
  Revert "Revert "Reorder widgets no longer overlaps when no space..."
2022-11-22 21:18:42 +00:00
Sihua Ma 06dbe3f685 Merge "Adding the flag for putting widget host in the background" into tm-qpr-dev am: 09f04d34a3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20535705

Change-Id: I9a3764920bca4ab369c2ca070f02473d052a9d30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 19:40:17 +00:00
Sihua Ma 09f04d34a3 Merge "Adding the flag for putting widget host in the background" into tm-qpr-dev 2022-11-22 19:22:09 +00:00
Pinyao Ting ff521c99ad Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev am: ad932045ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20535959

Change-Id: Idb226f20849c78a5c06c6dcf4078d15cfb9090da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 17:46:42 +00:00
Jon Miranda e5e4d5a070 Merge "Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS." into tm-qpr-dev am: e57cab1da8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20536952

Change-Id: I4afa4d3e50c501f8504d727e1973588927bcffb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 17:45:51 +00:00
Pinyao Ting ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Jon Miranda e57cab1da8 Merge "Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS." into tm-qpr-dev 2022-11-22 17:20:21 +00:00
Xiaowen Lei a5255f7295 Merge "Fix issue in RTL where swipes on Launcher Smartspace are intercepted." into tm-qpr-dev am: 8eb1c3bde5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20498445

Change-Id: I0351da87d19752c112ba7654bb4670b9f8896b52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 17:17:37 +00:00
Xiaowen Lei 8eb1c3bde5 Merge "Fix issue in RTL where swipes on Launcher Smartspace are intercepted." into tm-qpr-dev 2022-11-22 16:53:04 +00:00
Xiaowen Lei 6d66ad20cf Fix issue in RTL where swipes on Launcher Smartspace are intercepted.
The `+ getScrollX()` translation is a duplicate, because
`mapCoordInSelfToDescendant` also does it internally. Same for the `+
getScrollY()`.

This wasn't an issue in LTR because the top left corner of the root view
is the same as the top left corner of the first page.  `getScrollX()`
returns 0 in that case.

In RTL, the second page is to the left of the first page. If the touch
is on the first page, `+ getScrollX()` translates it outside of the
first page. This incorrectly sets mIsEventOverFirstPagePinnedItem to
false, leading to the swipe being intercepted.

Bug: 240380590
Fix: 240380590
Test: manual
Change-Id: I51f534695401ce527da8d2158130a4d54b086f3d
2022-11-21 23:52:20 +00:00
Jon Miranda 3d72ac1a78 Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS.
Bug: 260002412
Test: enable flag
Change-Id: I4d82a853061b1540b6c6aea5e58b05a3ea6638e0
2022-11-21 23:46:34 +00:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
Sihua Ma 04ce9fa3ef Adding the flag for putting widget host in the background
Bug: 235358918
Test: N/A
Change-Id: I300bb5e293de6995a0e69402a6e337739055ca59
2022-11-21 14:17:50 -08:00
TreeHugger Robot 1326dc1981 Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev am: db81133e94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20523600

Change-Id: I021598ca2f8cc2cc159ff0cb849b56ef3cadc682
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 22:01:44 +00:00
TreeHugger Robot db81133e94 Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev 2022-11-21 21:45:47 +00:00
TreeHugger Robot 1414f12c14 Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530

Change-Id: Ib9eeb7e73e6b84c7dab4c8f89187a454f333bb33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 18:49:50 +00:00
TreeHugger Robot 81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Sunny Goyal bbe956ef5f Removing ENABLE_LOCAL_COLOR_POPUPS feature flag
The feature has been disabled for a while and is not working correctly.
Also there is no UX plan to revisit this currently

Bug: 206508141
Bug: 259733681
Test: Presubmit
Change-Id: If1279c22b9d074592ba181c7caa0cf38f9cb842e
2022-11-21 10:21:45 -08:00
TreeHugger Robot c0eb61e82c Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev am: c9c45ed783
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20489432

Change-Id: I59fa040c912c209f241d70b4d693df5b4d2649f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-19 01:04:01 +00:00
TreeHugger Robot c9c45ed783 Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev 2022-11-19 00:48:49 +00:00
Sebastián Franco df8f8a9e97 Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev am: 6322cb2e61
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512199

Change-Id: If5ac96d72dbc287445bb35d1eb7f418852f97365
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 18:42:49 +00:00
Sebastián Franco 6322cb2e61 Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev 2022-11-18 18:20:15 +00:00
Thales Lima ae0d7ef782 Increase icon size to be closer to spec
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
Brian Isganitis d652a85075 Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev am: 2766142f80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20502300

Change-Id: Iaa266409b8878dee8146bb8ad85c5197924f4729
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 06:20:43 +00:00
Brian Isganitis 2766142f80 Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev 2022-11-18 05:58:17 +00:00
Brandon Dayauon 5d4646ab66 Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev am: e1b66bd1bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512477

Change-Id: I6d6edc1468bedac51e0cbd9ff283fc011fa851e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 04:33:08 +00:00
Brandon Dayauon e1b66bd1bf Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev 2022-11-18 04:05:26 +00:00
TreeHugger Robot ed37fabc9c Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156

Change-Id: I2a176b09a92ce02acd2a406f6647701098164328
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 01:57:55 +00:00
TreeHugger Robot 3a801de233 Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev 2022-11-18 01:44:01 +00:00
TreeHugger Robot 4f366af03e Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev am: c5b5044aff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240749

Change-Id: I1998767143366e5e7ed2f2d0bad7a596cf9e8729
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 01:32:56 +00:00
TreeHugger Robot c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Stefan Andonian b626411c99 Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860

Change-Id: I397957b5d9584aebf4182930763a2c5ab6401073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 00:17:45 +00:00
Brandon Dayauon bcd65e85f4 Fix pause work apps button being higher than normal
This issue can be repro'd by typing something in toast box, hightlighting text, share, then back gesturing back to allApps work tab.
To fix, we can simply reset the translation when updating the visibility of the button by calling onApplyWindowInsets() in updateVisibility()

bug: 259004115
test: Photos Before: https://screenshot.googleplex.com/6JbHbK3rfdXiXM4 after: https://screenshot.googleplex.com/B99SLsFcPYf6jrG
Change-Id: I2d44de37666d5342457c6ae14c691eb1804043cd
2022-11-17 14:44:44 -08:00
Sebastian Franco 02b4711e74 Fix issue where the solution is not updated when the grid is empty
Test: Manually move widgets and shortcuts around and the position should match the animation
Fix: 259502044
Change-Id: I20a98f9366394c840bb3cd0577de26a181a229ac
2022-11-17 14:23:09 -08:00
Stefan Andonian a04de842d1 Fix ConcurrentModificationExceptions during binding.
The same lists of extra items stored in BgModelData are also stored in
UI components. This is causing ConcurrentModificationExceptions. The
solution is to clone these lists or mark them as immutable before storing
them in their respective components.

Bug: 206918543
Test: Verified that crash no longer occurs after fix.
Change-Id: I571a2c451af58137aa7513b372b6a8ecf9bd3ff6
2022-11-17 20:46:51 +00:00
Brian Isganitis 589c8d3e29 Add overlay proxy type to ALL and REBIND_SAFE.
Test: Manual
Fix: 259575422
Change-Id: I121fa0471f96df90e5ff88bbd0aba04556293dc7
2022-11-17 20:08:05 +00:00
Stefan Andonian 146701ca3e Move SharedPreferences code to its own class.
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
TreeHugger Robot 1b3a9650ce Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev am: 698239e16a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20033817

Change-Id: I1a36a8b8cef9038d95bc226f902f0b13f1acf12b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 11:34:40 +00:00
Alex Chau 29db172f9f Merge "Update overview to fit transient taskbar" into tm-qpr-dev am: 3dc6d7fb47
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469954

Change-Id: I3907c3804f3c1a7e8b4fc9f647bde01b5eb186ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 11:34:15 +00:00
TreeHugger Robot 698239e16a Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev 2022-11-17 11:28:05 +00:00
Alex Chau 3dc6d7fb47 Merge "Update overview to fit transient taskbar" into tm-qpr-dev 2022-11-17 11:04:18 +00:00
Tracy Zhou 7f754c162e Merge "Implement split from workspace to workspace" into tm-qpr-dev am: a71d353ff8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341821

Change-Id: I868918e650e3ef220a371ff785f2cd8d5de18225
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 07:46:17 +00:00
Tracy Zhou a71d353ff8 Merge "Implement split from workspace to workspace" into tm-qpr-dev 2022-11-17 07:04:48 +00:00
Jeremy Sim e589b0bd2e Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev am: c480c268e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432050

Change-Id: I9a65608333cf457ca36e7bcf6407c8296913d9e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 04:55:09 +00:00
Jeremy Sim c480c268e8 Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev 2022-11-17 04:19:04 +00:00
TreeHugger Robot dfd1f36639 Merge "Cleaning Utilities.java" into tm-qpr-dev am: 3ea398ecb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20392137

Change-Id: Ib65cd706bb230d7e8a8789d8e4a72c8ad0ed5815
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:02:59 +00:00
TreeHugger Robot 3ea398ecb7 Merge "Cleaning Utilities.java" into tm-qpr-dev 2022-11-17 02:39:38 +00:00
TreeHugger Robot 81a00e3d59 Merge "[QL-v2] Add logging for quick launch." into tm-qpr-dev am: ff86dd930d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304437

Change-Id: I6dd93058b39d35b28a30daf425a7a422e03d99fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 02:07:24 +00:00
Sihua Ma 1d678ad179 Merge changes If022ec8d,I34341937 into tm-qpr-dev am: c6bd4ad21f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20418246

Change-Id: Id937014a746d38749e7d22c3c269092c7108ba5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 02:07:09 +00:00