* feat(ui): Add toggle to disable search bar background in app drawer
* Fix double opacity on the Search Bar's background
- Before, the Search Bar added another -possibly transparent- layer on top of the already existing app drawer background.
- This adds a toggle to disable the double-opacity
- It is made so it is non regressive
Fixes#4158
* style(strings): Fixed inconsistency
Previously broken flow:
- Open All Apps on inner screen
- Drawing controller is set to the AllApps container
- Close All Apps (resting state becomes NORMAL)
- Fold, unlock
- Because we are still in NORMAL, the drawing controller was not
updated. Therefore when the ScrimView draws (alongside all other
views due to Launcher starting), it asks the inner screen's All
Apps container to render its panel on the scrim.
The fix is to remove the drawing controller when All Apps resets,
thereby avoiding trying to draw on the scrim in the first place. The
drawing controller is updated upon the next transition to All Apps,
as usual.
Bug: 426397329
Test: Manual: https://drive.google.com/file/d/1l9qAIkrgFalcO5DABOEIRX1Po3POYzab/view?usp=sharing&resourcekey=0-ccU6q2fbYE6y87ehIKdbEQ
Flag: com.android.launcher3.all_apps_sheet_for_handheld
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:288006fe11bdaec4bd229999619dd7097806620a)
Merged-In: I0a4872e6bd668583d08848a8b9c5f0f1389c4f0f
Change-Id: I0a4872e6bd668583d08848a8b9c5f0f1389c4f0f
This was previously the case, but I think I mistakenly updated this
to include phones with the all_apps_sheet_for_handheld flag at some
point. However, there was also some broken logic with the panel bounds
on phones. panel.getLeft() would be 0 because that's relative to the
container, so we need to do getLeft() + panel.getLeft().
Landscape (camera on left): https://hsv.googleplex.com/5035787895701504
Seascape (camera on right): https://hsv.googleplex.com/6210562886205440
Portrait: https://hsv.googleplex.com/6563945312681984
Tablet: https://hsv.googleplex.com/6704696994562048
Bug: 419235232
Test: See HSVs above compared to before images in the bug
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Change-Id: Id8b6f3367ee94ef22cb917e00518e843553b42d8
Previously we updated many other things, such as the buttons and RV
decorators, but the latest UX guidance is to use the same colors
when blurs are enabled or disabled, other than the panel color.
Note: When Overview blur is enabled, the activity is recreated and
this change is redundant. So this is only done if that flag is off.
Demo with home and taskbar all apps (toggling blur with adb):
https://drive.google.com/file/d/1HzveExKpAERxMVdu7JXQSYeGRwaBNR4_/view?usp=sharing&resourcekey=0-l-dGWOS6aCQjj2KStvwySA
Fix: 413229346
Flag: com.android.launcher3.all_apps_blur
Test: Manual with battery saver and `adb shell wm disable-blur 1` / 0
Change-Id: I55c9b46f0999c574c29a6ac7ae557b1e30d91d15
It reuses the predictive back animation now. In addition, if All
Apps entered directly into the Search state (i.e. via QSB), the
back gesture now scales the whole panel to indicate it will close
and return to the home screen (as opposed to closing Search within
All Apps).
Demo: https://drive.google.com/file/d/1wpaZg3JaSxDMMc62uU-1miP9RaIO10EB/view?usp=drive_link&resourcekey=0-h8qKzuDguwIE2vUDr0H6lQ
Fix: 406523972
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I470d67e03b2d8bbbaa39aea76c7dde639cff62f5
This can help debug issues like the blank all apps issue.
Bug: 393406722
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I0481531313d3633c46e63646511b59e081046cf8
This enables blur both for Taskbar and Launcher, but in slightly
different ways.
For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.
Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).
In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.
Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.
Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg
Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).
Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
Adding logs for investigation to verify related bugs where work profile
may seem inactive but is supposed to be active. This also helps verify
if touch is being received.
Bug: 383301695
Test: manually- screenshot in bug
Flag: EXEMPT adding logs
Change-Id: I9f42d7013c8a127767b5cbcfbe5c416cebb2adbd
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
The navbar scrim is scaled during the predictive back animation. This should be prevented since the navbar itself does not change it's position or scale.
Bug: 373544911
Test: Manual, i.e. verifying that the navbar scrim remains in its original position during the predictive back animation (with 3-button-nav) on phones and tablets
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Iaffd31de5493dea8c856ad3d5b441cca066bbad8
Test: Open all apps view from taskbar, start typing,
verify search session starts with the typed
query.
Bug: 361627643
Flag: EXEMPT bug fix
Change-Id: Ibe946a0d4c1f7197099a4a656d8874785aac1ee4
- The function used is a raised cosine function to determine the sections to animate.
Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary
bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
ActivityAllAppsContainerView
Previously, ActivityAllAppsContainerView assumed a static height for the
search box and relied only on FloatingHeaderView's height calculation.
With multi-line search bar, we need to add to the FloatingHeaderView's
mMaxTranslation to update the clipping position for the recycler views
belowe
Bug: b/341795751
Flag: com.android.launcher3.multiline_search_bar
Test: http://recall/clips/32f64e77-3522-4873-bc7b-86d844912724
Change-Id: I67aab186e96d7bdecbba454f660d73f0f4408a98
Pun Butrach