> Adding a completionSignal when preview is generated so that callers can wait on it
> Also adding support for proving an optional screen-id for preview
Bug: 400403115
Test: atest GridPreviewTest
Flag: EXEMPT refactor and unused new API
Change-Id: I569e0ab318ad101e4f6dd808f2e1cfc39ba50bda
Currently there is a bit of inconsistency in the way grid change
happens.
1. Grid migration decides different size, inflate item uses
different, and scale is applied using yet another size.
2. also when
going from small -> medium we reload data, but if while wallpaper picker
is open, if we revert to small, it leads to a wrong state due to
inconsistencies in #1 and shows cropped widget content. Instead in this
cl, we always reload on grid update, so widgets are shown for correct
size. There is still possibility of issue if the widget didn't respond
with data - but even in public build today there are tons of issues with
widgets on changing grid.
Bug: 408934352
Flag: EXEMPT BUGFIX
Test: See demo.
Change-Id: I91741d762cbf34ab7f9e0269ea307d2aad9e0eda
Test: Use dumpsys to check if SurfaceControlViewHost still exists
Bug: 410052692
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ibbb29445422dd37e764be2f518c9d528340cdfaa
There is extra work needed from the Wallpaper picker side to support
showing the FixedLandscape view on the Launcher. They are already
working on it but in the meantime we will disable the preview and show
the portrait view instead.
Fix: 402353157
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I12942a8f4edb7eff537d8431880cfe108e161ed2
Also fixing folder items not getting loaded when using sandbox
Bug: 381897614
Test: Verified manually
Flag: com.android.launcher3.extendible_theme_manager
Change-Id: I57232dcb4112c9e4d9dd08f02fc1b720a5adb0e2
Moving widget filtering to UI layer as it changes with surface
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
on to the communication channel for preview.
Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
> Using ShapeDelegate for icon clipping
> Creating ShapeDelegate based on the current icon shape
> Defining different shape delegates for icon and folder
> Updating preview rendering to use dagger graph
> Adding tests for all icon shapes
Bug: 392145015
Test: atest IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ic9f287e2a6fef2aad18ba224404de58a64da0bb3
Dark theme preview currently works for views and themed icons but
doesn't work for widgets (remote views).
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified
Bug: 371985937
Change-Id: I33193dff09d5900f1480720143ea272125a4c06c
The implementation in this CL is no-op i.e. all widgets will be shown
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately
In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
Receive color update messages with a list of color resource ids and a
corresponding list of color overrides, and adjust the preview
accordingly.
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified that the selected colors are previewed
Bug: 350718581
Change-Id: Ibcde0575416df00b76627ac1004f21f5f9af1196
> Using a single RunnableList for all the cleanup
> Performing cleanup when renderer surface is released
Bug: 362292374
Test: Verified manually using heapdump
Flag: EXEMPT bugfix
Change-Id: Idc1ee20dee2a2944d8e1c1d06b2662818d2b7001
The line causes an error in Window Manager. When removed, it doesn't
seem to have an effect for the Wallpaper Picker use case. The preview
render still shows correctly after config changes including rotation
and dark/light theme because the picker restarts and re-requests a
preview.
Flag: NA
Bug: 328089367
Test: manually tested with config changes and different lifecycle cases
Test: manually tested with multi crop flag on and off
Change-Id: Id1bd30c7ab4c50d29622b647bd368aafbd5c043f
Launcher preview could crash when unfolding a foldable device due to the
folded state display id no longer being valid, resulting in getting a
null display. This was leading to an empty preview bundle being
returned, which is unexpected because null is expected in the case of an
exception. Instead of crashing in getDisplayId, it's better to throw an
exception earlier on if the display is null and return null.
Flag: NA
Bug: 326637851
Test: manually verified by testing unfold in WPP in old and new preview
Change-Id: Ibc353d9447a71d33092d96029a812017487d0970
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items
Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
Flag: persist.wm.debug.wallpaper_multi_crop
Fix: 292152331
Test: Manual testing, make sure to turn on the flags by running this adb commands
adb shell setprop persist.wm.debug.wallpaper_multi_crop 1
adb shell device_config put customization_picker com.android.wallpaper.multi_crop_preview_ui_flag true
Change-Id: Iba9518e93c09f0f8304cbce4c3bee9f8753cd583
The existing code almost have the avility to use different display
for the preview by providing a different display id, this change
just make sure the InvariantDeviceProfile is created after we
create a new context with the desired display and we need to use
the default display for the SurfaceControlViewHost
Test: Manual testing, changing the display id on FixedWidthDisplayRatioFrameLayout
Bug: 292152331
Change-Id: I450d94a9a3f1a6a7b0c2b0722a11cf335122de05
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.
Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.
Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
This reverts commit 9ef41413e0.
Reason for revert: This was the only launcher CL during the time b/280669657 and 280680602 occurred
Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24