Commit Graph
74 Commits
Author SHA1 Message Date
Sunny Goyal 63fe0c779e Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered
> Adding a completionSignal when preview is generated so that callers can wait on it
> Also adding support for proving an optional screen-id for preview

Bug: 400403115
Test: atest GridPreviewTest
Flag: EXEMPT refactor and unused new API

Change-Id: I569e0ab318ad101e4f6dd808f2e1cfc39ba50bda
2025-05-09 10:42:39 -07:00
Shamali Patwa 32a30e410c Merge "Fix widget size in wallpaper preview when switching the grid" into main 2025-04-29 14:40:15 -07:00
Shamali P 5ad55f2c68 Fix widget size in wallpaper preview when switching the grid
Currently there is a bit of inconsistency in the way grid change
happens.

1. Grid migration decides different size, inflate item uses
different, and scale is applied using yet another size.

2. also when
going from small -> medium we reload data, but if while wallpaper picker
is open, if we revert to small, it leads to a wrong state due to
inconsistencies in #1 and shows cropped widget content. Instead in this
cl, we always reload on grid update, so widgets are shown for correct
size. There is still possibility of issue if the widget didn't respond
with data - but even in public build today there are tons of issues with
widgets on changing grid.

Bug: 408934352
Flag: EXEMPT BUGFIX
Test: See demo.
Change-Id: I91741d762cbf34ab7f9e0269ea307d2aad9e0eda
2025-04-28 12:20:15 -07:00
George Lin ddabe29d29 Fix SurfaceControlViewHost holding surface view (1/4)
Test: Use dumpsys to check if SurfaceControlViewHost still exists
Bug: 410052692
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ibbb29445422dd37e764be2f518c9d528340cdfaa
2025-04-24 14:26:04 +00:00
Sebastian Franco af31a6fa80 Deactivate fixed landscape preview and show portrait preview instead.
There is extra work needed from the Wallpaper picker side to support
showing the FixedLandscape view on the Launcher. They are already
working on it but in the meantime we will disable the preview and show
the portrait view instead.

Fix: 402353157
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I12942a8f4edb7eff537d8431880cfe108e161ed2
2025-03-28 17:05:51 -07:00
Sunny Goyal 45f1a5190c Merge "Using item inflater for predicted items and previews" into main 2025-03-28 15:18:11 -07:00
Sunny Goyal bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Sihua Ma 5c1534b58d Enable previewing themed icon in wallpaper picker
Test: Presubmit
Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 406813938
Change-Id: I9377db41ac422cd80e7af434f28a5b16cdbd02d2
2025-03-27 22:38:03 +00:00
Sunny Goyal 31b4d2bd32 Adding support for custom layouts in Preview
Also fixing folder items not getting loaded when using sandbox

Bug: 381897614
Test: Verified manually
Flag: com.android.launcher3.extendible_theme_manager
Change-Id: I57232dcb4112c9e4d9dd08f02fc1b720a5adb0e2
2025-03-21 10:32:38 -07:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Treehugger Robot d300486e66 Merge "Adding option to skip animations for testing" into main 2025-02-28 13:10:53 -08:00
Sunny Goyal 998cf2cb7e Adding option to skip animations for testing
Bug: 398894260
Flag: EXEMPT test
Test: atest GridPreviewTest
Change-Id: I9c3a7f6d8dfd63eac46038cc5d769def0392c194
2025-02-25 19:22:12 +00:00
Federico Baron 45fe4733fb Fix grid previewing so it matches the applied layout
Bug: 392019771
Flag: com.android.systemui.shared.new_customization_picker_ui
Test: tested manually
Change-Id: If0fdd130d4278222b0b6ec2787aa7d6d56fc4b2f
2025-02-24 11:54:26 -08:00
Charlie Anderson de15672e6f Initialize shape with PreviewContext init and remove nullability
Bug: 372887760
Bug: 348664593
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: previewing shapes with flag on/off
Change-Id: I4d7278c54a0d69e38142d31dd7a9605a74db3348
2025-02-21 20:23:49 +00:00
Sunny Goyal 3fd385c1cd Moving grid customization provider to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I0ebc2a614b9448e5de97d3dda43d98b951989689
2025-02-20 10:16:56 -08:00
Sebastián Franco 3d3438ebbb Merge "Rotate Wallpaper Picker if in FixedLandscape" into main 2025-02-13 13:26:26 -08:00
Sunny Goyal 5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Sebastian Franco e34f561224 Rotate Wallpaper Picker if in FixedLandscape
Bug: 382906719
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id4f29567899e4fec5585247077456eec5f343b98
2025-02-11 12:32:52 -06:00
Sunny Goyal 986d7cb9c0 Fixing leaks in LauncherPreview
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
  on to the communication channel for preview.

Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
2025-01-30 00:16:08 -08:00
Sunny Goyal 4c261f7343 Fixing icon shape not properly clipped
> Using ShapeDelegate for icon clipping
> Creating ShapeDelegate based on the current icon shape
> Defining different shape delegates for icon and folder
> Updating preview rendering to use dagger graph
> Adding tests for all icon shapes

Bug: 392145015
Test: atest IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: Ic9f287e2a6fef2aad18ba224404de58a64da0bb3
2025-01-29 16:24:38 +00:00
Charlie Anderson 3799932a38 Add ability to preview and apply shapes from Picker
Bug: 372887760
Bug: 372887555
Bug: 388579538
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Manually change icon shapes

Change-Id: Ie423306e3ae5ae8176898ff5ffc59b4b576c20f4
2025-01-14 07:24:52 -08:00
Catherine Liang c6c724ac82 Merge "Add ability to preview dark theme into Launcher preview" into main 2024-11-08 20:37:49 +00:00
Catherine Liang daf1defe55 Add ability to preview dark theme into Launcher preview
Dark theme preview currently works for views and themed icons but
doesn't work for widgets (remote views).

Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified
Bug: 371985937
Change-Id: I33193dff09d5900f1480720143ea272125a4c06c
2024-11-07 19:09:38 +00:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Catherine Liang b5fdc80bb2 Handle messages to update Launcher preview color
Receive color update messages with a list of color resource ids and a
corresponding list of color overrides, and adjust the preview
accordingly.

Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified that the selected colors are previewed
Bug: 350718581
Change-Id: Ibcde0575416df00b76627ac1004f21f5f9af1196
2024-10-04 19:33:45 +00:00
Sunny Goyal be796be5e6 Fixing wallpaper preview rendered not being cleaned properly
> Using a single RunnableList for all the cleanup
> Performing cleanup when renderer surface is released

Bug: 362292374
Test: Verified manually using heapdump
Flag: EXEMPT bugfix
Change-Id: Idc1ee20dee2a2944d8e1c1d06b2662818d2b7001
2024-09-26 19:46:45 +00:00
George Lin de4d7457a8 Send message to launcher renderer to update grid (3/3)
This CL supports external surface view callbacks to send messages to
update the launcher's preview grid.

Bug: 348664593
Test: Manually tested. See bug.
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I8108ae2c49af6b4fc1a207c6ece23e82616baa61
2024-09-05 16:49:15 +00:00
Sunny Goyal 77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Catherine Liang 975a0695fb Merge "Remove createWindowContext in Launcher preview renderer" into main 2024-03-11 14:13:01 +00:00
Catherine Liang 0089efe18a Remove createWindowContext in Launcher preview renderer
The line causes an error in Window Manager. When removed, it doesn't
seem to have an effect for the Wallpaper Picker use case. The preview
render still shows correctly after config changes including rotation
and dark/light theme because the picker restarts and re-requests a
preview.

Flag: NA
Bug: 328089367
Test: manually tested with config changes and different lifecycle cases
Test: manually tested with multi crop flag on and off
Change-Id: Id1bd30c7ab4c50d29622b647bd368aafbd5c043f
2024-03-05 20:32:45 +00:00
Catherine Liang 71767d1605 Fix Launcher preview crash
Launcher preview could crash when unfolding a foldable device due to the
folded state display id no longer being valid, resulting in getting a
null display. This was leading to an empty preview bundle being
returned, which is unexpected because null is expected in the case of an
exception. Instead of crashing in getDisplayId, it's better to throw an
exception earlier on if the display is null and return null.

Flag: NA
Bug: 326637851
Test: manually verified by testing unfold in WPP in old and new preview

Change-Id: Ibc353d9447a71d33092d96029a812017487d0970
2024-02-26 21:35:20 +00:00
Andy Wickham b922dccbf5 Cleanup API checks for P, Q, and R.
Test: Build with gradle
Flag: NA
Change-Id: I3ef17090741d14bebd76cf09cf3dc5ac4f11e686
2024-01-24 14:58:08 -08:00
Charlie Anderson 511421c12f Adds logging for Launcher restore metrics in Launcher and LoaderTask
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items

Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
2023-12-18 19:32:02 +00:00
Stefan Andonian dd088daead Revert "Update launcher preview icons on themed icon update"
Revert submission 25242534-launcher-preview-update-themed-icon

Reason for revert: This change potentially breaks the launcher's database.

Reverted changes: /q/submissionid:25242534-launcher-preview-update-themed-icon

Change-Id: I90fd55695b24529752a82cb6bf001935204a53f7
2023-11-30 20:12:40 +00:00
Catherine Liang d64230f449 Update launcher preview icons on themed icon update
Flag: NA
Bug: 300257098
Test: manually verified
Change-Id: Ic34cdce3021d8fcc97c153671bd1f05013933b6d
2023-11-03 11:40:02 +08:00
Sebastian Franco 1b1c917af5 Adding the avility to have a PreviewSurfaceRenderer per screendID
Flag: persist.wm.debug.wallpaper_multi_crop
Fix: 292152331
Test: Manual testing, make sure to turn on the flags by running this adb commands
adb shell setprop persist.wm.debug.wallpaper_multi_crop 1
adb shell device_config put customization_picker com.android.wallpaper.multi_crop_preview_ui_flag true

Change-Id: Iba9518e93c09f0f8304cbce4c3bee9f8753cd583
2023-10-18 13:35:38 -07:00
Sebastian Franco 1e4e50149b Reorder code so we can use different displays on the preview render
The existing code almost have the avility to use different display
for the preview by providing a different display id, this change
just make sure the InvariantDeviceProfile is created after we
create a new context with the desired display and we need to use
the default display for the SurfaceControlViewHost

Test: Manual testing, changing the display id on FixedWidthDisplayRatioFrameLayout
Bug: 292152331
Change-Id: I450d94a9a3f1a6a7b0c2b0722a11cf335122de05
2023-08-14 12:56:13 -07:00
Stefan Andonian 9d7bffe37b Fix NPE in LauncherPreviewRenderer.
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.

Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.

Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
2023-05-15 22:41:04 +00:00
Sunny Goyal 7bc6cdee56 Revert "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""""
This reverts commit 09905cfa90.

Reason for revert: Fixed the crashing issue

Change-Id: Ibcfc28a89356d262e67e8842d6bae37e230a70f5
2023-05-13 01:59:19 -07:00
Sunny Goyal 09905cfa90 Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""
This reverts commit bca4e694f0.

Reason for revert: post submit broken

Change-Id: I8afc63b5aa67ee14127f79e2245ef543bff8cf31
2023-05-11 22:22:16 +00:00
Sunny Goyal bca4e694f0 Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""
This reverts commit 3772b246c2.

Reason for revert: Fixed the test failure

Change-Id: Ibdc9e184fcb32c7caa4ab25d8753a46fa322b703
2023-05-10 17:49:16 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
Stefan Andonian e4609a27bd Load Delegate Items in correct order when loading Launcher Data.
Bug: 251502424
Test: Loaded and bound the workspace properly.
Change-Id: Ia6d609ffa21c5036cb48e464d3e8d4fa561cb008
2023-04-10 15:46:12 +00:00