Commit Graph
9047 Commits
Author SHA1 Message Date
Anna Wasewicz d186820db0 Changing ENABLE_HINTS_IN_OVERVIEW flag to be true in qt-r1-dev. It should be false in qt-dev and true in qt-r1-dev.
am: 064cba4560

Change-Id: I674f00fb043223b67eef64df9956e62c384b453a
2019-07-23 18:04:09 -07:00
Anna Wasewicz 064cba4560 Changing ENABLE_HINTS_IN_OVERVIEW flag to be true in qt-r1-dev. It
should be false in qt-dev and true in qt-r1-dev.

Bug: 138252347
Change-Id: If9de47ef937ecb3da9c8d43eea8ad4b6e6885582
2019-07-23 17:34:34 -07:00
Tony Wickham dc9a1266ee Merge "Set FastBitmapDrawable scale=1 before drawing it in DragView" into ub-launcher3-qt-r1-dev
am: b2e6a77b0d

Change-Id: I844464daa971af505c34c4566e2c4c8c35143dc8
2019-07-23 17:28:55 -07:00
vadimt 443f05052c Merge "Adding debug tracing" into ub-launcher3-qt-r1-dev
am: 8578309f1b

Change-Id: If2f3b4d4a849e94449c4b06a567c12610547fc61
2019-07-23 17:28:32 -07:00
Tony Wickham b2e6a77b0d Merge "Set FastBitmapDrawable scale=1 before drawing it in DragView" into ub-launcher3-qt-r1-dev 2019-07-24 00:07:18 +00:00
vadimt cd7b00853b Adding debug tracing
Bug: 138251824
Change-Id: Ibe3de964aeacbf83fd46cc53fda7d15c9401fe4d
2019-07-23 16:49:48 -07:00
Tony Wickham d418f3c3fa Set FastBitmapDrawable scale=1 before drawing it in DragView
When we draw the icon to the DragView, we draw it
with the current scale, which is > 1 when animating
the icon down. Instead, we should always draw the
icon with scale 1 since the DragView itself is scaled.

Bug: 138236583
Change-Id: I6bca5cf28c54d58476240e0e68900a8f08ffe60b
2019-07-23 13:48:08 -07:00
Tony Wickham f05d3f8fd4 Revert the changes that prevented touch on RecentsView during animation
am: b6841ac630

Change-Id: Ia0c9ec7a600e5d3064297630d16eb862d486bf45
2019-07-22 15:57:55 -07:00
Tony Wickham b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Vinit Nayak f9b585b507 Don't specify 1P Launcher3 type if 3P Launcher is active
Instead of referencing Launcher directly (which may not be
present when there's a 3P launcher), reference the lowest
common ancestor of Launcher and RecentActivity to avoid
ClassCastExceptions.

Test: Visually inspected that Pixel Launcher crash dialog
no longer pops up.
* Install 3P launcher
* In developer options enable "enable freeform windows"
* Restart phone for settings to take effect
* Try to use it on any app you have in recent tasks

Fixes: 135419782
Change-Id: Ie1f54880ab46956b23e253850ca7f79b161da9bd
2019-07-19 11:11:35 -07:00
Tony Wickham 6e6ebe9db3 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev
am: 6670435c14

Change-Id: If4a2599b3011001d1ef09fb36e07778383b60fe1
2019-07-18 16:01:53 -07:00
Tony Wickham 6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
Pinyao Ting bca0d254ec Merge "do not close widgets that are safe for rebind upon orientation change" into ub-launcher3-master 2019-07-18 19:56:18 +00:00
Pinyao Ting a74b63aa07 do not close widgets that are safe for rebind upon orientation change
bug: 135608744
Change-Id: I58e9e44eb61f3b22df6ec656ac864f6da3fb479f
2019-07-17 23:26:06 -07:00
TreeHugger Robot 37d8437c60 Merge "Moving some utilities methods to separate class" into ub-launcher3-master 2019-07-18 00:27:53 +00:00
vadimt 2254bcae3f Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev
am: aaf6c7ce56

Change-Id: I9e32e16101a837a61c9488f4b0d4484982778092
2019-07-17 16:27:12 -07:00
TreeHugger Robot e5cb05f405 Merge "Removing global state from DeepShortcutManager" into ub-launcher3-master 2019-07-17 22:28:35 +00:00
vadimt 2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Sunny Goyal 31ab19f71d Removing global state from DeepShortcutManager
This makes DeepShortcutManager thread-safe and avoids any locks

Change-Id: If4593b3541da6259591ff7a607efa58158006481
2019-07-17 15:16:33 -07:00
Sunny Goyal 9dbb27c09c Moving some utilities methods to separate class
Change-Id: I5094b22ddc77c45590cea1a5f5dead0dc7580abf
2019-07-17 15:15:07 -07:00
TreeHugger Robot 401583f9b6 Merge "Getting starting point of swipe from overview to all apps via protocol" into ub-launcher3-qt-r1-dev 2019-07-17 00:24:55 +00:00
vadimt 6a75e52f85 Getting starting point of swipe from overview to all apps via protocol
Change-Id: Idf04579b67011dac45b081a81367cde2d1274117
2019-07-16 16:46:53 -07:00
TreeHugger Robot f2de54b275 Merge "Removing tracing for fixed bugs" into ub-launcher3-qt-r1-dev 2019-07-16 23:15:07 +00:00
Jon Miranda 42bd7dad6c Fix app open/close animation in RTL.
Bug: 135165284
Change-Id: Ib50f213904cb7ac7c769fac04dbfc70005fe25b8
2019-07-16 13:58:29 -07:00
TreeHugger Robot 160134e0b1 Merge "Fix overshoot velocity in 2-button landscape mode" into ub-launcher3-qt-r1-dev 2019-07-16 17:38:05 +00:00
vadimt 7a4ed2f258 Removing tracing for fixed bugs
Bug: 133009122
Bug: 133765434
Bug: 134532571
Change-Id: I37aa1851a1bc0874c0b9acf561bde28966e9b523
2019-07-15 18:48:06 -07:00
Anna Wasewicz f170b7efcb Set the chips flag to false in QP1A. This flag should be off by default. Chips should not be running in QP1A. Bug:137290162
am: 7400bb3f72

Change-Id: I64042172f17068b59bc3efeb23a9d9821510519c
2019-07-15 14:19:41 -07:00
TreeHugger Robot b8975ed602 Merge "Fix bug where app icons are clipped when transitioning from app to home." into ub-launcher3-qt-r1-dev 2019-07-15 20:06:06 +00:00
Tony 5818f9b3c5 Fix overshoot velocity in 2-button landscape mode
Now we use the velocity towards the middle of the screen
(e.g. x when in landscape) instead of always using y.

Test: testBackground with @PortraitLandscape

Bug: 135567630
Change-Id: I77ab6bdf0d556475a6c182ae91914a718a81e1c4
2019-07-12 18:02:09 -07:00
Becky Qiu 75970447a7 Merge "Fill the logging container in the AllAppsContainerView" into ub-launcher3-qt-r1-dev 2019-07-12 21:15:25 +00:00
TreeHugger Robot acc2b33574 Merge "Switching flinging gestures injection to model time" into ub-launcher3-qt-r1-dev 2019-07-12 18:12:59 +00:00
Anna Wasewicz 7400bb3f72 Set the chips flag to false in QP1A. This flag should be off by default.
Chips should not be running in QP1A.
Bug:137290162

Change-Id: I159e1bd00d1f9ff4f6cf63daf93a68e3e8d063c8
2019-07-11 18:58:05 -07:00
Tony Wickham a160e2bc78 Merge "Defer jumping to NORMAL state if overview is still peeking" into ub-launcher3-qt-r1-dev 2019-07-12 00:27:42 +00:00
Tony Wickham e1463f5580 Defer jumping to NORMAL state if overview is still peeking
Bug: 137316430
Change-Id: I1ace19bb229d07bd9dfe5ed6f60c63715b9f8cf2
2019-07-11 16:55:01 -07:00
vadimt 1fd52d9024 Remove tracing for a fixed bug
Bug: 132900132
Change-Id: Ic4ce3669f88c932e392b7517ec9fda11384dc334
2019-07-11 16:00:12 -07:00
Vadim Tryshev 59b5b3f2a2 Merge "Removing tracing for a fixed bug." into ub-launcher3-qt-r1-dev 2019-07-11 22:46:19 +00:00
TreeHugger Robot 36ca57e996 Merge "Fix bug where floating icon and workspace icon visible at the same time." into ub-launcher3-qt-r1-dev 2019-07-11 22:21:49 +00:00
Becky 8874e5f8a7 Fill the logging container in the AllAppsContainerView
This would fix the issue that when drag and drop an icon from the all apps
page, it doesn't have the right container information logged.

Logging after this fix:
07-11 10:57:04.392 12969 12969 D UserEvent: action:DRAGDROP
07-11 10:57:04.392 12969 12969 D UserEvent:  Source child:APP_ICON	parent:ALLAPPS
07-11 10:57:04.392 12969 12969 D UserEvent:  Destination child:APP_ICON	parent:WORKSPACE id=0
07-11 10:57:04.392 12969 12969 D UserEvent:  Elapsed container 744 ms, session 17440 ms, action 739 ms

Test: manual
Bug: 111935715
Change-Id: Ifb078e57697b051e3a527c16abaad40663eae687
2019-07-11 14:36:37 -07:00
vadimt 853852351f Correctly restarting Launcher from OOP tests
Waiting for touch interaction service; waiting for package-restart
events.

Bug: 136215685
Change-Id: I0c31c09fe3a58b898168dfdb4e4d23757b94a47c
2019-07-11 14:17:06 -07:00
vadimt 2af71dd058 Removing tracing for a fixed bug.
Bug: 133867119
Change-Id: I796118f5ff0c27db002bb0e3369e651c95b06bbe
2019-07-11 20:18:32 +00:00
vadimt 4d93df51a3 Switching flinging gestures injection to model time
This is a right thing to do in any case.

Change-Id: I34eeecac6d9eb13130eb1015f9a9a5e2a32974ec
2019-07-10 17:38:26 -07:00
Jon Miranda cabbaf986c Fix bug where floating icon and workspace icon visible at the same time.
- Add a signal for the animation to be "cancelled"
- Allow the workspace view to be attached to a spring during the animatoin
  (but kept hidden) to prevent any jumpy movement

Bug: 137215697
Change-Id: Ie6868a7f45fefaee5366c8d30bb323fe042e9156
2019-07-10 14:14:23 -07:00
Winson Chung 24fbe81e99 Merge "Copy resume callbacks list prior to making callbacks" into ub-launcher3-qt-dev
am: 094e5638a5

Change-Id: Ia3e9088f6341ebc37fd1286e12191cdd8776c64f
2019-07-10 13:59:06 -07:00
Jon Miranda 857b3fbb7e Fix bug where app icons are clipped when transitioning from app to home.
Bug: 135636137
Change-Id: Icaba06ed27b3196371730a5a4c5d3382cedc7000
2019-07-10 11:04:40 -07:00
TreeHugger Robot ddf64806e2 Merge "Fix bug where icon is no present during app close animation." into ub-launcher3-qt-r1-dev 2019-07-10 17:54:58 +00:00
Winson Chung 940b0ac015 Copy resume callbacks list prior to making callbacks
- Starting a deferred activity can trigger a new callback to be added
  to the list while we are iterating it

Bug: 136613192
Change-Id: I6690ab0695bb73f11bf343fb41e9fc86b4afec1b
2019-07-09 16:49:26 -07:00
Adam Cohen ab6be31746 Fix issue where can't interact with Workspace while App => Home is running
=> Regression from recent CL ag/8074890
=> Fix which scopes the change down to the RecentsView, but not all PagedViews

Bug 136733573

Change-Id: I0abaa61b2b132d8086dc3b2cb3e3e9c1f181b5f5
2019-07-06 04:27:49 +00:00
Jon Miranda 826cdcd32f Fix bug where icon is no present during app close animation.
* WindowTransformSwipeHandler closes all AbstractFloatingViews, including
  ListenerView, which results in FloatingIconView getting removed.
* In IconLoadResult.onIconLoaded, we remove the check for isIconLoaded since
  its not needed. This was also causing a race condition since isIconLoaded
  is not set to true until after we tell onIconLoaded to run.
* In BaseDragLayer, we have a delay before checking if the view is open and
  then closing the floating view if true. This caused issues since we reycle
  the view. Now we check if the view is open before running the delay to call
  close.

Bug: 136044361
Change-Id: I7442a589a62c3cdf90b70d146e0ecf3e4300ddf7
2019-07-02 14:35:11 -07:00
Winson Chung f5e81122a0 Revert "Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace""
This reverts commit c4c8b3c695.

Reason for revert: Re-enabling for R1

Change-Id: Id6706c548dcc9debbfaf2069164636bc22aa9b5e
2019-06-29 00:28:55 +00:00