Commit Graph
14186 Commits
Author SHA1 Message Date
Luca Zuccarini ce03c9972b Fix issue with keyboard disappearing too late.
This seems to have been caused by a bad merge which removed the call
from outside the end listener. We reintroduce it for atomic animations
only, as for manual ones we want the keyboard to animate in sync with
All Apps (note that this is how it used to be, and doesn't depend on the
keyboard sync flag).

Fixes: 243632287
Fixes: 240116666
Test: manual
Change-Id: I9d226a4bd7cbde0692ae82b5a138b0d523fd5f25
2022-09-12 11:01:31 +00:00
TreeHugger Robot 69b9e736a8 Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev 2022-09-10 05:03:23 +00:00
Sunny Goyal 8958a7078a Simplifying hideKeyboardAsync method
Bug: 246000321
Test: Presubmit
Change-Id: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
Merged-In: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
2022-09-10 04:01:48 +00:00
TreeHugger Robot 1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Andy Wickham 94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Sebastián Franco b64894b095 Merge "Adding specific case for applications in getEntryMigrationId" into tm-qpr-dev 2022-09-09 21:50:52 +00:00
TreeHugger Robot d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Winson Chung 607a976635 Merge "Fix missing call to super cancel method" into tm-qpr-dev 2022-09-09 16:16:09 +00:00
Aurélien Pomini 687c6e415c Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev 2022-09-09 14:25:16 +00:00
Winson Chung 82638f6ef1 Fix missing call to super cancel method
- Without the call, it's interpreted as a successful animation to the
  listener even though it was canceled

Bug: 245829938
Test: Swipe to previous task, immediately after settling touch the
      swipe area again
Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678
2022-09-09 05:58:27 +00:00
Anushree Ganjam a461660fa8 Introduce KeyboardStateManager to maintain keyboardstate as show or hide.
- Add a feature flag for IME Latency logging.

- Removed mShowImeAfterFirstLayout from ExtendedEditText.

   http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
   says "Show IME when search query != null after rotation".

   I verified the behavior by turning on "Allow home screen rotation".
   Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
   or even in the search screen.
   Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow

Bug: 240192346
Test: Manual.

Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.

- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard

Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
2022-09-09 04:32:33 +00:00
Raj Garg 2e106277d7 Merge "Introducing new variable to enable/disable shortcuts." into tm-qpr-dev 2022-09-09 03:41:47 +00:00
Sebastian Franco b0ac461e06 Adding specific case for applications in getEntryMigrationId
A string like this are sued as id when migrating the grid:

The problem is that sourceBounds can chagne for the same app
and then return the same app as different. To fix it I added
a new case for Aplications and remove the variable sourceBounds
for the default case if there is anotherr Favorites item that
has the same problem but we don't know.

Test: Manually migrated between different grids.
Fix: 232004084
Change-Id: Ida015c971c70c8de2915fca1ebc38f446c21a310
2022-09-08 17:10:53 -07:00
TreeHugger Robot 3426372ff8 Merge "Explicit Nullbility in Launcher (Part 3)" into tm-qpr-dev 2022-09-08 21:37:30 +00:00
Schneider Victor-tulias 82e112c2a4 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev 2022-09-08 17:53:26 +00:00
Pinyao Ting 96d3c589ef Explicit Nullbility in Launcher (Part 3)
This CL updates the nullabality on ItemInfo related classes.

Bug: 242895652
Test: manual
Change-Id: I5fa17a17ff876486431f48d750abdc31afbc56a0
2022-09-08 09:36:00 -07:00
Anushree Ganjam 94a54203f3 Merge "Add a feature flag for showing Search Educard in QSB" into tm-qpr-dev 2022-09-07 22:05:38 +00:00
Anushree Ganjam c74ef95d50 Add a feature flag for showing Search Educard in QSB
Bug: 243680092
Test: Manual
Change-Id: I3ba1f577df2a5cfb2eb5f7acad20b47980c20916
2022-09-07 19:14:35 +00:00
Alex Chau 0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal 7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Brian Isganitis 2d82ad2664 Merge "Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI" into tm-qpr-dev 2022-09-06 17:21:51 +00:00
Pat Manning b11dedc254 Merge "Use full screen width for drop target buttons to support higher screen densities from truncating text." into tm-qpr-dev 2022-09-06 14:59:48 +00:00
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Anushree Ganjam 37bcfaddba Merge "Add a boolean to track QSB edu card dismissal." into tm-qpr-dev 2022-09-02 15:37:17 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Sukesh Ram 8d3d944d5d Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI
Bug: 238325716
Test: Manual
Change-Id: I66a85eb79cda89a63c3116a56a52b51526720158
Merged-In: I66a85eb79cda89a63c3116a56a52b51526720158
2022-09-02 00:44:39 +00:00
Schneider Victor-tulias 119ae79e3c Enable input consumer selection reason logging and gesture navigation error detection.
Bug: 227514916
Test: ran locally, tested multiple gestures and checked logs
Change-Id: Iab0c9a21ee0141744cf82afd16ee941f2b49a9cc
2022-09-01 15:59:07 -07:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Sunny Goyal f2c6bf8346 Moving view capture dump to a service to allow longer timeout
Bug: 243827665
Test: Verified on device
Change-Id: I7273cc14d86620b52aaf71c7ea293bd643d881f9
2022-09-01 11:57:23 -07:00
Thales Lima e3948da48d Merge "Extract cell horizontal space to a method" into tm-qpr-dev 2022-09-01 16:23:53 +00:00
TreeHugger Robot a29868e30c Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev 2022-09-01 01:54:18 +00:00
Tony Wickham d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Anushree Ganjam b368fcc624 Add a boolean to track QSB edu card dismissal.
Bug: 243680092
Test: Manual.
Change-Id: I6981e423d037851020ae1cdec9879ab577769258
2022-08-31 21:46:39 +00:00
TreeHugger Robot bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00
Schneider Victor-tulias 038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Pat Manning e63dd25a54 Use full screen width for drop target buttons to support higher screen densities from truncating text.
Scale oversized text down if after all computations it will still be truncated at higher densities.

Fix: 239401464
Test: manual. To follow up with screenshot test: b/241386128
Change-Id: Ie088d0631b0d13beb2d9f9d5396a56f7b971dee1
2022-08-30 14:57:42 +01:00
Pat Manning b4a30ab955 Merge "Refactor overview progress as splash progress." into tm-qpr-dev 2022-08-30 13:29:53 +00:00
Pat Manning 81dc9ad131 Refactor overview progress as splash progress.
This also avoids showing splash in split select state

Fix: 242284413
Test: follow up after b/238405972
Change-Id: I2e83fa3d030e8a74edb4152c472dbf02ac5a80b1
2022-08-30 11:23:08 +01:00
Sebastian Franco 47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Becky Qiu edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Schneider Victor-tulias 7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias 24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Schneider Victor-tulias a0cd3e0295 Collapse EventLogArray into ActiveGesture log.
EventLogArray is never used directly, only used as a super class of ActiveGestureLog. Simplifying the hierarchy to simplify follow-up changes.

Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I0916f969a776953ddc4886846ad2f4936566e7d7
2022-08-25 09:59:13 -07:00
Thales Lima 1e8b45f8f1 Extract cell horizontal space to a method
Fixes: 229100375
Test: DeviceProfileTest
Change-Id: Ia2e560b37f4e9fbff9b5c2e7c0ef3fe710e55c29
2022-08-25 11:50:59 -04:00