Tony Wickham
aa2af22da8
Fix continueComputingRecentsScrollIfNecessary() running infinitely
...
When continuing a gesture during quick switch, we cancel the
previous animation but don't invalidate it (since the gesture
isn't fully finished), and the new gesture handler calls
mRecentsView.setOnPageTransitionEndCallback(), so the previous
handler will never get STATE_RECENTS_SCROLLING_FINISHED. Thus,
continueComputingRecentsScrollIfNecessary() will never end.
To fix this, also check !mCanceled, since that is set when
continuing the gesture. Also use postOnAnimation() instead of
post() since that has better guarantees that the next
computation will wait for the next animation frame, rather
than whenever the message queue is available, which might
happen too frequently.
Test: quick switch from A to B and back to A before settling
on B, ensure we stop calling computeScroll().
Bug: 153589287
Change-Id: I6b4389ef2cf5a818438c7ae36d8807b3e41c8501
(cherry picked from commit 49b57e955c )
2020-05-05 17:14:20 +00:00
Tony Wickham
c0535b23f6
Merge "Fix continueComputingRecentsScrollIfNecessary() running infinitely" into ub-launcher3-rvc-dev
2020-05-05 17:14:03 +00:00
Treehugger Robot
6cf1e6ca36
Merge "Remove MODULE_LICENSE_APACHE2 from Launcher3" am: f6bfbe767f
...
Change-Id: Ia11967c6f4cb86b5431cdb446a5b5c483ce09ba2
2020-05-05 17:11:32 +00:00
Sunny Goyal
cf19a92cde
Merge "Not caching TaskView during quickswitch" into ub-launcher3-rvc-dev
2020-05-05 17:05:20 +00:00
Treehugger Robot
f6bfbe767f
Merge "Remove MODULE_LICENSE_APACHE2 from Launcher3"
2020-05-05 16:54:43 +00:00
Tony Wickham
49b57e955c
Fix continueComputingRecentsScrollIfNecessary() running infinitely
...
When continuing a gesture during quick switch, we cancel the
previous animation but don't invalidate it (since the gesture
isn't fully finished), and the new gesture handler calls
mRecentsView.setOnPageTransitionEndCallback(), so the previous
handler will never get STATE_RECENTS_SCROLLING_FINISHED. Thus,
continueComputingRecentsScrollIfNecessary() will never end.
To fix this, also check !mCanceled, since that is set when
continuing the gesture. Also use postOnAnimation() instead of
post() since that has better guarantees that the next
computation will wait for the next animation frame, rather
than whenever the message queue is available, which might
happen too frequently.
Test: quick switch from A to B and back to A before settling
on B, ensure we stop calling computeScroll().
Bug: 153589287
Change-Id: I6b4389ef2cf5a818438c7ae36d8807b3e41c8501
2020-05-05 02:32:39 -05:00
Winson Chung
8e1f31f91d
Merge "Account for various launcher states when setting back button alpha" into ub-launcher3-rvc-dev am: 7ad937c78d
...
Change-Id: I9f12f5339844b15631b3d479ccbfd170df25df4c
2020-05-05 04:51:35 +00:00
Winson Chung
7ad937c78d
Merge "Account for various launcher states when setting back button alpha" into ub-launcher3-rvc-dev
2020-05-05 04:37:38 +00:00
TreeHugger Robot
b25262d722
Merge "Fixing max-zoom-scale not taking into account the the fullScreen scale" into ub-launcher3-rvc-dev am: 43e789ff9b
...
Change-Id: I9de7f31b066f9cc45d2c703db4c207252b3fe595
2020-05-05 02:14:43 +00:00
TreeHugger Robot
43e789ff9b
Merge "Fixing max-zoom-scale not taking into account the the fullScreen scale" into ub-launcher3-rvc-dev
2020-05-05 02:01:00 +00:00
Sunny Goyal
a88ca7643a
Not caching TaskView during quickswitch
...
RecentsList update case cause the TaskView to get unparented
Bug: 155568411
Change-Id: Ia05de9658ba2154f73311679a359a2eefeb73aec
2020-05-04 18:30:02 -07:00
Becky Qiu
0f1eb6dd3a
[Overview Actions] Expose task corner radius to use in TaskOverlay. am: 8f3b7e3249
...
Change-Id: Id2749a7dfbc27c4ceacd635accfef0dd7345cbda
2020-05-05 01:26:06 +00:00
Sunny Goyal
29e7a58f1a
Fixing max-zoom-scale not taking into account the the fullScreen scale
...
Also fixing the issue where display info is is not correctly initialized
Bug: 155257023
Bug: 155682580
Change-Id: Ib2cc981c1900f3d14f158f4dbb60ae77311f339b
2020-05-04 18:11:15 -07:00
thiruram
740e2ab12e
Implements LAUNCHER_ITEM_DROP_COMPLETED event.
...
Assigns InstanceId to match LAUNCHER_ITEM_DROP_COMPLETED, LAUNCHER_ITEM_DRAG_STARTED events.
Sample Log:
2020-05-01 14:07:53.158 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED(InstanceId:282)
# com.android.launcher3.logger.LauncherAtom$ItemInfo@c0711fbd
application {
component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
package_name: "com.google.android.apps.maps"
}
container_info {
workspace {
grid_x: 2
grid_y: 1
page_index: 0
}
}
is_work: false
2020-05-01 14:07:54.308 18369-18369/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DROP_COMPLETED(InstanceId:282)
# com.android.launcher3.logger.LauncherAtom$ItemInfo@90000206
application {
component_name: "com.google.android.apps.maps/com.google.android.maps.MapsActivity"
package_name: "com.google.android.apps.maps"
}
container_info {
workspace {
grid_x: 0
grid_y: 4
page_index: 0
}
}
is_work: false
Bug: 152978018
Change-Id: Ib4fc860e8080edd407ed15b93f7d55ac31328d11
2020-05-04 18:00:07 -07:00
Becky Qiu
8f3b7e3249
[Overview Actions] Expose task corner radius to use in TaskOverlay.
...
Test: local
Bug: 153478940
Change-Id: I03d410edb5a55ce5eda5c703752daf0ef5d04500
2020-05-04 17:31:40 -07:00
Zak Cohen
b4ee058955
OverviewActions - make button ripple workspace text color.
...
Uses a theme to set the control highlight color.
Test: local on dark and light wallpaper
Change-Id: Iddb668fcbd3ab760faabd9c296274315d63e044f
2020-05-04 17:17:52 -07:00
TreeHugger Robot
a6a5f89faa
Merge "Speeding up TAPL by calling getVisibleStateMessage() less frequently" into ub-launcher3-rvc-dev am: fc9ea9b0fc
...
Change-Id: I3d8a12c0fff05fba0eb970e0628532de976d4836
2020-05-04 23:29:13 +00:00
TreeHugger Robot
d295b62a94
Merge "Decouple feature flag and predictions" into ub-launcher3-rvc-dev am: f9ec6f670c
...
Change-Id: Iba90987b3586ab5d88fdca778497ebb509a220c6
2020-05-04 23:29:07 +00:00
TreeHugger Robot
fc9ea9b0fc
Merge "Speeding up TAPL by calling getVisibleStateMessage() less frequently" into ub-launcher3-rvc-dev
2020-05-04 23:18:04 +00:00
TreeHugger Robot
f9ec6f670c
Merge "Decouple feature flag and predictions" into ub-launcher3-rvc-dev
2020-05-04 23:12:37 +00:00
TreeHugger Robot
5221686173
Merge "Remove unnecessary waitForIdle calls" into ub-launcher3-rvc-dev am: 7bb915ba8e
...
Change-Id: Id1b81e004cf0dde365e51f3fd4fbb5859035499a
2020-05-04 22:58:20 +00:00
TreeHugger Robot
7bb915ba8e
Merge "Remove unnecessary waitForIdle calls" into ub-launcher3-rvc-dev
2020-05-04 22:44:21 +00:00
vadimt
faf4da386d
Speeding up TAPL by calling getVisibleStateMessage() less frequently
...
The information in the message can be derived from the object dump
printed anyways.
Change-Id: I22ee136568b767c3218eaabc3920c77b3ceaa78f
2020-05-04 15:40:47 -07:00
Samuel Fufa
49d0f64a9d
Decouple feature flag and predictions
...
- Always default to true for ENABLE_HYBRID_HOTSEAT
- Allow launcher to show predictions anytime regardless of notification and on-boarding.
- Remove past beta specific plans
- Migrate if first screen can accommodate hotseat items otherwise show tip
Bug: 142753423
Test: Manual
Change-Id: I142cd95d779964822da07a96e5884a0c82813742
2020-05-04 15:20:39 -07:00
TreeHugger Robot
88287a5969
Merge "Use rotation based on PagedOrientationHandler instead of touch" into ub-launcher3-rvc-dev am: 0dbbd8951d
...
Change-Id: I1eef8ec81eb812c72cbba1b566dea7acf43fefe0
2020-05-04 20:43:36 +00:00
TreeHugger Robot
0dbbd8951d
Merge "Use rotation based on PagedOrientationHandler instead of touch" into ub-launcher3-rvc-dev
2020-05-04 20:21:50 +00:00
TreeHugger Robot
28033a9f4c
Merge "Avoiding cascading "nested events checking" failure after timed-out wait" into ub-launcher3-rvc-dev am: d60e33de3e
...
Change-Id: I4d79859a14bd2ff83141b89e1a2847533c9c4dac
2020-05-04 20:01:07 +00:00
TreeHugger Robot
d60e33de3e
Merge "Avoiding cascading "nested events checking" failure after timed-out wait" into ub-launcher3-rvc-dev
2020-05-04 19:41:56 +00:00
Vinit Nayak
bb55f9e982
Use rotation based on PagedOrientationHandler instead of touch
...
Fixes: 154928106
Test: Tested overview w/ and w/o
home rotation enabled.
Change-Id: Ib7e91e51b2181824e5520ad69965ed3379302c27
2020-05-04 11:58:11 -07:00
vadimt
357e5499a2
Remove unnecessary waitForIdle calls
...
They were added back in times when the
code was very different, and we don't need them now.
Change-Id: Ie96b081a4f2319c7b58d22ffc410f74e9ab56d94
2020-05-04 18:57:52 +00:00
Bob Badour
ef27e0abdc
Remove MODULE_LICENSE_APACHE2 from Launcher3
...
Repositories containing third-party code need a METADATA and a
license_type. Repositories containing only first-party code no longer
need a MODULE_LICENSE_* file.
Bug: 68860345
Bug: 69058154
Bug: 151953481
Test: no code changes
Exempt-From-Owner-Approval: janitorial work
Change-Id: I17f3c230dbe730c03a2d8727e26c32b3e7e37e52
2020-05-04 18:51:14 +00:00
Vinit Nayak
c74eef522b
Revert drag factor calculation to pre-vertical overview am: d079aed058
...
Change-Id: I61bbfab583aff6e8c152e03e7dcbf3f6b58b40d1
2020-05-04 18:06:41 +00:00
vadimt
55495201e0
Avoiding cascading "nested events checking" failure after timed-out wait
...
Bug: 155656943
Change-Id: I0f11552349a9f6b3b14bd1bebb37904d5dfa9c55
2020-05-04 10:52:08 -07:00
Vinit Nayak
d079aed058
Revert drag factor calculation to pre-vertical overview
...
Fixes: 149609070
Test: Swiped up in landscape past
where thumbnail would be. Scaled accordingly.
Change-Id: Ib8e64af2d7a9e4ce517d5f56300d50b659217b71
2020-05-03 22:38:20 -07:00
Alex Mang
0e993fe9e9
Listening to progress of all apps transition. am: 5c6b320057
...
Change-Id: Ib9c1fdd3af7752081f04ad91498f715b97c2ff29
2020-05-02 04:15:24 +00:00
Alex Mang
5c6b320057
Listening to progress of all apps transition.
...
This will be used to synchronize keyboard popup. Also setting edittext before disabling to allow plugin to perform some cleanup
Change-Id: Ib9b4ab33d4292fe5d827c37f33c546a9fe6cb002
2020-05-01 16:47:22 -07:00
TreeHugger Robot
334baafb40
Merge "[AllAppsSearch] Update AllAppsSearch interface to expose the activity to the plugin" into ub-launcher3-rvc-dev am: e6843777b0
...
Change-Id: Iecf2d87e6411c34b872feb6f54a81096505c414c
2020-05-01 23:25:28 +00:00
TreeHugger Robot
e6843777b0
Merge "[AllAppsSearch] Update AllAppsSearch interface to expose the activity to the plugin" into ub-launcher3-rvc-dev
2020-05-01 23:08:00 +00:00
TreeHugger Robot
be9dc00fc0
Merge "Don't do full anomaly check after every gesture" into ub-launcher3-rvc-dev am: 122d2d9dbb
...
Change-Id: I5441c53a200d60662f5b311bf99e1449d51a148d
2020-05-01 21:38:07 +00:00
TreeHugger Robot
122d2d9dbb
Merge "Don't do full anomaly check after every gesture" into ub-launcher3-rvc-dev
2020-05-01 21:17:53 +00:00
TreeHugger Robot
ad23761c9a
Merge "[Overview Actions] Disable touching on the empty area when recent is modal." into ub-launcher3-rvc-dev am: 4544af1996
...
Change-Id: Ib4565b307642a90130be4decef40048f7d965938
2020-05-01 20:50:29 +00:00
TreeHugger Robot
4544af1996
Merge "[Overview Actions] Disable touching on the empty area when recent is modal." into ub-launcher3-rvc-dev
2020-05-01 20:43:03 +00:00
TreeHugger Robot
3d94facad3
Merge "Sets icon invisible when alpha 0 (Cannot be tapped while TaskView modal)" into ub-launcher3-rvc-dev am: c6d8838c33
...
Change-Id: Ie9bbb9a9543f205d735b91ddeece86d8b1acc4ab
2020-05-01 20:42:02 +00:00
TreeHugger Robot
c6d8838c33
Merge "Sets icon invisible when alpha 0 (Cannot be tapped while TaskView modal)" into ub-launcher3-rvc-dev
2020-05-01 20:27:40 +00:00
Becky Qiu
2d9f8284ca
[Overview Actions] Disable touching on the empty area when recent is modal.
...
Originally touching on the empty space would bring user back to homescreen. We will disable this for select mode.
Test: local
Bug: 154531538
Change-Id: Iee3780755fc2c32682ea0fa039ca5822a95fce2c
2020-05-01 12:51:07 -07:00
Hyunyoung Song
691e6e5b35
Merge "Force all apps content to be alpha 0 when plugin is in place Bug: 155114822" into ub-launcher3-rvc-dev am: e180641d38
...
Change-Id: I27a6f758ab931f6dce81794ccf75dde820306dd6
2020-05-01 18:07:42 +00:00
Hyunyoung Song
e180641d38
Merge "Force all apps content to be alpha 0 when plugin is in place Bug: 155114822" into ub-launcher3-rvc-dev
2020-05-01 17:55:56 +00:00
Winson Chung
a4b11dd984
Skip setting the controller if the animation is already finished
...
Bug: 154568748
Change-Id: I999c0cc3a4d9661bcf6dcd1e804746a3a0959a83
2020-05-01 16:25:04 +00:00
TreeHugger Robot
976db5a74f
Merge changes from topic "widget-logging" into ub-launcher3-rvc-dev am: 7a87f953a8
...
Change-Id: Iab0fae4977984e9f35c117011c561ef8273d0c5f
2020-05-01 08:15:55 +00:00
TreeHugger Robot
7a87f953a8
Merge changes from topic "widget-logging" into ub-launcher3-rvc-dev
...
* changes:
Fixes missing components info when logging Widget item.
Implement LAUNCHER_ITEM_DRAG_STARTED event.
2020-05-01 07:54:03 +00:00