Commit Graph
14531 Commits
Author SHA1 Message Date
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
TreeHugger Robot 691c6e511f Merge changes from topic "revert-20479526-revert-20427045-258023561-BPDASTWITO-FBDWZBDEFC" into tm-qpr-dev
* changes:
  Fixing the revert by not continuing the reorder if the solution is null.
  Revert "Revert "Reorder widgets no longer overlaps when no space..."
2022-11-22 21:18:42 +00:00
Sihua Ma 09f04d34a3 Merge "Adding the flag for putting widget host in the background" into tm-qpr-dev 2022-11-22 19:22:09 +00:00
Pinyao Ting ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Jon Miranda e57cab1da8 Merge "Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS." into tm-qpr-dev 2022-11-22 17:20:21 +00:00
Xiaowen Lei 8eb1c3bde5 Merge "Fix issue in RTL where swipes on Launcher Smartspace are intercepted." into tm-qpr-dev 2022-11-22 16:53:04 +00:00
Xiaowen Lei 6d66ad20cf Fix issue in RTL where swipes on Launcher Smartspace are intercepted.
The `+ getScrollX()` translation is a duplicate, because
`mapCoordInSelfToDescendant` also does it internally. Same for the `+
getScrollY()`.

This wasn't an issue in LTR because the top left corner of the root view
is the same as the top left corner of the first page.  `getScrollX()`
returns 0 in that case.

In RTL, the second page is to the left of the first page. If the touch
is on the first page, `+ getScrollX()` translates it outside of the
first page. This incorrectly sets mIsEventOverFirstPagePinnedItem to
false, leading to the swipe being intercepted.

Bug: 240380590
Fix: 240380590
Test: manual
Change-Id: I51f534695401ce527da8d2158130a4d54b086f3d
2022-11-21 23:52:20 +00:00
Jon Miranda 3d72ac1a78 Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS.
Bug: 260002412
Test: enable flag
Change-Id: I4d82a853061b1540b6c6aea5e58b05a3ea6638e0
2022-11-21 23:46:34 +00:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
Sihua Ma 04ce9fa3ef Adding the flag for putting widget host in the background
Bug: 235358918
Test: N/A
Change-Id: I300bb5e293de6995a0e69402a6e337739055ca59
2022-11-21 14:17:50 -08:00
TreeHugger Robot db81133e94 Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev 2022-11-21 21:45:47 +00:00
TreeHugger Robot 81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Sunny Goyal bbe956ef5f Removing ENABLE_LOCAL_COLOR_POPUPS feature flag
The feature has been disabled for a while and is not working correctly.
Also there is no UX plan to revisit this currently

Bug: 206508141
Bug: 259733681
Test: Presubmit
Change-Id: If1279c22b9d074592ba181c7caa0cf38f9cb842e
2022-11-21 10:21:45 -08:00
TreeHugger Robot c9c45ed783 Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev 2022-11-19 00:48:49 +00:00
Sebastián Franco 6322cb2e61 Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev 2022-11-18 18:20:15 +00:00
Thales Lima ae0d7ef782 Increase icon size to be closer to spec
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
Brian Isganitis 2766142f80 Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev 2022-11-18 05:58:17 +00:00
Brandon Dayauon e1b66bd1bf Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev 2022-11-18 04:05:26 +00:00
TreeHugger Robot 3a801de233 Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev 2022-11-18 01:44:01 +00:00
TreeHugger Robot c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Brandon Dayauon bcd65e85f4 Fix pause work apps button being higher than normal
This issue can be repro'd by typing something in toast box, hightlighting text, share, then back gesturing back to allApps work tab.
To fix, we can simply reset the translation when updating the visibility of the button by calling onApplyWindowInsets() in updateVisibility()

bug: 259004115
test: Photos Before: https://screenshot.googleplex.com/6JbHbK3rfdXiXM4 after: https://screenshot.googleplex.com/B99SLsFcPYf6jrG
Change-Id: I2d44de37666d5342457c6ae14c691eb1804043cd
2022-11-17 14:44:44 -08:00
Sebastian Franco 02b4711e74 Fix issue where the solution is not updated when the grid is empty
Test: Manually move widgets and shortcuts around and the position should match the animation
Fix: 259502044
Change-Id: I20a98f9366394c840bb3cd0577de26a181a229ac
2022-11-17 14:23:09 -08:00
Stefan Andonian a04de842d1 Fix ConcurrentModificationExceptions during binding.
The same lists of extra items stored in BgModelData are also stored in
UI components. This is causing ConcurrentModificationExceptions. The
solution is to clone these lists or mark them as immutable before storing
them in their respective components.

Bug: 206918543
Test: Verified that crash no longer occurs after fix.
Change-Id: I571a2c451af58137aa7513b372b6a8ecf9bd3ff6
2022-11-17 20:46:51 +00:00
Brian Isganitis 589c8d3e29 Add overlay proxy type to ALL and REBIND_SAFE.
Test: Manual
Fix: 259575422
Change-Id: I121fa0471f96df90e5ff88bbd0aba04556293dc7
2022-11-17 20:08:05 +00:00
Stefan Andonian 146701ca3e Move SharedPreferences code to its own class.
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
TreeHugger Robot 698239e16a Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev 2022-11-17 11:28:05 +00:00
Alex Chau 3dc6d7fb47 Merge "Update overview to fit transient taskbar" into tm-qpr-dev 2022-11-17 11:04:18 +00:00
Tracy Zhou a71d353ff8 Merge "Implement split from workspace to workspace" into tm-qpr-dev 2022-11-17 07:04:48 +00:00
Jeremy Sim c480c268e8 Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev 2022-11-17 04:19:04 +00:00
TreeHugger Robot 3ea398ecb7 Merge "Cleaning Utilities.java" into tm-qpr-dev 2022-11-17 02:39:38 +00:00
TreeHugger Robot ff86dd930d Merge "[QL-v2] Add logging for quick launch." into tm-qpr-dev 2022-11-17 02:01:56 +00:00
Sihua Ma c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
TreeHugger Robot 579ddc7aff Merge "Removing unnecessary event dispatching via touch-controller. Instead using a poll method similar to other touch controllers" into tm-qpr-dev 2022-11-17 01:22:54 +00:00
Sunny Goyal 47d4d81b4f Cleaning Utilities.java
> Removing some unused methods
> Moving some specialized methods to corresponding classes
> Removing GridProvider check as it is released

Bug: 257555083
Test: Presubmit
Change-Id: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
Merged-In: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
2022-11-17 01:06:16 +00:00
Jeremy Sim 6692f78229 Allow user to tap on stashed app to launch task in fullscreen
This patch implements a new feature that allows the user to tap on the staged app rectangle in split staging mode. When the user does so, split selection will be canceled, and the staged app will animate out to fill the screen and launch in fullscreen.

Done by creating a new onClick listener on mFirstFloatingTaskView that sets up the screen-filling animation, and then calls a new RecentsView function, launchStagedTask(), that launches mSplitHiddenTaskView and cleans up RecentsView afterwards (similar to what happens when a split pair is selected, but only one app is launched).

Open issues:
- After the staged task animates out to fill the screen, the task itself loads instantly without animating in. Ideally, it should fade in, similar to what happens when two split tasks are loaded in.

Bug: 257513449
Test: Manual on tablet
Change-Id: I2ae8e13e1c9848aae1978a536766c370949fd08b
2022-11-16 15:28:31 -08:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Sunny Goyal 6abdd5c735 Removing unnecessary event dispatching via touch-controller.
Instead using a poll method similar to other touch controllers

Bug: 259447608
Test: Verified on device
Change-Id: I5c29c7c1b87acb668ea93e9f44fb685379de54fb
2022-11-16 13:58:05 -08:00
Jon Miranda c3fc8da433 Merge "Check NPE and log error condition for enableTransientTaskbar in test harness." into tm-qpr-dev 2022-11-16 20:43:27 +00:00
Federico Baron 22ea023a32 Merge "Fix spring-loaded folder animation offset bug" into tm-qpr-dev 2022-11-16 20:07:09 +00:00
Alex Chau 0ea0b898a5 Merge "Put IDP.getDeviceProfile logging behind a feature flag" into tm-qpr-dev 2022-11-16 19:10:27 +00:00
Anushree Ganjam 9dd595b972 Merge "Introduce imeHeight in KeyboardStateManager." into tm-qpr-dev 2022-11-16 18:38:39 +00:00
Alex Chau 905e0f1637 Update overview to fit transient taskbar
Bug: 245320601
Test: manual
Change-Id: Ie2085811ef25dc03a3765559c9a0ee37e38aa38e
2022-11-16 17:02:12 +00:00
Jon Miranda 182d1e93dd Check NPE and log error condition for enableTransientTaskbar in test harness.
Fixes: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ifa929dca18437ae101cf3290feda4209790604d2
2022-11-16 08:04:57 -08:00
Tracy Zhou 7e0f5d8a57 Implement split from workspace to workspace
Fixes: 239824922
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/b745433d-cba7-4f7a-a28d-4223d9950c0b
Change-Id: I9bfd5844bb9ccb6e65e77fedb7fbccb37692f812
2022-11-15 22:11:28 -08:00
Andy Wickham 7b9433e6bc Adds flag to show 2 rows of predicted apps in All Apps 0 state.
Test: Manual
Bug: 251593164
Change-Id: Id1c295eda4d1e3ff39285435fc15b3f5ac298dea
2022-11-16 03:50:35 +00:00
Jon Miranda 47bea3eb5b Merge "Move feature flags that have been changed to the top of the list." into tm-qpr-dev 2022-11-16 02:18:50 +00:00
Holly Sun 0d69c8dde9 Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results.
Also add simple prefix matching method.

Bug: 255355348
Test: manual
Change-Id: I35f2089924d774f3bcc1c05638a5d6b45ed7443f
2022-11-15 16:55:29 -08:00
TreeHugger Robot c2f03ae080 Merge "Add ImpressionLogger to StatsLogManager" into tm-qpr-dev 2022-11-15 23:35:21 +00:00
Sebastian Franco 9c74327e13 Fixing the revert by not continuing the reorder if the solution is null.
Fix: 258023561
Bug: 259234533
Test: atest testAddDeleteShortcutOnHotseat
Change-Id: I63a2abf8a80e16fb45f4bbb3b2de413ef77b5e0c
2022-11-15 15:13:23 -08:00