Commit Graph
68 Commits
Author SHA1 Message Date
Pun Butrach 11f7abcb66 chore: Cleanup, and hidden feature logged
Signed-off-by: Pun Butrach <pun.butrach@gmail.com>
2026-01-10 20:48:25 +07:00
Pun Butrach 0a446431eb build: SNAPSHOT 0 (Draft) 2026-01-10 20:47:59 +07:00
Pun Butrach b67168f737 Allocate insane memory just for CI
Signed-off-by: Pun Butrach <pun.butrach@gmail.com>
2026-01-10 20:46:44 +07:00
Federico Baron df328e5dfa Add logs and prevent collissions when adding items
-AddWorkspaceItemsTask can add multiple items to the same position, we
avoid that here by adding each item to the database before processing
the next item.
-We add more logs to InstallSessionHelper to be able to check who the
installer is

Bug: 432237485, 425754534
Test: AddWorkspaceItemsTaskTest
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b439e999734852a017ce662543b4789b36e0e3b)
Merged-In: I2d238f3eb27734ab9cb723e2fe9d6752c5921dd1
Change-Id: I2d238f3eb27734ab9cb723e2fe9d6752c5921dd1
2025-07-27 22:00:10 -07:00
Sebastian Franco cc18ee380e Do not modify the original item info when adding a new item in Worksapce
Fix: 418114270
Test: NA
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dbd6f0d18f69d5d33862aaad015c4c8c5907fb46)
Merged-In: Ic0dd00da4f363868a1c2abeeb736b86f6f706631
Change-Id: Ic0dd00da4f363868a1c2abeeb736b86f6f706631
2025-06-25 21:04:11 -07:00
Sunny Goyal a57d75cd11 Adding ListenableRef as an alternative to StateFlows.
This allows using listener pattern instead of coroutines within the recommended repository pattern and avoid the jank due to coroutines

Bug: 390572144
Test: atest ListenableRefTest
Flag: com.android.launcher3.model_repository
Change-Id: I9f74166e01e1bdb4cb8afce3213022ea10137230
2025-05-23 13:52:16 -07:00
Sunny Goyal 869b20cb27 Adding repository for AppsList data
Flag: com.android.launcher3.model_repository
Test: atest AppsListRepositoryTest
Bug: 390572144
Change-Id: I6e5993c91f77ed8f0b6f2c12c9d743c87a497134
2025-05-14 21:19:18 -07:00
Sunny Goyal 473bc9a06a Adding support for diff in WorkspaceData, so that UI can apply incremental updates
Bug: 390572144
Flag: com.android.launcher3.model_repository
Test: atest WorkspaceDataTest

Change-Id: I5fead4fdedfa2f6ac03ca106f7f0a5900af3760e
2025-05-09 15:26:09 -07:00
Sunny Goyal 57a195b790 Making workspaceData immutable
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated

Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
2025-05-07 13:21:21 -07:00
Sunny Goyal aef6c7932e Moving predicted items to ItemIdMap instead of extraItems
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s

Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
2025-05-05 15:52:37 -07:00
Sunny Goyal c078d6554c Moving various launcher binding logic, outside LauncherModel
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually

Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
2025-04-22 14:12:17 -07:00
Sunny Goyal 54e5ed0d36 Creating a dumpmanager class to allow dumping state from singleton objects
Bug: 410927105
Flag: EXEMPT refactor
Test: atest DumpManagerTest
Change-Id: Idcd1c74b1edf7a79ec8e4fa91676e617afa04907
2025-04-17 11:05:20 -07:00
Sunny Goyal 613db2b609 Removing flag enable_smartspace_removal_toggle
Test: Presubmit
Flag: EXEMPT cleanup
Bug: 303471576
Change-Id: Iae8cc3afbf15c66612589fd1e19377e4339af7fc
2025-04-16 10:54:45 -07:00
Sunny Goyal 040ff3a7bf Adding HomeScreenRepo to expose homescreen data as repository
Bug: 390572144
Test: Presubmit
Flag: com.android.launcher3.model_repository
Change-Id: If82a388a44d7a9c448f6eb4901c2acdb508ccfdc
2025-04-11 13:28:08 -07:00
Sunny Goyal bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Sunny Goyal 2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Sunny Goyal 0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sunny Goyal 3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF) 35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Sunny Goyal e8d901fbdb Deflaking ShortcutsChangedTaskTest by not using an active model
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running

Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
2025-03-25 12:12:20 -07:00
Charlie Anderson ca9a920fa9 Make sure loading icons from db for archived apps only happens once after restore.
- This is to enable users to theme and shape archived apps

Bug: 402303619
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: performing restore and toggling themed icons on/off
Change-Id: I5883f703c3b0c8df5ee303ea4d99b0c02743faa4
2025-03-21 13:29:14 -07:00
Federico Baron c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Sunny Goyal 7629bc4dcd Merge "Converting LauncherAppState to Dagger" into main 2025-02-21 10:06:01 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Shamali Patwa e532fc86b4 Merge "Update widgetsModel to return pickable vs all widgets separately." into main 2025-02-20 17:42:32 -08:00
Shamali P f6efa25a49 Update widgetsModel to return pickable vs all widgets separately.
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.

This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).

Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
2025-02-20 14:13:16 -08:00
Charlie Anderson 7a7fcf5394 Merge "Fix WorkspaceItemProcessorTest for HSUM" into main 2025-02-18 13:39:05 -08:00
Charlie Anderson 0e18dee91d Fix WorkspaceItemProcessorTest for HSUM
Bug: 395684478
Test: WorkspaceItemProcessorTest
Flag: EXEMPT test fix
Change-Id: Ib884af01fd225a01a7ba5408bcb38991b7b4c2c4
2025-02-18 13:43:47 -05:00
Federico Baron b8030e9627 Fix issue where hotseat apps don't migrate to the new grid
Hotseat apps would not migrate to a new grid if the new grid already had
hosteat filled out. This resolves the issue and addresses the issue of
workspace spots showing up as occuppied when they should be available

Bug: 395786587
Test: GridSizeMigrationTest, GridMigrationTest, ValidGridMigrationTest
Flag: EXEMPT bugfix
Change-Id: I79613986702c7dddf15a9a31c29b4ef59eac2b3a
2025-02-14 18:30:54 +00:00
Charlie Anderson ceb401c3e7 Revert^2 "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit f5cb1b664b.

Reason for revert: adding test fix and reverting

Change-Id: I2fc8dc83259b2ee7992ac2291df6ee4246a2e9d5
2025-02-07 12:14:55 -08:00
Liana Kazanova (xWF) f5cb1b664b Revert "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit abbb991d8f.

Reason for revert: DroidMonitor: Potential culprit for Bug X - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ifa241a631a1a4361623cfe0e81e31ca6b44e9d73
2025-02-04 15:37:46 -08:00
Charlie Anderson abbb991d8f Restore Archived Pinned Shortcuts instead of removing them.
Bug: 375414891
Test: ShortcutsChangedTaskTest, WorkspaceItemProcessor test and manually backing up + restoring.
Flag: com.android.launcher3.restore_archived_shortcuts

Change-Id: I798d56bc1ffef9a454e3899e4155d63f7edf39f2
2025-02-04 11:29:29 -08:00
Charlie Anderson 0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Charlie Anderson 722f6f3143 Refactor ShortcutsChangedTask to Kotlin
Bug: 375414891
Test: ShortcutsChangedTaskTest
Flag: EXEMPT no functionality change
Change-Id: If80b74a80abf9bed90f1572a9fee2494d39a6829
2025-01-29 16:41:29 -08:00
Treehugger Robot de6fea5e00 Merge "Fix hotseat issue on grid migration where extra items get removed" into main 2025-01-28 12:40:17 -08:00
fbaron a80aed9429 Fix hotseat issue on grid migration where extra items get removed
Flag: EXEMPT bugfix
Test: n/a
Fix: 333849747
Change-Id: I6bf3b291de33930764ca8e4fac82c59c328adbde
2025-01-28 17:07:47 +00:00
Sunny Goyal 777324ed15 Removing redudntant objects from BgDataModel
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated model tests
Change-Id: Ied8a0bfdbfd324b9fb05724f1fcf67238aa37d16
2025-01-23 12:55:37 -08:00
Treehugger Robot a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Stefan Andonian fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Sihua Ma 48db4ef770 Move model tests to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: EXEMPT test only
Change-Id: I751c449561175d3c7c5a770b7b30bc4f24c1cd44
2024-12-13 05:51:51 +00:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Charlie Anderson 24e3132bbd Revert^2 "Update test activities with a non-default icon."
3e7d28e1c7

Change-Id: Ifea50664980a5bb52700e494abb10643d68fbd01
2024-11-20 23:23:01 +00:00
Uwais Ashraf 970d19327d Close repeatedly unclosed resources at the end of tests
Fix: 379432671
Test: edited tests, presubmits passing
Flag: EXEMPT test only change
Change-Id: I45c46d7a56a30af4a11dff54b5bcc8a1e9bcda5f
2024-11-18 21:39:59 +00:00
Charlie Anderson 3e7d28e1c7 Revert "Update test activities with a non-default icon."
Revert submission 29570743-fix-default-app-icons

Reason for revert: possible culprit of b/371183869

Reverted changes: /q/submissionid:29570743-fix-default-app-icons

Change-Id: I6be362d03791893f94d3393bf9c9ffc4d9e83ec9
2024-11-11 22:04:33 +00:00