Commit Graph
14608 Commits
Author SHA1 Message Date
TreeHugger Robot c995ec1dd8 Merge "Set the default value for SCROLL_TOP_TO_RESET to true." into tm-qpr-dev 2022-12-13 20:44:23 +00:00
TreeHugger Robot 5c1cc6ac4b Merge "Reset TASKBAR_EDU_SEEN preference." into tm-qpr-dev 2022-12-13 19:21:01 +00:00
TreeHugger Robot be968ab8e2 Merge "Adding feature flag for simulating two CellLayouts using one." into tm-qpr-dev 2022-12-13 16:56:38 +00:00
TreeHugger Robot 742294305f Merge "Changed widget picker personal-work tab layout" into tm-qpr-dev 2022-12-12 22:59:08 +00:00
Andy Wickham 29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Brian Isganitis 8f981e4bad Reset TASKBAR_EDU_SEEN preference.
The EDU has been updated to support both transient and persistent
taskbar cases, so we should show it to the use again.

Test: Manual
Bug: 217261955
Change-Id: Ied59e6226c4f9599ad98333012313db57edc7c1f
2022-12-12 13:56:35 -05:00
TreeHugger Robot 9c19638ca3 Merge "Support mouse right click on HomeScreen to show the customization menu" into tm-qpr-dev 2022-12-11 01:57:52 +00:00
TreeHugger Robot f7590ed79c Merge "Remove delightful page indicator" into tm-qpr-dev 2022-12-10 05:47:19 +00:00
Jon Miranda 229d9bc3b7 Merge "Enable transient taskbar flag on by default." into tm-qpr-dev 2022-12-10 02:03:04 +00:00
Sebastian Franco 5f022614b0 Adding feature flag for simulating two CellLayouts using one.
Bug: 188081026
Test: compiles
Change-Id: Idd9ad8c6d0e4814d93fc9dd019e250d9469020d8
2022-12-10 00:37:43 +00:00
Federico Baron 9a6a2c8a2d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev 2022-12-09 23:33:17 +00:00
Sihua Ma 60813a89f7 Changed widget picker personal-work tab layout
Used layout margin instead of padding. Also making sure that Talkback would focus on the widgets title once the widget picker is opened.

Before: https://screenshot.googleplex.com/AgZspqTc7yS2Lte
Now: https://screenshot.googleplex.com/5W66ky7XAByCFRZ

Fix: 247121867
Test: Manual
Change-Id: I76534454754c5e57ab51ae7ce06ca4370a3fd22b
2022-12-09 13:58:57 -08:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Fengjiang Li a6a67e347d Support mouse right click on HomeScreen to show the customization menu
Bug: b/250089861
Fix: b/250089861
Test: Manual Testing
Video: https://b.corp.google.com/action/issues/250089861/attachments/40243664?download=true
Change-Id: Ia23e302bf8f3e18fafd6ccd079740c8005ae7860
2022-12-09 02:44:09 +00:00
Federico Baron 3f82a06c7f Remove delightful page indicator
Due to design changes, we are no longer going to use the  changes guarded under the flag SHOW_DELIIGHTFUL_PAGINATION, so we remove the flag and the code that was guarded by that flag

Bug: 261904707
Test: verify flag SHOW_DELIGHTFUL_PAGINATION no longer exists and that the regular pagination works without issues after removing all this code
Change-Id: I244b88b98df0357aa99a325a11988e8248a03206
2022-12-08 15:00:02 -08:00
Holly Sun 66a7fdcd90 Set the default value for SCROLL_TOP_TO_RESET to true.
Per UX, we can enable this feature by default.

Bug: 218846025
Test: manual
Change-Id: I828515ec45e84007cee3893cd2b76fca7c5afee2
2022-12-08 14:13:07 -08:00
Federico Baron 47d81686e6 Move AnimatedFloat from quickstep to launcher
We are moving AnimatedFloat to launcher to be able to use this in class in launcher. Having it in launcher will allow us to do restore icon treatment animations to do with scaling the icon size

Bug: 254858049
Test: verified that the device still works
Change-Id: I1c4c47ab436c389a94abf7c910c1a44724efc955
2022-12-08 13:58:07 -08:00
Sunny Goyal 9898d7906e Merge "Adding support for generating manachrome icon from a colored icon" into tm-qpr-dev 2022-12-08 18:54:59 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Jon Miranda 7234034cee Enable transient taskbar flag on by default.
Bug: 261859222
Test: manual
Change-Id: I46ed930aba743f76da3b6fe94629fdb0f585ee55
2022-12-08 16:45:10 +00:00
Tony Wickham 788f8e09fe Merge "Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar" into tm-qpr-dev 2022-12-08 16:21:43 +00:00
Tony Wickham 5de5ac9008 Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar
This avoids us trying to read FORCE_PERSISTENT_TASKBAR feature flag
which apparently crashes tests due to permission issues. Going forward,
when we support persistent taskbar better, we should update the tests
and this check as commented in the code.

Test: com.google.android.apps.nexuslauncher.TaplTestsNexus#testSearchNoInputs
Fixes: 261604544
Change-Id: I35c20825e8171766834f0f32be4f3818d02ab1df
2022-12-08 16:19:16 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00
Sunny Goyal d954229d1a Adding support for generating manachrome icon from a colored icon
Bug: 261625158
Test: Verified on device
Change-Id: Ibda922fd2c9c0a856ea02a8e73f43af8573f2450
2022-12-07 22:57:24 -08:00
Sunny Goyal 3e58eea9da Simiplifying the Parner override definition so that it can be used
for multiple overrides

Bug: 257555083
Test: Presubmit
Change-Id: I14eb98edb19ccf109222d6806e27de707e485457
2022-12-07 23:35:18 +00:00
TreeHugger Robot 1c744c996c Merge "Remove feature flags and use search config flags." into tm-qpr-dev 2022-12-07 22:58:39 +00:00
TreeHugger Robot 13b432cd9d Merge "Support right click to bring up app menu and actions" into tm-qpr-dev 2022-12-07 20:00:33 +00:00
Schneider Victor-tulias f0de6cc2ca Revert "Cancel gestures on launcher destroy"
Revert "Refactor SchedulerCallback implementation"

Revert submission 20555112-launcher-destroy-gestures

Reason for revert: causes test failures
Reverted Changes:
Ib43cdd597:Refactor SchedulerCallback implementation
Ia8e936e26:Cancel gestures on launcher destroy

Change-Id: I2199e39237b7c9fe25784b46e16960cd5f17c46c
2022-12-07 19:46:00 +00:00
Andy Wickham abb18ea62a Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev 2022-12-07 19:08:53 +00:00
Jon Miranda 6ba531d1aa Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev 2022-12-07 17:33:53 +00:00
TreeHugger Robot 5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Fengjiang Li 9f90efb39e Support right click to bring up app menu and actions
Test: https://b.corp.google.com/action/issues/250092449/attachments/40159735?download=true
Change-Id: I159005cc982478896d442bb2675ccb1bb7f0322e
2022-12-07 08:48:16 -08:00
Andy Wickham 0adad24408 Adds header protection on tablet all apps panel.
Removes background and manually draws it while drawing scrim. Then
draws header protection on top as needed.

Currently this only applies to all apps from Launcher, as Taskbar
doesn't seem to use the same scrim flow. So taskbar adds the same
static background that was previously used.

Demo videos: https://drive.google.com/drive/folders/11PyFsrLV6-QhU_E-zD3s5bfzZK2nOU87?resourcekey=0-E41uw5TP9xuqTifLAs71yw&usp=sharing

Test: Manually on phone and tablet with dark/light mode, floating
search bar on/off, work profile present/absent, taskbar/home entry
Bug: 240670050

Change-Id: I81dcc956d9dbbc7552c8a227a49741bcf71eed71
2022-12-06 18:31:33 -08:00
Andy Wickham 493831af1a Fixes for floating search bar (e.g. background protection).
- Adds background protection for the search bar
 - Views animating based on keyboard now support manual swipes.

Bug: 213954333
Bug: 259004115
Bug: 251460671
Test: Manual
Change-Id: I055766126fb46a8e8b48907e442c9e54aaa4badf
2022-12-06 17:59:53 -08:00
Alex Chau 5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Holly Sun 581aa03806 Remove feature flags and use search config flags.
Bug: 210661150
Test: manual
Change-Id: I6aa176895f80f31840570ce2c0ecbfbfb11079a1
2022-12-06 11:31:31 -08:00
Sebastián Franco 9adbab96b7 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev 2022-12-06 17:17:26 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
TreeHugger Robot 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sihua Ma 7b467addea Merge "Replace title of system services with more specific ones" into tm-qpr-dev 2022-12-03 06:26:18 +00:00
Sebastián Franco fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00
Becky Qiu c99da62f6f Merge "[Toast] Add a new type for AppSearch latency logging." into tm-qpr-dev 2022-12-03 01:23:33 +00:00
Sebastián Franco 9f775cab1a Merge "Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0" into tm-qpr-dev 2022-12-03 01:18:02 +00:00
Sebastian Franco 5bf936ac16 Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0
Bug: 260984829
Test: atest HomeScreenEditStateImageTest
Change-Id: I4aba76de512aedf5b4c921593fe43099700eb773
2022-12-02 14:05:24 -08:00
Sebastian Franco 2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00