Commit Graph
10129 Commits
Author SHA1 Message Date
Tracy Zhou c8beebf5a3 Consolidate isTablet logic across Launcher and SysUI
Fixes: 197960261
Test: Change display size; no nav bar and task bar showing at the same time
Change-Id: I56753e9389a49ca3ee455b248a041b3c1569f153
2021-09-23 15:06:53 -07:00
Tony Wickham 6b8a139581 Merge "Remove nonOverlappingTaskarInsets" into sc-v2-dev 2021-09-22 22:44:45 +00:00
Schneider Victor-tulias f4f17df565 Merge "Add logging to help debug invalid icon state and UI." into sc-v2-dev 2021-09-22 19:26:59 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Steven Ng c137171c8d Merge "Allow WidgetsBottomSheet to wrap its content" into sc-v2-dev 2021-09-22 13:31:33 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Tony Wickham 21970ccd29 Remove nonOverlappingTaskarInsets
- Override our insets in LauncherRootView to explicitly only care about nav bar size, ignoring any insets due to taskbar.
- Previously we used nonOverlappingTaskbarInsets to belatedly subtract from measurements in e.g. DeviceProfile, but now we can revert most of those calculations since we effectively subtract taskbar insets at the root.

Test: visual in different orientations and navigation modes, and testPressHomeOnAllAppsContextMenu to ensure REQUEST_WINDOW_INSETS still works for automated tests
Fixes: 200607741
Change-Id: I8de5a268c686a1354b4beaa30e101bab6bed5af9
2021-09-21 13:52:43 -07:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
TreeHugger Robot 3b90e1099b Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev 2021-09-21 20:51:08 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
Tony Wickham be34ef61a3 Merge "Take panel count into account for page indicator size" into sc-v2-dev 2021-09-21 15:43:54 +00:00
Steven Ng 6e54d62abd Allow WidgetsBottomSheet to wrap its content
Test: manual. See videos in b/200036849
Fix: 200036849
Change-Id: I64bc162834c715b48a4571ee95be7543e60bd6d8
2021-09-21 16:26:26 +01:00
Steven Ng 3bbebe2439 Merge "Add an animation for invalid widget resizing in 2 panel UI" into sc-v2-dev 2021-09-21 09:27:44 +00:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa 414f17138f Merge "Restore hidden text on Popup close" into sc-v2-dev 2021-09-21 00:10:46 +00:00
Tony Wickham bab101c818 Take panel count into account for page indicator size
Test: on a device with 2 panels, workspace page indicator width reflects number of needed scrolls rather than number of pages.
Fixes: 200607741
Change-Id: Ic2d0bdc644a15944c2d69a832068889071dc25e2
2021-09-20 15:13:33 -07:00
Samuel Fufa 964c7641ad Merge "Support Accessibility workspace addition for WorkspaceItemInfo" into sc-v2-dev 2021-09-20 22:00:51 +00:00
TreeHugger Robot 0f4e4856a2 Merge "[AllApps] NORMAL <-> ALL_APPS motion clean fixes for AOSP" into sc-v2-dev 2021-09-20 21:50:58 +00:00
sfufa@google.com 0828fec3d2 [Hotseat] Show edu tip within screen bounds
Screenshot: https://screenshot.googleplex.com/8grkbkYQu5jQhU8
Bug: 163162675
Test: enable hotseat predictions while in landscape mode, dismiss hotseat edu dialog and verify toolTip is shown properly.
Change-Id: Ia6daa7412d728be702e30972136f4c849315793d
2021-09-20 14:22:25 -07:00
sfufa@google.com d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
TreeHugger Robot 6173a7302b Merge "Workaround: don't migrate grid when hotseat size or device type changes in multi display" into sc-v2-dev 2021-09-20 15:19:58 +00:00
Steven Ng 4b346108d1 Add an animation for invalid widget resizing in 2 panel UI
Test: manual
Fix: 197509872
Change-Id: Ibcfae107e7f4b3bfbc562d4a6436f4b9237db122
2021-09-20 15:33:23 +01:00
Alex Chau d2f5a91936 Merge "More logging for drop bar not appearing for dragged widget" into sc-v2-dev 2021-09-20 11:48:01 +00:00
Alex Chau e35ef91c3e Workaround: don't migrate grid when hotseat size or device type changes in multi display
Bug: 198965093
Test: manual
Change-Id: I804ec854b98d27717c32723028f892ca2556d327
2021-09-20 12:29:00 +01:00
sfufa@google.com 6a12ec34fb Support Accessibility workspace addition for WorkspaceItemInfo
Bug: 192678946
Test: Manual using TalkBack
Change-Id: I1d0d06ccac934eb80dba7670e93ec631c12e5074
2021-09-20 01:15:08 -07:00
sfufa@google.com 78e7b24eb7 Restore hidden text on Popup close
When handleClose is called with no animation, overridden closeComplete gets fired before mOpen is set to false inside the super class. This results in getOpenView(launcher, TYPE_ACTION_POPUP) returning self and breaking text visibility restore.

Bug: 183713889
Test: Long press on allapps/workspace item to show PopUp under it; on popup open, capture screenshot, start a sharing activity, return to launcher and verify popup dismissed and text restored.
Change-Id: Iae8d2c73e4b7f57708468bf47bb0983a30ebbddc
2021-09-20 06:21:59 +00:00
sfufa@google.com 6e91ccbe82 [Search] Sync header Y translation with AllApps y scroll
Instead of calling scrollToTop directly, calling  mHeader.reset scrolls recylcerview to top and reset headerView y translation

Bug: 195365449
Test: enable three button mode, open AllApps, slightly scroll so predictions are partially visible, tap on search box and then outside; verify AllApps is scrolled to top and header is reset appropriately.
Change-Id: I9ba7cf019cb23dd259356243dc2a6294ca5481fe
2021-09-19 22:37:06 -07:00
TreeHugger Robot c9e7bf458f Merge "Use ICU to format plural strings" into sc-v2-dev 2021-09-18 04:37:46 +00:00
vadimt 876c15aa1f More logging for drop bar not appearing for dragged widget
Test: presubmit
Bug: 195031154
Change-Id: I28673866e2c893584402081b0f61acfa2a9c88c1
2021-09-17 19:43:07 -07:00
Steven Ng 707b118184 Use ICU to format plural strings
Test: manual
Fix: 199230208
Change-Id: I0b6fe9f8bb134a1479117c832575c63da2a07794
2021-09-17 22:44:06 +01:00
Vinit Nayak 03c13ad130 Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev 2021-09-17 21:27:18 +00:00
Vinit Nayak af6b85e3bc Show multiple icons for GroupedTaskView
* Hide all overview actions for GroupedTaskView
* Move some logic from TaskView into respective
PagedOrientationHandlers
* Remove unused methods from PagedOrientationHandler
* NOTE this is just visual changes. Properly showing
task menu's is still in-progress

Bug: 181704764
Test: Tested GroupedTaskView in portrait/landscape,
fake landscape in small screen, and real portrait/landscape
in large screen

Change-Id: I9c13ca114024db0a8e3fa5d295951696adb8516f
2021-09-17 10:16:56 -07:00
Thales Lima 5f8bbcd552 Merge "launcher: use scalable grid in 4x4" into sc-v2-dev 2021-09-17 16:42:24 +00:00
Thales Lima d1df5fcaac launcher: use scalable grid in 4x4
Many changes are required to make scalable displays work correctly on
foldables. This first one is making sure that the correct number of
columns is used when calculating the used width for scalable grid. The
spaces around the workspace are not final yet.

Bug: 191879424
Test: manual
Change-Id: Idc41ed004580f1f86d8f9595d005abc72301b1e3
2021-09-17 10:43:42 +01:00
Tracy Zhou 088ec093e5 Merge "Stash the bar after settling in Overview" into sc-v2-dev 2021-09-16 23:15:53 +00:00
Brian Isganitis a682cda639 Merge "Add CONTAINER_WALLPAPERS for storing wallpaper info." into sc-v2-dev 2021-09-16 19:37:48 +00:00
TreeHugger Robot 7b5aedc72d Merge "[Search] Apply background to entire SearchInput view instead of just EditText" into sc-v2-dev 2021-09-16 17:11:52 +00:00
TreeHugger Robot 460e2c4299 Merge "Scroll AllApps to top when new padding is set." into sc-v2-dev 2021-09-16 17:01:22 +00:00
András Klöczl 25e84690b3 Merge "Add logging to catch rare launcher wipe issue" into sc-v2-dev 2021-09-16 16:29:11 +00:00
Andras Kloczl 971da6c3aa Add logging to catch rare launcher wipe issue
Test: not necessary
Bug: 200010396
Change-Id: If7c478e220c2c0ee9f6479b18bf05bf39811b451
2021-09-16 17:26:04 +01:00
Tracy Zhou 308851d866 Stash the bar after settling in Overview
Test: https://recall.googleplex.com/projects/81822932-8526-4ee7-b5f7-4ef6d6603f1d/sessions/f0f7a3db-76b6-4f60-87e8-8918bd6cf180
Bug: 193938970
Change-Id: Ic08d3156f5c78a34f353783b760d5cf098e442e8
2021-09-16 00:06:47 -07:00
TreeHugger Robot ca1ee7a161 Merge changes from topic "launcher-loading" into sc-v2-dev
* changes:
  Improve workspace loading times.
  Add tracing to help in launcher load time profiling.
2021-09-16 04:24:23 +00:00
Schneider Victor-tulias b988ab77cb Improve workspace loading times.
Updated loadWorkspace to load all required icons in a series of bulk sql queries. This reduces the cost of SQL lookups (up to two lookups per user, rather than one lookup per icon)

Bug: 195674813
Test: Added all icons to workspace, added duplicate icons, added icons for same component name from different users

Change-Id: I56afaa04e7c7701f0d3c86b31c53f578dfa73fe6
2021-09-15 17:09:06 -07:00
Schneider Victor-tulias 927d6dcc6c Add tracing to help in launcher load time profiling.
Bug: 195674813
Test: None
Change-Id: I895a64bbba515ce7b7df8d093d40e0a5b6056d2e
2021-09-15 17:08:53 -07:00
Samuel Fufa 2397d60074 Scroll AllApps to top when new padding is set.
Bug: 198212488
Test: presubmit
Change-Id: I084939e3c7685531c56b1478887fd872e0e101e9
2021-09-15 14:40:39 -07:00
TreeHugger Robot da76a1defd Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 20:26:49 +00:00
Tony Wickham 3d0fca7e0d Merge "Don't set Taskbar window to non-fullscreen while folder animates closed" into sc-v2-dev 2021-09-15 17:47:46 +00:00
Tony Wickham 2908eb70fc Merge changes from topics "TaskbarLogging", "taskbar-log" into sc-v2-dev
* changes:
  Add logs for taskbar and overview split action
  Add TaskBarContainer to launcher_atom.proto
2021-09-15 16:28:45 +00:00
Vadim Tryshev 72da449f8a Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 02:35:04 +00:00