Infinite scrolling kept a wrap state (target page, saved scroll bounds,
a cached feed flag) that every path out of a swipe had to tear down.
Paths that missed it caused the bugs: a short or backward swipe on the
last page wrapped anyway, the first page flashed when a layout pass
reset the bounds mid-wrap, touching during a wrap jumped to the target,
two-panel layouts got stuck between pages, and the page indicator lost
its active dot.
The wrap now follows from the scroll position alone: on an end that
wraps, the scroll may run one screen further, and the screen from the
other end is translated into that gap. Workspace decides which ends
wrap; other paged views behave as in AOSP.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(home): live glass blur behind icons, folders and widgets
Add an optional "Glass blur" setting that blurs the wallpaper behind home
screen icons, folder icons, open folders and widgets, like CSS
backdrop-filter. SurfaceFlinger renders the blur through blur regions
(a copy of the framework BackgroundBlurDrawable), so it stays live and
follows the items during page scrolls and animations.
SurfaceFlinger ignores all the blur of an app layer once there are more
than 10 blur requests on screen (kMaxBlurRequests, b/399120953), unless
the layer was created by a privileged process. With root, the regions go
to an effect layer created by the root helper and placed below the
launcher window content. Without root, they go to the window layer and
are subject to that limit.
Also fix RootHelperManager, unused until now: it reported root as not
available until a root shell had been created, and bound the root
service off the main thread.
* fix(home): redraw when a glass blur region is removed
Without a frame the pre-draw listener never sends the regions left, so a
removed blur, the last one in particular, could stay on screen until the
next redraw.
Home screen > Icon size (homeIconSizeFactor) had no effect on responsive
grids such as "practical": DeviceProfileOverrides scales the IDP's
iconSize, but responsive grids take their icon size from their cell
specs (mResponsiveWorkspaceCellSpec.getIconSize()) and never read
inv.iconSize.
getResponsiveIconSizePx() now applies the factor to the cell specs' icon
size, for the workspace, the hotseat and folder content, the same three
places the IDP-sized grids use inv.iconSize. The responsive code still
shrinks an icon that doesn't fit its cell (getIconSmallerThan). The icon
bitmap size already followed the factor, as the IDP computes it from the
scaled iconSize.
Visible change: on responsive grids the setting now works; at 100% (the
default) nothing changes.
(cherry picked from commit 6345b71df7dbd77be6c4da03ddcc76ebcadd2e90)
Co-authored-by: Claude <noreply@anthropic.com>
* fix(display): keep the device type stable across folds
LawnchairWindowManagerProxy estimated the supported bounds only from
DisplayManager#getDisplays, which reports the panel in use. On a foldable
the DisplayController cache then held a single state, so every fold and
unfold invalidated it ("Unexpected normalizedDisplayInfo found"), the
device type flipped between PHONE (folded) and MULTI_DISPLAY (unfolded,
through the hinge check), and CHANGE_SUPPORTED_BOUNDS reloaded the grid
and the model. The smaller dock of the phone profile also made the
loader delete the dock items past its size.
On devices with FEATURE_SENSOR_HINGE_ANGLE, the estimate now also holds
the other states of the internal display:
- WindowManager#getPossibleMaximumWindowMetrics, like
SystemWindowManagerProxy, when the system answers (it only does for the
recents provider) and the current state is one of its states.
- Otherwise each state of the default display seen on the device is
remembered. A state with the same aspect ratio replaces an older one,
so a resolution change leaves no stale bounds.
The extra states are built the way DisplayController.Info builds the key
it looks up (getDisplayInfo(context).normalize(), no-cutout default), so
the lookup finds them and folding no longer changes the supported
bounds. Once both panels are known they hold a phone and a tablet size,
and the device type is MULTI_DISPLAY in both states, across restarts too.
A hinge device never seen unfolded still reports PHONE: flip phones also
have the hinge sensor, so it can't be assumed.
The states are kept in their own device-protected file,
lc_display_states, not in boot_aware_prefs: DisplayController can run
before unlock, the values must not be backed up or restored on another
device, and the write happens while DisplayController is being
constructed. AOSP's taskbar-pinning listener on boot_aware_prefs calls
getInfo() for every change, which is still null at that point, so a write
to that file crashed the launcher when it started on the other screen
than last time.
The hinge check now lives in one place, LawnchairWindowManagerProxy
.isFoldable(), which DisplayController.Info uses as well.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit 14e6051ac83cba92cb371eec1c408966cb41ba9d)
* chore(display): log the device type once per info
getDeviceType() is called many times for each display change (once per
DeviceProfile and more), and logged its result every time. Log it once
per DisplayController.Info, that is once per display change, with the
current size, so the device type of each state can be read in logcat.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit 9fa57ec7e3d678c3e19d6ce1309ae11b893e18fc)
---------
Co-authored-by: Claude <noreply@anthropic.com>
* fix(fold): keep dock items past the hotseat size instead of deleting them
LoaderCursor#checkItemPlacement rejects hotseat items whose rank is not
below InvariantDeviceProfile#numDatabaseHotseatIcons, and checkAndAddItem
then marks them deleted like overlapping items, so they are removed from
the database. That size can shrink only for a while: on a foldable the
folded (phone) profile has a smaller hotseat than the unfolded one, and
folding once deleted the dock icons at ranks 4 and 5 for good.
Skip such items for binding but keep them in the database, so they show
up again once the hotseat is large enough. Why this is safe:
- Overlapping items (in bounds) are still deleted as before.
- Nothing can be placed at a rank past the current hotseat size, so a
kept item can't collide with a new one while it is hidden. If it ever
does, the regular overlap check deletes it when it comes back.
- Grid migrations are unchanged and run before the loader.
- Only top-level hotseat items are bound, so the contents of a kept
folder stay unbound with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit d556864ee08d0e2494f21a5fc3a9f00676f1269a)
* fix(migration): skip dock entries past the hotseat size (pre-existing crash)
Both solveHotseatPlacement versions (GridSizeMigrationDBController and
GridSizeMigrationLogic) mark the target's remaining dock items in an
array sized to the new dock: occupied[entry.screenId] = true. When the
target grid's database was last used with a larger dock, an entry's
rank can be past that size, and moving back to that grid with anything
to add to the dock throws ArrayIndexOutOfBoundsException. The Kotlin
path then aborts the migration; the Java path resets the target
database.
Such an entry takes no slot in the new dock, so it is skipped when
marking. Nothing else changes: the placement loop and every other entry
are as before.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit f9bdf9e9eebd710a11281c066c5293b76d71d18c)
* fix(migration): also skip negative dock ranks in the hotseat guard
A corrupt database could hold a negative hotseat rank, which would still
index outside the array. Such an entry takes no slot either.
Suggested in review by CodeRabbit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
InvariantDeviceProfile.initGrid took closestProfile's folder arrays as
they were, and DeviceProfileOverrides then wrote the folder settings
into them. The folder sliders take their default from closestProfile
(numFolderRows/numFolderColumns[INDEX_DEFAULT]), so the default they
compared against was the value currently applied, not the grid
option's. Setting the value that was already current, e.g. releasing
the slider thumb without moving it, removed the key and the folder grid
fell back to the grid option's on that reload.
Copy the arrays instead. Nothing else reads closestProfile's folder
arrays: the profiles read the IDP's own arrays, and every initGrid
parses fresh grid options.
(cherry picked from commit 198724e42446611b204d0700e6630a82d0c10502)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The "Use multiple lines" setting of the app drawer shows in every
language, but AOSP only honoured it in English, so it did nothing for
other languages. Labels break at spaces, or between words in camel case
names, which works for other scripts too.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit fixes the infinite scroll wrap animation so it scrolls one page in the correct swipe direction instead of animating through all intermediate pages.
This commit reimplements support for app predictions without root.
---------
Signed-off-by: Pun Butrach <pun.butrach@gmail.com>
Co-authored-by: TheSuperDragon <70206496+SuperDragonXD@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This commit improves the app drawer search state system to do the following things to match Pixel Launcher:
* Activate zero state only if these conditions are met:
- The drawer search bar is tapped
- The dock search bar is tapped, and matchHotseatQsbStyle is on or AppSearch is the current provider
- The query is cleared
* Improves the search bar animation state to only remove the background and padding when the search bar has focus or has query
* Fixes the search bar end icon animation on tap
* Adds a back state handler in LawnchairLauncher so when back button is pressed, it exits search instead of exiting the app drawer, matching the intention of shouldBackExitSearch.
Tapping the upper edge of the All Apps bottom sheet goes to NORMAL
without FLAG_CLOSE_POPUPS, so folders opened from the drawer stayed
visible on the workspace.
Co-authored-by: Cursor <cursoragent@cursor.com>
Depth blur could leave RenderEffect on workspace/hotseat when SurfaceControl apply returned early, then setDepth(0) skipped re-apply. Always sync view blur with depth and force re-apply when settling to NORMAL; also clear leftover effects on folder dismiss.
blurWorkspaceDepthTargets can run on API 30; setRenderEffect and
createBlurEffect require API 31 and would throw on R.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Expressive folder animations ignored folderColor and always used the theme charcoal background. Resolve preview/open colors from prefs in both animation paths, and return after applying a custom color.
Reveal the first-page preview before showing the folder icon again, instead of sliding page previews for ~400ms after close.
Address CodeRabbit nit: the field was never populated after dropping the post-close slide animation.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
User badges are redundant when the Work tab or Private Space section
already establishes the profile context. Keep badges on home and search.
Guard skipUserBadge with hasSearchResults() so work/private badges
remain visible when search results are shown.
Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the double status-bar inset and leftover AOSP header padding so
search, personal/work tabs, and the app grid sit at even gaps. Also
collapse reserved space when the drawer search bar is hidden.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix: Apply icon packs to work/private profile apps
Resolve components via ActivityInfo/LauncherApps instead of
getLaunchIntentForPackage, and harden icon customization for
non-current users. Also restore work badges when themed icons are off.
Fixes#5202Fixes#4988
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor: Cache getActivityList result in SelectIconPreference
Avoid a redundant LauncherApps IPC when resolving work/private app labels.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>