Commit Graph
19629 Commits
Author SHA1 Message Date
Treehugger Robot d3e559a244 Merge "Add logging for which type of migration occurs." into main 2025-03-20 11:13:55 -07:00
Charlie Anderson 591a58cc93 Merge "Avoid downgrading archived app icon when widget is restored and when apps are archived." into main 2025-03-20 10:46:01 -07:00
Federico Baron c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Charlie Anderson 19c4a92ebc Avoid downgrading archived app icon when widget is restored and when apps are archived.
- Restored widget were requesting icons through iconcache, and overwriting the restored icon from restored db.
	- Manually archiving icons would delete icon in cache, we should instead reuse the icon from when it was installed.

Bug: 399649982
Test: Manually performing restore with apps, widgets and shortcuts.
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Change-Id: I4184af480f29eb3ef41173fe5edc5307f263d0b0
2025-03-19 21:28:37 -04:00
Stefan Andonian 4567dac1f6 Merge "Fix PageIndicatorDots Outline" into main 2025-03-19 16:03:33 -07:00
Stefan Andonian 386a7b2c40 If Folders would show extremely cropped title, hide title.
This is an edge case, not standard behavior. This only happens when
the text / display size is at the highest level, and when a folder has
10+ page indicator dots.

Bug: 394355070
Test: Verified manually that this works well, and looks great in LTR mode and RTL mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Id31aad47b94d20d9945495366d5381de27282153
2025-03-19 12:01:47 -07:00
Treehugger Robot 445e12fdb5 Merge "Update Workspace App Icon Long-Press Menu's Text to Google Sans Flex" into main 2025-03-18 15:38:27 -07:00
Stefan Andonian 00cde3149b Fix PageIndicatorDots Outline
Invalidate the outline when a Folder or WidgetPicker's PageIndicatorDots
become visible with 0 scroll. Necessary to avoid stale Outlines which
appear as grey shadows.

Bug: 394355070
Test: Verified manually that this works well, and looks great in LTR mode and RTL mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I3e730b1109b9cd05e25454865f7e97df2078725b
2025-03-18 12:38:41 -07:00
Stefan Andonian 031188dd0a Update Workspace App Icon Long-Press Menu's Text to Google Sans Flex
Bug: 393615290
Test: Verified via hard-coding flag to be true that fonts were correctly updated.
Flag: com.android.wm.shell.enable_gsf
Change-Id: I9ff1405356a4ceb2930b09f27e973e4cacb72d2e
2025-03-17 17:56:31 -07:00
Sunny Goyal d7a1c17988 Merge "Moving LauncherAppWidgetHolder to dagger" into main 2025-03-17 10:42:15 -07:00
Brandon Dayauon 95cb740e76 Merge "Let psApp change according to theme." into main 2025-03-17 10:27:35 -07:00
Sunny Goyal 66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Treehugger Robot 86045eadd7 Merge "Making GridCustomizatonProxy extendible" into main 2025-03-14 14:05:58 -07:00
Treehugger Robot ffde6fdec8 Merge "Add logging for each migration type" into main 2025-03-14 09:31:34 -07:00
Helen Cheuk 8b408e4767 Merge "Check null when getting drop view in DragController" into main 2025-03-14 04:05:23 -07:00
Sunny Goyal 370eabf534 Merge "Making ModelDbController injectable" into main 2025-03-13 23:20:17 -07:00
Federico Baron 3da182844d Add logging for each migration type
Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Idfa551cb1e83c3c3bce498b6986035460798b93b
2025-03-14 02:54:31 +00:00
Brandon Dayauon 59ed963a06 Let psApp change according to theme.
Since psApp is supposedly a system app, private space team requests that
the icon changes according to theme like previous "install" icon. To do
so Launcher can apply the same treatment to the bitmapInfo as for
the private space app.

bug: 360313403
Test: manually video in bug
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I78f0d0dbb12d5cfba2cac7e7b53714e424a49660
2025-03-13 21:20:22 +00:00
Treehugger Robot f2ceba9ba7 Merge "Removing listeners from FolderInfo" into main 2025-03-13 12:48:34 -07:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Brandon Dayauon d6e638c5cd Merge changes from topic "privateProfileMoveContent" into main
* changes:
  Change private space app content description
  Don't show system shortcuts for the psApp
2025-03-13 11:03:01 -07:00
Stefan Andonian 22574b46e8 Merge "Fix Entry Animations for VisualRefresh Page Indicator Dots" into main 2025-03-13 10:42:53 -07:00
Sunny Goyal 1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
helencheuk de869b3624 Check null when getting drop view in DragController
When the flag is on, there are some cases dropTarget is null:
TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
TaplTestsTaskbar.testLaunchShortcutInSplitscreen
TaplTestsTaskbar.testLaunchShortcut

Add logic to check null before getting drop view and calling drop complete.

Bug: 343650193
Test: TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
Test: TaplTestsTaskbar.testLaunchShortcutInSplitscreen
Test: TaplTestsTaskbar.testLaunchShortcut
Flag: com.android.launcher3.remove_apps_refresh_on_right_click
Change-Id: If8ce93bd6f7d0506e2272ca17dd7c19666549cfa
2025-03-13 15:21:11 +00:00
Stefan Andonian 43e7eba492 Fix Entry Animations for VisualRefresh Page Indicator Dots
Previously, the folder entry was offset, and also clipped in RTL modes.
This is because the new PageIndicatorDots are wider than the previous ones.

Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I3bacf454befac2b8148236253a82bd5b7317036a
2025-03-12 21:32:40 -07:00
Stefan Andonian db74d32103 Fix Page Indicator Dots Arrow Clicks in RTL Mode
I assumed that these would map to start and end, but they actually
are literally right and left arrows, even in RTL mode.

Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I8027f33cde9b2c7cc241b9b13414bb1ffed94d31
2025-03-12 21:18:57 -07:00
Sebastián Franco 837e576c56 Merge "Add padding in Fixed Landscape on the side oposite of the camera hole" into main 2025-03-12 18:34:30 -07:00
Brandon Dayauon 0e3de56211 Change private space app content description
bug: 360313403
Test: manually
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I3fb779e5217285c6d6b059f021c6d5f965aed531
2025-03-13 01:01:44 +00:00
Brandon Dayauon 726fbcf003 Don't show system shortcuts for the psApp
bug: 360313403
Test: manually - https://hsv.googleplex.com/5320142379548672
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: Ibb3322ab7793d3d9e925d5392a80bb6bd16568fd
2025-03-13 01:01:40 +00:00
George Lin 4aec306026 Merge "Handle app icon preview and update cases" into main 2025-03-12 17:48:53 -07:00
Treehugger Robot 9e50f5eea4 Merge "Fixing folder contents getting clipped during open/close animation" into main 2025-03-12 13:41:42 -07:00
Andy Wickham 250d85698c Merge "Adds all_apps_blur flag." into main 2025-03-12 11:25:50 -07:00
Sunny Goyal 778b89c334 Fixing folder contents getting clipped during open/close animation
Bug: 394932723
Test: Manual
Flag: EXEMPT bug-fix
Change-Id: I4995f8c178f7a422cb03a2b548b77fd88b93fab6
2025-03-12 11:23:23 -07:00
Helen Cheuk df47454b28 Merge "Reland - Not refresh predicted app in right click" into main 2025-03-12 11:14:26 -07:00
Thu-Huong Vu 09846676b5 Merge "Register SimpleBroadcastReceiver permission." into main 2025-03-12 10:36:22 -07:00
Stefan Andonian 85b5f813eb Merge "Fix RTL mode for new PageIndicatorDots" into main 2025-03-12 10:01:00 -07:00
helencheuk 69193807f7 Reland - Not refresh predicted app in right click
When users right click the mouse/touchpad, predicted apps in hotseat refresh and it is weird.
It refreshes because the right click is treated as a drag and a drag would trigger predicted apps refresh.
This fix adds a PreDragCondition when right click to avoid it from starting drag.

Bug: 343650193
Test: Manual, connect to touchpad and right click on widget and folderIcon
Flag: com.android.launcher3.remove_apps_refresh_on_right_click
Change-Id: Id0be87beb8a0e9baf78a4ba8ec4c93462ec7bb3e
2025-03-12 15:56:53 +00:00
Treehugger Robot b615b9bdaf Merge "Add Arrows to Folder PageIndicatorDots for Accessibility Purposes." into main 2025-03-11 23:50:53 -07:00
Treehugger Robot 0b5f6698c9 Merge "Attempt #2. Fix OutlineProvider for PageIndicatorDots for new visual updates." into main 2025-03-11 23:50:50 -07:00
Treehugger Robot 8561c5690f Merge "Drag and drop from the search view on the overview screen." into main 2025-03-11 18:26:48 -07:00
Andy Wickham ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
mpodolian 61de3b43cb Drag and drop from the search view on the overview screen.
Bubble bar drop targets have been added to the TaskbarDragController
used in the TaskbarOverlayContext. This enables dragging taskbar icons
to the bubble bar drop zone from the search view on the overview screen.

Bug: 399678274
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to the overview screen. Click the search icon. Drag any
application icon from the grid to the bubble bar drop zone. Drop the
application icon.

Change-Id: I33eb13785d8837fefc717a95a6566d3091ec855b
2025-03-11 16:07:21 -07:00
George Lin e24533cb40 Handle app icon preview and update cases
Add 2 more cases:
1. Update icon shape only
2. Preview icon themed

Test: TBD
Bug: 402161932
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I2dc21e14d346a1d444ed8baa759e7a6d38f6cd41
2025-03-11 23:02:59 +00:00
Stefan Andonian 105fe8cdda Fix RTL mode for new PageIndicatorDots
Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Idcbff06321fedfd6720780387803a0139a920520
2025-03-11 15:32:33 -07:00
Stefan Andonian cea8019728 Attempt #2. Fix OutlineProvider for PageIndicatorDots for new visual updates.
This attempt puts 100% of the change behind a flag and doesn't round any values.

Bug: 394355070
Test: Verified locally that the active indicator is outlined properly.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I6e610cb8a5ad9914d3152ef0019fcb5f50c331c3
2025-03-11 15:10:38 -07:00
Ana Salazar Maldonado 71d485d264 Merge "Add Widget Resize Frame actions" into main 2025-03-11 15:01:43 -07:00
Sebastián Franco 9e77e5de46 Merge "Adding access to All Apps in the long press menu in Launcher" into main 2025-03-11 15:00:47 -07:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Sebastian Franco ad047c74b3 Add padding in Fixed Landscape on the side oposite of the camera hole
Fix: 380031237
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie7557767f629f0c7a5b7b62a3039c8a5c3cc7f43
2025-03-11 14:27:52 -07:00
Stefan Andonian aa29761825 Add Arrows to Folder PageIndicatorDots for Accessibility Purposes.
Bug: 383974843
Test: Verified via go/web-hv that the hitbox sizes were correct. Measured the width and height within the folder for 1 through 7 pages, and everything looked great.Change title worked, and pressing on arrows to change page worked great.
Flag: com.android.launcher3.enable_launcher_visual_refresh

Change-Id: Ic095b2abe330544882467fb4803724e8d50a1798
2025-03-11 14:27:35 -07:00