Commit Graph
13020 Commits
Author SHA1 Message Date
Liran Binyamin bd19a3b2c2 Merge "Set the bubble bar background scale for initial animation" into main 2024-12-05 22:23:12 +00:00
Liran Binyamin 789a8c7f43 Merge "Don't crop bubble flyout in overview" into main 2024-12-05 22:22:36 +00:00
Liran Binyamin 0e14bb8ef9 Merge "Fix bubble bar flicker in initial animation" into main 2024-12-05 22:22:07 +00:00
Uwais Ashraf 4b05341d6e Merge "Use custom background dispatcher to stop excess thread creation." into main 2024-12-05 21:37:38 +00:00
Jon Miranda 433c9ef018 Merge "Keep transient taskbar open while overflow is open." into main 2024-12-05 21:09:13 +00:00
Ikram Gabiyev b95b0eec92 Merge "Do not send setFinishTaskTransaction if not swipe" into main 2024-12-05 20:38:14 +00:00
Treehugger Robot e457cb7a78 Merge "Revert^2 "Check if all apps are translucent when finishing recents animation."" into main 2024-12-05 20:29:00 +00:00
Saumya Prakash cfe6de65b4 Merge "Prevent Taskbar all apps from showing multi instance options" into main 2024-12-05 20:14:55 +00:00
Jagrut Desai dbfd95e6de Merge "Open Task into Desktop Mode when Taksbar is in DesktopMode" into main 2024-12-05 19:32:26 +00:00
Jagrut Desai 463c3b06b9 Merge "Don't recreate taskbar in Overview" into main 2024-12-05 19:32:07 +00:00
Liran Binyamin f0e5a19658 Set the bubble bar background scale for initial animation
When turning off DND all the previous bubbles get reposted and
the bubble bar background scale is set for stashed state incorrectly.

This change sets the background scale correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377597242
Test: manual
       - send some bubbles in the bubble bar
       - go to settings -> do not disturb -> turn on
       - observe bubbles are hidden
       - turn do not disturb off
       - observe bubbles animate in correctly
Change-Id: I50c07248fb95cf3ae92c86090838c40901918220
2024-12-05 14:24:32 -05:00
Tracy Zhou d2b90982eb Merge "Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state" into main 2024-12-05 19:08:24 +00:00
Uwais Ashraf 1348514466 Use custom background dispatcher to stop excess thread creation.
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Change-Id: I0e205cf7f55c90375a5a1e95fbd0f1adf0fc6658
2024-12-05 11:05:27 +00:00
Luca Zuccarini 7be62fbe00 Merge "Revert "Revert "Use the Coreographer's frame time for a more rel..."" into main 2024-12-05 10:23:36 +00:00
Matt Sziklay f47c28ef95 Merge "Implement cancel transition on tapping floating view." into main 2024-12-05 03:16:51 +00:00
Saumya Prakash ddd667ac9a Prevent Taskbar all apps from showing multi instance options
This change makes it so that we don't show any multi instance options in
Taskbar all apps. This matches the behavior from regular All apps.

Fix: 382342931
Test: Long press an app icon in Taskbar all apps and ensure multi
instance options don't show up.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: I5322df328ee5484168b96831f32c2023521704e6
2024-12-05 01:04:54 +00:00
Treehugger Robot db013a8e75 Merge "TaskViews indices inside RecentsView continue [2/n]" into main 2024-12-05 00:35:26 +00:00
Ikram Gabiyev ee4d9ed3ad Do not send setFinishTaskTransaction if not swipe
In PiP2, there is no need to send setFinishTaskTransaction()
unless we are swiping PiP to home.

This is because either ATMS#enterPictureInPictureMode() is supposed
to request a TRANSIT_PIP as the activity goes to pause.

Bug: 380515865
Flag: com.android.wm.shell.enable_pip2
Test: repro the steps in the bug
Change-Id: Ic24c0c0f471179198a5fe3221971cf5b6d634797
2024-12-04 15:36:26 -08:00
Jon Miranda 591c44a63b Keep transient taskbar open while overflow is open.
Fixes: 380375446
Test: open taskbar overflow, interact with overflow, taskbar stays open
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Iec95e40336debd6cc2a8f9a79fce2093b6d10e6c
2024-12-04 22:57:34 +00:00
minch 1bf7678154 TaskViews indices inside RecentsView continue [2/n]
In applyLoadPlan
- Refactored newFocusedTaskView to be based on first non-Desktop TaskView
- Set newFocusedTaskView to null when enableGridOnlyOverview() is on
- Updated target page calcuation to be based on the following priority: running task, focused task, first non-desktop task, last desktop task

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure targetPage in applyLoadPlan is correct in the following scenarios:
1. Only have desktop task
2. Desktop task and a few full screen tasks
3. Swipe up from desktop, 1st fullscreen task, and 2nd fullscreen task
4. Repeat with enableGridOnlyOverview() on, which does not have focused task

Change-Id: Iea519ad4a37c15f76557487078ac4dcf4d53480c
2024-12-04 22:21:20 +00:00
Jon Miranda 73797f8188 Revert^2 "Check if all apps are translucent when finishing recents animation."
This reverts commit 4fd400994a.

Reason for revert: Found the cause of the regression and fixed it
The regression was caused when adding a new method params to an
overloaded method, and then passing in the wrong parameter.

Bug: 379602904 
Bug: 354627538 
Change-Id: I54bc40042e08ae2da1808427b16e3587b6da789c
2024-12-04 21:57:04 +00:00
Liran Binyamin 77827d3167 Fix bubble bar flicker in initial animation
When the first bubble animates in we make the bubble bar visible
before translating it below the screen to prepare for the spring
animation. This change defers updating the visibility letting the
animator notify when it's safe to update visibility.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382296842
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - dismiss bubble bar
       - send new bubble
       - observe bubble bar does not flicker
Change-Id: Ib611771dd9f315ab57ef00f8f6cb982b8b88ea73
2024-12-04 15:05:22 -05:00
Liran Binyamin 0de5987efb Don't crop bubble flyout in overview
When switching to overview we set the taskbar window size as part
of the taskbar animation. If a bubble is animating the window size
becomes too small and the bubble flyout gets cropped. This change
avoids updating the window size in the middle of a bubble animation.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377809168
Test: manual
       - create a bubble and wait for the flyout to show
       - switch to overview
       - observe the flyout is not cropped
Change-Id: Ic0a3f2c0fc534162ae5583e744a7bc400c3d921b
2024-12-04 12:36:56 -05:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Tracy Zhou 3d31b97389 Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state
Fixes: 379816005
Test: manual
Flag: EXEMPT bugfix
Change-Id: I2a181c498cb674f077d1b0accfe85b62880a1cfc
2024-12-03 17:16:09 -08:00
Tony Wickham ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Saumya Prakash 1fa9b25b73 Merge "Ensure Desktop Tasks show up in Taskbar multi instance menu" into main 2024-12-03 21:14:32 +00:00
Schneider Victor-tulias bbefa5daf7 Merge "Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled" into main 2024-12-03 16:06:40 +00:00
Treehugger Robot 1c9b6dd4f3 Merge "[Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback" into main 2024-12-03 03:56:03 +00:00
Saumya Prakash a32f7f3f4a Ensure Desktop Tasks show up in Taskbar multi instance menu
This change adds in desktop tasks to show up in the Manage Windows
Taskbar menu. Previously these were getting filtered out.

Fix: 380167542
Bug: 315989246
Test: Launch multiple tasks in desktop mode and see that they show up in
the multi instance viewer from the Taskbar menu
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Ia07b3ad68f43c0f121b0608c5341d50970c8af4c
2024-12-02 23:44:59 +00:00
Tony Wickham 7614088dc5 Merge "Fix Taskbar 3 Button y position on launcher home pause/resume" into main 2024-12-02 23:33:57 +00:00
Wen-chien Wang ef427290c9 Merge "Register back action to close the KQS view" into main 2024-12-02 22:04:11 +00:00
Schneider Victor-Tulias 1df3836591 Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled
Test: pre/postsubmit
Fixes: 381548102
Flag: EXEMPT checking broken tests
Change-Id: I5764c661c53c383a80fbd568e839a5f3d2633427
2024-12-02 16:40:32 -05:00
Treehugger Robot fc6d6be050 Merge "Using inteface descriptor as the key for various interface extras" into main 2024-12-02 21:22:45 +00:00
Wen-Chien Wang ecc50c6d7c Register back action to close the KQS view
As the KQS view is not extending the floating view, we have to
explicitly register the back action to close the KQS view.

Bug: 379778483
Test: open KQS via alt-tab/overflow button and tap the back button
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I140813d1792f0c17aee5f9f8dd9fa3ed8b40ba6c
2024-12-02 21:00:35 +00:00
Liran Binyamin 35b7616cd9 Merge "Reset the bubble bar scale when the animation is interrupted" into main 2024-12-02 19:51:19 +00:00
Fengjiang Li c83ee2aefe [Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback
Heap dump shows that we keep AbsSwipeUpHandler in memory via Launcher#onDeferredActivityLaunchCallback after swipe up gesture or qucik switch gesture is completed.

Fix: 380860147
Flag: NONE - release code
Test: presubmit
Change-Id: I40da887aedf6ed040b4262fcd6a918f885968e1f
2024-12-02 10:25:01 -08:00
Saumya Prakash 5b878bbf1a Merge "Add animations to Manage Windows menu in Taskbar" into main 2024-12-02 17:58:32 +00:00
Liran Binyamin 3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00
Liran Binyamin 495fe1d255 Merge "Animate the bubble bar on dismiss" into main 2024-12-02 14:28:30 +00:00
Luca Zuccarini 1c28a44714 Revert "Revert "Use the Coreographer's frame time for a more rel..."
Revert submission 30577378-revert-30509816-raf-timing-EAFMYZVSQM

Reason for revert: this test on Cuttlefish seems to be very unstable in general. I tried to re-test on ABTD with these reverts patched in, but the test isn't being included in the suite, and I couldn't find information anywhere on whether it's supposed to be still running. Since these changes are fully flagged, I don't see how they could be the real culprit. Trying to submit again and monitoring the impact on the postsubmits.

Reverted changes: /q/submissionid:30577378-revert-30509816-raf-timing-EAFMYZVSQM

Change-Id: I4c1dc43858060716450bab20e3c56728235508c7
2024-12-02 12:49:08 +00:00
Andy Wickham 3be4c7d458 Merge "Cleanup the null checks added in ag/30408877" into main 2024-12-01 06:00:19 +00:00
Treehugger Robot 16740cd22a Merge "Make TaskView not clickable when in select mode for switch access and touchscreen usage." into main 2024-11-29 21:13:31 +00:00
Uwais Ashraf a8f01bac1d Make TaskView not clickable when in select mode for switch access and touchscreen usage.
Fix: 320228423
Flag: EXEMPT BUG_FIX
Test: Manual - steps from bug
Change-Id: Ib831ab52ce3cc3a19e73f6b255cab519074c24b6
2024-11-29 16:38:14 +00:00
Johannes Gallmann cc6e7f09c9 Merge "Fix ConcurrentModificationException in TouchInteractionService" into main 2024-11-29 13:13:39 +00:00
Johannes Gallmann 108dc037a0 Fix ConcurrentModificationException in TouchInteractionService
Bug: 381018493
Test: Manual, i.e. verified that unregistering listener during set iteration works
Flag: EXEMPT bugfix
Change-Id: Ia4600797ce579b80621b32977fcd9712d4fc26bb
2024-11-29 11:15:40 +00:00
Treehugger Robot b1629b250d Merge "Add missing overview state event to tests" into main 2024-11-28 22:38:13 +00:00
Treehugger Robot 9ba4899872 Merge "Wait until AllSetActivity.onResume to start the background animation" into main 2024-11-28 16:42:01 +00:00