Commit Graph
3839 Commits
Author SHA1 Message Date
Jon Miranda 6352c9bc88 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev 2023-06-14 01:10:08 +00:00
Jon Miranda a6653ae660 Revert "Suspend immersive mode autohide while pending transient taskbar timeout"
This reverts commit 0a074648c2.

Reason for revert: caused regression
Bug: 260765455
Fixes: 286808390

Change-Id: I0e017cf8e432f9c36b0ad34154c127c0dbe73504
2023-06-13 20:09:58 +00:00
Randy Pfohl f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
randypfohl d3cc664391 switching animation to screenshot to avoid visual jank
Test: built locally, recorded, and slow replayed it to verify no jank/visual anomalies visible.

Bug: 245750127
Change-Id: If7e72512d3303222f4d006a9e2a1639b2f86b1af
2023-06-12 18:28:57 -07:00
Vadim Tryshev af641a6e80 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev 2023-06-12 21:49:39 +00:00
Vadim Tryshev b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00
Brian Isganitis 77a40999e1 Merge changes If4669756,Ide702745 into udc-dev
* changes:
  Make sure FLAG_IN_APP is set when launching apps from keyguard.
  Report unstashed content insets for notification panel.
2023-06-12 16:51:37 +00:00
Jagrut Desai 2d5bb34b6b Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev 2023-06-09 22:26:39 +00:00
Jagrut Desai 5e9203e737 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-09 18:50:52 +00:00
Tony Wickham 0a074648c2 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none

Change-Id: I05c61de911f1bf326962d84c4f7c3e12135f23cf
2023-06-09 10:08:45 -07:00
Sunny Goyal ef6fbb5be8 Merge "Fising launcher stuck on blur" into udc-dev 2023-06-09 06:07:31 +00:00
Jagrut Desai 78ddf47150 Set AccessibilityPaneTitle for taskbar view
we need to set pane title for taskbar view so accessibility service knows to focus/unfocus on it upon it appearing and disappearing

Test: Manual
Bug: 284081291
Flag: Not needed
Change-Id: I5404c97bdc3e1d3308942cd907e7f7701a04bee3
2023-06-08 17:08:40 -07:00
Jon Miranda 10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Sunny Goyal 521c2a038b Fising launcher stuck on blur
The same surface can become invalid, in which case we need to wait
until the next draw to apply blur

Bug: 284411563
Test: Verified on device
Change-Id: Ifb6be94756fd00c5925e11a6b7d57f206e063a17
2023-06-08 13:18:34 -07:00
Brian Isganitis fd896ed6bd Make sure FLAG_IN_APP is set when launching apps from keyguard.
This flag was not being set in the case where you lock from launcher and
then unlock by tapping on launcheable items from keyguard such as home
controls, notifications, smartspace, etc. This change makes sure we
double check if we are unlocking to launcher or not and then setting
FLAG_IN_APP accordingly.

Test: manual
Fix: 284314711
Change-Id: If46697566d252c649a00a7b3d728a14789dc6aed
2023-06-07 18:28:30 -04:00
Brian Isganitis 63582a0a00 Report unstashed content insets for notification panel.
Test: FlickerTests, manual
Bug: 284314711
Flag: no
Change-Id: Ide7027454f8b447f82778c8e24dbc39c5ade0248
2023-06-07 18:26:58 -04:00
Jon Miranda 95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Fengjiang Li 3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
Fengjiang Li 1a2462914d Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test
Fix: 282945183
Test: N/A
Change-Id: I96680f04a6946129b14c365e2300f408dfe8f0c3
2023-06-05 09:19:07 -07:00
Brian Isganitis 0aa30e2292 Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
(cherry picked from commit 34c6b871af)
2023-06-02 15:34:35 +00:00
Anushree Ganjam 9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Vinit Nayak e65bf2a620 Merge "Skip drawing taskbar background in setup" into udc-dev 2023-06-01 23:13:19 +00:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Vinit Nayak 5364b0dac9 Skip drawing taskbar background in setup
Test: Manually went into SUW and observed
Fixes: 272674390
Change-Id: I102d1433692793f51d930e710d68134d4536c397
2023-06-01 10:52:39 -07:00
Schneider Victor-tulias 8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Achim Thesmann 2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Schneider Victor-tulias f304ab8e2b Fix launcher activity leak in TouchInteractionService
TouchInteractionService cannot be garbage collected until it has been cleared from the sysui process. Switching to use a WeakReference to help with garbage collection.

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
Change-Id: I37aa5f858f2ae0ac78b46478ab4c5f24770bd64f
2023-05-26 14:39:14 -07:00
Schneider Victor-tulias 010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Luca Zuccarini 07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Jagrut Desai 990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias 8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Luca Zuccarini f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Luca Zuccarini a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Tony Huang 2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Treehugger Robot 25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Schneider Victor-tulias b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias 7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Jagrut Desai 6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Tony Huang 2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Jon Miranda 9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda 0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt 144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai 709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Achim Thesmann ab66d1461d Allow BAL in Launcher
Widgets like Google News were blocked when they tried to start
background activities on non-Pixel devices that use Launcher3.

Bug: 281617254
Test: manual test
Change-Id: I2b68aeafd0d1dce7b37428dcada58d2648e57681
2023-05-19 21:05:56 +00:00
Vinit Nayak 258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Luca Zuccarini 2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
Vinit Nayak 6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00