Commit Graph
3278 Commits
Author SHA1 Message Date
Wen-chien Wang ad0b62daad Merge "pin-shortcut: Add pin shortcut to the context menu" into main 2024-12-13 17:00:42 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Artsiom Mitrokhin 4c7663768d Merge "Add haptics for opening taskbar pinning popup view from anywhere" into main 2024-12-13 05:34:00 -08:00
Johannes Gallmann 9b524b0f60 Merge "Play workspace reveal animation for predictive back-to-home" into main 2024-12-13 02:10:17 -08:00
Liran Binyamin 138dd0bc5f Fix bubble bar visibility issue
Update the bubble bar visibility for the initial bubble if the animation
is suppressed, e.g. if we're creating the bubble when the shade is open.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 382693837
Test: manual
       - enable bubbles
       - remove all conversations from the list of allowed to bubble
       - create notification
       - open shade and click on the bubble button to bubble the notification
       - observe bubble bar becomes visible

Change-Id: If771c28998b2b091f4f1ab38001e9485ed1ed849
2024-12-12 15:36:29 -08:00
Johannes Gallmann c8fd3f23fe Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: com.android.launcher3.predictive_back_to_home_polish
Change-Id: I092a74ab2340828e18067ca15c7019c44d30f40b
2024-12-12 14:18:03 +00:00
Ats Jenk bcc12470b7 Handle suppressed bubbles
Hide or show bubble based on suppression signals from shell.
If this is the only bubble, hides or shows the bubble bar.

Bug: 273316505
Test: have a single bubble in the bubble bar, suppress the bubble,
  observe that bubble is hidden and bubble bar is not shown,
  unsuppress the bubble, check that bubble bar and bubble is shown
  again, perform check with transient and persistent taskbar
Test: have multiple bubbles, suppress one bubble, check that this bubble
  is not shown, but the bubble bar remains visible with other bubbles,
  perform the check with transient and persistent taskbar
Test: have a single bubble in bubble bar that is suppressed, receive
  notifications to trigger new bubbles, observe bubble bar is shown for
  new bubbles, check that after unsuppressing bubble, it is added back,
  perform the checks with tranient and persistent taskbar
Test: suppress a bubble and rotate the device to trigger launcher
  recreation, check that after unsuppress, the bubble is added back

Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I17e5cec750a2666feecc62213a3e8fc204ee510a
2024-12-11 16:02:32 -08:00
mpodolian 3e419ebbf1 Remove usage of the enableBubbleBarInPersistentTaskBar flag.
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.

Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
2024-12-10 15:10:49 -08:00
Artsiom Mitrokhin 2e0d122ed1 Add haptics for opening taskbar pinning popup view from anywhere
The divider's listener is implemented via `View.OnLongClickListener`,
which automatically handles haptics. While the taskbar view uses a
custom gesture detector (to get the associated event and its x/y
coordinates), which doesn't have the same logic out of the box. This CL
adds a manual call to perform haptic feedback for long press events
(this also corresponds to the implementation in a similar gesture
detector - `WorkspaceTouchListener`).

Bug: 382056013
Flag: com.android.launcher3.show_taskbar_pinning_popup_from_anywhere
Test: manual on a fold
Change-Id: I3887e0f9839a7992ccd8b6786bdf1268bfafd09e
2024-12-10 22:05:24 +00:00
Johannes Gallmann 9899283045 Merge "Don't cancel or commit predictive back on multi touch in 3-button-nav" into main 2024-12-10 13:33:00 +00:00
Johannes Gallmann 200ee94279 Don't cancel or commit predictive back on multi touch in 3-button-nav
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
2024-12-10 13:28:36 +00:00
Brian Isganitis 9c0552e09d Merge changes from topic "taskbar-view-recents-changes" into main
* changes:
  Move recents divider if hotseat is set after recents.
  Animate out/in the correct task view when recents change.
  Implement initial LayoutTransition for Taskbar recents.
2024-12-10 02:18:53 +00:00
Treehugger Robot 9bb546953c Merge "Adapt TaskbarOverflow tests to check items added overflow view" into main 2024-12-10 00:21:18 +00:00
Brian Isganitis c7f6cd6062 Move recents divider if hotseat is set after recents.
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
2024-12-09 15:35:43 -05:00
Brian Isganitis 3c24c421f6 Animate out/in the correct task view when recents change.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I6c7708ed9f03eff8469b5f2e75ce00e545b03f54
2024-12-09 15:35:43 -05:00
Brian Isganitis 8e2b850df7 Implement initial LayoutTransition for Taskbar recents.
The animations mostly match the spec, though the recents indicators scale/fade with icon currently.

The change transitions need to incorporate translateX since that changes based on the number of icons in Taskbar. We need the translateX for pinning update to happen before TaskbarView lays out its children so that the animator computes the correct start and end values.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I13aa49abf80ddc09fab890f78bde924a8f7f1d6e
2024-12-09 15:35:43 -05:00
Treehugger Robot c531c9fb90 Merge "Minor kotlin cleanup" into main 2024-12-06 23:49:12 +00:00
Toni Barzic 7bea1821d4 Adapt TaskbarOverflow tests to check items added overflow view
Adds a step to verify that TaskbarOverflowView items get set to the list
of the least recent tasks. Adds test cases for an edge case where
taskbar hits max number of items event without recent tasks
(b/379774843).
Has a fix for a further edge case where taskbar overflow view could be
created with a single item (in which case we can just show that item
directly).

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: I004676da3e17f26b8110d14d39589c84a9f384d8
2024-12-06 19:39:47 +00:00
Winson Chung 3660fe4505 Merge "Add some debug names to various remote transitions" into main 2024-12-06 17:00:32 +00:00
Liran Binyamin 56a173c1de Minor kotlin cleanup
Use regular function instead of expression functions for Unit return
types.
go/kotlin/practices/expression-functions#unit-functions

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 281083629
Test: no-op change. just verify this builds
Change-Id: Ie13fdad5f33bb4cda9e5e85e2fb4394131d3c63f
2024-12-06 10:30:40 -05:00
Treehugger Robot 4ab6f0451c Merge "[CD Taskbar] Refactor TaskbarManager to create object creation methods" into main 2024-12-06 09:02:06 +00:00
Winson Chung b26430a9e4 Add some debug names to various remote transitions
- This helps with debugging and shell dumps

Bug: 378565144
Flag: EXEMPT adding debug strings
Test: dumpsys activity service SystemUIService WMShell
Change-Id: I57ea1c359667b4e7f7ac1e261cc6fba6ad30c6e7
2024-12-06 06:07:29 +00:00
Liran Binyamin f8b5dec6dc Merge "Fix cropped bubble flyout when animating in app" into main 2024-12-06 01:19:15 +00:00
Sukesh Ram 23470e8832 [CD Taskbar] Refactor TaskbarManager to create object creation methods
Every object that needs its own instance for an instance of a new display-specific taskbar needs its own creation method.

Flag: EXEMPT not adding new behavior
Bug: 381105283
Test: Manual
Change-Id: I24794fefbf2a64f38795eca970cf30eb63c51e66
2024-12-05 15:39:10 -08:00
Liran Binyamin bd19a3b2c2 Merge "Set the bubble bar background scale for initial animation" into main 2024-12-05 22:23:12 +00:00
Liran Binyamin 789a8c7f43 Merge "Don't crop bubble flyout in overview" into main 2024-12-05 22:22:36 +00:00
Liran Binyamin 0e14bb8ef9 Merge "Fix bubble bar flicker in initial animation" into main 2024-12-05 22:22:07 +00:00
Jon Miranda 433c9ef018 Merge "Keep transient taskbar open while overflow is open." into main 2024-12-05 21:09:13 +00:00
Treehugger Robot e457cb7a78 Merge "Revert^2 "Check if all apps are translucent when finishing recents animation."" into main 2024-12-05 20:29:00 +00:00
Saumya Prakash cfe6de65b4 Merge "Prevent Taskbar all apps from showing multi instance options" into main 2024-12-05 20:14:55 +00:00
Liran Binyamin f2161dd8c3 Fix cropped bubble flyout when animating in app
When animating the bubble bar in an app with a stashed handle,
the flyout might not be displayed entirely.

Fix the calculation of the amount of space needed to fully display
the bubble bar and flyout views.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382513856
Test: manual
       - remove all bubbles
       - launch app
       - send a bubble with a 2-line message
       - observe flyout is fully visible
Change-Id: I7953cb7f619f2c00b04bb4cb08c57a8195ff79fe
2024-12-05 14:35:09 -05:00
Jagrut Desai dbfd95e6de Merge "Open Task into Desktop Mode when Taksbar is in DesktopMode" into main 2024-12-05 19:32:26 +00:00
Liran Binyamin f0e5a19658 Set the bubble bar background scale for initial animation
When turning off DND all the previous bubbles get reposted and
the bubble bar background scale is set for stashed state incorrectly.

This change sets the background scale correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377597242
Test: manual
       - send some bubbles in the bubble bar
       - go to settings -> do not disturb -> turn on
       - observe bubbles are hidden
       - turn do not disturb off
       - observe bubbles animate in correctly
Change-Id: I50c07248fb95cf3ae92c86090838c40901918220
2024-12-05 14:24:32 -05:00
Tracy Zhou d2b90982eb Merge "Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state" into main 2024-12-05 19:08:24 +00:00
Saumya Prakash ddd667ac9a Prevent Taskbar all apps from showing multi instance options
This change makes it so that we don't show any multi instance options in
Taskbar all apps. This matches the behavior from regular All apps.

Fix: 382342931
Test: Long press an app icon in Taskbar all apps and ensure multi
instance options don't show up.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: I5322df328ee5484168b96831f32c2023521704e6
2024-12-05 01:04:54 +00:00
Jon Miranda 591c44a63b Keep transient taskbar open while overflow is open.
Fixes: 380375446
Test: open taskbar overflow, interact with overflow, taskbar stays open
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Iec95e40336debd6cc2a8f9a79fce2093b6d10e6c
2024-12-04 22:57:34 +00:00
Jon Miranda 73797f8188 Revert^2 "Check if all apps are translucent when finishing recents animation."
This reverts commit 4fd400994a.

Reason for revert: Found the cause of the regression and fixed it
The regression was caused when adding a new method params to an
overloaded method, and then passing in the wrong parameter.

Bug: 379602904 
Bug: 354627538 
Change-Id: I54bc40042e08ae2da1808427b16e3587b6da789c
2024-12-04 21:57:04 +00:00
Liran Binyamin 77827d3167 Fix bubble bar flicker in initial animation
When the first bubble animates in we make the bubble bar visible
before translating it below the screen to prepare for the spring
animation. This change defers updating the visibility letting the
animator notify when it's safe to update visibility.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382296842
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - dismiss bubble bar
       - send new bubble
       - observe bubble bar does not flicker
Change-Id: Ib611771dd9f315ab57ef00f8f6cb982b8b88ea73
2024-12-04 15:05:22 -05:00
Liran Binyamin 0de5987efb Don't crop bubble flyout in overview
When switching to overview we set the taskbar window size as part
of the taskbar animation. If a bubble is animating the window size
becomes too small and the bubble flyout gets cropped. This change
avoids updating the window size in the middle of a bubble animation.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377809168
Test: manual
       - create a bubble and wait for the flyout to show
       - switch to overview
       - observe the flyout is not cropped
Change-Id: Ic0a3f2c0fc534162ae5583e744a7bc400c3d921b
2024-12-04 12:36:56 -05:00
Tracy Zhou 3d31b97389 Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state
Fixes: 379816005
Test: manual
Flag: EXEMPT bugfix
Change-Id: I2a181c498cb674f077d1b0accfe85b62880a1cfc
2024-12-03 17:16:09 -08:00
Tony Wickham ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Saumya Prakash 1fa9b25b73 Merge "Ensure Desktop Tasks show up in Taskbar multi instance menu" into main 2024-12-03 21:14:32 +00:00
Saumya Prakash a32f7f3f4a Ensure Desktop Tasks show up in Taskbar multi instance menu
This change adds in desktop tasks to show up in the Manage Windows
Taskbar menu. Previously these were getting filtered out.

Fix: 380167542
Bug: 315989246
Test: Launch multiple tasks in desktop mode and see that they show up in
the multi instance viewer from the Taskbar menu
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Ia07b3ad68f43c0f121b0608c5341d50970c8af4c
2024-12-02 23:44:59 +00:00
Tony Wickham 7614088dc5 Merge "Fix Taskbar 3 Button y position on launcher home pause/resume" into main 2024-12-02 23:33:57 +00:00
Wen-chien Wang ef427290c9 Merge "Register back action to close the KQS view" into main 2024-12-02 22:04:11 +00:00
Wen-Chien Wang ecc50c6d7c Register back action to close the KQS view
As the KQS view is not extending the floating view, we have to
explicitly register the back action to close the KQS view.

Bug: 379778483
Test: open KQS via alt-tab/overflow button and tap the back button
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I140813d1792f0c17aee5f9f8dd9fa3ed8b40ba6c
2024-12-02 21:00:35 +00:00
Liran Binyamin 35b7616cd9 Merge "Reset the bubble bar scale when the animation is interrupted" into main 2024-12-02 19:51:19 +00:00
Saumya Prakash 5b878bbf1a Merge "Add animations to Manage Windows menu in Taskbar" into main 2024-12-02 17:58:32 +00:00
Liran Binyamin 3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00