Commit Graph
4765 Commits
Author SHA1 Message Date
William Leshner 0c2b98e876 Merge "Tweak WidgetPickerActivity size filtering." into main 2024-02-23 23:22:16 +00:00
Saumya Prakash b3b4cc6edb Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into main 2024-02-23 22:59:57 +00:00
Johannes Gallmann 1a9cff800f Merge "Transfer coordinate into new Rect instead of in-place" into main 2024-02-23 21:20:24 +00:00
Schneider Victor-tulias bdc846448c Merge "Update KQS launch task callbacks" into main 2024-02-23 19:54:44 +00:00
Saumya Prakash 40fc6eb323 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A

Change-Id: I3ee14ffc84d72512acdb750d0f614acacefc7639
2024-02-23 19:15:44 +00:00
Johannes Gallmann f3fe3b47a4 Merge "Fix flickers when invoking overview transition during predictive back-to-home" into main 2024-02-23 17:15:46 +00:00
Johannes Gallmann c71b48c658 Transfer coordinate into new Rect instead of in-place
Other parts of the animation rely on currentRectF to remain stable, therefore we shouldn't modify the RectF object in place.

Bug: 323628523
Flag: NONE
Test: Manual, i.e. verifying that widget close (and app close) animation animates correctly regardless of device orientation
Change-Id: I48e9ed047b956db654192eef39e5d94fbac53553
2024-02-23 12:30:46 +01:00
Johannes Gallmann 0ccdb91990 Fix flickers when invoking overview transition during predictive back-to-home
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
2024-02-23 10:29:26 +01:00
bvineeth fdf6df3226 Add tags for CUJ_TASKBAR_EXPAND/COLLAPSE
Test: Checked traces
Flag: None
Bug: b/263362887
Change-Id: I28652b0629b8033fe931809bacceeede3c36ea93
2024-02-23 03:27:54 +00:00
Vineeth Bhende 510886fc14 Merge "Fix taskbar_expand/collapse jank monitor" into main 2024-02-23 03:01:58 +00:00
Will Leshner 0467404c25 Tweak WidgetPickerActivity size filtering.
Better conform to documentation about how to use widget sizes when
filtering for sizes in WidgetPickerActivity.

Bug: 322191186
Test: atest Launcher3Tests
Flag: NA
Change-Id: I4239e64dd620e00a3c55046bfb66fe3099336aac
2024-02-22 12:50:50 -08:00
Sunny Goyal 72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Jagrut Desai 08a4e68bae Merge "Handle SystemGestureRegion in TaskbarDragLayer" into main 2024-02-22 17:55:28 +00:00
bvineeth 4d38783106 Fix taskbar_expand/collapse jank monitor
Issue : Currently opposite jank is being reported taskbar expand and taskbar collapse


Test: Checked the trace
Fixes: b/326333977
Flag: None
Change-Id: Ib5adeb33506717ee28d669c5d46557087ebf7e60
2024-02-22 04:12:45 +00:00
Jagrut Desai c8a5176bfc Handle SystemGestureRegion in TaskbarDragLayer
- Currently user can tap on taskbar icons when in persitent mode when a popup is visible on screen.
we are making it so that touch event is not performed at view level and get dismissed before at drag layer.

Test: Presubmit, Manual
Bug: 320229858
Flag: NONE
Change-Id: I9a76faa0e282317d808ba0f55b49741dc7b750a3
2024-02-21 11:35:29 -08:00
Brandon Dayauon 0fa9113028 Merge "Add home settings toggle featureflag for enablingTwoLineText" into main 2024-02-21 18:14:21 +00:00
Vineeth Bhende 18f3f63a2c Merge "Add tag for cuj OPEN_ALL_APPS when swiping to open all apps" into main 2024-02-21 02:25:19 +00:00
Vinit Nayak 2b031727f0 Merge "Log split metrics through individual sessions" into main 2024-02-21 00:20:44 +00:00
Schneider Victor-tulias 56aa9ed61b Update KQS launch task callbacks
Updated KQS to allow launching tasks through OverviewCommandHelper to allow launching the overview task without it having focus.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324888738
Fixes: 324904244
Test: used enter and tap to launch tasks in KQS
Change-Id: I6de38ceea22c362a52a420c8ba0165ba23e5c862
2024-02-20 14:54:08 +00:00
Anushree Ganjam 9ea1724245 Merge "Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK." into main 2024-02-17 00:23:11 +00:00
Anushree Ganjam 06c98fd685 Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK.
Jank CUJ's cannot be added in LauncherState since it's aosp code.
Introduced `onBackPressComplete` method so the LauncherState subclasses can override this method to get back press complete call after back press animation is successful. Here we can add necessary jank CUJ's.

Perfetto trace : https://ui.perfetto.dev/#!/?s=3fc6eed848bdd692949ddb3afbdcdf04a7ef0d99cb9a83804ce9e1840492ed66

Test: Perfetto trace. https://screenshot.googleplex.com/5yviY5LxKusnKvF.png
Bug: 319132905
Flag: NA. Adding jank CUJ.

Change-Id: Ia418f06cb76fe4e14c2032c62c2250e9143442f2
2024-02-16 14:35:20 -08:00
Jon @ d3693424f5 Merge "Notify home is visible when launching a translucent app." into main 2024-02-16 21:43:28 +00:00
Treehugger Robot 821715127d Merge "Prevent taskbar reset animation from playing when gesture is in progress." into main 2024-02-16 21:36:59 +00:00
bvineeth e8bdf16b65 Add tag for cuj OPEN_ALL_APPS when swiping to open all apps
Test: Checked trace
Bug: b/270128536
Flag: None
Change-Id: I0d5f562fc156423af2b5ce7e54e1bff54a522aa6
2024-02-16 10:41:15 +00:00
Jon Miranda 26447ddc98 Notify home is visible when launching a translucent app.
To fix the taskbar stash delay when launching an app, ag/18875100
sets the state so that the taskbar stashes immediately after
app is launched.

Since we cannot know if the app is translucent at that point,
we have to check after the animation is started so we can update the
launcher visibility state.

Bug: 314792981
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TRUNKFOOD
Test: HomeObserverTest
Change-Id: Ifc3a6559d7a8c6fda4c08a0fc2d6791da46b38d6
2024-02-15 13:55:42 -08:00
Jon Miranda 4a9a67816d Prevent taskbar reset animation from playing when gesture is in progress.
This fixes the bug that appears when you launch an app and immediately
swipe up on taskbar.

Fixes: 278617335
Test: launch app, immediately swipe up on taskbar
Flag: NONE
Change-Id: I56eddfae9c81b1ef827622cf0f13ffd26fadd5c3
2024-02-15 18:04:17 +00:00
bvineeth d2379d11c7 Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar
Added instrumentation when allapps is opened by button click in the
taskbar. Starting the slice in the onClickListener of the allApps button
and ending it on the end of the animation.

Test: checked the trace
Fixes: b/270128563
Flag: None
Change-Id: I492a4a7af81e0c40dc3d7d415ffc7b16c057b25d
2024-02-15 12:28:47 +00:00
Sunny Goyal 772e0127c3 Merge "Cleaning up some no-op calls during workspace binding" into main 2024-02-15 01:56:02 +00:00
Andy Wickham 1abc0a7f66 Merge "Extract TaskbarViewCallbacks to a separate class + factory." into main 2024-02-14 23:15:55 +00:00
Sunny Goyal e337a80ef2 Cleaning up some no-op calls during workspace binding
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ida21d849a06ed9c0ebf5671214dd9ee8525288d3
2024-02-14 15:10:54 -08:00
Schneider Victor-tulias 33ce1cf67c Merge "Remove KQS touch handling outside its bounds" into main 2024-02-14 18:11:52 +00:00
Saumya Prakash 3acd0708ab Merge "Add insets for taskbar when a camera cutout interrupts it" into main 2024-02-14 17:45:30 +00:00
Alex Chau 76502e84f2 Merge "Refactored StateManager logs" into main 2024-02-14 17:40:08 +00:00
Schneider Victor-tulias e724cb8e5f Remove KQS touch handling outside its bounds
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324906627
Fixes: 324893557
Test: opened KQS and tapped outside the bounds with taskbar present/absent
Change-Id: I10de9a1ea1ccca7321981fd5e9e66e9388a8dd0a
2024-02-14 10:42:01 -05:00
Tracy Zhou 64cdbf5c77 Merge "Do not add jank monitor for stash state change when the drag layer is not attached to the window" into main 2024-02-14 03:08:01 +00:00
Andy Wickham 0ae51bcdb9 Extract TaskbarViewCallbacks to a separate class + factory.
Also log long presses on the taskbar all apps button.

Test: Manual
Flag: NA
Change-Id: Id2bf194f09007bfccff9f83162e4bcfb6562580f
2024-02-13 18:51:48 -08:00
Vinit Nayak 5a9d4af170 Log split metrics through individual sessions
* Now we log the original source of the first selected app
as soon as the user selects it (previously we only did when user
selected second app)
* We log the item info for the second app to determine second
surface.
* Added new metrics to log after user has started a split session
and ended a split session
* We log different cancellation reasons (cancel button,
home gesture, general other app interruptions, etc).
* One KI/Bug: When the second app is selected via taskbar in
overview, the container will say hotseat because we are using
Launcher's logger and not Taskbar's. Taskbar's logger manually
overwrites the container in TaskbarActivityContext, we may be
able to make something hacky that can allow us to overwrite, but
that'll have to be a separate change

Bug: 322551862
Test: Logged metrics manually with event and itemInfo
Change-Id: I177623fd00ce62acf2d4ee983b58561d8c946d59
2024-02-13 17:55:08 -08:00
Saumya Prakash bb3af5d904 Add insets for taskbar when a camera cutout interrupts it
Certain devices have camera cutouts that taskbar's insets did not account for previously. This change adds in the cutout's height as a bottom inset (if it is present) to avoid a black bar being drawn in the taskbar area.

Fix: 322954760
Test: Open a full screen app on a large screen device and ensure that a black bar doesn't show up when rotating the screen to 90 degrees and 180 degrees.
Flag: N/A
Change-Id: I876274b561c7f0101554654ce758fc9c08180de7
2024-02-13 23:00:21 +00:00
Tracy Zhou 91546d401d Do not add jank monitor for stash state change when the drag layer is not attached to the window
An alternative here is to use the root layer when NO_RECREATE flag is on. However, we do not have a reference to it here (shall we consider passing it in?)

Fixes: 325096498
Test: Need to verify
Change-Id: I1709bc88753a90547f7a61dc6e24cdaf489d19e0
2024-02-13 20:57:16 +00:00
Mady Mellor 9a1fb27508 Merge "Follow changes for MagneticTarget.Listener to pass the dragged object" into main 2024-02-13 17:47:30 +00:00
Alex Chau 4e6e1555c4 Refactored StateManager logs
- Make the log permanaent behind a DEBUG flag
- Logs are currently enabled with b/279059025 marked as the related bug

Bug: 279059025
Flag: None
Test: Manual
Change-Id: I60a75d73d40d00e7d42292f3d42cc9dd8c9b0825
2024-02-13 15:35:15 +00:00
Tracy Zhou 92f9d10cea Merge "Hide task bar when folding before the new config renders the correct task bar" into main 2024-02-13 03:52:03 +00:00
Tracy Zhou dfb334f1e1 Hide task bar when folding before the new config renders the correct task bar
Currently on folding, onConfigurationChange doesn't return about 0.5sec after the small screen turns on. The old bar is visible on the new screen before a visual jump from rendering the new bar.

While the ideal solution is to figure out what causes the delay, we can mitigate the visual jump by dimming the old bar when folded listener returns folded

Test: repeatedly fold and unfold, observe that there is no glare task bar change in task bar area after folding
Bug: 291562764
Change-Id: Ic6834d2d3b7df01a8ef841dde601cdb6a3e481b0
2024-02-12 17:06:04 -08:00
Brandon Dayauon 5faed49eaf Merge "Fix color contrast in All Apps text by setting the color to onSurfaceVariant" into main 2024-02-12 23:15:05 +00:00
Tony Wickham e5451b10e4 Merge "Add CUJ annotations for going to Recents from Home" into main 2024-02-12 19:13:11 +00:00
William Leshner 2d30ff33e0 Merge "Add widget category filter to WidgetPickerActivity." into main 2024-02-12 17:30:46 +00:00
Brandon Dayauon 5787a2710c Add home settings toggle featureflag for enablingTwoLineText
- Have shouldUseTwoLine() be decided with the home settings toggle value

bug:316027081
spec: https://www.figma.com/file/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?type=design&node-id=405-384593&mode=design&t=UBkdeuNlAdRh2FGU-0
Test:
Video: https://drive.google.com/file/d/15VUhNVro2fiwv3SzMda1StiPb3PV1eMT/view?usp=sharing
before searchPreferenceScreen: https://screenshot.googleplex.com/3uqdMsZoGSBYb6c
after searchPreferenceScreen: https://drive.google.com/file/d/15dswiHRTnafyhgQA_tL2tRc7vHFWdHbZ/view?usp=sharing
before homeSettingsPage: https://screenshot.googleplex.com/7wsNevxGun2KCCB
after homeSettingsPage: https://drive.google.com/file/d/15m5bjEyewlNHI_h26aygHa7zrgZ5qDF6/view?usp=sharing
AppListSettingsPage: https://drive.google.com/file/d/15hl4ScHBOLgKv3M38HtatMxQw85pgl7t/view?usp=sharing
Flag: enableTwolineToggle DEVELOPMENT

Change-Id: I3ad133dd51dcb97e14ccded730e7737c5049261a
2024-02-12 09:24:48 -08:00
Vineeth Bhende e2c72c0178 Merge "Add HOME_TO_APP tag to CUJ_TASKBAR_EXPAND/COLLAPSE" into main 2024-02-12 04:03:58 +00:00
Will Leshner afe715a64b Add widget category filter to WidgetPickerActivity.
The category filter can be added to the intent used to show the widget
picker activity.

Bug: 314804170
Test: manually
Flag: NA
Change-Id: I1c2006e23fb5cf076166f7c376298527e47d2e9e
2024-02-11 15:31:00 -08:00
Tony Wickham 1a895f05c5 Add CUJ annotations for going to Recents from Home
Bug: 321756829
Flag: none
Test: switchToOverview, e.g. TaplTestsQuickstep
Test: Manually check traces for:
  - Home to quick switch to Overview
  - Home to quick switch to app
  - Home to Overview
  - Home to Overview to Home (one gesture)
Change-Id: I7e09957202b844d5db49f6c8545f864e7ace3522
2024-02-10 00:31:41 +00:00