Commit Graph
311 Commits
Author SHA1 Message Date
Alex Chau ecd12b32c9 Show overview as grid in fallback recents
- Replace mShowAsGrid with state specific mOverviewGridEnabled and mCurrentGestureEndTarget
- Avoid showing invisible home task in grid
- Fix quick switch out of orientation in fallback recents
- Add a HOME state to switch to when starting home, to avoid showing grid overview briefly in quick switch
- Separate clear all button and overview actions handling
- Always maintain first task's fullscreen translation at 0 to avoid jumping when mOverviewFullscreenEnabled changes
- Moved fullscreenTranslation calculation to RecentsView
- Added GestureEndTarget -> BaseState translation to allow querying displayOverviewAsGrid for a displayOverviewTasksAsGrid

Bug: 174464863
Test: Launch overveiw from home, launch overveiw from app, launch into app, test for both small and large screens
Change-Id: Iee06d94d3067ea45cadd2051717223ddc0e6e70c
2021-03-16 17:08:03 +00:00
Vinit Nayak d987a828e8 Initial commit of new split screen work.
TODO:
* Extract out common elements in TaskShortcutFactory.MultiWindowFactory
for commonalities between new and old way of
invoking split screen
* Integrate with WM APIs (b/182002789)
* Write tests for SplitSelectStateController

Bug: 181704764

Change-Id: Ice35adb4ea82897f5e2433dc9b93a549f3d511b5
2021-03-15 15:42:32 -07:00
Zak Cohen 6066f3dde4 Update Overview UI to new layout.
This change spaces out app icon and proactive row as well as removing
the clipping from task snapshots.

Bug: 179922117
Test: Local on two devices

Change-Id: I5075b6dd7895cb40cdd59495fd27e4153c9cc2ea
2021-03-11 15:27:50 -08:00
Sunny Goyal da2ecb3095 Merge "Adding support for listening for app launch animation completion" into sc-dev 2021-03-11 21:36:43 +00:00
Sunny Goyal b65d766d88 Adding support for listening for app launch animation completion
Bug: 181165935
Bug: 179065491
Test: Verified on device
Change-Id: Ifa6a91560cb31b4dfb72a0f582607e873d8a002d
2021-03-10 15:53:21 -08:00
Sreyas cd9f8719bc Let chips take full screen width.
Bug: 180917948
Test: Manual
Change-Id: I1b8602a567c4906fb52fa686092d0bf16b1f64d9
2021-03-10 10:00:26 -08:00
Alex Chau ae53cb246f Fix overview grid scroll problem
- This can be reproduced ocassionally without any obvious pattern, when this happen the page scroll and min/max scroll is messed up
- When this happen, onLayout happens before the first setGridProgress call from animations
- The fix is to request a relayout at the end of state transition

Bug: 174464863
Test: manual
Change-Id: I12683c49d7ed72349a4b9cb3b4d3871741e3e22e
2021-03-08 15:16:07 +00:00
Tracy Zhou 64c6428acc Merge "Remove LiveTileOverlay" into sc-dev 2021-03-05 21:09:17 +00:00
Alex Chau 718d0c3e2f Animate task from overview grid when launching
Bug: 174464863
Test: Manually launching from different grid positions
Change-Id: Iafb03b86c6b85fb0ebabc0f2ba98acf89d7ea971
2021-03-05 16:59:29 +00:00
Tracy Zhou 6f25775978 Remove LiveTileOverlay
Since we place app on top during the initial swipe up, LiveTileOverlay is no longer necessary. LiveTileOverlay was used to hole punch during the initial swipe when we place app under. After the initial swipe up settles in overview, hole punching job is given to the TaskView.

Fixes: 181937887
Test: manual
Change-Id: If5293dc0143af8be9db9d2745f567c4c680010a0
2021-03-05 01:10:08 -08:00
Tracy Zhou 162ed05ac9 Add NavigationModeFeatureFlag
3 Button mode doesn't use recents animation so live tile would not work on 3 button mode before migration to recents animation happens.

Bug: 169694902
Test: manual
Change-Id: I9574c624f3d220834fa18e910637cd64460adb0c
2021-03-03 10:52:12 -08:00
Alex Chau b794ea64c7 Show TaskView as grid in large screens
- Introduced gridProgress to RecentsView/TaskView ofr animating into grid
- Introduced gridProgress dependant translation and scale properties in TaskView
- Animate running task into grid with TaskViewSimulator
- Remove overview actions (for now) but keep clear all button in large screens
- Adjust ClearAllButton translation to acoomodate for grid
- Use screen width +-50% to calculate task visibility
- Use the position where TaskView is on screenEnd as pageScroll
- TODO: Handle separate recents activity

Doc: go/foldables-launcher-overview
Video: http://dr/file/d/107Aydii1LoFCwP63nWG3Twr2PBDE5ZgD/view?resourcekey=0-aUjdnx8ezimS9tmAgao9ag
Test: Test Launchering overview and launching overview from apps with folloiwng combination:
- large / small screen sizes
- portrait / landscape
- thumbnails from different screen sizes / orientations
Bug: 174464863
Fixes: 181509346

Change-Id: I4b691cde774f2e37532b68ba83c6eed399f2332e
2021-03-02 17:10:45 +00:00
Sreyas 25992f12e5 Fix DWB cutting off above inset when translating down.
Bug: 180979788
Test: Manual
Change-Id: I08577db4149b339fa217cab6401250a3fca10e65
2021-02-23 19:10:47 -08:00
Alex Chau 3a06568d8b Use PersistedTaskSnapshotData to calculate TaskView size
- Disabled variable width for running task, as PersistedTaskSnapshotData is not always up to date for current task after rotating the device

Bug: 174464656
Test: Test tablet overview with different comination of portrait/landscape wide/narrow thumbnails in portrait/landscape
Change-Id: Ifa01e72020ccaf422e3975b092462de85fa19efd
2021-02-17 11:41:24 +00:00
Zak Cohen b849aaf63d Remove scaling and dimming for adjacent tasks in Overview.
New designs flatten out the overview list and don't have scaled and dimmed
tasks adjacent to the main one.

Bug: 179922117
Test: Local run
Change-Id: I2dde04ed60b9d8459810a10d0c27dd6e131855a6
2021-02-11 19:21:27 +00:00
TreeHugger Robot 99f23c9714 Merge "Update TaskIcon UI." into sc-dev 2021-02-10 22:03:30 +00:00
Becky Qiu dffbdf861c [Overview Sharing] Pass the full screen progress to task overlay.
This is to change the alpha value of the suggest view when user swipe down.

Bug: 179514465
Test: local

Change-Id: Idfa66ff6d9bb43f35f859df828a19e3b47abcd65
2021-02-10 03:07:40 +00:00
Sreyas 4defb4009d Update TaskIcon UI.
Moved TaskView Icon up and removed TaskMenuView Icon.
Screenshot: https://drive.google.com/file/d/1dVJOr_n4hfj7HvqHs3GQY-ZsPFkv3aFP/view?usp=sharing
Bug: 179490926
Test: Manual

Change-Id: I41844901a3e47ec6d6a8bdb6ed1fb7f4524500c4
2021-02-09 18:56:44 -08:00
Sreyas Rangaraju 8eced27076 Merge "Updating Chips UI" into sc-dev 2021-02-09 20:06:02 +00:00
Alex Chau 7944ee5c79 Enable variable size thumbnail for large screen
- Introduced a feature flag
- Refresh TaskView size when thumbnail is refreshed or Recents resizes
- Disable edge scale down in large screens
- Added temp method to get task width/height ratio
- In fullscreen, scale down TaskThumbnailView and disable TaskView elevation
- Task boxing mechanism: http://screen/3NkePthAVUVH2Rv.png

Bug: 174464656
Test: Manually test overview and quickswitch for folded and unfolded, including with RTL.
Change-Id: I2ce24d588a246cc6a2408039a37d884021aa0800
2021-02-08 19:40:49 +00:00
Sreyas 6c7e594d06 Updating Chips UI
Old Screenshot: https://drive.google.com/file/d/1_ptMdXCQGTz_vafOMbB-BZVZ_EP1LsaN/view?usp=sharing
New Screenshot: https://drive.google.com/file/d/1bM6Ur5H5OJdG22XU0MdRfVlNBAf_8aUy/view?usp=sharing
Test: Manual
Bug: 179490983

Change-Id: I14715b07a412239535b4916ba9cb355a0f0cf09e
2021-02-05 17:05:27 -08:00
Tracy Zhou 035bb22298 [Live Tile] Fix a bunch of issues related to touch input
Here are the issues
- Touch down again during transition of quick switch brings back the previous app
- During transition to overview, touch down on task / in the background area results in weird behaviors

These issues related to touch input are caused by the z-ordering of app and launcher. Because in the current implementation we place launcher on top upon initial swipe up, during the transition (to overview / quick switch), any touch event goes directly to launcher instead of the overview input consumer (where it normally goes to in the non-live tile case), resulting in these weird behaviors mentioned above.

The reason we put app below launcher upon swipe up is to render task view icon earlier (before swipe up settles into overview), which, is not as critical (we don't have the feature now), and we can find other ways to make that happen.

So here are the proposed changes
- Place app on top upon swipe up. Only place launcher on top after transition to overview.
- Remove the temporary fix to disable click for live tile task during transition.
- Remove icon logic in live tile overlay (in this change I only removed the call, but let me know if it's preferred that they are completely removed from LiveTileOverlay in this change)

Test: manual
Fixes: 178640174
Fixes: 175039524
Change-Id: Ib97804c8bbc487bc55160719375c0f2ff3ba7fd3
2021-02-02 10:01:25 -08:00
Tracy Zhou 15b0f700fe Temporary fix to disable task#onClickListener during transition to overview
The root cause is InputConsumerProxy not getting events during the transition. Will need to investigate more, but since we dont allow interaction with TaskView during the transition currently, apply this temporary fix to unblock

Bug: 175039524
Test: manual
Change-Id: Ifc3eb0569cf3a60d193e91bf70519a0737afb90a
2021-01-27 19:29:16 +00:00
Tony Wickham 10a2b9c8af Separate TaskView translationX into dismiss + offset translations
- Previously, these both setTranslationX() directly, meaning one
  could clobber the other. Now they are set independently and
  aggregated to setTranslationX().
- For fake landscape, we actually are setting translationY, so
  had to create both translationX and translationY properties, and
  set the appropriate one via the current orientation handler's
  "primary" dimension.

Fixes: 176766821
Change-Id: I00ed0bd73dbea00f4018de62260ed35f4d6966a5
2021-01-15 10:42:41 -08:00
vadimt 4b77e83a42 Not using blocking call to populate task title for logging
For now, passing null title

Bug: 175048504, 173072373
Test: presubmit
Change-Id: Ia2ed5433be9490d71786c98b8244f1c76e4e3088
2020-12-10 23:47:12 +00:00
vadimt 6b193434ee Jank: not blocking UI thread when starting a task
This created jank at the end of quick switch.
Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db

Change-Id: I96f821013d900ef57d61c462f897cba17f106bb8
2020-11-20 19:48:45 -08:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 1a7e371214 Merge "Refactoring DigitalWellbeing Banner to not use footers." into ub-launcher3-master 2020-11-11 01:42:19 +00:00
Sunny Goyal ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Sreyas 6dcba89581 Refactoring DigitalWellbeing Banner to not use footers.
Removing use of footers as they are no longer necessary. Refactoring DWB code to a separate class to be cleaner. Also fixes bug with DWB animating in twice.

Bug: 171317883
Bug: 171317874
Tested:Manual

Change-Id: I78c4e541e7afa76301c3afc373ab3fa251a2c3b0
2020-10-30 11:55:48 -07:00
Winson Chung 87f2b09072 Merging from ub-launcher3-master @ build 6925377
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6925377.html

Change-Id: I928b100c8f41abff34047df69d988622123f9939
2020-10-23 10:16:50 -07:00
Winson Chung f99351888c Revert "Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ...""
This reverts commit 087a9e39b6.

Change-Id: I05b17a6e4aaaef6de3c2fa26aad45a39eb2833f9
2020-10-23 09:27:48 -07:00
Tracy Zhou 8b488ccc2e [Live Tile] Support launching running task animation
Fixes: 170338170
Test: manual
Change-Id: I2526b7cfbacaea7899b8e2ed233f913630071d36
2020-10-20 23:42:44 -07:00
vadimt 7a6e4c931f Annotating Quick Switch CUJ for 3-button mode
Bug: 169221288
Change-Id: Ief62345fe6004dde699f44aa0c90329b7cd84e8b
2020-10-07 10:51:01 -07:00
Alistair Delva 087a9e39b6 Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ..."
Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert submission 12738409-merge_ub-launcher3-master_6877130

Reason for revert: Introduced crashes to global presubmit

Reverted Changes:
I624658ce6:Merge commit '8d14dbe041199d611839140f1c9285fd4174...
Iccd2f1e3a:Merging from ub-launcher3-master @ build 6877130
I791d64951:Merging from ub-launcher3-master @ build 6877130
Icdd32ab01:Merging from ub-launcher3-master @ build 6877130

Bug: 169963211
Change-Id: I77a4ae59e823147beae8dd7cb9b54ccdace2c7f4
2020-10-05 14:46:26 +00:00
Matt Casey 49a94be109 Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' into merge_ub-launcher3-master_6877130
Change-Id: I624658ce682b55042a12faacd4cf0cfd5d3a9a56
2020-10-01 18:55:38 +00:00
Tracy Zhou c8cbd822b5 Fix logic around launchTask in the live tile case
When how things are structured changed in the past 1-2 releases, we have dup logic in launchTask. There are two cases
- Swipe down from Overview: RecentsView#createTaskLaunchAnimation. In endListener, call launchTask in the non live tile case, and call finishRecentsAnimation in the live tile case
- Tap on the TaskView to launch task: In the non live tile case, call launchTask as it calls startActivity with option. In the live tile, currently we call createLaunchAnimationForRunningTask, which plays the task launch animation, which calls finishRecentsAnimation at the end. But this animation is not sufficient, when the user swipes the live tile task off to the right and tries to launch it. We will need to replace this animation with createRecentsWindowAnimator

Fixes: 169516051
Test: manual
Change-Id: Id764d6787175bcdb1c82adb8e4743af192a1fd9d
2020-09-30 16:41:44 -07:00
TreeHugger Robot cc7b860566 Merge "Fixing lock during RecentsModel initialization" into ub-launcher3-master 2020-09-28 19:32:07 +00:00
Sunny Goyal 10759887c2 Fixing lock during RecentsModel initialization
HandlerThread.getLooper blocks the current thread until.
the final thread is initialized. Updating RecentsModel to
use an executor instead of a handler thread to avoid this.

Change-Id: I3b2e82a375ea65bea1526af4a32c6a2488102541
2020-09-28 08:57:08 -07:00
Hyunyoung Song 95786e077d Good riddance UserEventDispatcher
Bug: 165675920
Bug: 161381246

TL;DR;;
- nano -> lite proto
- add all the missing logs to WW
- pin item related logging fix
- Removed logging for assistant

sgrep "com.android.launcher3.userevent.nano." | cut -f1 -d: | xargs sed -i -e 's/userevent\.nano\./userevent\./g'

Change-Id: Ie2a49fdd891cacbd7ef40a1dc9e41ff0574c7517
2020-09-27 13:41:49 -07:00
Jon Miranda fcc7dd7e57 Merging from ub-launcher3-master @ build 6834159
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6834159.html

Change-Id: I4350d0ddedd107d7005625480aefda19e5d06ba2
2020-09-14 22:13:30 +00:00
TreeHugger Robot 1aee9da5b8 Merge "Make modal based UI changes in TaskView only if modalness changes." into ub-launcher3-master 2020-09-02 22:12:34 +00:00
Sreyas ed5e43bd25 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
2020-09-02 11:18:01 -07:00
Sreyas 639505c23b Scale down chip proportional to TaskView becoming fullscreen.
Merging into ub-launcher3-master manually as automerger failed.

Tested: Manual
Change-Id: Ic8e6dd6ba83206d67ee27d4af9d56639e9e43ff9
2020-09-02 11:17:19 -07:00
Sreyas 90faa282f1 Implementing TouchDelegate to make full chip clickable.
Merging to ub-launcher3-master manually as automerger failed.
Tested: Manual

Change-Id: I1b8b43de7f04e1e13cb283c88f95a7c6fea84ea6
2020-08-28 12:10:55 -07:00
Hyunyoung Song 6b670d62df Good riddance UserEventDispatcher [1/n]
Bug: 165675920
Change-Id: I237ed4243e1724b3c370c5660673bb3966bf4811
2020-08-24 21:19:09 -07:00
Sunny Goyal 5fb83a47f2 Removing icon recents version
Change-Id: Ibdc88715e38590cedf8a7b5174061bb2c6ef9533
2020-08-14 10:49:19 -07:00
Kevin 576d203a91 Remove several files from Recents Go src
As Go will not be using RecentsView, there are several files that are
unneeded in the recents Go source. This moves these files to
recents_ui_overrides where they will be used for non-Go builds.

Bug: 114136250
Test: Build NexusLauncher, aospWithQuickstep, l3GoWithQuickstep
Change-Id: I9d0154a75f4f2c71b865d414448e262b3019b2b9
2019-02-25 14:53:04 -08:00
Sunny Goyal 3f271d4b7f Deleting Quickscrub related logic
Bug: 124255113
Change-Id: Ic5f2338f1e3ae0a0cfb08f822dee0e01ae54a7b0
2019-02-14 11:40:03 -08:00