Commit Graph
12090 Commits
Author SHA1 Message Date
Federico Baron 810fd0cee7 Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev am: d8b78523ca am: b4388e3ef2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017949

Change-Id: I8c8743f8e88c26fa75b120a4e75249219fe5d4d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-27 04:25:55 +00:00
Federico Baron d8b78523ca Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev 2022-09-27 03:31:09 +00:00
Brian Isganitis 80014b118a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev am: 815018be9a am: 7fc8bf0c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040590

Change-Id: I4b1e3d676569c0f06f4963b3c83727d534fd40f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26 23:31:49 +00:00
Brian Isganitis 815018be9a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev 2022-09-26 22:56:06 +00:00
Federico Baron 4f5e573d3a Replace drawRect with drawable for delightful pagination
In order to eventually use the shape referenced in the task (https://docs.google.com/presentation/d/1V9-1C3mJ3zRGsuzzzYExisr9vLYecgADa1FucMoW_aw/edit#slide=id.g14256d0c614_0_311) we need to use a drawable. This CL adds the drawable that will be changed to that shape and uses it in PageIndicatorDots.java instead of using drawRect.

Bug: 247561880
Test: manual
Change-Id: I01e10bd9ddc7e378f2dcfdee0f84ba7443c3b9d3
2022-09-26 15:51:33 -07:00
Brian Isganitis 731ef0c301 Properly color taskbar nav buttons when slide-in view is shown.
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.

Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A

Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789

Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Federico Baron 36c0389d67 Rename alpha and refactor the way alpha is set in PageIndicator am: cdadbaa225 am: b5ed62b8fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20010024

Change-Id: I2d607e9997b237c8c72eca0237f19cf600cc77d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-26 18:07:06 +00:00
Federico Baron cdadbaa225 Rename alpha and refactor the way alpha is set in PageIndicator
Here we rename DOT_INACTIVE_ALPHA and DOT_ACTIVE_ALPHA to reflect the new code, and we also use mPaginationPaint.setAlpha a bit differently

Bug: 247561880
Test: Manual
Change-Id: I5ee25ee3fb36715d54f9ed86c0d59448829d7260
2022-09-26 09:34:11 -07:00
Andy Wickham fafa374dcc Merge "Reduces search clipping when work profile is not present." into tm-qpr-dev am: 59cd0e0228 am: 914aae1860
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19981474

Change-Id: Iba2790e13875037161f4a8967ef9147af8043eef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-24 18:57:15 +00:00
Andy Wickham 59cd0e0228 Merge "Reduces search clipping when work profile is not present." into tm-qpr-dev 2022-09-24 18:04:52 +00:00
Andy Wickham 14101659f7 Reduces search clipping when work profile is not present.
Basically, adds the spacing that is otherwise included by
the tab protection (which is about 4dp less than the spacing
that was previously being added).

Adds a compile-time flag to render the header at all times to
help visualize issues like this in the future. Check the
screenshots below to see some examples of this.

Screenshots: https://drive.google.com/drive/folders/1n4wwtjMwOR-eDIE1xAoG3oLXO7txpoT_?resourcekey=0-WP0RNbp7vFh2Yw1wUBZTaA&usp=sharing

Bug: 240672593
Bug: 243728487
Test: Manually checked search transition, scrolling behavior, and
highlight of the search results with and without a work profile.

Change-Id: I166d136e568c5621c81378fa09021666d95f0ffc
2022-09-23 19:36:44 -07:00
Federico Baron 469e34e02b Merge "Add rotation to folder pagination for delightful pagination" into tm-qpr-dev am: 178a45a5ab am: 8349c1f027
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993513

Change-Id: I04aa502db032eef47288b341ddf91b98ec7b2b17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 22:31:08 +00:00
Becky Qiu 05a630a991 Merge "[Toast] Change toast qpr1 feature flags to all apps device config." into tm-qpr-dev am: dd002b87e0 am: 9c2e5f509c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19978762

Change-Id: I1168bd5b3d809fe3382d3ee562e3da8ec8c139d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 22:29:59 +00:00
Federico Baron 178a45a5ab Merge "Add rotation to folder pagination for delightful pagination" into tm-qpr-dev 2022-09-23 21:40:48 +00:00
Becky Qiu dd002b87e0 Merge "[Toast] Change toast qpr1 feature flags to all apps device config." into tm-qpr-dev 2022-09-23 21:31:15 +00:00
Becky Qiu 3aec5d59dc [Toast] Change toast qpr1 feature flags to all apps device config.
Bug: 247122218
Test: local
Change-Id: I096f9fe4f8d071ea4b3292c6245da0c0ec509077
2022-09-23 11:59:56 -07:00
Federico Baron bdcc17c2aa Add rotation to folder pagination for delightful pagination
Here we add rotation for the page indicator in order to make it align with the new animation design.

Bug: 247561880
Test: manual
Change-Id: I91202c8ac259d4876f6182938db79c466f99c6ed
2022-09-23 11:30:00 -07:00
Brandon Dayauon 83095afdfd Merge "Fix pause work apps overlapping IME" into tm-qpr-dev am: 7f98856395 am: 1d8912d37b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20009124

Change-Id: I80f6a37daf96f412237de1927dcf693618635989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 17:55:15 +00:00
TreeHugger Robot 06c90832d1 Merge "Adding flag for material U popup" into tm-qpr-dev am: 07bcfaa72a am: acc0a729bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20002183

Change-Id: I5c59e44ec777e88b815499a1d404e91bf6328a5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 17:54:47 +00:00
Brandon Dayauon 7f98856395 Merge "Fix pause work apps overlapping IME" into tm-qpr-dev 2022-09-23 17:00:25 +00:00
TreeHugger Robot 07bcfaa72a Merge "Adding flag for material U popup" into tm-qpr-dev 2022-09-23 16:56:42 +00:00
Anushree Ganjam 99dc3b08e5 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev am: 65e73ce5b3 am: 56e941b5a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017952

Change-Id: I3beba5496a348bc9b35de99f0df738ae58ee9d77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:48 +00:00
Andy Wickham 549c93ca2f Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev am: 0f7b01c775 am: 99d8b992c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20010025

Change-Id: I35a70aed2a0e662164ac883d1c4ffcc610a3cf33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:31 +00:00
Anushree Ganjam 0dc2b99c80 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev am: ae81433665 am: 3aa7d90ff3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004646

Change-Id: Ieb6124cb8688f71d6717c7cf261ec0a1f43a948b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 07:45:16 +00:00
Schneider Victor-tulias dcbd4917e3 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev am: 418b1f8e82 am: d496c3d20d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19611434

Change-Id: Ic6677741689b4c609ef2fd86aa2832730dd479f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:32 +00:00
Hyunyoung Song fa5052e4db Merge "Fix the case of the missing header." into tm-qpr-dev am: 64d5e25ab7 am: 0564ea24f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20016944

Change-Id: I8e5ca4967eb65d6b87d12cef8762e970f9bfc8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:13 +00:00
Anushree Ganjam 65e73ce5b3 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev 2022-09-22 23:32:45 +00:00
Brandon Dayauon 23ff6774b7 Fix pause work apps overlapping IME
The bottom margin for button in gesture navigation is wrong.
The bottom margin for the button is supposed to be 20dp from the gesture nav bar,
not 20dp from the bottom of the screen. The calculation was correct for 3 button nav but
was forgotten to be applied to gesture nav.

bug: 246243359
test: Manual - after: https://hsv.googleplex.com/5763335673872384
Change-Id: If678a70b4ad43791cf9e66390164e1ab25a6e366
2022-09-22 13:35:01 -07:00
Andy Wickham 0f7b01c775 Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev 2022-09-22 19:01:12 +00:00
Anushree Ganjam ae81433665 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev 2022-09-22 18:03:52 +00:00
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Hyunyoung Song 64d5e25ab7 Merge "Fix the case of the missing header." into tm-qpr-dev 2022-09-22 15:45:22 +00:00
Federico Baron 7110a274b6 Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev am: 06c0f35c4e am: 34a5c7fdb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971348

Change-Id: I2544fe9e091688272e1c10a8f77e6970db425221
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 02:49:48 +00:00
Stefan Andonian 22f1eb2db4 Merge "Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home." into tm-qpr-dev am: beccfe5928 am: 22683b1288
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19583216

Change-Id: If2ea6c55a61e3b0d2063bca92e4eb1393f70cfa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 02:21:58 +00:00
Federico Baron 06c0f35c4e Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev 2022-09-22 01:10:48 +00:00
Anushree Ganjam 25ba5203e4 Add Ime transition type, Controlled and Atomic to LatencyType.
Bug: 240192346
Bug: 234812580

Test: Manual
Change-Id: I90042aa41acb1a01e3c45f67ccdc9c0f2f0eaf81
2022-09-22 01:07:08 +00:00
Federico Baron f837fd1795 Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages.
Here we add a feature flag for delightful pagination and if the feature flag is on we show a new pagination without the old animation, instead it will show a square that will move on scroll from one page to another.

Bug: 247561880
Test: manual
Change-Id: Ic88b6b2e4c677fd2012bca579407168cbda63785
2022-09-21 17:56:08 -07:00
Andy Wickham d20fe5b299 Removes search animation when tapping home screen QSB.
Test: Manual
Bug: 234882587
Fix: 247965855
Change-Id: Ib6d3c3f81924fdb693a90d4672b6d643b0b87407
2022-09-22 00:41:35 +00:00
Brian Isganitis ac4b5ddf62 Merge "Add content description for taskbar all apps button." into tm-qpr-dev am: 4ef5056be8 am: 4cb7c01c5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19995934

Change-Id: Iacb2cc29cb8d037afcf700ba3432d0fbf5c90461
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 00:31:15 +00:00
Andy Wickham 7e080b29c3 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev am: a297508c15 am: c6ed393aae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19937149

Change-Id: Icfc5ef8d7461ddf70b8685b6689899468681aced
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 00:31:03 +00:00
Andy Wickham 30b87aad7d Fix the case of the missing header.
We should not override the tabs based on the search state now
that they are hidden (but still active) during the animation.

For an explanation of why this fixes the issue, please see
https://b.corp.google.com/issues/247615711#comment15.

Fix: 247615711
Test: Manually with predicted apps being updated every second
(part of the way I found to repro the bug).

Change-Id: I5ba45c42726c34f471a7743c06aecc05c89f6105
2022-09-21 17:04:48 -07:00
Anushree Ganjam 2043d36b86 HideKeyboard when animations are disabled.
ValueAnimator.areAnimatorsEnabled() returns false

- When talkback is turned on.
- when "Settings -> Accessibility -> remove animations" are turned on.

In launcher code, when launcherstate goes from ALLAPPS -> NORMAL, AllAppsTransitionController.setStateWithAnimation is called only when animations are enabled and this function hides keyboard as well.

However, when animations are disabled
AllAppsTransitionController.setState -> onProgressAnimationEnd() is called which is where we need to hide keyboard. But the condition "if (FeatureFlags.ENABLE_DEVICE_SEARCH.get()) return;" caused the keyboard to not hide instead just return from onProgressAnimationEnd().

See https://source.corp.google.com/android-internal/packages/apps/Launcher3/src/com/android/launcher3/statemanager/StateManager.java;l=221-235;rcl=08a9bcac1f8400b44356ad4da445de8d7f360578

Bug: 239610759
Test: Manual
Video : https://drive.google.com/drive/folders/1Tif2uf13dYxIgtDlELkE4SiRthr_w-dZ?resourcekey=0-7Po8nbQPxhsgLqeMJGgKIw&usp=sharing

Change-Id: Ice9a0f951435d2fc1594d09414f299ce0cff775c
2022-09-22 00:04:13 +00:00
Stefan Andonian beccfe5928 Merge "Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home." into tm-qpr-dev 2022-09-21 22:48:42 +00:00
Yein Jo 01422d40b5 Merge "Move OnBackInvoked to BaseActivity." into tm-qpr-dev am: 364af1837e am: b0ae43f81c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19995367

Change-Id: I25e6962b55fe772aac9b4c6da3610a14e2ce2987
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 22:26:10 +00:00
Brian Isganitis 4ef5056be8 Merge "Add content description for taskbar all apps button." into tm-qpr-dev 2022-09-21 18:40:42 +00:00
Stefan Andonian d768f73f37 Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home.
Bug: 235812580
Test: Verified the correct "Swipe Back to Home" position for the
floating icon view in landscape and portrait (rtl and ltr for both
orientations) with a tablet. There is a screen recording on the bug.

Change-Id: Id06f43e70ef617e39e1b26d0c8b7466147e325d2
2022-09-21 17:54:24 +00:00
Schneider Victor-tulias e64a8cfb20 Allow Taskbar stashing for external tests
Moved Taskbar stashing enabling logic to QuickstepTestInformationHandler to allow external tests to use the Taskbar API

Test: TaplTestsTaskbar
Bug: 240129939
Change-Id: I0ede8e4767cbe068328997a3afd51f9d5df2799a
2022-09-21 10:44:23 -07:00
Andy Wickham a297508c15 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev 2022-09-21 17:25:39 +00:00
Yein Jo 364af1837e Merge "Move OnBackInvoked to BaseActivity." into tm-qpr-dev 2022-09-20 23:21:44 +00:00
Sebastian Franco 3493764337 Adding flag for material U popup
Test: compile
Bug: 247880037
Change-Id: I989fe88e070f5fe14494aa2c3d00071259907472
2022-09-20 18:02:41 -05:00