Commit Graph
13849 Commits
Author SHA1 Message Date
James O'Leary 7bbf0b5e42 Merge "Update notification dot from T90 to T80" into tm-dev 2022-06-07 22:39:46 +00:00
Andy Wickham 2d5bda75fc Merge "Enables keyboard option by default." into tm-dev 2022-06-06 21:45:17 +00:00
James O'Leary ede514f275 Update notification dot from T90 to T80
Bug: 213314628
Test: work with UX to pick something darker than T80, present options
from T70 to T90, get feedback to use T80, verify at runtime via
screenshot dot is T80.

Change-Id: Ic5b47a419eb7697c22c4dd9ab849b8a00d73be9f
2022-06-06 16:01:45 -04:00
Hyunyoung Song d4a79eb99b Merge "Fix IME hiding animation being delayed after unlocking the device" into tm-dev 2022-06-04 05:10:48 +00:00
hyunyoungs d7a02ec7ae Fix IME hiding animation being delayed after unlocking the device
Hide keyboard with WindowInsetsController if could. In case
hideSoftInputFromWindow may ignored by input connection being finished
when the screen is off.

Bug: 233158645
Test: manual as steps:
  1.  Launch AllApps.
  2.  Tap search bar to invoke IME.
  3.  Screen off.
  4.  Screen on.
And all other keyboard hide cases such as back gesture, swipe down, etc.

Change-Id: I4154f38f94b6760a430f7510a650422020d8f59a
2022-06-03 14:19:45 -07:00
TreeHugger Robot dd053e79e2 Merge "Adds helper methods in SearchUiManager and OnboardingPrefs." into tm-dev 2022-06-03 20:10:27 +00:00
Andy Wickham 9899468884 Enables keyboard option by default.
This just enables the setting for this feature. The default
value of the setting itself is still false.

Bug: 231433168
Test: Manually verified the option worked as expected, including
showing the user education when typing directly in All Apps
without tapping the QSB. Also verified previous features like
the snackbar to enable keyboard by default worked as before.

Change-Id: If423ae49436d1bf71579d52a99aea5ca3f2407dc
2022-06-02 16:51:01 -07:00
Andy Wickham e20a35c7a3 Adds helper methods in SearchUiManager and OnboardingPrefs.
Bug: 233656600
Test: With topic change.
Change-Id: I9ddb910e94d389ec682617ce874fff6a2ce703c8
2022-06-02 16:44:16 -07:00
Sunny Goyal c2c1fdad54 Merge "Fixing wrong diffing logic in AdapterItem" into tm-dev 2022-06-02 16:45:31 +00:00
Stefan Andonian 0c809bbe67 Merge "Give FloatingIconView a copy of, rather than, the original icon." into tm-dev 2022-06-02 15:33:45 +00:00
Sunny Goyal 959a9f5444 Fixing wrong diffing logic in AdapterItem
Bug: 232932442
Test: Verified on device
Change-Id: I87eae4c238a7b2d9749859307d253822916bb31c
2022-06-01 15:02:39 -07:00
Luca Zuccarini a6c36eb4d0 Merge "Update the workspace and background scale interpolators." into tm-dev 2022-06-01 16:51:42 +00:00
Luca Zuccarini 46338b09e3 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev 2022-06-01 09:35:20 +00:00
James O'Leary 202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
James O'Leary dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
Stefan Andonian 2a7fbee0d4 Give FloatingIconView a copy of, rather than, the original icon.
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.

Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.

Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
2022-05-31 17:32:08 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Luca Zuccarini 7ee40a4190 Update the workspace and background scale interpolators.
The spec had a typo (EMPHASIZED_DECELERATE instead of
EMPHASIZED_ACCELERATE). In addition, we're now using LINEAR for the
background since the feel is smoother this way. Cleared with motion
(simonroberts@).

Bug: 232418544
Test: manual
Change-Id: I492dbe8008856d331836793177f1dd58c3265ca2
2022-05-30 09:47:40 +00:00
James O'Leary 2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
Winson Chung 1e211e0c03 Merge "Ensure page scrolls are initialized even for 0 children." into tm-dev 2022-05-27 17:42:22 +00:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Winson Chung 359cb5d1b6 Ensure page scrolls are initialized even for 0 children.
Bug: 233713180
Test: Walk through CtsVerifier Lock Task UI flow as described in the bug
Change-Id: I49cb942a37a202b3e1b7ee00479d68402fcaf8b0
2022-05-26 23:38:48 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Brandon Dayauon 5ba5c76c76 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev 2022-05-26 16:06:02 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Abhilasha Chahal d18c5085c5 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev 2022-05-25 18:31:59 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau 158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Alex Chau e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Stefan Andonian 748195421c Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev 2022-05-24 22:47:50 +00:00
TreeHugger Robot 69149d07ff Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev 2022-05-24 19:52:32 +00:00
Stefan Andonian 45fc301b0e Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
(cherry picked from commit 83bc5f5050)
2022-05-24 18:21:33 +00:00
Sunny Goyal f7a48aae65 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev 2022-05-24 18:21:24 +00:00
Stefan Andonian af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Brandon Dayauon 6bb327888e Merge "Fixes scroll bar issues." into tm-dev 2022-05-24 18:10:42 +00:00
Anushree Ganjam 223bfe0908 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev 2022-05-24 17:38:08 +00:00
Alex Chau 5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot ec3723beb1 Merge "Fix widget span" into tm-dev 2022-05-24 17:31:13 +00:00
Sunny Goyal 425bfa320f Fixing ConcurrentModificationException in FirstScreenBroadcast
Bug: 232333237
Test: Not sure, unable to reproduce
Change-Id: I3eeabf76c14651d2fb64c82955851efa883760ce
2022-05-24 09:17:39 -07:00
Brandon Dayauon c472da1e5e Fixes scroll bar issues.
Fix issue where the letter bubble stays showing. Now it is able to disappear.
Fix fast scroll so its smoother and able to grab

Bug: 233607012
Bug: 233076260
Test: Manual
Change-Id: Ieccc72079602f4606da6ded7ee48d82440882ef7
2022-05-24 08:50:07 -07:00
Thales Lima 4f3cf5d05f Fix widget span
Need to take the horizontal margin of the view into consideration.

Fix: 233302799
Test: manual
Change-Id: I5f584977db85d5436b22c3701f586a5b079099ae
2022-05-24 14:49:26 +01:00
Anushree Ganjam 13b3922af9 Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."
Revert submission 18568158-revert-18500283-dismissEduCard-SCFTOPONPS

Reason for revert: b/233680944 , This is a build merger issue. 
Reverted Changes:
Ia39781c78:Revert "Add "incrementEventCountBy" function to On...
Ibba14f7c2:Revert "Save the value to sharedPreference When ed...

Change-Id: I1c0e4be10cf7e9b21623a056604618cbea2639d4
2022-05-24 02:19:57 +00:00
Cherry Ng 6a4ea4c849 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev 2022-05-24 02:16:40 +00:00
Anushree Ganjam 514979dd2d Revert "Add "incrementEventCountBy" function to OnboardingPrefs."
Revert submission 18500283-dismissEduCard

Reason for revert: Reverting because of build failures.
Reverted Changes:
I727cefb70:Save the value to sharedPreference When edu card i...
I180ab3bd6:Add "incrementEventCountBy" function to Onboarding...

Change-Id: Ia39781c78776a629d4678c78dd4ca75f49abbb6d
2022-05-24 00:44:55 +00:00
Anushree Ganjam 218703d5a9 Merge "Add "incrementEventCountBy" function to OnboardingPrefs." into tm-dev 2022-05-23 23:55:36 +00:00