Commit Graph
842 Commits
Author SHA1 Message Date
Hyunyoung Song dfdeddc66a Merge "Add group highlighting to AA+ result" into sc-dev 2021-02-19 20:48:37 +00:00
TreeHugger Robot aa14b19725 Merge changes Id68b6c37,I16d39d3e into sc-dev
* changes:
  Fix a couple of crashes when taskbar isn't yet attached
  Subtract taskbar size from DeviceProfile#availableHeight
2021-02-19 19:01:38 +00:00
Tony Wickham 786dd93f2b Fix a couple of crashes when taskbar isn't yet attached
- Handle back to back addTaskbarIfNecessary(). Specifically, handle
  cleanup() before the previous add was attached. This is already
  handled on WM side, just had to remove isAttachedToWindow() check.
- Add isAttachedToWindow() check to isViewInTaskbar()

Test: call addTaskbarIfNecessary() three times back to back, ensure no crash.

Fixes: 180509238
Bug: 171917176
Change-Id: Id68b6c376029eb5c651f47afa56666391c516aef
2021-02-18 15:40:33 -08:00
Tony Wickham 15883891ea Subtract taskbar size from DeviceProfile#availableHeight
Normally availableHeight excludes system insets, but taskbar is added
after availableHeight is calculated. This discrepency causes some bad
calculations such as TaskView size.

Test: touch nav bar when in an app with taskbar present, ensure the
task doesn't jump due to incorrect calculation

Fixes: 179478728
Bug: 171917176
Change-Id: I16d39d3e1d9708e2a64c81b1ac24466f9567d1b9
2021-02-18 11:39:10 -08:00
Hyunyoung Song db9a53d9aa Add group highlighting to AA+ result
Bug: 180071886
Test: manual
Change-Id: Id1cc3d7400e1a7fe41af272d689aa9315030b420
2021-02-18 02:19:27 -08:00
Sunny Goyal 3c5e748b36 Merge "Removing menu and dialog for custom actions hanlding. These do not work well with gesture-nav and can potentially block the Launcher UI." into sc-dev 2021-02-17 21:40:26 +00:00
Tony Wickham bb4de85c25 Draw folder leave-behind when opening folder in taskbar
Previously there was only support for CellLayout to draw the
leave-behind. Added FolderIconParent interface so any parent can
draw the leave-behind, and implement that by TaskbarView.

Test: Open folder in Taskber, ensure leave-behind draws

Bug: 171917176
Change-Id: I08d1d939a34f971f893994fe05cac972d165ef53
2021-02-16 15:10:05 -08:00
Tony Wickham 7ba547cd2d Folder support in Taskbar
- Add TaskbarActivityContext which allows shared Launcher elements to
  "just work" using existing generic ActivityContext.
- TaskbarContainerView extends BaseDragLayer<TaskbarActivityContext>.
- Inflate FolderIcon and Folder using TaskbarActivityContext to be
  shown in TaskbarContainerView.
- Use TaskbarActivityContext's DeviceProfile to determine icon size
  instead of overriding in styles. This also ensures that normal
  BubbleTextView icons have the same size as FolderIcons.

Test: Place a folder in home screen hotseat, ensure it shows up in
taskbar and can be opened, and that apps inside it can be launched
or dragged.
Bug: 171917176

Change-Id: Ic25d2f84bcd7e3399c88989305ea565497c030d9
2021-02-16 15:07:01 -08:00
Sunny Goyal 384b578ab2 Removing menu and dialog for custom actions hanlding.
These do not work well with gesture-nav and can potentially
block the Launcher UI.

Instead exposing on custom actions with keyboard accelerator and
using thee internal arrowPopup for resize options
Fixing SecondoryDropTarget not sending appropriate stats log

Bug: 179854703
Test: Verified on device
Change-Id: I268690f8a937896e4350496128a38959003f8939
2021-02-16 10:45:06 -08:00
Andy Wickham 9199fd1831 Merge "Adds CONTAINER_QSB to be used for QSB data." into sc-dev 2021-02-16 05:35:56 +00:00
thiruram c96873caad [AA+] Log LAUNCHER_ONSTOP & LAUNCHER_ONRESUME events with AllApps session InstanceId.
* Transitions between AllApps and App screen logs LAUNCHER_ONSTOP & LAUNCHER_ONRESUME events. This change add InstanceId specific to the current AllApps session to these logs; this will help to regenerate AllApps session from logs on the server side. This should only affect logs from AllApps screen, but not others.

* Removes LiveSearchManager.allAppsLogger method as it may create confusion with 2 methods for logging into Statsd

* Moved AllApps entry and exit logs to Launcher.

Bug: 178562918
Test: Manual
Change-Id: I5fab941777a3dfd2e9b19c0efd5b06d3884222ef
2021-02-15 23:56:52 +00:00
thiruram 6600860f0f [AA+] Log app launches with AllApps session InstanceId when current state is ALL_APPS.
Bug: 178562918
Test: Manual
Change-Id: I65b264cc37079280b59179d5b2f29b67e7a12cc5
2021-02-12 20:02:41 +00:00
Andy Wickham 19ab177d1b Adds CONTAINER_QSB to be used for QSB data.
Also updates some related generics definitions for
better/simpler compile-time checks.

Bug: 178536734
Test: Manual
Change-Id: If439b64ad968f62674f856fd3ff465bf21cc9204
2021-02-11 22:16:24 -08:00
Sunny Goyal 1f6b7fcc35 Merge "Deduping multiple prediction UI update calls" into sc-dev 2021-02-09 23:15:37 +00:00
Samuel Fufa 1d8a2a6e0d Merge "Migrate AA+ Search related files" into sc-dev 2021-02-09 21:24:37 +00:00
Hyunyoung Song a3a30a9224 Migrate AA+ Search related files
Bug: 179495850
Test: Manual

Change-Id: I32180f14a11eaf72d5d4981e76c2f2ea74472494
2021-02-09 21:23:36 +00:00
Sunny Goyal c402fdaf7b Deduping multiple prediction UI update calls
Bug: 179445858
Test: Manual
Change-Id: I6ad86af247a6d94dcaf45206b3d7fb8c44c602d6
2021-02-09 21:22:26 +00:00
Sunny Goyal 9fa3a07086 Merge "Removing released features" into sc-dev 2021-02-09 19:57:18 +00:00
TreeHugger Robot 823c5f8bf6 Merge "Enable variable size thumbnail for large screen" into sc-dev 2021-02-09 11:26:33 +00:00
Tony Wickham afd0d81a70 Fix some issues with taskbar
- Update Hotseat items in init() to ensure they are reloaded
- Don't update Recent items if we get the new tasks after cleanup()

Test: Fold and unfold, ensure Taskbar disappears/reappears without
crashing

Bug: 171917176
Change-Id: I1c2ae1022ae56cddece655b22db187684f691bf8
2021-02-08 21:54:01 +00:00
Alex Chau 7944ee5c79 Enable variable size thumbnail for large screen
- Introduced a feature flag
- Refresh TaskView size when thumbnail is refreshed or Recents resizes
- Disable edge scale down in large screens
- Added temp method to get task width/height ratio
- In fullscreen, scale down TaskThumbnailView and disable TaskView elevation
- Task boxing mechanism: http://screen/3NkePthAVUVH2Rv.png

Bug: 174464656
Test: Manually test overview and quickswitch for folded and unfolded, including with RTL.
Change-Id: I2ce24d588a246cc6a2408039a37d884021aa0800
2021-02-08 19:40:49 +00:00
thiruram 73821a9c6d [AA+] Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
Bug: 179529616

Change-Id: Id35c952c94d8a10743f147b194d3c27e22bc5062
2021-02-08 10:11:32 -08:00
thiruram 43b1d40918 [AA+] Add QueryLength to DeviceSearchResultContainer.
Bug: 178562918
Change-Id: I4891433bcd8848edd92f103448f5c00c5f9619e4
2021-02-08 10:08:11 -08:00
TreeHugger Robot fd03d04ae0 Merge "Enable slice again" into sc-dev 2021-02-08 08:55:00 +00:00
TreeHugger Robot bcf2ecc9e5 Merge "After AA+Search Edu, bring up IME" into sc-dev 2021-02-08 01:19:33 +00:00
TreeHugger Robot a693baa663 Merge "Catching generic app start exceptions in ProxyActivity" into sc-dev 2021-02-06 02:53:14 +00:00
TreeHugger Robot 9165c00438 Merge changes I9ccb4335,I0d2f9be8 into sc-dev
* changes:
  Add OnComputeInsetsListener to TaskbarContainerView
  Use SYSTEM_APPLICATION_OVERLAY instead of SYSTEM_ALERT_WINDOW for Taskbar
2021-02-06 01:54:37 +00:00
Sunny Goyal ead22a5257 Removing released features
Bug: 179224463
Test: Presubmit
Change-Id: I6aa989fa8e52398112cca2c7f4bed0ae69881f7b
2021-02-05 11:36:08 -08:00
Tony Wickham 734be0b5ae Add OnComputeInsetsListener to TaskbarContainerView
Instead of updating visibility of TaskbarContainerView, keep it
VISIBLE but with alpha 0, and update touchableInsets to allow
touches to pass through. This avoids sending insets changed
when Taskbar is hidden.

Test: Swipe to Overview, no jumping/jank due to insets change;
also tap where Taskbar would be and ensure it doesn't launch

Bug: 171917176
Change-Id: I9ccb4335e0301f34eec459657f3bbaf88b0d8a52
2021-02-05 08:51:42 -08:00
Samuel Fufa 0569375610 Merge "Only show OOBE once" into sc-dev 2021-02-05 16:40:31 +00:00
Issei Suzuki d5c8bd8c0b Merge "Make keyguard exit animation to remote animation." into sc-dev 2021-02-05 15:05:03 +00:00
Issei Suzuki 192f662963 Make keyguard exit animation to remote animation.
The change is disabled by default. To enable remote animation, one needs
to set a property and to restart the WMS.

% adb root
% adb shell setprop persist.wm.enable_remote_keyguard_animation 1
% adb reboot

Test: Existing tests pass.
Bug: 175686676
Bug: 179122467
Exempt-From-Owner-Approval: The owner already gave +2 on the exactly same CL.
Change-Id: I3054ce4bbb296f09ab8bc12595f2ad17b32db7b4
2021-02-05 15:00:46 +00:00
Hyunyoung Song 681154e533 After AA+Search Edu, bring up IME
Bug: 179154570
Test: Manual

Change-Id: I2d010103dd37b84b3672ba0d6ff5897373991585
2021-02-05 00:29:06 -08:00
Hyunyoung Song da74a44511 Enable slice again
Bug: 179068415
Test: manual
Change-Id: Ib2e8d17d91488719eb439fd55c8b24e62338fc94
2021-02-04 20:57:59 -08:00
Sunny Goyal b0bff050f2 Merge "Moving slice loading on a background thread" into sc-dev 2021-02-04 23:29:42 +00:00
Sunny Goyal d028812c9e Merge "Updating predictions if hotseat items get removed/added as a result of model callback" into sc-dev 2021-02-04 21:36:45 +00:00
Sunny Goyal 79e52fc23b Moving slice loading on a background thread
> Also fixing slice icon loading, such that the request is cancelled
  if views are recycled quickly
> Loading widget label on dg thread and cancelling request if views
  are recycled quickly.

Bug: 179068415
Test: verified locally
Change-Id: Id5a524e2bf596862330a8170394aef9ffd708544
2021-02-04 13:03:33 -08:00
Samuel Fufa 3a39b56434 Only show OOBE once
Bug: 179333425
Test: Manual
Change-Id: I23de8fffa31ae06b0f4feccfb75144c7c55143c2
2021-02-04 13:06:38 -06:00
Tony Wickham 63fc59b801 Use SYSTEM_APPLICATION_OVERLAY instead of SYSTEM_ALERT_WINDOW for Taskbar
Test: Taskbar still shows up and works, can't hide it from Settings
Bug: 169054709
Change-Id: I0d2f9be8a0af2242472d8406bbc31a6aecaa9285
2021-02-04 10:07:59 -08:00
Tony Wickham d10b587003 Merge "Add recent tasks to Taskbar" into sc-dev 2021-02-04 06:30:37 +00:00
Tony Wickham aaa42bd0e8 Add recent tasks to Taskbar
- Also adds a divider between Hotseat and Recents
- Dedupes Recents from Hotseat

Test: Open some recent tasks, ensure they are deduped
from Hotseat and also handle < 2 tasks.

Bug: 171917176
Change-Id: Ia782c6ccbcda94cfd844aad04dc3d25a3f072c2b
2021-02-03 18:54:58 -08:00
Sunny Goyal 0983b8070d Catching generic app start exceptions in ProxyActivity
Bug: 178815863
Test: None
Change-Id: I39ae2879e107160d552625db2946a439ee14440b
2021-02-03 21:02:31 +00:00
Sunny Goyal b245c552d4 Updating predictions if hotseat items get removed/added as a result of model callback
Bug: 179284787
Test: Verified on device
Change-Id: Iecfc7f291f54aacccc6d2afe674ccd2f20e2035d
2021-02-03 12:57:03 -08:00
thiruram f4d19f4614 [AA+] Log app launches from DeviceSearchResultContainer with instance ID.
This InstanceId is used to recreate the AA+ session on the server side.

Bug: 178562918
Change-Id: I1bba94417d3a142351e2470bb6153707d2cadb11
2021-02-03 10:17:18 -08:00
thiruram cbeb13d6c7 [AA+] Log app launches from AA+ search result container.
This change will update westworld logs for app launches from AA+ search result. Updates log's container info from AllAppsContainer -> AllAppsPlusSearchResultContainer.

Bug: 178562918
Change-Id: I9ffca27fea42951a57640ef36717c04ff0251506
2021-02-03 10:08:57 -08:00
Hyunyoung Song aa793ff226 Merge "Support shorter height row layout / Disable ICON_SLICE" into sc-dev 2021-02-03 16:47:02 +00:00
Hyunyoung Song 7239df7258 Support shorter height row layout / Disable ICON_SLICE
Bug: 178815297
Bug: 178128837
Bug: 178823469

Test: manual, attached screenshot on the bugreport

Change-Id: Ie69c8928f5acc430320cfc5c85547195866e829e
2021-02-03 01:25:16 -08:00
Hyunyoung Song 5809a40f3e Fix issue of slice icon being rendered on non-UIthread
Bug: 178989579
Test: Manual

Change-Id: I23aa5055c8f07ee9877c1f3ce51cb280ac38a2b7
2021-02-02 01:25:45 -08:00
Tony Wickham e747278ee8 Support drag and drop from Taskbar
- Long clicking a BubbleTextView in Taskbar will start a system drag
  and drop operation, setting the original view invisible meanwhile.
- Defer gesture navigation when starting over a Taskbar item, and
  cancel any started gesture if a Taskbar drag and drop starts.

Bug: 171917176
Change-Id: If5049071fbf1755f545ee937daa4edabd869f00d
2021-02-01 18:29:06 -08:00
Tony Wickham b11e4d517d Delegate Taskbar touches to nearest view to ensure 48x48dp touch size
In TaskbarView#onTouchEvent(), which is only reached if a Taskbar
icon didn't already consuem the event, check each child to see if
the event occurs within a 48x48dp bounding box, and delegate the
event and subsequent events to it until UP or CANCEL.

Bug: 171917176
Change-Id: I7afafe0835828ab9213ec6abfe4e88ad7b9af3c4
2021-02-01 18:29:06 -08:00