Commit Graph
913 Commits
Author SHA1 Message Date
Andras Kloczl 7b83486fe4 Trying to fix flaky launcher tests
Test: run AddWorkspaceItemsTaskTest.kt
Bug: 227650070
Change-Id: Ie093c5b13bdb4143829f82767fdeb208805f388a
2022-08-10 16:07:02 +00:00
Thales Lima c0268f4f49 Merge "Calculate hotseat width based on available width" into tm-qpr-dev am: c92b40f10a am: a1afc2313f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19416116

Change-Id: I3d503774a1cd8e797c96334b51f7af25cfcb1a30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-08 09:40:48 +00:00
Thales Lima 9938c2f791 Calculate hotseat width based on available width
Navigation buttons take space on the hotseat, so hotseat width (qsb width and border space between icons) should be calculated instead of having a coded value.

Bug: 223724516
Bug: 228998463
Test: manual, changing display size
Test: manual, changing hotseatBarEndOffset value
Test: HotseatWidthCalculationTest
Change-Id: Ibd4f5ff2e06afda8e7420fb744db049d2e418e14
2022-08-04 15:21:06 +01:00
Sunny Goyal f4d0a0ba70 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev am: f28c428050 am: e00fc434f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19498070

Change-Id: If53c5b0c7977b6570c14bf9aac6efe7802728f48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-03 14:49:21 +00:00
Sunny Goyal f28c428050 Merge "Create less number of dot-renderers at startup" into tm-qpr-dev 2022-08-03 14:08:07 +00:00
Sunny Goyal 65190aef37 Create less number of dot-renderers at startup
Bug: 235568943
Test: Launcher starts and shows dots normally
Change-Id: I6958b9b98efb43aa280e6ce31af9c0c936610dea
2022-08-02 14:43:31 -07:00
Schneider Victor-tulias fa4bca182b Merge "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask" into tm-qpr-dev am: 4eec22f818 am: 187b9ef0f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19462408

Change-Id: I862086421d6d67f229674b5ff96774149323aecf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-01 22:43:44 +00:00
Schneider Victor-tulias 4eec22f818 Merge "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask" into tm-qpr-dev 2022-08-01 21:50:09 +00:00
Alex Chau e62dbea9ad Merge "Refactor DeviceProfile tests based on dump() and use real device dimensions for tests." into tm-qpr-dev am: ceb2aaa9e4 am: a8b1b20f70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19356826

Change-Id: I22e17e64a30c44e42fa17e1f130143054e30adf8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-01 18:50:08 +00:00
Pat Manning 5f74bfd76d Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
2022-08-01 17:54:43 +00:00
Schneider Victor-tulias 62511de74e Add logging to help debug additional app infos being updated by CacheDataUpdatedTask
Bug: 239465630
Test: ran test locally.
Change-Id: I1b31cfaeb697f87acd99d787284f55d7e6b75b54
2022-07-28 23:09:39 +00:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
vadimt 47f347b1cf Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877
Test: presubmit
Change-Id: I95c267e46cf675ac44dc27b07d0a1143ab761e35
2022-07-26 15:43:00 -07:00
Nataniel Borges 504a09ba96 Merge "Allow disabling orientation changes check on TAPL" 2022-07-26 20:38:10 +00:00
TreeHugger Robot d33659576c Merge "Space out 3 button nav on taskbar" into tm-qpr-dev am: 5e6fe32818 am: 2a8906bfba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19272533

Change-Id: I2ea492fac54d0fabf1af92500e2ad102855c4c79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 17:21:17 +00:00
TreeHugger Robot 5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Alex Chau 2a9dafcce1 Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev am: 66bac181ac am: eed67e721e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19398184

Change-Id: If4406214f9853f055719deda5674ea0e1fc3e958
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 10:29:02 +00:00
Alex Chau 66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00
Nataniel Borges d2e978c54f Allow disabling orientation changes check on TAPL
This is necessary when a command intentionally changes the device orientation. For example, when triggering `goHome` from an app that is in landscape mode, without enabling launcher rotation

Bug: 238757607
Test: testDisableRotationCheck
Change-Id: Ia00d85d3263b6524b4806f54f729a0749684b92a
2022-07-26 08:19:37 +00:00
Vinit Nayak c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
Alex Chau 62572c04e2 Revert "Move BaseActivityInterface task size methods to DevicePr..."
Revert "Move BaseActivityInterface task size methods to DevicePr..."

Revert submission 19279487-baseactivityinterface

Reason for revert: As per discussion in ag/19341332, make sure DeviceProfile can properly react to inset changes before moving task size calculations there
Reverted Changes:
I30324d34c:Move BaseActivityInterface task size methods to De...
Ia9c1d0387:Move BaseActivityInterface task size methods to De...

Bug: 238593212
Change-Id: I0d40fdd4a5d4468494e30cef32a284479ddd2feb
2022-07-25 18:38:03 +00:00
Tracy Zhou efdf9cb0d7 Merge "Add splitFromOverviewForTablet test" into tm-qpr-dev am: 3e64f94387 am: 3d3104179c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19231730

Change-Id: Ib0b1991bf08232fe91bda8ac2c4e19a25c3e6765
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 21:17:10 +00:00
Sebastián Franco 0a8a529f15 Merge "Adding test for the Widgets reordering." into tm-qpr-dev am: df1c1c84b5 am: e8cba5fc8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18875278

Change-Id: I56fe28a97509df8e573f5c41b31dd4bf6c955613
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 21:14:17 +00:00
Pat Manning 762a930942 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev am: 01a7bcc665 am: 80cb0fa02b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19279487

Change-Id: I4c0f8cb53bade850f1beddda1efc943a1064c69d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 20:24:05 +00:00
Sunny Goyal 02d21c33be Merge "Removing unnecessary work adapter wrapper" into tm-qpr-dev am: 7dcc9831e2 am: 740a19fd08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19292690

Change-Id: Icc0acefbdff90cd03df0687d13176fa07299b3b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 19:57:44 +00:00
Tracy Zhou 3e64f94387 Merge "Add splitFromOverviewForTablet test" into tm-qpr-dev 2022-07-19 19:06:47 +00:00
Sebastián Franco df1c1c84b5 Merge "Adding test for the Widgets reordering." into tm-qpr-dev 2022-07-19 16:36:31 +00:00
Pat Manning 01a7bcc665 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev 2022-07-19 10:31:51 +00:00
Tracy Zhou 86a844c976 Add splitFromOverviewForTablet test
Design doc: go/split_tapl

Bug: 238553914
Test: run this test

Change-Id: Ibb385d852f73dee10470d14c4962cf482740105d
2022-07-19 01:57:35 +00:00
Sebastian Franco 5cba476362 Adding test for the Widgets reordering.
TAPL design chagnes at https://docs.google.com/document/d/1PdJZZIn-85-UMRFGZuqj-tJgruIWcg31lZnrb34iBTY/edit?resourcekey=0-uAZuiLCDFV9YhOtLB7wQHQ

The tests consist of a board representing the widgets on
the CellLayout a position to move the main widget (m) to
and the resulting board.

iiiii    iiiii
-----    --x--
-xxx- -> -xmx-
--m--    -----
-----    -----

Move m to 2,2.

Then whe make sure the device corresponds with the resulting
board.

I had to add the event TestLogging.recordEvent(TestProtocol.SEQUENCE_MAIN, "Widgets.onLongClick");
on ItemLongClickListener because the tests where not expecting
a long press on a widget after is being place on the
workspace.

Also, I needed to add the option to drag a widget
to a specific point instead of the previous option
of only dragging to the workspace.

Fix: 231449779
Test: Run the test and make sure they pass.
Change-Id: I58183b7ce2ca64c999e21073cce5e0ba6e6f3a9e
2022-07-18 11:52:12 -07:00
Pat Manning 4e73e5e352 Move BaseActivityInterface task size methods to DeviceProfile.
Fix: 238593212
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I30324d34ca119a467f530b590949743c2ba7b91a
2022-07-18 16:35:02 +01:00
Sunny Goyal cba5f9a64e Removing unnecessary work adapter wrapper
Simplifying view type constants to make it easier to add new view types

Bug: 234008165
Test: Verified on device
Change-Id: I96589ceba362ea7e75afdfc3fe8da3be214aa682
2022-07-15 16:24:31 -07:00
Pat Manning 89d0073c08 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev am: e700efde22 am: 980bbf0f3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19197012

Change-Id: I5e9e8117bd6546e3485318853899cbfc8bd166b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-13 11:38:54 +00:00
Pat Manning 26f70f777e Add DeviceProfile tests on all attributes across different configurations.
Fix: 237542518
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I1596dcd1fb8c9b353cdfcab224d7670d88bed716
2022-07-12 14:17:18 +01:00
Thales Lima 92a1e7f1de Add new hotseat bottom margin options am: b8c0595d42 am: a70b07d04c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605485

Change-Id: I42e901c26b8b34f52e2ba5c8b0edfc8cfcd3ac9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 11:05:01 +00:00
Thales Lima b8c0595d42 Add new hotseat bottom margin options
This changes how the hotseat height is calculated and by consequence how spaces are distributed in the workspace as well. This is the first of a series of changes that will improve and streamline workspace calculations.

Bug: 228998463
Fix: 234023782
Fix: 230191631
Fix: 232914299
Fix: 236238226
Test: manual, HSV and comparing to mocks
Change-Id: If021e8ba2c7c24c0bf9f27a1aa7aa946792ed04f
2022-07-05 15:33:47 +01:00
Pat Manning 94a437c2a9 Merge "Simplify vertical bar hotseat bottom calculation for spring loaded state." into tm-qpr-dev am: 0f8bbef729 am: e73e245ba4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19084089

Change-Id: Id2c80742c36708d3974fdea1144fd26a2b70f2f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-05 11:27:50 +00:00
Pat Manning 0f8bbef729 Merge "Simplify vertical bar hotseat bottom calculation for spring loaded state." into tm-qpr-dev 2022-07-05 10:28:10 +00:00
Pat Manning a7335bccdc Simplify vertical bar hotseat bottom calculation for spring loaded state.
Fix: 236941743
Test: manual.
Change-Id: I7f110fea48eb88e7f941a64c17a65feec14531f3
2022-07-04 12:45:40 +01:00
TreeHugger Robot 72c5f330bf Merge "Add TAPL API for adding app icon to hotseat" into tm-qpr-dev 2022-06-30 05:28:14 +00:00
Alex Chau 5a51002333 Merge "Add test to dismiss AllApps bottom sheet" into tm-qpr-dev am: f52a13e424 am: 75b1f6d5ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18993353

Change-Id: I827e3c23f957eaaed6610a41f351371849bfc104
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-27 10:27:27 +00:00
Alex Chau f52a13e424 Merge "Add test to dismiss AllApps bottom sheet" into tm-qpr-dev 2022-06-27 09:56:58 +00:00
Chilun Huang 7662dae663 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
Merged-In: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-27 11:10:21 +08:00
Chilun Huang 22e829eb2f Merge "Add TAPL API for adding app icon to hotseat" 2022-06-27 02:33:04 +00:00
Vadim Tryshev 83f326adcd Merge "Ignoring failing test" into tm-qpr-dev am: 630fd0b09f am: 17ff5150fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19067510

Change-Id: Ia93d634bd35ed14330a24f22f14e88e430cfdb66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-25 02:24:03 +00:00
Vadim Tryshev 542d3cf4f2 Ignoring failing test
Bug: 233075289
Change-Id: I4f270127b72255037dd5aaccdc375dfebb6b1dc4
Test: presubmit
2022-06-24 20:50:42 +00:00
Alex Chau d936273b1f Add test to dismiss AllApps bottom sheet
- http://docs/document/d/1ITZDMchoMndfa0nMuOTXbhKhK2aMDz0AT9dgusgxEro

Bug: 236360930
Test: TaplTestsLauncher3.testAllAppsDeadzoneForTablet
Test: TaplTestsNexus.testSearchDeadzoneForTablet
Change-Id: I62adb1d6ef237f9bca3812b8cdce9e5a8383158f
2022-06-24 18:29:43 +01:00
Vadim Tryshev 90708e661c Merge "Remove unused tracing; it confuses investigators" into tm-qpr-dev am: 0bc6491ee7 am: 79a71bb7ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19033082

Change-Id: I2e999bed3a43cedb5cb394b7f9dfac0867912b8f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 05:16:56 +00:00
Vadim Tryshev 0bc6491ee7 Merge "Remove unused tracing; it confuses investigators" into tm-qpr-dev 2022-06-24 02:05:16 +00:00
Chilun Huang a518e034f7 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-23 19:24:18 +08:00