Commit Graph
9514 Commits
Author SHA1 Message Date
Steven Ng 0e410e404b Merge "Use grid size as the upper bound for widgets' default size in initSpans" into sc-dev am: eb1617521c am: e2517121dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776609

Change-Id: I34e10bc5799e6ef69272ca63a22487be3f8bfc70
2021-06-08 15:18:20 +00:00
Steven Ng eb1617521c Merge "Use grid size as the upper bound for widgets' default size in initSpans" into sc-dev 2021-06-08 14:48:29 +00:00
Steven Ng 1d47d8c705 Use grid size as the upper bound for widgets' default size in initSpans
Test: In Pixel 4, drag a monthly view Google calendar widget to a new
      home page from the full widgets picker. The widget outline is
      correctly shown.
Bug: 189060113
Change-Id: I33113b29cc8923098de95f1d5eb14c2b02429de1
2021-06-08 14:15:50 +01:00
Stevie Kideckel 19215e9cc1 Merge "Fix accounting for the position/offset of headers with collapsing views" into sc-dev am: acf27b6d64 am: 538e5789bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881294

Change-Id: I818c9a13399b54bfd4b0af0241254b25a45bbe38
2021-06-08 09:17:07 +00:00
Stevie Kideckel acf27b6d64 Merge "Fix accounting for the position/offset of headers with collapsing views" into sc-dev 2021-06-08 08:37:25 +00:00
Stevie Kideckel fd9bfd3aab Fix accounting for the position/offset of headers with collapsing views
The offset should be taken before views are modified, the position
should be taken after. This fixes an off by one issue when expanding a
header below another already expanded header.

Bug: 183378651
Test: verified locally
Change-Id: I4987d57846d7bcde23b76280f800f19350b3521e
2021-06-08 07:08:42 +00:00
Tony Wickham 0f7d4cb981 Have AlphaUpdateListener update visibility in onAnimationEnd() am: 26ab4621ce am: d2f84ec857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14882859

Change-Id: I6f8587f9091dafb9d6baf5b0982ee8d120cfd0ed
2021-06-08 00:32:58 +00:00
Jonathan Miranda ec58206fcd Merge "New folder icon style (uncropped icons)." into sc-dev am: 93c0cfadb1 am: 785c6bc1b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14849713

Change-Id: Iefa32787f155e5710bf93bbfbb96d713258fb438
2021-06-07 22:22:10 +00:00
Tony Wickham 26ab4621ce Have AlphaUpdateListener update visibility in onAnimationEnd()
Previously we were only updating visibility in onAnimationSuccess(), which doesn't handle the canceled case.

Test: swipe up from nav bar twice in all apps, ensure all apps is invisible/non-interactable
Bug: 190315266
Change-Id: Ic59e6d4b404de4ee2d17c45d6fa59e2aee70c65f
2021-06-07 22:16:22 +00:00
Jonathan Miranda 93c0cfadb1 Merge "New folder icon style (uncropped icons)." into sc-dev 2021-06-07 21:48:50 +00:00
Steven Ng 452a687c62 Merge "Fix preview layout crash upon screen rotation" into sc-dev am: 0062822976 am: 23b50a34be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881297

Change-Id: I3f1654d156cf28e45099fa6e8c0156fe48fd7f0d
2021-06-07 21:04:21 +00:00
Steven Ng 0062822976 Merge "Fix preview layout crash upon screen rotation" into sc-dev 2021-06-07 20:38:39 +00:00
Jay Aliomer f4750b2bd5 Merge "Improve local color extraction handling." into sc-dev am: 4049f539c2 am: 8874da2534
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14844551

Change-Id: I9aa2bcdcc4af8bc54a1d331c0aa2f709bad743c5
2021-06-07 20:02:48 +00:00
Jay Aliomer 4049f539c2 Merge "Improve local color extraction handling." into sc-dev 2021-06-07 19:45:13 +00:00
Steven Ng db4ec8ac1a Fix preview layout crash upon screen rotation
Preview layouts are rendered via LauncherAppWidgetHostView. These
layouts are not yet added to the launcher. And thus, there is no
LauncherAppWidgetInfo.

Test: When a preview layout is shown in the recommended widget section,
      rotate the screen. No crash is observed.
Bug: 190395009
Change-Id: Ib1d080a106681fbfe3a4293f9f51f9576ef9414b
2021-06-07 18:55:47 +01:00
Hyunyoung Song 06e139616e Merge "Icon sizes/ keyline / font for AA+ results" into sc-dev am: 02b62ed6fe am: b8be5e65cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14837351

Change-Id: Ia41bd4b8efeaf0b1ebc77d049c555e9c9b56c26f
2021-06-07 15:22:09 +00:00
Hyunyoung Song 02b62ed6fe Merge "Icon sizes/ keyline / font for AA+ results" into sc-dev 2021-06-07 14:49:50 +00:00
Pierre Barbier de Reuille 7fca870571 Improve local color extraction handling.
Local color extraction doesn't happen if the wallpaper is not currently
visible, so we don't need to add/remove the locations when the widget is
visible/hidden.

Also now compare the locations with some approximate measure, to account
for possibly slightly different calculations during drag vs drop.

Fix: 189827568
Test: Install Clock or test widgets and try to move them: the color are applied correcly.
Change-Id: Ib2a08bb0552c75bd351868e4fd5b5df8b8b732b2
2021-06-07 13:01:28 +01:00
Alina Zaidi 13f305e70b Merge "Adjust Widgets education dialog size when in landscape" into sc-dev am: 25788e9635 am: 2ac92795c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800537

Change-Id: Ie394ec0d549f9d5c8800814fe34e1aff7739feb9
2021-06-07 09:42:30 +00:00
Alina Zaidi 25788e9635 Merge "Adjust Widgets education dialog size when in landscape" into sc-dev 2021-06-07 09:11:25 +00:00
thiruram 9b59d0cf64 [AA+] Fixing missing logs forr keyboard close interactions. am: 5435b07ed4 am: 980da427c9 am: 5694fd1dd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14792585

Change-Id: I17617ab41af9e3a6cbbc1e3b942b22e74969fe3a
2021-06-06 22:30:03 +00:00
thiruram 980da427c9 [AA+] Fixing missing logs forr keyboard close interactions. am: 5435b07ed4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14792585

Change-Id: I13b8ed7327d3dfabc0fe810c240ae4697f9f3b81
2021-06-06 21:46:57 +00:00
thiruram 5435b07ed4 [AA+] Fixing missing logs forr keyboard close interactions.
Bug: 178562918
Test: Manual
Change-Id: Id5a7fc3d8ded675c6a64de7416fade74ae2bacd1
2021-06-06 21:26:31 +00:00
Jon Miranda e41dd483e6 New folder icon style (uncropped icons).
- Switch Circle to PathShape as it allows for more flexibility on
  choosing what gets cropped.
- Remove shadows, and stroke.

Bug: 188095988
Test: manual
Change-Id: I602b3efcd35c2c11dc3461f49099c2f2a56eae59
2021-06-04 18:32:10 -07:00
Stevie Kideckel 28aef0bccc Merge "Fix corner radius for expanded widget picker list items" into sc-dev am: 6f3081affa am: af0c258b2d am: ff515aeb17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14830781

Change-Id: I4104145831173ebdc68b2ebff6e83d197d6d817a
2021-06-04 21:33:33 +00:00
Stevie Kideckel ff515aeb17 Merge "Fix corner radius for expanded widget picker list items" into sc-dev am: 6f3081affa am: af0c258b2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14830781

Change-Id: I9e63d6072568aa2190bae15d1428b1d56478b7d1
2021-06-04 21:19:33 +00:00
Stevie Kideckel 6eff99a7d3 Merge "Fix corner radius for expanded widget picker list items" into sc-dev am: 6f3081affa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14830781

Change-Id: Ic29d0cbdc804c77981c0ed4945eedaa93c5da1b9
2021-06-04 21:05:03 +00:00
Stevie Kideckel 6f3081affa Merge "Fix corner radius for expanded widget picker list items" into sc-dev 2021-06-04 20:50:52 +00:00
Hyunyoung Song e4cb75b944 Merge "Remove APP_SEARCH_IMPROVEMENTS" into sc-dev am: 9450883e74 am: 75987bddd3 am: ea6b3db51d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14829362

Change-Id: Iaee30ea22e6b388b6ea3cea6c68d7cd0ca1c5d1b
2021-06-04 19:19:11 +00:00
Hyunyoung Song 75987bddd3 Merge "Remove APP_SEARCH_IMPROVEMENTS" into sc-dev am: 9450883e74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14829362

Change-Id: Id83670f5fbb70af1dd774025829b5fe301389936
2021-06-04 18:44:05 +00:00
Sunny Goyal 9d9930e2fc Merge "Taskbar layout update" into sc-v2-dev am: a72e9e20bf am: f703600a8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14722697

Change-Id: Idc4f8932d94a215231076269b2d6fb18611a8188
2021-06-04 18:35:22 +00:00
Steven Ng 540644d92b Merge "Include widget padding & boarder spacing in widget preview size estimation" into sc-dev am: 5063805a4e am: d4e862e826 am: 6d85030138
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14830785

Change-Id: I656e8af97b4e7c6a52f4cb452139a75faa1bbdea
2021-06-04 18:34:31 +00:00
Hyunyoung Song 9450883e74 Merge "Remove APP_SEARCH_IMPROVEMENTS" into sc-dev 2021-06-04 18:24:11 +00:00
Sunny Goyal a72e9e20bf Merge "Taskbar layout update" into sc-v2-dev 2021-06-04 18:08:58 +00:00
Steven Ng d4e862e826 Merge "Include widget padding & boarder spacing in widget preview size estimation" into sc-dev am: 5063805a4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14830785

Change-Id: Ib2f09e79cddc7a331463854e533f0ee3ba439291
2021-06-04 18:05:44 +00:00
Steven Ng 5063805a4e Merge "Include widget padding & boarder spacing in widget preview size estimation" into sc-dev 2021-06-04 17:45:29 +00:00
Alina Zaidi 9f5a7f8366 Adjust Widgets education dialog size when in landscape
Test: Tested manually
Bug: 185354491
Change-Id: Ifd86f48d705b054ae6a2315a11e5398423020755
2021-06-04 18:14:02 +01:00
Yogisha Dixit 80abb18d53 Add new log events for widgets. am: 4ff5ee3a8f am: f8ef794774 am: 45491961d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14425539

Change-Id: I519c29d4a047fc01e43f4642fa2f4345db39d387
2021-06-04 17:05:40 +00:00
Yogisha Dixit f8ef794774 Add new log events for widgets. am: 4ff5ee3a8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14425539

Change-Id: Icfd93b918332a391602c788aa84f27d421c7ef14
2021-06-04 16:37:07 +00:00
Steven Ng 4a0e1b40f3 Include widget padding & boarder spacing in widget preview size estimation
Test: Sideload Google dev clock and verify the 5x5 widget preview is
      rendered correctly.
      Verify conversation widget preview is rendered correctly in the
      full widgets picker and priority flow (aka pin widget flow).
Bug: 189975670
Change-Id: I4b0212ae347044c970ba40b9b33439448a6aa941
2021-06-04 15:31:22 +01:00
Yogisha Dixit 4ff5ee3a8f Add new log events for widgets.
Design doc: go/widgets-logging

Bug: 185778648
Test: manual
Change-Id: Ia3c6edb87766a33e77865e9461e7101a1df864c1
2021-06-04 14:52:37 +01:00
TreeHugger Robot 115cbebb7c Merge "Use a selector instead of loading resource for drop target." into sc-dev am: b1e51e2a3f am: 8b52ff1ab0 am: 7668cbb9cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817811

Change-Id: I37fd00e6f06c8ef94a12b33a0b3c2e92d49bd8dc
2021-06-04 13:10:34 +00:00
Stevie Kideckel d93feeba0a Fix corner radius for expanded widget picker list items
Also create the drawables at runtime to avoid all the permutations

Fix: 189329394
Test: verified locally
Change-Id: I0497759ff68bd4ae6b1635423cfd4713f06d349f
2021-06-04 13:04:04 +00:00
TreeHugger Robot 7668cbb9cc Merge "Use a selector instead of loading resource for drop target." into sc-dev am: b1e51e2a3f am: 8b52ff1ab0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817811

Change-Id: I246afad583fa73c8e5be7f2a21d1d729aea87bf7
2021-06-04 12:56:53 +00:00
TreeHugger Robot 4d296cc3d8 Merge "Use a selector instead of loading resource for drop target." into sc-dev am: b1e51e2a3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817811

Change-Id: Ieb674f68802b1550eb2675b0c0a7ef5abf233779
2021-06-04 12:49:20 +00:00
Stevie Kideckel 9d5a46f8b7 Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev am: 6d12fb29f7 am: 68dd580d81 am: 17ee35f0cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817820

Change-Id: Id464c79c336252e0e969171a2a280e132603fbc9
2021-06-04 12:32:54 +00:00
TreeHugger Robot b1e51e2a3f Merge "Use a selector instead of loading resource for drop target." into sc-dev 2021-06-04 12:29:22 +00:00
Stevie Kideckel 17ee35f0cf Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev am: 6d12fb29f7 am: 68dd580d81
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817820

Change-Id: I8ec0554beca342301e0305892164fd746d6b52d3
2021-06-04 12:19:45 +00:00
Stevie Kideckel c5a9ffb31c Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev am: 6d12fb29f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817820

Change-Id: I49ebce6c0d887e18b7087d9bfc46ca255e0fe912
2021-06-04 12:05:47 +00:00
Stevie Kideckel 6d12fb29f7 Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev 2021-06-04 11:45:27 +00:00