Commit Graph
58436 Commits
Author SHA1 Message Date
Pinyao Ting 0646dde219 Don't crash Launcher when attempting to endTransaction on an
already-closed DB.

Since the DB is already closed, if we can't end the
transaction, it should not put the code in a bad state.

Bug: 173162852
Test: manually tested backup and restore flow and existing tests
Change-Id: I2692d98f0a8efc8aeb6bfd826fe738e4436c6ee4
2020-11-24 15:16:10 -08:00
Schneider Victor-tulias f6f41535bf Disable app theme crossfade animation.
Pending the resolution of b/172467144, disabling the app theme crossfade animation.

Test: manual
Change-Id: Id18d2022601d7c5d7debb2365d4b65e5fcf6c5a5
2020-11-24 15:03:36 -05:00
android-build-team Robot 07c70f3a1d Snap for 6991248 from 64594c803a to sc-release
Change-Id: I0ae88e55fc3b97c1a22eb87e805c895146a10509
2020-11-24 02:14:11 +00:00
Xin Li ecb18a6573 Merge rvc-qpr-dev-plus-aosp-without-vendor@6881855
Bug: 172690556
Merged-In: I56abeae5adec79a1c7bdad1a261f0f62c055cf2e
Change-Id: I2efd8b65312e25c5c96bf36b3c4a655baffe2eaa
2020-11-23 17:13:54 -08:00
Tony Wickham 7199acdbad Add null check to AbstractStateChangeTouchController#onDragEnd()
Fixes: 171444185
Change-Id: I32eec545c849164463e2820603bfb6dc26260f11
2020-11-23 16:09:07 -08:00
TreeHugger Robot 64594c803a Merge "Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"" 2020-11-23 20:38:50 +00:00
Samuel Fufa ec5e095430 [DO NOT MERGE] Encode launch location for hotseat items
Bug: 162003157
Test: Manual
Change-Id: I18f8f3f431dbabb3d22898d27d70c8730ad0150f
(cherry picked from commit 9b947993be)
2020-11-23 19:39:00 +00:00
TreeHugger Robot cd0c18460a Merge "fix the issue widget id wasn't being migrated in backup" 2020-11-23 17:49:16 +00:00
Sean Stout beb416cd4f Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"
This reverts commit 3a8075366c.

Reason for revert: This behavior is no longer needed and was requested to be removed here: b/165931807

Change-Id: I3f16528403fb2e33eba620f8082ac2dcbe9591bf
2020-11-23 16:35:53 +00:00
Pierre Barbier de Reuille c63e16f99e Rename flag to remove reference to blocked word.
Change-Id: I145f5dfb2ba020331a4cae3225a4345a6d10233a
2020-11-23 11:16:25 +00:00
android-build-team Robot 9789c16340 Snap for 6988335 from f8d7e3428c to sc-release
Change-Id: Idd2d4898021db3bc062f65e1383d3e8aea58e701
2020-11-22 00:09:55 +00:00
vadimt 6b193434ee Jank: not blocking UI thread when starting a task
This created jank at the end of quick switch.
Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db

Change-Id: I96f821013d900ef57d61c462f897cba17f106bb8
2020-11-20 19:48:45 -08:00
TreeHugger Robot f8d7e3428c Merge "Fixing jank in launching app from recents" 2020-11-21 03:38:39 +00:00
Pinyao Ting 7aaaa35501 fix the issue widget id wasn't being migrated in backup
After SuW the favorite table is copied into backup table, but the widget
id in the backup table hasn't been migrated. This introduces general
unstabality and can sometimes leads to the disappearance of widgets
after a restore.

Bug: 171774227
Test: run Backup Restore flows and verified database status with arbitrary
logging

Change-Id: If275a6b5395504d6de90e26c3998f759e797f6e1
2020-11-20 18:18:52 -08:00
android-build-team Robot 4d3d86ca04 Snap for 6987265 from b4f5e6f016 to sc-release
Change-Id: I632c4a7d14787cb469af5e4f01cae092e56950c2
2020-11-21 02:06:50 +00:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
vadimt 6c1fa64a1d Fixing jank in launching app from recents
Moving expensive actions from the last
frame's rendering.

This reduces the max frame time from > 16 ms
to <= 8 ms, which is good for now.

Test: Trace, metrics
Bug: 173640772
Bug: 173072373
Change-Id: I6d06a129f68d9b26f52c773b817558c77604ae5e
2020-11-21 00:09:42 +00:00
TreeHugger Robot b4f5e6f016 Merge "Removing obsolete shadows" 2020-11-20 20:35:43 +00:00
Samuel Fufa cb6ac3df97 Merge "hide app results if app info can't be found" 2020-11-20 16:29:57 +00:00
android-build-team Robot 618b4d1a0e Snap for 6984833 from b43d8fa9a5 to sc-release
Change-Id: I3433e524796c29a0a71de3d8e3c025d1e6e7ca52
2020-11-20 02:05:43 +00:00
Samuel Fufa e5d2ad8e34 Even more logs for flaky work test
Bug: 159671700
Change-Id: I009f243b5e3076d15bc89a4755d5ddb9a5b3119e
2020-11-19 22:54:02 +00:00
vadimt daa731f1fe Removing binder call from the gesture injection
This causes jank under lock contention stress.

Test: local
Bug: 173072373
Change-Id: I3a44e510254f6d651cedb91f72e1789ae97d9b67
2020-11-19 22:12:09 +00:00
Samuel Fufa d41dfd3288 hide app results if app info can't be found
Bug: 173673806
Change-Id: I337912a354ba4374240c4be1c3f2595c4228ec74
2020-11-19 12:55:06 -06:00
John Li b43d8fa9a5 Merge "Haptic effect on alphabetical scroll in Pixel Launcher" 2020-11-19 08:15:06 +00:00
android-build-team Robot 9c90fed68e Snap for 6981746 from 2f4654ee04 to sc-release
Change-Id: Ia89b4663fffce8b14facc369d710cfd5a3373134
2020-11-19 02:14:52 +00:00
Sunny Goyal 3751be0f1c Removing obsolete shadows
Change-Id: I9dcaa69e4e86130642be15e3585f5898dd866839
2020-11-18 21:45:14 +00:00
Tiger Huang 2f4654ee04 Merge "Replace the system UI visibility with appearance (Launcher)" 2020-11-18 13:30:06 +00:00
John Li ce7f9f2ae1 Haptic effect on alphabetical scroll in Pixel Launcher
Bug: 169397156
Test: manual
Change-Id: Id0c51ac9e9ca7d0f3aaf9b490874de6ee0e97a28
2020-11-18 08:13:25 +00:00
Sunny Goyal 8bc273056f Merge "Resolve auto close on widget swipe" 2020-11-18 06:18:14 +00:00
android-build-team Robot 76cb6d69f1 Snap for 6978977 from 54834b0909 to sc-release
Change-Id: I2ad150f1bb13d18c9e0d09de0fd37a2a868f5d13
2020-11-18 02:07:39 +00:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Samuel Fufa 2c86122fa4 Resolve auto close on widget swipe
Bug: 172891360
Test: Manual
Change-Id: Icb384b6dc5ec9a29b6a9a7811b862a2d83ca11a7
(cherry picked from commit 5fa6f3ce503cde51687985ebc9dee6f163b9b1ea)
2020-11-17 18:34:46 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2cd8dd6282 Merge "Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON" into ub-launcher3-master 2020-11-13 19:24:40 +00:00
vadimt 4dd0fb173b Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON
This is a part of Blue Chip de-janking effort and is
a P0 item in our CUJ list.

In the last frame of the app-open animation, we have
a
android.view.IRemoteAnimationFinishedCallback$Stub$Proxy.onAnimationFinished call
which is blocking and prone to lock contention in WindowManager.

Moving the call to after the animation.

Bug: 173072373
Change-Id: If5eb6469900d1892b861eda6d6b4807d90630b6b
2020-11-12 18:42:20 -08:00
android-build-team Robot b5a8616d7b Snap for 6969923 from af0391f9b2 to sc-release
Change-Id: Iec9933ded75e5aee038fbc9a8b506c6e4deb097d
2020-11-13 02:01:55 +00:00
android-build-team Robot cfaaa59a9a Merge cherrypicks of [13044672, 13045117, 13045007, 13045118] into sc-release
Change-Id: Ia4978317715e764c2547b099c1717277f699e92f
2020-11-12 17:07:06 +00:00
Pinyao Ting 4fd82210af Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
(cherry picked from commit ae1997b9d5)
(cherry picked from commit af0391f9b2)
2020-11-12 17:05:35 +00:00
Schneider Victor-tulias 64154ead74 Fix hotseat predicted app update regression.
Hotseat predicted app updates were only being allowed then the hotseat was invisible or when the workspace was loading. This was too strict. Changed the logic to ignore hotseat visibility when the workspace is loading, when there are empty spots in the hotseat and when the predicted items are unchanged. This ensures the hotseat always has the intended number of icons and that icons can be updated in-place.

Fixes: 172597819

Demo: https://drive.google.com/file/d/100svnqX048Da7vues2p-vvQNN6sIF8v4/view?usp=sharing
Change-Id: I2f93ff44618c0282a6411918c34d70f75ec73b73
2020-11-12 11:22:53 -05:00
Schneider Victor-tulias 7bbec50031 Fix AllAppsSearchPlugin icon redrawing without special-casing.
Preventing icon animations in deep shortcuts fixed the icon redrawing issue in the all apps search page, however other icons could still be redrawn, yet could not be special-cased without removing icon update animations altogether. Added logic to only animate icon updates outside of the all apps search page.

Demo: https://drive.google.com/file/d/1ReT2O_1tV20terY0Jr1NJGxIxPblHCK4/view?usp=sharing

Change-Id: Ibe0b43801ec5340c3551125aef13170d569d2c55
2020-11-12 10:31:20 -05:00
Sunny Goyal 6f1bc72fda Merge "Fixing animation cancelled not called if gesture was not initiated" into ub-launcher3-master 2020-11-12 04:33:07 +00:00
android-build-team Robot fd4d44d4fb Snap for 6967390 from ff6bcae03a to sc-release
Change-Id: I078b9565a15331edd89c8ce69af1af63a0899f78
2020-11-12 02:07:35 +00:00
Sunny Goyal 986ea0da60 Fixing Robolectic model tests
Some tests were broken because of refactoring in LauncherModel.

Change-Id: I55aa32d75a4d16338796a1b1765717fd72ba4b33
2020-11-12 01:01:55 +00:00
android-build-team Robot db2bd24c8b Snap for 6966897 from a18b9f3e42 to rvc-qpr2-release
Change-Id: Ie846f5555e90cb09245c3f11f05eed7aebb8c237
2020-11-12 00:08:14 +00:00
TreeHugger Robot c32e39f1db Merge "Fix OutOfBounds issue on getFocusedChild" into ub-launcher3-master 2020-11-11 21:56:54 +00:00
Sunny Goyal 0112a3d434 Fixing animation cancelled not called if gesture was not initiated
Previously, in case of a tap in the gesture region, swipeHandler was not
explicitly cancelling the launcher state animation. It was getting reset
bucause launcher gets onStop immediately after that.
But in some cases, it may not get onStop (if the top activity finishes),
which leaves the Launcher UI in a broken state

Bug: 172842997
Change-Id: Iff7b1e5b8f67b2f4dd8096b88c4cd97115ec912a
2020-11-11 12:23:47 -08:00
Pinyao Ting af0391f9b2 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
(cherry picked from commit ae1997b9d5)
2020-11-11 19:36:09 +00:00
Samuel Fufa 437513d5ef Federate SliveLiveData for Search results
Instead of every slice result creating its own live data, we should manage a single SliceLiveData per url that SliceViews can observe.

Bug: 173022319
Test: Manual
Change-Id: Ieaf599aadfac40450be4f39657d3cefb70644e0c
2020-11-11 12:48:40 -06:00
Samuel Fufa c25bc0335b Fix OutOfBounds issue on getFocusedChild
In cases where search only shows items that don't require focus highlighting,getFocusedChildIndex returns -1.

Bug: 13023194
Change-Id: I6145ae26e3953c5fc4fd1ed1696eb931017cac0f
2020-11-11 11:31:54 -06:00
Samuel Fufa 9ee4e86cf8 Merge "Search support for widgets with config activity" into ub-launcher3-master 2020-11-11 16:21:01 +00:00