Commit Graph
58436 Commits
Author SHA1 Message Date
vadimt ab469ac515 Better diagnosing leaked activities.
Test: manual
Bug: 181356264
Change-Id: I9bf843a1d26bc4cf255c1b8d2cce0febeaa4c4fe
2021-02-26 14:45:10 -08:00
Samuel Fufa a18abf55b4 Add tracing to track every allApps rebind
Bug: 159671700
Test: presubmit
Change-Id: I1c7507ac2175d6e2f4514e4ad51c356aa75dd6e9
2021-02-26 16:40:27 -06:00
TreeHugger Robot 3be39aa0b9 Merge "Update ArrowPopup to accommodate more rounded dialogs." into sc-dev 2021-02-26 22:17:40 +00:00
Hongwei Wang 9140af12d2 Skip window transform if SwipePipToHomeAnimator's running
Launcher tries to set the window transform on the recents animation
leash when it's settled on end target, which might conflict with
SwipePipToHomeAnimator and causes flash/flick at the end of the
transition. Simply skip the window transform since
SwipePipToHomeAnimator is the one solely responsible for updating the
leash in this case.

Bug: 179720719
Test: repeatedly enter PiP from ApiDemos with autoEnterPip enabled
Change-Id: Ia98675c21e3bd898cd11cf6ed97f6eaadcb11a42
2021-02-26 14:11:45 -08:00
Andy Wickham bb993c484a Adds dump method to ModelDelegate.
This allows delegates to include additional data in log dumps.

Bug: 181351828
Test: Checked that data was found in a bug report and
adb shell dumpsys activity com.google.android.apps.nexuslauncher

Change-Id: I7a63430202ff899ac885a544c558e1248d2ce829
2021-02-26 13:36:07 -08:00
thiruram 490ef5edf4 [AA+] Logs LAUNCHER_ALLAPPS_ITEM_LONG_PRESSED event. am: e9fe7f2789
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13682552

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I48d06a761e8db519658b4e3c1d275446b576942a
2021-02-26 21:15:56 +00:00
thiruram 67ecc8e983 [AA+] Logs LAUNCHER_ALLAPPS_ITEM_LONG_PRESSED event. am: e9fe7f2789
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13682552

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ica58cfc23bb522452e36b49efa92cafd39b20b49
2021-02-26 21:15:50 +00:00
TreeHugger Robot 505ba9d889 Merge "Adds a removeChangeListener to FeatureFlags$BooleanFlag." into sc-dev am: a9cb2fb476
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13700168

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2b2314ceb57dbc4dfbd4a330debbb7cc64783b53
2021-02-26 21:15:22 +00:00
TreeHugger Robot a1e0a801c5 Merge "Adds a removeChangeListener to FeatureFlags$BooleanFlag." into sc-dev am: a9cb2fb476
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13700168

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I00d2769059cfae7e0b68ca1c6e28578386a5f88c
2021-02-26 21:15:07 +00:00
thiruram e9fe7f2789 [AA+] Logs LAUNCHER_ALLAPPS_ITEM_LONG_PRESSED event.
Bug: 178562918
Test: Manual
Change-Id: I6f195b7bdfa222332a250379bb7667501cbee762
2021-02-26 20:46:14 +00:00
TreeHugger Robot a9cb2fb476 Merge "Adds a removeChangeListener to FeatureFlags$BooleanFlag." into sc-dev 2021-02-26 20:21:51 +00:00
Vadim Tryshev de87397863 Merge "Waiting for the state of views to settle after orientation change" into sc-dev am: e1ea6cf754
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13701383

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6da47d554bafc5d1cd4e4fbfe29c60bfccc003dd
2021-02-26 19:38:34 +00:00
TreeHugger Robot 1437e28c54 Merge "Diagnosing expected selector in app-start" into sc-dev am: 47603e4e69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13699872

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I5446d5642b0fd4892b0625d090778b563f4d3f74
2021-02-26 19:38:14 +00:00
Jonathan Miranda 1c47edabbd Merge "Check for developer option on resuming settings activity." into sc-dev am: e1d06c5ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13711345

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I07a6c0b6a1df512bdb96c8cd906ff2663ebc75cd
2021-02-26 19:38:03 +00:00
Vadim Tryshev dd6e426b67 Merge "Waiting for the state of views to settle after orientation change" into sc-dev am: e1ea6cf754
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13701383

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I7ebf15f3ce83df2c3565627b6fb7264bab54d392
2021-02-26 19:37:23 +00:00
TreeHugger Robot 87f880ce92 Merge "Diagnosing expected selector in app-start" into sc-dev am: 47603e4e69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13699872

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ief154d17f16a88491ff09b9ccf18ecd14affb493
2021-02-26 19:37:18 +00:00
Jonathan Miranda 7b531843f9 Merge "Check for developer option on resuming settings activity." into sc-dev am: e1d06c5ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13711345

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I26ad617681c6aec1154fd33cd5818594f93d1f0b
2021-02-26 19:37:13 +00:00
thiruram 66cea2fe43 [AA+] Fixes duplicate LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB logs. am: 1bfd24e13f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13564081

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ieb4b3353842fcfb516406c560a493afb30f1d793
2021-02-26 19:37:12 +00:00
Vadim Tryshev e1ea6cf754 Merge "Waiting for the state of views to settle after orientation change" into sc-dev 2021-02-26 19:37:06 +00:00
thiruram e5cf64307b [AA+] Fixes duplicate LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB logs. am: 1bfd24e13f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13564081

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I367ff30d0611b1b479ab98bba34fa58d80ceb127
2021-02-26 19:37:01 +00:00
TreeHugger Robot 47603e4e69 Merge "Diagnosing expected selector in app-start" into sc-dev 2021-02-26 19:28:44 +00:00
Jonathan Miranda e1d06c5ccd Merge "Check for developer option on resuming settings activity." into sc-dev 2021-02-26 19:06:32 +00:00
thiruram 1bfd24e13f [AA+] Fixes duplicate LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB logs.
LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB is logged when transistioning from AllApps search results view to all apps view.

Bug: 178562918
Test: Manual
Change-Id: Ie02e23ae9eaabad719ad2a1fc8f08a9e4c36936f
2021-02-26 18:57:57 +00:00
TreeHugger Robot 2d956cceaa Merge "Add a header container view to the widgets full sheet" into sc-dev am: 21803095ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13687970

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I737a9e425e6d591cf561ac01c63b76df459db38f
2021-02-26 18:36:05 +00:00
TreeHugger Robot cc564f0ba0 Merge "Add a header container view to the widgets full sheet" into sc-dev am: 21803095ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13687970

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6cf69ce828d6a13e52cf3b8e459f58f3fbe043b6
2021-02-26 18:36:04 +00:00
Samuel Fufa 81bf29c998 Show typeahead hint for app results
Preview: https://drive.google.com/file/d/1_qB-HDVfqqzPOhnuq5Hj9grhh69av7xf/view

Bug: 180545101
Test: Manual
Change-Id: I0649fa0e19f850fdc4de3776f6ac9f450bb0501b
2021-02-26 12:26:41 -06:00
Steven Ng 11773f47d2 Show widget previews in their expected cell sizes
1. Show widget previews in their expected cell sizes.
2. Update the bottom picker to use a table layout rather than
a horizontal scrollbar.
3. Move the title and cell size description to the bottom of
the preview.

Test: Run AddConfigWidgetTest
      Manually open full and bottom widgets picker and observe
      widget previews.
      Video: https://drive.google.com/file/d/1K8A8hK5B4FgPTsX3cb-Yt4a_VjI0pk-w/view?usp=sharing
Bug: 179797520
Change-Id: I938612cb2e2477ce4a3a2d6c8891a0a36fc0978c
2021-02-26 17:47:32 +00:00
TreeHugger Robot 21803095ee Merge "Add a header container view to the widgets full sheet" into sc-dev 2021-02-26 17:45:12 +00:00
Jon Miranda 45cb6a8739 Check for developer option on resuming settings activity.
Test: Turn system dev option off, check pref is gone in home settings
      Turn system dev option on, check pref is visible in home settings

Change-Id: I71d90aa5840571e908228552e498ab3a82a3352d
2021-02-26 11:18:19 -05:00
Alina Zaidi a686b9e72b Merge "Refactor SearchAlgorithm and SearchCallback interface to work on generic search result type." into sc-dev am: 4ffd4f03c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13581959

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ia87c937f66280967408f31f6c39018227f8cae72
2021-02-26 15:53:15 +00:00
Alina Zaidi 8eacef0e48 Merge "Refactor SearchAlgorithm and SearchCallback interface to work on generic search result type." into sc-dev am: 4ffd4f03c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13581959

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I78b42f5565dfe1cc9e520165083db49226c8c6e8
2021-02-26 15:53:06 +00:00
Alina Zaidi 4ffd4f03c6 Merge "Refactor SearchAlgorithm and SearchCallback interface to work on generic search result type." into sc-dev 2021-02-26 15:44:37 +00:00
Steven Ng 167f81b931 Add a header container view to the widgets full sheet
A header container view will contain
1. A horizontal bar: for indicating the popup view can be dragged
   to dismiss:
2. A title view: a title of the widgets full sheet popup view.
3. A search bar: for widgets / shortcut search. Since we will be
   making the fallback search algorithm available in AOSP, the
   search bar will now live in the Launcher3 codebase.
4. Recommended widgets (coming soon...)

This CL also added a scroll effect which gradually collapses the
title view when the user scrolls down the recycler view. The title
view will gradually restore its height when the user scroll to the
top of the recycler view.

Test: Manually test widgets pickers in work profile and non work
      profile setup. Verified the fast scroll bar works well in
      both setup.
      With searchbar: https://drive.google.com/file/d/19grUHL_LspLhMD_5p6-i0CiMW1FpflmD/view?usp=sharing
      Without searchbar: https://drive.google.com/file/d/1KRPgEAESHUhJDo1UJsQN80JO1c9Y8Nhl/view?usp=sharing

Bug: 179797520

Change-Id: If0016e3b3c693414897140e7912531ed9bd5deef
2021-02-26 10:03:36 +00:00
Andy Wickham 75845ed9a8 Adds a removeChangeListener to FeatureFlags$BooleanFlag.
This will help us avoid leaks, etc.

Also changes ENABLE_SMARTSPACE_ENHANCED back to a DeviceFlag

Bug: 181194850
Bug: 181077020
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests -- --abi armeabi-v7a
Change-Id: I6f54af3e6b6302a073b8b7d448ff72b05a803d8f
2021-02-26 07:41:45 +00:00
android-build-team Robot bdbe30a959 Snap for 7171433 from 87fab748b1 to tm-release
Change-Id: Iab5d68a656f1255c0f99016794c59fb7575c1d88
2021-02-26 04:08:52 +00:00
android-build-team Robot c71cfdb5bc Snap for 7171622 from d6844dcb7f to sc-v2-release
Change-Id: Ie5c8d490ba140e2393c6f875e4b4df6985d8d485
2021-02-26 03:38:31 +00:00
android-build-team Robot f56acece7d Snap for 7171598 from d6844dcb7f to sc-release
Change-Id: I82eb6c2b619ae4b3b5df4de5a96479aecba39a9f
2021-02-26 03:38:21 +00:00
vadimt 6e2a8e86df Diagnosing expected selector in app-start
Test: manual
Bug: 179392551
Change-Id: I4c7173e784caaa6435927f94eef6b269884d0ce9
2021-02-25 19:32:41 -08:00
vadimt 5f21f104f0 Waiting for the state of views to settle after orientation change
Presumably, we currently have flakes when immediately
after orientation change, we check for the presence of certain
views, and they are still not present.

Test: presubmit
Bug: 181057446
Change-Id: I6dbcb757a47c19728d4096283da6710f6dd5aa02
2021-02-25 18:50:49 -08:00
Zak Cohen 452005a14e Update ArrowPopup to accommodate more rounded dialogs.
Adjusts layouts to accommodate more rounded dialogs, includes adding a
new rounded triangle drawable that can be clipped by a rounded rect.



Bug: 179922117
Test: checked all instances and RTL
Change-Id: I4c2f0ead0fd56eba14ffd9b82f0c100f7d92ef5b
2021-02-25 16:59:55 -08:00
Jon Miranda e126d72fa8 More grid changes, closer to final specs.
* Added isScalable, minCellWidth, minCellHeight, and borderSpacing attrs

When isScalable is true, we use set workspace cell values to
minCellWidth/minCellHeight and then scale the cell values to
fit the available space. This allows us to have consistent
aspect ratios when two devices match the display/grid options.

This is different from the dynamic grid, which calculates
cell values based on iconSize/textSize/etc and then allows
the cell width to be as wide as space allows.

I adjusted some variables so that they will auto adjust
based on another value, indepenent from whether the
grid isScalable or not. An example of this is the folder
label text, where it's always set to be 1.14x of whatever
the workspace icon text size is. This is so we don't need
to add a bunch of more variables to DisplayOption/GridOption.

Bug: 175329686
Test: - switching between device profiles,
      - testing folder open/close
      - testing in multiwindow
      - testing in landscape
Change-Id: Ia469ae0d65b518469ef264b726db46f4a3210056
2021-02-25 17:34:56 -05:00
Andy Wickham 4aeb5216cc Merge "Revert "Changes ENABLE_SMARTSPACE_ENHANCED to be a DeviceFlag."" into sc-dev am: d6844dcb7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13700879

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6a2bfabd40a441ee4c442e67bae24f51f86dab99
2021-02-25 21:44:48 +00:00
Andy Wickham 87fab748b1 Merge "Revert "Changes ENABLE_SMARTSPACE_ENHANCED to be a DeviceFlag."" into sc-dev am: d6844dcb7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13700879

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ifb91337c115407014e72b6f273d1ace6655f5a2c
2021-02-25 21:41:53 +00:00
Andy Wickham d6844dcb7f Merge "Revert "Changes ENABLE_SMARTSPACE_ENHANCED to be a DeviceFlag."" into sc-dev 2021-02-25 21:02:34 +00:00
Andy Wickham 0779f74049 Revert "Changes ENABLE_SMARTSPACE_ENHANCED to be a DeviceFlag."
This reverts commit f480a87423.

Reason for revert: Broke tests

Change-Id: I508e1db58b7973a60e350aa679b9b6f5fe4ecbd1
2021-02-25 20:06:08 +00:00
Evan Rosky 2341776fd8 Merge "Update input-monitors to accept unrotated coordinates" into sc-dev am: be5fdb08a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13486583

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ia47dd2ccb584f48a385910455e975cdd2d0e0997
2021-02-25 18:20:51 +00:00
Evan Rosky aa15ec0897 Merge "Update input-monitors to accept unrotated coordinates" into sc-dev am: be5fdb08a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13486583

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I44709c7c8ed00bd8e4fd5f82916d12cb2669acba
2021-02-25 18:20:39 +00:00
Evan Rosky be5fdb08a5 Merge "Update input-monitors to accept unrotated coordinates" into sc-dev 2021-02-25 17:53:57 +00:00
Alina Zaidi 331140f665 Refactor SearchAlgorithm and SearchCallback interface to work on generic search result type.
Test: Manually tested that 'All apps' search works fine
Bug: b/157286785
Change-Id: Id4b7fb133149e9211f871b46b47d5853ec0e0050
2021-02-25 12:05:41 +00:00
android-build-team Robot 17bef2271a Snap for 7168803 from dfbb2a4883 to tm-release
Change-Id: If8a925a064d3fb6b19bcfaef499abe014d7478bc
2021-02-25 04:12:31 +00:00