PRD AD-11, the last buildable row of M4.
- FlexeraNotificationPreview keeps the text of the notifications that currently show a
dot, fed by Launcher3's NotificationListener on its worker thread, and sets a second,
smaller and dimmer line on a drawer row whenever the row's dot state is applied.
- It uses what the dots already use: the same notification access and the same filter
for which notifications count. Without notification access nothing changes.
- PopupDataProvider now refreshes an app's icons on every posted notification, so a
notification updated in place brings its new text to the row.
- Only rows of the drawer list take the second line (marked with a view tag); search
result icons share the "all apps" display type but stay as they were.
- New setting under Settings > App drawer: Notification previews, on by default.
Checked on the Android 17 emulator (debug build): a test SMS showed under Messages,
a second one replaced it while the drawer was open, removing the notification put the
plain name back, and the setting switches the line off and on.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Scrub from home (PRD AD-10)
- New setting, off by default: a vertical slide along the alphabet's edge of the home
screen opens the drawer and scrubs it in the same touch (FlexeraEdgeScrubController).
It claims a touch only once it has clearly moved up or down, and never during an item
drag. Nothing is drawn on the home screen.
Work profile (PRD AD-14)
- The Personal and Work tabs and the work info card were one icon wide, because their
width came from grid maths that assumes several columns. In the one-column list they
now line up with the search bar.
- The info card's own scroller section no longer shows up as a letter in the alphabet.
Navigation modes (PRD SI-2, AD-17)
- With three-button navigation, the controller that carries swipe up and hold stood aside
completely, so a hold did nothing there. It now takes the ordinary swipe up from the
home screen in that mode too.
Wave alphabet
- The list darkens under the wave where the letters cross icons and names: always from
the left edge, and from the right edge in proportion to how far the wave reaches in.
Release script
- -BuildOnly builds and checks the APK without publishing, so a version can be tried
first and then published with -SkipBuild.
Checked on the Android 17 emulator (debug build): work tabs at full width, scrub from the
home screen's edge, the search field keeping its background while typing. The
three-button change and the right-edge darkening were written after that build and are
not yet checked.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
PRD M3 (AD-4 to AD-6, AD-17), plus three look changes the owner asked for.
Wave alphabet
- WaveAlphabetView (flexera/src): a strip of letters on the drawer's end edge showing only
letters that have apps. Touching it jumps the list to that letter with a haptic tick; the
letters near the finger bulge away from the edge and reach further the further in the
finger moves; the selected letter is enlarged.
- The strip reserves the edge from the system back gesture and tells the drawer not to
drag closed under a scrub.
- Launcher3's scroll bar is hidden by default and no longer takes touches while hidden.
Swipe up and hold
- NoButtonNavbarToOverviewTouchController reuses its motion-pause detector on an ordinary
swipe up from the home screen: a pause finishes opening the drawer and hands the same
touch to the alphabet. Swipes that start on the navigation bar keep their stock meaning.
Look
- The drawer fades in over the home screen instead of sliding up from the bottom.
- No background panel or drag handle (drawer opacity default 0); the wallpaper keeps
Lawnchair's blur and scrim.
- App names, letter headers and alphabet letters are white with a soft shadow.
Tested on the Android 17 emulator: quick swipe opens the drawer, edge scrub jumps the
list, swipe up and hold opens the drawer and scrubs from mid-screen, Back closes it.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
PRD M2 (AD-1 to AD-3, AD-7, AD-8, HS-7). The drawer keeps Launcher3's adapter, sorting,
live updates, click, long-press menu and drag; only what differs from the grid is new.
- FlexeraDrawer (flexera/src): column count, row styling, and a letter-header adapter item
- flexera/res/layout/all_apps_icon.xml overrides Launcher3's grid cell with a horizontal
row (46dp icon, name beside it, 64dp tall)
- AlphabeticalAppsList adds a header item at the start of each letter group and points
the fast-scroll section at it; Private Space keeps its own framing
- BaseAllAppsAdapter creates and binds the header view type and styles rows
- DeviceProfileOverrides forces one drawer column
- DeviceProfile.getAllAppsIconStartMargin returns the row padding for a one-column
drawer, which keeps the search bar full width
- Suggested apps row above the list is off by default
Tested on the Android 17 emulator: scrolling, tap to launch, long-press menu, drag to the
home screen, and live removal and return of an app all work. The right-edge fast
scroller did not respond to scripted drags and still needs a hand test.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* feat and fix : Add Tilt to swipe pages setting
Replace the multi-level Motion controls with a single Home screen toggle named “Tilt to swipe pages,” positioned below Infinite scrolling. Update the description to explain that tilting the phone moves between pages while rearranging apps or widgets, and make the pan controller use the toggle directly while retaining the existing preference key for compatibility. Fix for "[BUG] Large empty gap between app drawer search bar and app grid when app suggestions are disabled
#7490"
* EDITS : Coderabbit suggested edits for PR #7500
* Coderabbit suggested changes (2) #7500
* Update gradle-daemon-jvm.properties
* Remove unrelated Gradle toolchain changes
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add docstrings for pan-to-move and all apps header changes
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add a tilt sensitivity control
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: don't crash at startup when the restriction bypass lib is missing
Unseal.unseal() loads ChickenHook's libnrb.so. Repackaged APKs and
multi-open containers can fail to load it, in which case the call throws
UnsatisfiedLinkError (an Error) that catch (Exception) does not handle. This
runs from Application.onCreate(), so the process crash-loops forever.
Catch Exception | LinkageError. A failed unseal only disables the hidden API
exemption for that launch; other Errors (OOM, etc.) still propagate.
* fix: don't crash reading allowEnterPip when the restriction bypass is broken
getAllowEnterPip() uses RestrictionBypass below SDK 35. If the native bypass
library failed to load, the bypass class is permanently broken and any further
access throws LinkageError (ExceptionInInitializerError on the first touch,
NoClassDefFoundError afterwards), which catch (ReflectiveOperationException)
does not handle.
Return false (PIP not allowed) instead of crashing the transition.
---------
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
mSettingsCache is only assigned in onListenerConnected(), but
onListenerDisconnected() unregisters from it unconditionally. The framework
calls onListenerDisconnected() from NotificationListenerService.onDestroy(),
so a service that is destroyed before it ever connects dereferences null and
kills the process.
Guard the unregister; the connected path is unchanged.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
getAnimationData() read itemsInPreview[0] to derive the base icon size. The
preview list can be empty when the folder has no bound child views yet, which
made opening the folder crash with an IndexOutOfBoundsException.
Fall back to the device profile icon size when the list is empty; the normal
path is unchanged.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
* fix(widgets): let the resize frame reach the screen edge horizontally
The resize frame is drawn resize_frame_background_padding (24dp) outside
the widget, but the horizontal drag range clamped the frame's outer edge
to the DragLayer. When the grid sits close to the screen edge (low
workspace/widget padding, many columns) the last column could not be
reached.
When the frame already overhung the screen edge (gap + widget padding
< 24dp, which is the default), the old range did not contain 0 (left
start positive, right end negative), so the first move event snapped the
frame up to 24dp inward on either side. With half-cell resize steps that
would be enough to drop a step.
Bound the widget's edge instead of the frame's, and keep 0 inside the
range so a touch without movement never moves the frame. The vertical
range is unchanged.
* fix(widgets): count the last partial resize step when the finger hits the edge
The finger cannot travel past the screen edge, and the handle can be
grabbed up to 24dp outside the widget. With little workspace/widget
padding, the travel left for the last column can then be shorter than
RESIZE_THRESHOLD of a step.
While a left/right handle is dragged and the finger is within
resize_frame_background_padding of that screen edge, a partial step of
more than 1 - RESIZE_THRESHOLD towards the edge counts as reached. That
threshold keeps the step from being undone right after it is taken, and
it only applies in the growth direction.
* refactor(widgets): shorten resize frame LC-Notes
Comment-only change: trim the edge-clamp LC-Notes in AppWidgetResizeFrame to one or two lines. No behaviour change.
createDatabaseHelper renamed restored.db to the IDP's dbFile but opened
the dbFile it was passed, from the DB_FILE pref. The Nova import writes
grid prefs before restoring, and hotseatColumns' reloadGrid listener can
move the IDP to an intermediate grid (e.g. launcher_6_4_5.db) first. The
restored layout then landed in a file that was never opened, the opened
file was created empty, performRestore sanitized nothing, and the next
start reset the "empty" database to the default layout. A second import
worked because the prefs no longer changed.
Rename into the file that is opened instead.
migrateDbName moves launcher.db to dbName when dbName doesn't exist yet.
With the restore now renamed into dbFile, a dbFile of launcher.db (the
5_by_5 grid) would be moved away and deleted before DatabaseHelper opens
it. Migrate first, then rename.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
SettingsCache observes hidden Settings keys — e.g.
hide_privatespace_entry_point, which ModelInitializer registers a
listener for. Since Android S, hidden settings keys are only readable
by system apps; a query from a third-party app throws
SecurityException.
3962597e6e fixed this for the read path by catching SecurityException
in getValue(), but the ContentObserver path was missed: when the system
writes such a key, onChange() calls updateValue() on the main-thread
handler and the launcher crashes.
Skip the cache update instead, mirroring the existing guard in
getValue().
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
On some OEM builds (e.g. Huawei EMUI on API <= 28), WallpaperManager
.setWallpaperOffsets() internally fetches the current wallpaper bitmap,
and WallpaperManagerService enforces READ_EXTERNAL_STORAGE on that
binder call. When the permission is not granted the call throws
SecurityException, which escaped setOffsetSafely() and fatally crashed
the launcher on every workspace page swipe.
Skip and log the offset update on affected devices instead; wallpaper
parallax simply stops updating there.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
getMultiWindowDisplaySize() calls WindowManager.getCurrentWindowMetrics(),
added in API 30, without a version check. Lawnchair runs down to
minSdk 26, so building the multi-window device profile
(Launcher#initDeviceProfile and the fallback RecentsActivity) throws
NoSuchMethodError on Android 8-10 devices in split-screen.
Derive the bounds from the default display size below R.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
VibratorWrapper.vibrate(primitiveId, ...) calls
Vibrator.areAllPrimitivesSupported() and builds a
VibrationEffect.Composition, both added in API 30, without a version
check. Lawnchair runs down to minSdk 26, so dismissing a task in
Recents — TaskViewTouchControllerDeprecated passes PRIMITIVE_TICK, a
non-negative id — throws NoSuchMethodError and crashes the launcher
on Android 8-10 devices.
Fall back to the plain fallback effect below R, mirroring the existing
ATLEAST_S guard in vibrateForTaskbarUnstash() and the ATLEAST_Q branch
that already builds EFFECT_CLICK.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
config_icon_mask is a framework resource that ROM overlays can replace.
When its value is not valid path data (seen in the wild with a line break
inside a coordinate), PathParser throws during Launcher onCreate and the
launcher enters a crash loop. Parse the mask defensively and fall back
to the platform default mask, mirroring the existing guard around
GenericPathShape in the same file.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
So that we can use the bounds to set on BackgroundBlurDrawable
Bug: 445467156
Test: manual in the next CL
Flag: EXEMPT BUGFIX
Change-Id: I002d9dfd1d1aabc90c5cd6097772103575d91de9
- Folder pages should not swipe out of bounds while opening
- Folder pages should be revealed if swiped in bounds while opening
- Closing the folder should not clip the preview icons
Bug: 458072199
Test: opening/closing/swiping a large folder
Flag: com.android.launcher3.enable_expressive_folder_expansion
Change-Id: I3773a9c79ec0e5efc24c0ac185a516353f955cec
Bug: 449923444
Flag: com.android.launcher3.enable_expressive_folder_expansion
Test: open folder and immediately swipe to next page
Change-Id: Iafa46f3748fdf0c1982b5de6df539b8c8609204f
Bug: 456164513
Test: manual - close app and quickly open folder
Flag: com.android.launcher3.enable_expressive_folder_expansion
Change-Id: I47886b034402549176f99618699ae90bd0356086
Bug: 452119282
Flag: com.android.launcher3.enable_expressive_folder_expansion
Test: use longpress on folder item and tap remove shortcut
Change-Id: Ia6e60189a74d731ed7a23ab74c144a228118a1d9
Bitmap.createBitmap(Picture) was only added in API 28, but Lawnchair
runs down to minSdk 26. Creating a folder drag preview on Android 8.x
therefore throws NoSuchMethodError and crashes the launcher.
Reuse the existing BitmapRenderer fallback on versions below P to
rasterize the recorded foreground Picture into a software bitmap.
Co-authored-by: caizhixing <17589399+caizhixing03@user.noreply.gitee.com>
Infinite scrolling kept a wrap state (target page, saved scroll bounds,
a cached feed flag) that every path out of a swipe had to tear down.
Paths that missed it caused the bugs: a short or backward swipe on the
last page wrapped anyway, the first page flashed when a layout pass
reset the bounds mid-wrap, touching during a wrap jumped to the target,
two-panel layouts got stuck between pages, and the page indicator lost
its active dot.
The wrap now follows from the scroll position alone: on an end that
wraps, the scroll may run one screen further, and the screen from the
other end is translated into that gap. Workspace decides which ends
wrap; other paged views behave as in AOSP.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(home): live glass blur behind icons, folders and widgets
Add an optional "Glass blur" setting that blurs the wallpaper behind home
screen icons, folder icons, open folders and widgets, like CSS
backdrop-filter. SurfaceFlinger renders the blur through blur regions
(a copy of the framework BackgroundBlurDrawable), so it stays live and
follows the items during page scrolls and animations.
SurfaceFlinger ignores all the blur of an app layer once there are more
than 10 blur requests on screen (kMaxBlurRequests, b/399120953), unless
the layer was created by a privileged process. With root, the regions go
to an effect layer created by the root helper and placed below the
launcher window content. Without root, they go to the window layer and
are subject to that limit.
Also fix RootHelperManager, unused until now: it reported root as not
available until a root shell had been created, and bound the root
service off the main thread.
* fix(home): redraw when a glass blur region is removed
Without a frame the pre-draw listener never sends the regions left, so a
removed blur, the last one in particular, could stay on screen until the
next redraw.
Home screen > Icon size (homeIconSizeFactor) had no effect on responsive
grids such as "practical": DeviceProfileOverrides scales the IDP's
iconSize, but responsive grids take their icon size from their cell
specs (mResponsiveWorkspaceCellSpec.getIconSize()) and never read
inv.iconSize.
getResponsiveIconSizePx() now applies the factor to the cell specs' icon
size, for the workspace, the hotseat and folder content, the same three
places the IDP-sized grids use inv.iconSize. The responsive code still
shrinks an icon that doesn't fit its cell (getIconSmallerThan). The icon
bitmap size already followed the factor, as the IDP computes it from the
scaled iconSize.
Visible change: on responsive grids the setting now works; at 100% (the
default) nothing changes.
(cherry picked from commit 6345b71df7dbd77be6c4da03ddcc76ebcadd2e90)
Co-authored-by: Claude <noreply@anthropic.com>
* fix(display): keep the device type stable across folds
LawnchairWindowManagerProxy estimated the supported bounds only from
DisplayManager#getDisplays, which reports the panel in use. On a foldable
the DisplayController cache then held a single state, so every fold and
unfold invalidated it ("Unexpected normalizedDisplayInfo found"), the
device type flipped between PHONE (folded) and MULTI_DISPLAY (unfolded,
through the hinge check), and CHANGE_SUPPORTED_BOUNDS reloaded the grid
and the model. The smaller dock of the phone profile also made the
loader delete the dock items past its size.
On devices with FEATURE_SENSOR_HINGE_ANGLE, the estimate now also holds
the other states of the internal display:
- WindowManager#getPossibleMaximumWindowMetrics, like
SystemWindowManagerProxy, when the system answers (it only does for the
recents provider) and the current state is one of its states.
- Otherwise each state of the default display seen on the device is
remembered. A state with the same aspect ratio replaces an older one,
so a resolution change leaves no stale bounds.
The extra states are built the way DisplayController.Info builds the key
it looks up (getDisplayInfo(context).normalize(), no-cutout default), so
the lookup finds them and folding no longer changes the supported
bounds. Once both panels are known they hold a phone and a tablet size,
and the device type is MULTI_DISPLAY in both states, across restarts too.
A hinge device never seen unfolded still reports PHONE: flip phones also
have the hinge sensor, so it can't be assumed.
The states are kept in their own device-protected file,
lc_display_states, not in boot_aware_prefs: DisplayController can run
before unlock, the values must not be backed up or restored on another
device, and the write happens while DisplayController is being
constructed. AOSP's taskbar-pinning listener on boot_aware_prefs calls
getInfo() for every change, which is still null at that point, so a write
to that file crashed the launcher when it started on the other screen
than last time.
The hinge check now lives in one place, LawnchairWindowManagerProxy
.isFoldable(), which DisplayController.Info uses as well.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit 14e6051ac83cba92cb371eec1c408966cb41ba9d)
* chore(display): log the device type once per info
getDeviceType() is called many times for each display change (once per
DeviceProfile and more), and logged its result every time. Log it once
per DisplayController.Info, that is once per display change, with the
current size, so the device type of each state can be read in logcat.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit 9fa57ec7e3d678c3e19d6ce1309ae11b893e18fc)
---------
Co-authored-by: Claude <noreply@anthropic.com>
* fix(fold): keep dock items past the hotseat size instead of deleting them
LoaderCursor#checkItemPlacement rejects hotseat items whose rank is not
below InvariantDeviceProfile#numDatabaseHotseatIcons, and checkAndAddItem
then marks them deleted like overlapping items, so they are removed from
the database. That size can shrink only for a while: on a foldable the
folded (phone) profile has a smaller hotseat than the unfolded one, and
folding once deleted the dock icons at ranks 4 and 5 for good.
Skip such items for binding but keep them in the database, so they show
up again once the hotseat is large enough. Why this is safe:
- Overlapping items (in bounds) are still deleted as before.
- Nothing can be placed at a rank past the current hotseat size, so a
kept item can't collide with a new one while it is hidden. If it ever
does, the regular overlap check deletes it when it comes back.
- Grid migrations are unchanged and run before the loader.
- Only top-level hotseat items are bound, so the contents of a kept
folder stay unbound with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit d556864ee08d0e2494f21a5fc3a9f00676f1269a)
* fix(migration): skip dock entries past the hotseat size (pre-existing crash)
Both solveHotseatPlacement versions (GridSizeMigrationDBController and
GridSizeMigrationLogic) mark the target's remaining dock items in an
array sized to the new dock: occupied[entry.screenId] = true. When the
target grid's database was last used with a larger dock, an entry's
rank can be past that size, and moving back to that grid with anything
to add to the dock throws ArrayIndexOutOfBoundsException. The Kotlin
path then aborts the migration; the Java path resets the target
database.
Such an entry takes no slot in the new dock, so it is skipped when
marking. Nothing else changes: the placement loop and every other entry
are as before.
Co-Authored-By: Claude <noreply@anthropic.com>
(cherry picked from commit f9bdf9e9eebd710a11281c066c5293b76d71d18c)
* fix(migration): also skip negative dock ranks in the hotseat guard
A corrupt database could hold a negative hotseat rank, which would still
index outside the array. Such an entry takes no slot either.
Suggested in review by CodeRabbit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
InvariantDeviceProfile.initGrid took closestProfile's folder arrays as
they were, and DeviceProfileOverrides then wrote the folder settings
into them. The folder sliders take their default from closestProfile
(numFolderRows/numFolderColumns[INDEX_DEFAULT]), so the default they
compared against was the value currently applied, not the grid
option's. Setting the value that was already current, e.g. releasing
the slider thumb without moving it, removed the key and the folder grid
fell back to the grid option's on that reload.
Copy the arrays instead. Nothing else reads closestProfile's folder
arrays: the profiles read the IDP's own arrays, and every initGrid
parses fresh grid options.
(cherry picked from commit 198724e42446611b204d0700e6630a82d0c10502)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The "Use multiple lines" setting of the app drawer shows in every
language, but AOSP only honoured it in English, so it did nothing for
other languages. Labels break at spaces, or between words in camel case
names, which works for other scripts too.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit fixes the infinite scroll wrap animation so it scrolls one page in the correct swipe direction instead of animating through all intermediate pages.