Commit Graph
8497 Commits
Author SHA1 Message Date
Steven Ng b0dca0f9b3 Merge "Refactoring before adding a new view type in the WidgetsListAdapter" into sc-dev am: fa58bfa0b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13519369

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ifc0ce9eccb6c47d49612bb6d1d2aa974b4ce8200
2021-02-11 02:08:17 +00:00
Steven Ng fa58bfa0b7 Merge "Refactoring before adding a new view type in the WidgetsListAdapter" into sc-dev 2021-02-11 01:06:11 +00:00
Adam Cohen b14a4c165b Merge "Draw the workspace scrim in the LauncherRootView instead of DragLayer" into sc-dev am: 12e547f2a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13463974

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I441e0b92a8e00821159e34a95899ee1ab3b4d9db
2021-02-10 23:44:13 +00:00
thiruram b16be229cb Fix to avoid NPE with LiveSearchManager. am: 91d4f9f007
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13546785

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Iee1335070081b11ddcf148be7179448f191e8f3c
2021-02-10 23:44:08 +00:00
Adam Cohen 12e547f2a8 Merge "Draw the workspace scrim in the LauncherRootView instead of DragLayer" into sc-dev 2021-02-10 23:33:06 +00:00
thiruram 91d4f9f007 Fix to avoid NPE with LiveSearchManager.
Bug: 179911188
Test: manual
Change-Id: Ic7f8ae7f7e2795eb18569670e166310102b7ea02
2021-02-10 23:24:32 +00:00
Steven Ng 2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
TreeHugger Robot 646d58a6ed Merge changes I0e4cedbf,Idfa1b82c into sc-dev am: 16126eedcd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13502882

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I907ccf4c44be7772fa3d6c76a767fac6b5cdc094
2021-02-10 21:04:58 +00:00
Adam Cohen 501e139c6e Draw the workspace scrim in the LauncherRootView instead of DragLayer
=> The entire DragLayer is translated during the -1 transition which creates a janky looking edge at the top of the screen

=> By bumping the scrim up a level, we avoid this

=> Separated WorkspaceAndHotseatScrim into two separate scrims, since only part of the scrim needed to be bumped up to a level. Further, it was an overloaded class.

=> We had previously been implicitly relying on the fact that the scrim was rendered in the Workspace parent; we need to make sure to propagate workspace inavlidations to the container of the scrim. While things would still work without this change, it's more correct to leave it, as we no longer assume a hierarchy for functinoality.

Bug: 178215332

Test: manual verification. See video in bug.

Change-Id: I0a76ddf35ceea8c9635367f69380ef24f42e9479
2021-02-10 19:16:26 +00:00
thiruram 217ee5eb0c [AA+] Add LAUNCHER_ALLAPPS_SWITCHED_TO_WORK_TAB & LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB events. am: 9aac07e87d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13496878

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib2c10c00ea98bdba7d8238b993657aae7c2a6daf
2021-02-10 18:32:36 +00:00
thiruram 03f8dcb8a4 Add instanceId to LAUNCHER_FOLDER_CONVERTED_TO_ICON log event.
Bug: 179534152
Change-Id: I0e4cedbfc2310258ec83f5dd756f8eb71189206b
2021-02-10 10:31:24 -08:00
thiruram 7823402ec9 Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
Bug: 179532038
Change-Id: Idfa1b82c35338a7472ff80d94fb20c69e498a028
2021-02-10 10:30:03 -08:00
thiruram 9aac07e87d [AA+] Add LAUNCHER_ALLAPPS_SWITCHED_TO_WORK_TAB & LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB events.
Bug: 178562918
Change-Id: I6ae1e034dc8fbbca6fa046104ab69c1ec9f4e6da
2021-02-10 18:02:46 +00:00
thiruram f898b6325e [AA+] Add LAUNCHER_ALLAPPS_KEYBOARD_CLOSED event. am: aafa8a44a3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13486540

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9e60a6ea5756bd7e12454810505e54071b299e18
2021-02-10 03:41:12 +00:00
thiruram aafa8a44a3 [AA+] Add LAUNCHER_ALLAPPS_KEYBOARD_CLOSED event.
Also adds Launcher.allAppsLogger method to simplify AllApps specific user events logging.

Bug: 178562918
Change-Id: I57520fe1504079091f0ff2c4c74268f727ffe14f
2021-02-09 16:45:52 -08:00
Thiru Ramasamy 847f0f1030 Merge "Fixes NPE with LAUNCHER_ALLAPPS_EXIT log event." into sc-dev am: 9012515fef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13532487

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I7ae847272dbfff919ca3ec20bdb6599f5a36e339
2021-02-09 23:52:41 +00:00
Thiru Ramasamy 9012515fef Merge "Fixes NPE with LAUNCHER_ALLAPPS_EXIT log event." into sc-dev 2021-02-09 23:37:17 +00:00
Sunny Goyal 0969693b33 Merge "Removing released features" into sc-dev am: 9fa3a07086
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13468029

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I55b7537c5fc1354a319ec2ba501ee66d424b55fd
2021-02-09 22:10:47 +00:00
Sunny Goyal 9fa3a07086 Merge "Removing released features" into sc-dev 2021-02-09 19:57:18 +00:00
thiruram 61620e7537 Fixes NPE with LAUNCHER_ALLAPPS_EXIT log event.
Bug: 179720471
Test: rnlt -until-error -t com.android.launcher3.ui.TaplTestsLauncher3
Change-Id: Ic8f91092aa060a2225c059a89a33b6877cf35f36
2021-02-09 10:52:11 -08:00
TreeHugger Robot f0146b72ed Merge "Enable variable size thumbnail for large screen" into sc-dev am: 823c5f8bf6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13427477

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I78354b5ae84c742eefcefe200dc8130a740df4c6
2021-02-09 12:32:48 +00:00
TreeHugger Robot 823c5f8bf6 Merge "Enable variable size thumbnail for large screen" into sc-dev 2021-02-09 11:26:33 +00:00
thiruram 223784cec2 [AA+] Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event. am: 73821a9c6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13501152

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I0dbe95908b2034fb3501d9001f8c15c6b19d9633
2021-02-08 22:11:19 +00:00
Alex Chau 7944ee5c79 Enable variable size thumbnail for large screen
- Introduced a feature flag
- Refresh TaskView size when thumbnail is refreshed or Recents resizes
- Disable edge scale down in large screens
- Added temp method to get task width/height ratio
- In fullscreen, scale down TaskThumbnailView and disable TaskView elevation
- Task boxing mechanism: http://screen/3NkePthAVUVH2Rv.png

Bug: 174464656
Test: Manually test overview and quickswitch for folded and unfolded, including with RTL.
Change-Id: I2ce24d588a246cc6a2408039a37d884021aa0800
2021-02-08 19:40:49 +00:00
thiruram 73821a9c6d [AA+] Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
Bug: 179529616

Change-Id: Id35c952c94d8a10743f147b194d3c27e22bc5062
2021-02-08 10:11:32 -08:00
TreeHugger Robot 9834e06b63 Merge "Enable slice again" into sc-dev am: fd03d04ae0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13490546

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I217744cee86bc38c439c04f8a73e6ac9ad4f0577
2021-02-08 09:16:49 +00:00
TreeHugger Robot fd03d04ae0 Merge "Enable slice again" into sc-dev 2021-02-08 08:55:00 +00:00
TreeHugger Robot d83a5c0019 Merge "After AA+Search Edu, bring up IME" into sc-dev am: bcf2ecc9e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13491648

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ifd1c4687cdc2529fb8e38d05f0739d792decab13
2021-02-08 01:39:33 +00:00
TreeHugger Robot bcf2ecc9e5 Merge "After AA+Search Edu, bring up IME" into sc-dev 2021-02-08 01:19:33 +00:00
Sunny Goyal a47a1c4509 Merge "Adding support for keyboard based drag and drop" into sc-dev am: 3186fbaed4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13460194

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I19bcb2bf7a074d3ed1f6a4c5f539f2d3afdf034b
2021-02-06 03:44:48 +00:00
Sunny Goyal 3186fbaed4 Merge "Adding support for keyboard based drag and drop" into sc-dev 2021-02-06 02:55:06 +00:00
Sunny Goyal a4647b681f Adding support for keyboard based drag and drop
For keyboard DnD, we use Accessible DnD implementation.
A placeholder FloatingView draws the focus indicator
for the virtual views

Test: Visible
Bug: 178781566
Change-Id: I632fc7377dffa1e05e3f0a9c3ad18641deb5a1a4
2021-02-05 13:05:24 -08:00
TreeHugger Robot 2bcf753745 Merge "Postponing registering widget listener" into sc-dev am: 1508e062e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13475349

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Idc2968f72257f62b1c728b087b38e926145de763
2021-02-05 20:20:16 +00:00
Sunny Goyal ead22a5257 Removing released features
Bug: 179224463
Test: Presubmit
Change-Id: I6aa989fa8e52398112cca2c7f4bed0ae69881f7b
2021-02-05 11:36:08 -08:00
TreeHugger Robot 1508e062e8 Merge "Postponing registering widget listener" into sc-dev 2021-02-05 19:23:29 +00:00
Thiru Ramasamy 44691c488d Merge "[AA+] Add LAUNCHER_ALLAPPS_ENTRY, LAUNCHER_ALLAPPS_EXIT events." into sc-dev am: 67171e2335
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13463978

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I154fa59e8bc8999395b76fa925f7acb04ec3dd65
2021-02-05 18:51:50 +00:00
Hyunyoung Song 681154e533 After AA+Search Edu, bring up IME
Bug: 179154570
Test: Manual

Change-Id: I2d010103dd37b84b3672ba0d6ff5897373991585
2021-02-05 00:29:06 -08:00
Hyunyoung Song da74a44511 Enable slice again
Bug: 179068415
Test: manual
Change-Id: Ib2e8d17d91488719eb439fd55c8b24e62338fc94
2021-02-04 20:57:59 -08:00
thiruram 4fc871f977 [AA+] Add LAUNCHER_ALLAPPS_ENTRY, LAUNCHER_ALLAPPS_EXIT events.
This would help us to define clear start and end events for AllApps sessions on the server side.

Bug: 178562918
Change-Id: I77f236c9bc1a21e868545b1309e47d91d6fc1d96
2021-02-04 16:48:07 -08:00
Sunny Goyal b02bf7e15b Merge "Moving slice loading on a background thread" into sc-dev am: b0bff050f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13473795

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I025fc20f5fe66b8ab3c4cab57ca6fdbc2ad97f30
2021-02-04 23:55:06 +00:00
Sunny Goyal b0bff050f2 Merge "Moving slice loading on a background thread" into sc-dev 2021-02-04 23:29:42 +00:00
Sunny Goyal 79e52fc23b Moving slice loading on a background thread
> Also fixing slice icon loading, such that the request is cancelled
  if views are recycled quickly
> Loading widget label on dg thread and cancelling request if views
  are recycled quickly.

Bug: 179068415
Test: verified locally
Change-Id: Id5a524e2bf596862330a8170394aef9ffd708544
2021-02-04 13:03:33 -08:00
Schneider Victor-tulias 8914f1dcc2 Merge "Fix icon flicker on transition from installing, to installed, to downloading incrementally." into sc-dev am: 2fd2694b9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13475165

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I1102de2535c89ce5cede92a7a6fe57036469910d
2021-02-04 18:43:45 +00:00
Schneider Victor-tulias 2fd2694b9c Merge "Fix icon flicker on transition from installing, to installed, to downloading incrementally." into sc-dev 2021-02-04 18:19:08 +00:00
Alex Chau edfb09bab3 Ensure isTablet is only enable when simulated landscape is disabled am: 4e2c25a788
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13472281

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9dd014c00a00602453327fe656f2fbd9f0685d0e
2021-02-04 11:44:13 +00:00
Alex Chau 4e2c25a788 Ensure isTablet is only enable when simulated landscape is disabled
- Tablet UI (e.g. grid overview and two panel workspace) is built with assumption that simulated landscape is disabled, make sure this is the case in DeviceProfile
- This is usually true as swDPs is generally smaller than sw used to determine xml files

Bug: 174464656
Test: Try different combination of smallest width and Display Size, isTablet is only set when allow_rotation is true
Change-Id: I3ee1c76909f29b6f14c4032be812bb8c9ea7e827
2021-02-04 11:24:06 +00:00
Tony Wickham d455bc44aa Merge "Add recent tasks to Taskbar" into sc-dev am: d10b587003
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13455072

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I3c0d21577eddf0b90aa4c87be8cdc2c318153f13
2021-02-04 07:00:44 +00:00
Tony Wickham d10b587003 Merge "Add recent tasks to Taskbar" into sc-dev 2021-02-04 06:30:37 +00:00
Tony Wickham aaa42bd0e8 Add recent tasks to Taskbar
- Also adds a divider between Hotseat and Recents
- Dedupes Recents from Hotseat

Test: Open some recent tasks, ensure they are deduped
from Hotseat and also handle < 2 tasks.

Bug: 171917176
Change-Id: Ia782c6ccbcda94cfd844aad04dc3d25a3f072c2b
2021-02-03 18:54:58 -08:00
Schneider Victor-tulias 1b4d5034fb Fix icon flicker on transition from installing, to installed, to downloading incrementally.
When an app finished downloading, we assumed that its progress level was 100%. This caused flicker in apps that supported incremental downloads. Added a check for the total download progress on app installation.

demo: https://drive.google.com/file/d/11NwwhHj_4rmDFwpsb8gTX-uA5YSinjSj/view?usp=sharing

Fixes: 178745816

Test: manual

Change-Id: I08328296db2ce2c2242fc4fe87158ff4b911c659
2021-02-03 16:39:16 -08:00