Commit Graph
6684 Commits
Author SHA1 Message Date
Ats Jenk 5dd9cffa5d Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev am: 1a8b95a9d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20483285

Change-Id: I02c2f8c040064ec5c0f304fc86d76199f799abe1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:21:15 +00:00
Brian Isganitis 5ff72eaa46 Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev am: 0ccbd7334c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20522179

Change-Id: I19f12060d771c4121642a5dbaf8ccdd291795a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:20:02 +00:00
Brian Isganitis 183f07e0da Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev am: 455eca41be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20514045

Change-Id: Iada41f7e36da2570cf285c6291de801a7f15597f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:19:09 +00:00
Schneider Victor-tulias 8b9090cc35 Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev am: b9e03da563
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20521649

Change-Id: Iaff26841709cacabfd6254e1e05c8a328eb36da9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:16:40 +00:00
Ats Jenk 1a8b95a9d4 Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev 2022-11-21 19:04:15 +00:00
Brian Isganitis 0ccbd7334c Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev 2022-11-21 19:04:04 +00:00
Brian Isganitis 455eca41be Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev 2022-11-21 19:02:44 +00:00
Schneider Victor-tulias b9e03da563 Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev 2022-11-21 19:01:04 +00:00
TreeHugger Robot 3ea711d992 Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886

Change-Id: I0a4f2a8755c49d230417c9b71afaa9ccd6ff410d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 18:49:35 +00:00
TreeHugger Robot d46450dd1f Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev am: 8700307b23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501358

Change-Id: Ie3cf43c96594bb0201678e189fd874a74535f4b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 18:49:07 +00:00
TreeHugger Robot 104517cefb Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev 2022-11-21 18:30:19 +00:00
TreeHugger Robot 8700307b23 Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev 2022-11-21 18:18:49 +00:00
Schneider Victor-tulias 1ba39205bc Fix NPE from using DeviceLockedInputConsumer after the surface has been released
Fixes: 243154747
Test: swipe up from camera app while device is locked
Change-Id: Ia92e3e3cccb37e0d14592b0f3094f5aba1073300
2022-11-19 12:26:34 -08:00
Brian Isganitis 4ff301eb9d Do not start drag from pre-drag if cancelled during animation.
This change affects the preDragCondition for icons that do not have a
popup menu. The condition assumes we are still in pre-drag after
DragView is finished animating, but the user can cancel the drag in this
time (e.g. by releasing their finger early).

Test: Manual. Holding and releasing on suspended icon does not crash,
while holding and dragging still works as expected.
Fix: 258233476

Change-Id: Ic76f785cffcbfe0fe51eb1473022f2dc34563070
2022-11-19 02:32:08 +00:00
Ikram Gabiyev 244d48097f Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev am: 793c37153a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20490352

Change-Id: I26e1675d9832f5c80c430450698a908e93951e1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-19 02:27:13 +00:00
Jon Miranda 0964f40f1f Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev am: e912742234
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470530

Change-Id: Ieb4dd888a30103985cc4a4aa10ce24824d8a41e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-19 02:27:02 +00:00
Ikram Gabiyev 793c37153a Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev 2022-11-19 02:19:25 +00:00
Jon Miranda e912742234 Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev 2022-11-19 01:58:37 +00:00
Sihua Ma 9af9ebcd2f Merge "Clear drag views during swipe up animation progress" into tm-qpr-dev am: 7b516983bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446856

Change-Id: Ib41e1a777127f4562d3f5c7dd4242f5d84fb62b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 23:41:19 +00:00
Sihua Ma 7b516983bc Merge "Clear drag views during swipe up animation progress" into tm-qpr-dev 2022-11-18 22:59:10 +00:00
Brian Isganitis c970bd5b61 Merge "Only allow one TaskbarRecentsAnimationsListener at a time." into tm-qpr-dev am: 543528594a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20067011

Change-Id: Id526d0dae17759e6268b9621d53b6b810dddbd13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 21:53:42 +00:00
Brian Isganitis 543528594a Merge "Only allow one TaskbarRecentsAnimationsListener at a time." into tm-qpr-dev 2022-11-18 21:38:58 +00:00
Hawkwood Glazier 3a93f9f5d4 Merge "Update PluginManager Import" into tm-qpr-dev am: d5ab17164d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20455291

Change-Id: Ia7c4699c1b2248582bc30afb930559e8bd3cb457
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 21:26:36 +00:00
Jon Miranda 7ae410b011 Merge "Fix home/overview threshold." into tm-qpr-dev am: e3bcc7bf40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511766

Change-Id: Ibbf9b180a26715787f9b3d1decb25fc7e8b96e35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 21:26:11 +00:00
Hawkwood Glazier d5ab17164d Merge "Update PluginManager Import" into tm-qpr-dev 2022-11-18 21:17:18 +00:00
Jon Miranda 08be3775f6 Prevent x-axis window movement during the initial swipe up to show transient taskbar
- If gesture starts and isLikelyToStartANewTask=true, we do not clamp
- If gesture starts and isLikelyToStartANewTask=false AND transient taskbar is not
  already showing, we clamp the scrolling

Bug: 258851206
Test: swipe up to show taskbar, no x-axis movement
      swipe left/right still works as expected

Change-Id: Iac194df63e03b4a28b49008983c88c165847aa31
2022-11-18 13:10:34 -08:00
Jon Miranda e3bcc7bf40 Merge "Fix home/overview threshold." into tm-qpr-dev 2022-11-18 21:02:01 +00:00
Schneider Victor-tulias e04a878709 Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."
This reverts commit a0be92c830.

Reason for revert: Bug fixed and logs are too verbose

Test: ran launcher and checked logs
Fixes: 244593270
Change-Id: Ia67ba96b0b2146308f9cad1df884144edf2ab186
2022-11-18 11:00:33 -08:00
TreeHugger Robot 1c3916daeb Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev am: 9b3aaf2b7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508312

Change-Id: Ief0f13b064472a37924ce7fe5c05adf8f35c23a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 17:21:57 +00:00
TreeHugger Robot 9b3aaf2b7d Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev 2022-11-18 16:45:30 +00:00
Jon Miranda 81e33a07d3 Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev am: 4b26e8f081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511769

Change-Id: If783c22198f860dee1e184040f3aa64dea9805e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 03:41:01 +00:00
Jon Miranda 4b26e8f081 Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev 2022-11-18 03:12:00 +00:00
Jon Miranda 21d4253c01 Fix home/overview threshold.
Fixes: 258836670
Test: Enable I06e16d78c179b7c3281f423ed8c7dd6cfc42229a to visually show
      thresholds on screen
      Swipe up to overview where taskbar not showing
      and also with taskbar already showing

Change-Id: Ie7487a5f869c0718d9ee08209dee8331a01d5989
2022-11-17 18:09:31 -08:00
Brian Isganitis 57a3312468 Merge "Add a11y titles for taskbar windows." into tm-qpr-dev am: 50b3b62eba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20239440

Change-Id: If23159090c979589410bd41a1c82ceb28e70582f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:00:04 +00:00
TreeHugger Robot ed37fabc9c Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156

Change-Id: I2a176b09a92ce02acd2a406f6647701098164328
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 01:57:55 +00:00
Brian Isganitis 50b3b62eba Merge "Add a11y titles for taskbar windows." into tm-qpr-dev 2022-11-18 01:56:22 +00:00
TreeHugger Robot 3a801de233 Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev 2022-11-18 01:44:01 +00:00
Brian Isganitis 424c7f4393 Still launch disabled item if we can't handle its click.
See where ItemClickHandler#handleDisabledItemClick returns false for
context. If we do not honor this return value, the framework will not
show a dialog in response to attempting launch the item.

Fix: 258232619
Test: Manual
Change-Id: Ie3b112eea17caf0a84defb331133bda9f3add5b6
2022-11-18 01:09:18 +00:00
Stefan Andonian b626411c99 Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860

Change-Id: I397957b5d9584aebf4182930763a2c5ab6401073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 00:17:45 +00:00
Brian Isganitis 9390b500a9 Only allow one TaskbarRecentsAnimationsListener at a time.
If another animation is created while one is occurring, we should clean
up the previous one.

Test: Manual
Fix: 233868461
Change-Id: Idf0e33ae95cbf19741ee943e450d478b1e18716b
2022-11-18 00:02:53 +00:00
Stefan Andonian 3233010c5a Merge "Move SharedPreferences code to its own class." into tm-qpr-dev 2022-11-17 23:46:26 +00:00
TreeHugger Robot 92924fca3e Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev am: 4059ff0a0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469952

Change-Id: Id803a2004f4574287a2d225ed67f30949e6731da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 23:27:22 +00:00
TreeHugger Robot 4059ff0a0c Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev 2022-11-17 23:03:31 +00:00
Jon Miranda 2049f3990a Use mContext instead of TaskbarActivityContex to enable transient taskbar.
Bug: 259586791
Bug: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ibb0a8e8539946f3a496318a6a9cf4b553693d790
2022-11-17 14:20:33 -08:00
Schneider Victor-tulias 383c950918 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev am: 193f8992f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20486066

Change-Id: I6200232bd2f266a365e8559ca060f0594052d797
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 22:11:05 +00:00
Ikram Gabiyev c06426164f Stash transient taskbar upon icon drag
Transient taskbar needs to be stashed upon
dragging the icon from it to create a
splitscreen.

Bug: 258850827

Test: manually reproduced the steps in the bug
Change-Id: I88f2b4b25cb4c12fbe7e646a8ed668921ef24ab9
2022-11-17 22:01:41 +00:00
Sihua Ma ff0f98dd03 Clear drag views during swipe up animation progress
This is to avoid clearing it too lately, at a point where the user starts to see a flicker on the screen.

There was already a report of this bug. Filing a bug report on my own because the original one is hard to find. I will mark that as fixed once I find it again.

Test: Manual
Fix: 259157574
Change-Id: Idc9bb67ebf6fc3ff6d78880f28c46d916a02ab77
2022-11-17 13:52:26 -08:00
Schneider Victor-tulias 193f8992f1 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev 2022-11-17 21:47:18 +00:00
Ats Jenk 4b4e4a39df Add onTaskMovedToFront to close floating views
Fixes a bug with allapps not being closed if the launching activity does
not trigger a onTaskStackChange callback. For example this is the case
when allapps launches a task in freeform mode. In this case the previous
task is still visible and won't be paused. The onTaskStackChange
callback is not triggered. Leaving the allapps view visible.

Bug: 259264346
Test: enable destop mode, open gmail, open allapps and open chrome,
  observe allapps view is closed
Change-Id: I5e60baa15ebc04b5094a84ed977eb9f3bc73d4a6
2022-11-17 13:09:19 -08:00
Brian Isganitis 61b01e2c2a Add a11y titles for taskbar windows.
Test: Manual with Talkback.
Fix: 228389333
Change-Id: If30311166fde155d04cf1c9a6865c98d380a93ea
2022-11-17 20:56:04 +00:00