Commit Graph
4893 Commits
Author SHA1 Message Date
Gina Ko 5b845d2831 Reapply "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
The revert was not supposed to be auto-merged.

This reverts commit 5a3bf93d82, reversing
changes made to 84f8002586.

Bug: 331384026
Change-Id: Ieb11a8544db90259aae856c4af805c37ce9e68cc
2024-03-26 15:03:31 -07:00
Liana Kazanova 5a3bf93d82 Revert "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26720630

Change-Id: I235f6d6263be6e39a583ac7b1a0783bfc77533c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-26 20:57:12 +00:00
Liana Kazanova 036a83cd99 Revert "Support toggling Taskbar All Apps with 3P Launcher."
This reverts commit 176f186a6d.

Reason for revert: DroidMonitor: Potential culprit for http://b/331438065 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ie375277ad2f65199749f0211ab50037d4b37e664
Merged-In: Ie375277ad2f65199749f0211ab50037d4b37e664
2024-03-26 20:34:09 +00:00
Sunny Goyal 62a11974fa Merge "Cleaning up some build configurations" into main 2024-03-26 20:00:51 +00:00
Vinit Nayak 926e03f5e5 Merge "Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-26 17:59:31 +00:00
Sunny Goyal 77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Jeremy Sim 46ca78ee78 Merge "Refactor how app pair icons draw" into main 2024-03-26 02:39:37 +00:00
Brian Isganitis 176f186a6d Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
(cherry picked from commit c113b277e6)
2024-03-26 01:16:39 +00:00
Treehugger Robot a8efc84122 Merge "Using xml override instead of code swap for predicted icon" into main 2024-03-26 00:53:37 +00:00
Jeremy Sim b37faec287 Refactor how app pair icons draw
This changes (and cleans up) the way app pair icons are composed. Previously, the background and 2 icons were drawn individually and separately onto the canvas. Now, they are composed into a combined drawable first. This also allows the full icon drawable to be requested by external functions (which will be needed for display app pairs in folder previews).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Visually confirmed that app pairs loooks the same in all scenarios: rotation, disabled, themed, taskbar, pinned taskbar. Screenshot test to follow.
Change-Id: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
2024-03-25 16:43:40 -07:00
Treehugger Robot 43879a7256 Merge "Handle widgets added with tap-to-add in AppEventProducer" into main 2024-03-25 23:25:39 +00:00
Sunny Goyal bd7ec3335b Using xml override instead of code swap for predicted icon
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I5ff52464b931630da003fb6aeff2a4fd9d2dd3b3
2024-03-25 15:18:48 -07:00
Schneider Victor-tulias 017af39acb Merge "Use the task background color in KQS when we are missing a thumbnail" into main 2024-03-25 21:31:50 +00:00
Schneider Victor-tulias 086758c821 Merge "Allow KQS to be reopened during the close animation for responsiveness" into main 2024-03-25 18:55:25 +00:00
Tracy Zhou e3720885c1 Merge "Revert "Hide task bar when folding before the new config renders the correct task bar"" into main 2024-03-25 17:39:07 +00:00
Schneider Victor-tulias 841734e091 Use the task background color in KQS when we are missing a thumbnail
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328686729
Test: forcibly used a null bitmap in dark/light modes
Change-Id: Ie5e106d6b0e69a60a77d065b945fe036c6dd9ef9
2024-03-25 13:26:35 -04:00
Schneider Victor-tulias fe7319ec40 Allow KQS to be reopened during the close animation for responsiveness
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 327421402
Test: quickly quick switched during close animation
Change-Id: I11dad62d11afd796aadf9b6165f0b4404f344311
2024-03-25 12:52:12 -04:00
Schneider Victor-tulias 081d6f4b59 Merge "Focus the first task after the desktop task when launching overview from KQS" into main 2024-03-25 15:25:50 +00:00
Tracy Zhou 4dbac6caa9 Revert "Hide task bar when folding before the new config renders the correct task bar"
This reverts commit dfb334f1e1.

Reason for revert: A bunch of WM fixes are in (b/291562764)

Change-Id: I9d08dab976cda112f802ee91256c09ef2026a01f
2024-03-23 19:35:50 +00:00
Vinit Nayak f1a832fa55 Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 541c5d272d.

Reason for revert: test still failing w/ revert https://android-build.corp.google.com/abtd/run/L66700030002678824/

Change-Id: If3ab4bb850ee519446e6cae4160ea6271049f83a
2024-03-23 00:51:00 +00:00
Sukesh Ram a47eff5e21 Merge "Revert "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-22 20:31:42 +00:00
Schneider Victor-tulias 5f14ec50dd Focus the first task after the desktop task when launching overview from KQS
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Fixes: 327420683
Test: opened overview using KQS
Change-Id: I9395ad6065844bf5f5007180cd8c3f80573ee473
2024-03-22 11:36:56 -04:00
Tiger 3a9c464eb3 Let taskbar can trigger insets resize animation
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"

Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
      InsetsResizeAnimationRunner.
Merged-In: I0d915422d160a81f12c3992ffe53200fd957f6d7
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
2024-03-22 07:36:34 +00:00
Tiger Huang d930eefefa Merge "Let taskbar can trigger insets resize animation" into main 2024-03-22 03:39:45 +00:00
Wei Sheng Shih c5a2e4bf03 Merge "Do not report finish in mergeAnimation..." into main 2024-03-22 03:30:20 +00:00
wilsonshih 7130116894 Do not report finish in mergeAnimation...
...if the handler don't know how to process the transition.
So the Transitions can pass that transition to next handler.

Flag: NONE
Bug: 328619216
Test: manual, use alt+tab to relaunch a task where it's activity
is destroyed.

Change-Id: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
2024-03-22 01:14:37 +00:00
Sukesh Ram 541c5d272d Revert "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 0adca26744.

Reason for revert: potential cause of presubmit failures

Change-Id: I102d92f86afc7fa21c806d3cf1642e343dc91d45
2024-03-21 21:25:30 +00:00
Ats Jenk ee7a069467 Merge "Set bubble bar alpha to 0 and collapse if it bubbles are hidden" into main 2024-03-21 17:15:45 +00:00
Alex Chau 59781a7d79 Remove DesktopTaskView.isDesktopModeSupported
- Use Flags.eanbleDesktopWindowingMode directly
- Also clean up unnecessary and improper flag usage

Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: presubmit
Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
2024-03-21 14:05:27 +00:00
Tony Wickham 3c58551e12 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-21 07:57:56 +00:00
Vinit Nayak 41e0e65bd4 Merge "Call setOverviewDragState() whenever taskbar is recreated" into 24D1-dev 2024-03-21 02:43:11 +00:00
Treehugger Robot 6a8662c560 Merge "Increase IME switcher Left Margins to meet spec" into main 2024-03-21 02:17:05 +00:00
Sukesh Ram aad306396e Increase IME switcher Left Margins to meet spec
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
2024-03-21 01:04:28 +00:00
Willie Koomson 2471805414 Handle widgets added with tap-to-add in AppEventProducer
Widgets added with tap-to-add do not emit an ITEM_DROP_COMPELTED event,
so this change updates AppEventProducer to check for
WIDGET_ADD_BUTTON_TAP event so that it can emit an ACTION_PIN
event for these widgets as well.

Also moves the stats logging for tap to add to after
Launcher.addPendingItem is called, so that the PendingAddItem's container
is set to CONTAINER_DESKTOP.

Bug: 323886237
Test: manual, add widget and confirm event is produced through logging,
 and widget no longer appears in suggestions
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add STAGING
Change-Id: Iaf46a408d05f61864a79f87b23160364b6513323
2024-03-20 22:07:02 +00:00
Vinit Nayak 5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Vinit Nayak 3b63408ad1 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
2024-03-20 19:42:03 +00:00
Ats Jenk 259552350e Set bubble bar alpha to 0 and collapse if it bubbles are hidden
Only set bubble bar alpha to 0 and mark it collapsed when bubbles are
hidden.
When bubble bar should be hidden due to system ui state, only update
visibility.

Bug: 324068295
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: trigger a buble from bubbles test app
  - swipe to home screen
  - observe bubble bar is shown
  - swipe notification shade down and away again
  - observe bubble bar is hidden when shade is open, and shown when
    closed
  - expand bubble bar
  - repeat swipe shade down and away, observe expanded bubble is hidden
    while shade is open and bubble is expanded when shade is swiped away
Change-Id: Icc717ab250061f14f02a558eb9f7301fdc08c5c7
2024-03-20 12:12:53 -07:00
Vinit Nayak e0c3403a9a Merge "Call setOverviewDragState() whenever taskbar is recreated" into main 2024-03-20 17:20:48 +00:00
Sihua Ma f0518bb89f Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
2024-03-20 16:58:00 +00:00
Eghosa Ewansiha-Vlachavas dc40eeae80 Merge "Disable quickswitch interactions with desktop mode" into main 2024-03-20 12:22:13 +00:00
Tiger 425aec696f Let taskbar can trigger insets resize animation
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"

Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
      InsetsResizeAnimationRunner.
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
2024-03-20 17:45:12 +08:00
Vinit Nayak 0adca26744 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
2024-03-19 17:30:33 -07:00
Federico Baron 7bd1fa82f6 Merge "Remove logspam for resolved bug" into 24D1-dev 2024-03-19 21:02:29 +00:00
Treehugger Robot 4d22811f76 Merge "Cancel animations after reading MotionPauseDetector#isPaused()" into main 2024-03-18 23:53:17 +00:00
Vinit Nayak 422a634a24 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-03-18 16:27:47 -07:00
Vinit Nayak c2a6055768 Merge "Launch overview instance of app for taskbar in Overview" into main 2024-03-18 23:21:23 +00:00
Brian Isganitis d1af1ec631 Merge "Support toggling Taskbar All Apps with 3P Launcher." into main 2024-03-18 23:17:55 +00:00
Vinit Nayak b761e9834e Launch overview instance of app for taskbar in Overview
* This only works for fullscreen tasks, app pairs aren't
properly launching yet
* We re-layer the leash to be above launcher since live tiles
are originally below
* The new task comes in from TaskAnimationManager#onTaskAppeared

Bug: 316485863
Test: Tested w/ tapping fullscreen apps in overview when
their thumbnail is scrolled off screen. Animation occurs for
both live tile and thumbnail

Change-Id: I5a3c079244a1517becb845ce25ff9f4e671383b1
2024-03-18 14:41:57 -07:00
Tony Wickham 77802d6da4 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
2024-03-18 19:11:57 +00:00
Liana Kazanova 7d5531757b Merge "Revert "Add CUJ Jank interactions for App Pair saving and launching"" into main 2024-03-18 18:39:20 +00:00