Commit Graph
87505 Commits
Author SHA1 Message Date
Treehugger Robot bd93d0d4d3 Merge changes If104c67d,Id59fb236 into main
* changes:
  [CD][Alt+Tab] Show apps from all desktops for KQS on CD
  [CD][Alt+Tab] Implement skeleton code for KQS on CD
2025-02-09 13:07:46 -08:00
Ajinkya Chalke 3ef91e087d [CD][Alt+Tab] Show apps from all desktops for KQS on CD
- Even without multiple desktops, apps that are moved to connected display show up in separate desktop task.
- Further changes may be required to launch a desktop after multiple desktops is implemented.

Bug: 382762871
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Test: manually built and run the CUJ
Change-Id: If104c67d95a1ec3de404998b06352edfa02c0f09
2025-02-09 19:06:54 +00:00
Ajinkya Chalke 4078347cbf [CD][Alt+Tab] Implement skeleton code for KQS on CD
- This change will not render KQS on connected display (CD) even with the flag ON as taskbars are not yet created for connected displays.

Bug: 382762871
Change-Id: Id59fb23630aaf0e74c35818f2a4ca56e5ef2e7bb
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Test: manually built and run the CUJ
2025-02-09 19:06:45 +00:00
Jordan Silva 9f56a1f793 Fix empty thumbnail/icon by re-fetching data from cache
Request data for all tasks in `TasksRepository` to prevent stale data. This ensures thumbnails and icons are not replaced and become null due to race conditions. The updated code requests data for all tasks, leveraging the cache for immediate returns.

Fix: 394384233
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Change-Id: I356de13b5e9671f50bb1c2680b54b78478fadc28
2025-02-09 05:29:45 -08:00
Lawnchair BotandCrowdin Bot 3e2b001c9e New Crowdin translations by GitHub Action (#5244)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2025-02-09 03:56:26 +03:30
Ben Lin 473bea410c Merge "Update DesktopMode config for test." into main 2025-02-08 10:47:56 -08:00
Charlie Anderson 4905defc6a Add flag for launcher iconography and font updates
Bug: 364950287
Flag: com.android.launcher3.enable_launcher_visual_refresh
Test: Presubmit
Change-Id: I8bb311cf282e1fa25c7517f405c9d637f0b9d99f
2025-02-07 20:30:43 -08:00
Vadim Tryshev 4d7e822181 Merge "Remove stale TODO." into main 2025-02-07 18:21:48 -08:00
Treehugger Robot b3ca33ee45 Merge "Refactor: Extract splash alpha logic from TaskThumbnailViewModel" into main 2025-02-07 17:30:46 -08:00
Treehugger Robot 628b37af3d Merge "Sort grid options in onegrid" into main 2025-02-07 14:48:16 -08:00
Vadim Tryshev a750726198 Remove stale TODO.
The TODO was added by an external contributor from the test org. The contributor is not available for the proper fix, so leaving the workaround as is.

Bug: 225505986
Change-Id: I4d94214f36a4d927546d87f01c924db82fbbe898
Test: presubmit
Flag: NA test code
2025-02-07 14:27:59 -08:00
Treehugger Robot ff1fbcf177 Merge "Reorder shape options, making sure that the default Circle is first." into main 2025-02-07 13:31:17 -08:00
Treehugger Robot d633c4774b Merge "Fix issue where turning off fixed landscape goes to default grid" into main 2025-02-07 13:16:16 -08:00
Jordan Silva a0c936b6ad Refactor: Extract splash alpha logic from TaskThumbnailViewModel
This commit updates how splash alpha is propagated to `TaskThumbnailView`. These changes reduces the usage of flows to handle animations to improve the performance by avoiding inherent overhead for sending messages between threads (go/sysui-flow-overhead).

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Test: TaskThumbnailViewModelImplTest
Test: TaskThumbnailViewScreenshotTest
Change-Id: I467da1a90b653fb108eb32534bc0dd2a67d95083
2025-02-07 20:52:37 +00:00
Treehugger Robot d74a33af5a Merge "Make AddDesktopButton can be navigated to through keys" into main 2025-02-07 12:33:46 -08:00
Treehugger Robot 2d906e472c Merge "launcher3: Gate strict mode enablement behind flag." into main 2025-02-07 12:32:39 -08:00
Charlie Anderson ceb401c3e7 Revert^2 "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit f5cb1b664b.

Reason for revert: adding test fix and reverting

Change-Id: I2fc8dc83259b2ee7992ac2291df6ee4246a2e9d5
2025-02-07 12:14:55 -08:00
Federico Baron 8d9d81e4b2 Sort grid options in onegrid
We need to make sure that the new grid options are sorted by column
count from greatest to least

Bug: 395086953
Flag: com.android.launcher3.one_grid_specs
Test: manually verified
Change-Id: I94fbf0fe74fa7dfc92afc64be92cdf511b79e763
2025-02-07 20:13:41 +00:00
Treehugger Robot 126566a096 Merge "desktop-exploded-view: Implement layout algorithm" into main 2025-02-07 12:00:23 -08:00
Treehugger Robot 795b36785e Merge "Initial Desks tracking on Launcher" into main 2025-02-07 11:53:55 -08:00
Brandon Dayauon b995cbe857 Fix shadow clipping in work FAB.
The reason is because the parent container having set clipped children
to true. It is already turned off for the fast letter scroll prototype
so we can probably just set to false all together.

Bug: 383299303
Test: manually-
before: https://drive.google.com/file/d/1GfJtmdX6RPi0QWlpjd1uBNGcDm_ePJko/view?usp=sharing
after: https://drive.google.com/file/d/1Lf6boBSeZ1ZcJ9M24S_JP6jzdUfov8kh/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I5060081f51a11dd34fd55afb75a5302759e16670
2025-02-07 19:24:59 +00:00
Daniel Norman da4d1d9f00 Merge "aconfig must have the same container with the declaration" into main 2025-02-07 11:10:45 -08:00
Charlie Anderson 4f23162f77 Reorder shape options, making sure that the default Circle is first.
Bug: 394885877
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verifying options
Change-Id: I85e9b56f6ede3b5a367e6833fa51ce5962f42883
2025-02-07 18:57:31 +00:00
minch b39d3015f8 Make AddDesktopButton can be navigated to through keys
Add the focus outline to the button as well.
Same color, ripple effect as the ClearAllButton is applied.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug:391875235
Test: TaskGridNavHelperTest
Change-Id: If93f86a1dce4df8ee6b1c50dfc44092dad2eafab
2025-02-07 18:33:23 +00:00
Xiaoqian Dai 3491fa49a7 desktop-exploded-view: Implement layout algorithm
It was ported over from ChromeOS Overview layout algorithm. In overview,
the layout is done in two stages:
1. Optimal height is determined. In this stage height is bisected to
   find maximum height which still allows all the windows to fit.
2. Row widths are balanced. In this stage the available width is reduced
   until some windows are no longer fitting or until the difference
   between the narrowest and the widest rows starts growing. Overall
   this achieves the goals of maximum size for previews (or maximum
   row height which is equivalent assuming fixed height), balanced rows
   and minimal wasted space.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: b:367353392, b:353948965

Change-Id: I1d0fd2b30ffa5bbc0853650884cf85b519be4227
2025-02-07 10:06:05 -08:00
Ahmed Fakhry c0597ac53b Initial Desks tracking on Launcher
This CL adds the initial implementation of the desks tracking
on the launcher side inside `DesktopVisibilityController`.

Bug: 392986431
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I7ece2407a03fec1cad4663efa230ec9a1980fb75
2025-02-07 17:49:36 +00:00
Treehugger Robot cdc1483f59 Merge "Append application name to content description for direct share targets" into main 2025-02-07 09:28:51 -08:00
Alex Chau 90fb4f883e Merge "Fix Home->Overview grid task not in top-right" into main 2025-02-07 09:28:31 -08:00
Vinit Nayak 7f6f7aad7b Re-use existing method to get split root
Test: Launching app pair from desktop, in-app,
overview from taskbar launches as expected
Bug: 372837890
Flag: EXEMPT bugfix

Change-Id: I50ab3cb1dc95a2cf20b77ae5d00cad3be7cd8e5c
2025-02-07 12:23:50 -05:00
Treehugger Robot bc37b2c46d Merge "desktop-exploded-view: Add some comments" into main 2025-02-07 09:00:07 -08:00
Mykola Podolian 7fa6b816e9 Merge "Added application shortcut extra to allow the Shell adding bubble." into main 2025-02-07 08:17:23 -08:00
Gustav Sennton dad84b4121 Merge "Only set task surface corner radius once in TransformParams" into main 2025-02-07 07:42:06 -08:00
Alex Chau ee082ce6e8 Fix Home->Overview grid task not in top-right
- Use expectedCurrentTaskView's position to calculate if we should add extra gap between clear all button, instead of using the right most task's position; this fixed the case where current task is not the right most task e.g. grid task and desktop task
- The accumulated row width to expectedCurrentTaskView is tracked in the udpateGridProperties loop, and used to calculate the position of the expected position of expectedCurrentTaskView from ClearAllButton
- With this new calculation we no longer needs to adjust longRowWidth when there are onlg large tile tasks

Fix: 391306182
Test: With and without grid-only Overview, test both home and app to Overview with 0-5 tasks with a desktop task; repeat for RTL
Flag: EXEMPT BUG_FIX
Change-Id: I324208c7e063c8b043815291cc0fef7beec884b6
2025-02-07 07:30:08 -08:00
samcackett d4d4d580da Append application name to content description for direct share targets
The direct share targets `label` will be the name of the receiving
device, so we also need to append the application name for a better
readout

Fix: 380008872
Test: MANUAL. Talkback on. Open an app with a url or image. Open Recents
. Select the url or image AiAi chip. Select the first direct share
target. Talkback should read the targets name and application name.
Share. App should dismiss.
Flag: EXEMPT bugfix

Change-Id: I3d7df44d239ae9b8a3a62b7343e65bcd6a2e9939
2025-02-07 15:25:59 +00:00
Charlie Anderson b97431394e Merge "Adjust predicted app icon to draw better inner stroke for shapes:" into main 2025-02-07 05:39:51 -08:00
Federico Baron 54b09dc41f Fix issue where turning off fixed landscape goes to default grid
Bug: 390091751
Test: manually verified on device
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id9de8cadc6fc1ee0ac0124638b2c487b8f8357bb
2025-02-07 09:22:42 +00:00
Gustav Sennton cbb7ecddfe Only set task surface corner radius once in TransformParams
When setting the corner radius constantly in TransformParams sometimes
we set the radius after the end of the recents transition, causing
Desktop tasks to have non-rounded corners at the end of recents
transitions.

Bug: 378657004
Test: manual + TransformParamsTest
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Change-Id: I2ae919424602d655d0995b4dc1951d96c7dfd3d8
2025-02-07 07:16:33 +00:00
Justin Yun 8b6d59f97b aconfig must have the same container with the declaration
com_android_launcher3_flags is in the system_ext container. Flags in
this declaration must have the same system_ext container.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I9a674fc91ab2114741480a118349102455aa6020
2025-02-06 20:23:49 -08:00
Treehugger Robot 026930cd14 Merge "Use pinned taskbar with desktop tasks on freeform displays" into main 2025-02-06 19:37:47 -08:00
Brandon Dayauon b30bb197d1 Fix focusability of web suggest via talkback
The reasson is due to shortcut flow not having sent an accessibility
event. Shortcuts adding to home can use the same flow of how apps are
added to home by using bindInflatedItems() with an animation
endCallback(). This change should be fine since addInScreen() is called
in bindInflatedItems() too.

Bug:383461209
Test:Manually video- https://drive.google.com/file/d/1y3CslaIvRQMsODlQCYnGtG0Im4t7p4rR/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I3b88b5ee40b4bcd43a83d362b6cbb0925120b700
2025-02-07 02:34:16 +00:00
Saumya Prakash 44daae3c06 Merge "Remove back button and enable back gesture on SUW" into main 2025-02-06 18:06:47 -08:00
Charlie Anderson c150eeb2e1 Adjust predicted app icon to draw better inner stroke for shapes:
Bug: 377938036
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verifying

Change-Id: Ib2c80f0db08bdd24fc6338bed3d666348d09037f
2025-02-06 16:26:50 -08:00
Charlie Anderson 2ffea06040 Merge "Resizes shaped icons based on selected shape" into main 2025-02-06 16:26:37 -08:00
Daniel Andersson 31191f8cee desktop-exploded-view: Add some comments
This adds some comments in DesktopTaskViewModel. There are no semantic changes.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: N/A
Bug: 367353392
Change-Id: I484bf4d0f094c5b87716022ffcd3db85d8b85ef7
2025-02-06 16:14:50 -08:00
MrSluffy 7bbd29094f fixed crash abstract method class on A10 2025-02-07 07:49:20 +08:00
Daniel Andersson 4899bc2c80 Merge "desktop-exploded-view: Initial implementation" into main 2025-02-06 14:51:31 -08:00
Saumya Prakash f6496357e2 Remove back button and enable back gesture on SUW
According to new spec, for devices that have a different theme, Setup Wizard
should no longer have the back button, and instead should use the back
gesture in between screens.

Fix: 349495243
Flag: EXEMPT bugfix
Test: Set the System property for setup wizard device theme to be expressive. Rerun setup wizard and ensure the back button doesn't show up and the back gesture works. For the existing theme, the behavior should remain unchanged.

Change-Id: I6b8e95f4eeecdf7422c9f1c099b30a4fc2d2fd12
2025-02-06 22:17:46 +00:00
Hongwei Wang 4d883c5b78 Update the comment on detach
With ag/31545168, it's no longer caller's responsibility to recycle the
bitmap being for overlay. Comment is updated accordling.

Flag: EXEMPT comment
Bug: 393584443
Test: N/A comment only
Change-Id: Idc9b01dc71cf4b15773a03272baa97f9821710f7
2025-02-06 14:01:58 -08:00
Charlie Anderson c902340594 Resizes shaped icons based on selected shape
Bug: 372905360

Test: Manual verify specs
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ia73fde0f493235004ed577738696c8be98a290f7
2025-02-06 12:32:47 -08:00
Fengjiang Li c324094762 Merge "[Memory Leak] Fix leak of TouchInteractionService from DisplayInfoChangeListener" into main 2025-02-06 09:49:27 -08:00