Commit Graph
87505 Commits
Author SHA1 Message Date
Treehugger Robot dad3394772 Merge "Fix LauncherPrefs crash by allowing sub-types of Set" into main 2025-02-28 16:49:02 -08:00
Toni Barzic a5c5536d7d Test all apps -> workspace drag for taskbar on home
Adds TAPL test that verifies users are able to drag app items from all
apps to workspace when all apps is opened on from a pinned taskbar shown
on the home screen, as may be the case when a desktop mode taskbar is
shown on home screen.

Adapts LauncherInstrumentation to handle the case where taskbar is shown
on home - when verifying launcher states, it sets taskbar visibility
expectations to account for a posibility that taskbar is visible in
home, or workspace states. Adds a request to the test protocol to
determine whether taskbar should be visible on home.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: Ran TaplTestLockedTaskbar tests
Change-Id: I40b06da70aaa49b0a3e0673797e6c18773a72238
2025-03-01 00:31:46 +00:00
Sihua Ma 2e964781ad Merge "Enable forced theme icon in Launcher3 tests" into main 2025-02-28 16:06:04 -08:00
Stefan Andonian c09f4d331a Fix OutlineProvider for PageIndicatorDots for new visual updates.
Bug: 394355070
Test: Verified locally that the active indicator is outlined properly.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ia8bd95285292c532f741707e446c83df01c3d540
2025-02-28 15:12:28 -08:00
Brian Isganitis fbe72436c8 Merge "Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE." into main 2025-02-28 14:58:30 -08:00
Shamali P aeeedc02cc [Part 3] Clean up references for flags from past release.
Cleans up the unfold 2-pane picker flag

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: I14a0f58cc25ba8984a1cd61a8453da5ddc57089b
2025-02-28 22:45:52 +00:00
Shamali P d5123be6d0 [Part 2] Clean up references for flags from past release.
Cleans up the tap to add flag.

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: Ifc7bb572ed93f36ebb7f7ae808d0e14bba020a2f
2025-02-28 22:45:52 +00:00
Shamali P c7b3ec241e [Part 1] Clean up references to flags from past release.
Cleans up the categorized suggestions flag.

Bug: 399933655
Flag: EXEMPT cleanup
Test: Screenshot tests
Change-Id: I6cbd1b4e912a51e7cfe50171424512300f2d783f
2025-02-28 22:45:50 +00:00
Charlie Anderson 4e4ad89696 Fix LauncherPrefs crash by allowing sub-types of Set
Bug: 396616795
Test: LauncherPrefsTest
Flag: EXEMPT bugfix
Change-Id: Id380a6e4bb5eb809978070ff1b523c9e98e6b869
2025-02-28 21:57:43 +00:00
Brandon Dayauon aa39accd49 Include multiuser flag to launcher3 dependency
Bug: 360313403
Test: mp Launcherd / Static import of the android.multiuser.Flag method
Flag: EXEMPT adding dependency
Change-Id: I1a234ce61550c12d65c6e682285ec357fe91b82a
2025-02-28 21:51:33 +00:00
Toni Barzic 26ad16592a Taskbar on home should open all apps that support drag to workspace
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
      drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
2025-02-28 21:31:46 +00:00
Federico Baron 66999f0a19 Add screenrecord for uninstallWorkspaceIcon
Bug: 399756302
Flag: EXEMPT TEST_ONLY
Test: TaplUninstallRemoveTest
Change-Id: I4bdf8087276a93f8f736c23ba95f35acb7f05c3a
2025-02-28 21:27:07 +00:00
Treehugger Robot d300486e66 Merge "Adding option to skip animations for testing" into main 2025-02-28 13:10:53 -08:00
Toni Barzic 8ca3eaa345 Arrows to scroll recent tasks in KQS
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
    Verify that arrow buttons are present; tapping them scrolls in the
    correct direction; when fully scrolled in a direction, the
    associated arrow button is disabled; verify arrow buttons have hover
    effects.
    Open Alt+Tab view, verify no buttons are present if the view cannot
    be scrolled (and present if the view can be scrolled).

Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
2025-02-28 19:49:50 +00:00
Ana Salazar Maldonado d4cce41c27 Fix tokens for App Contrast Pill
Bug: 397101795
Test: update screenshots
Flag: com.android.launcher3.enable_contrast_tiles
Change-Id: Iffe86d8b1bdebbf8ddab9dcfd6197ad24edb684f
2025-02-28 11:23:44 -08:00
Daniel Andersson 7250db2fee desktop-exploded-view: Calculate an accurate crop rect for desktop tasks
This change fixes crop rects on desktop tasks when exploded view is
enabled. The crop rect calculation now takes the current task rect
transform into account (which is used to position windows when exploded
view is enabled).

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392
Change-Id: I2b296a5065a5bc74c8ba884f2329081546b40ad0
2025-02-28 11:17:38 -08:00
Alex Chau 59e8c59ec6 Update gridTranslation of live tile when gestures ends
- Instead of updating in updateGridProperties, which will be re-run after dismiss and potentially apply wrong translations to live tile.
- Also set gridTranslationX of live tile to 0, as recentsScroll already takes care of horizontally task offest
- Guaded assigning RemoteTargetHandle to DesktopTaskView with enableDrawingLiveTile, so going to Home won't continue to mananages the TaskViewSimulator

Fix: 398231631
Fix: 394316748
Test: App to Overview with live tile on different location in the grid
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I2e0f83a55421279581f3632c16c1e4c41d1fdae6
2025-02-28 18:48:40 +00:00
Randy Pfohl 42405b2fa3 Enabling secondary deviceprofile creation in windowcontext
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window
      com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Iafb75840c4acadb35eb9e89810e9de61bbeda326
2025-02-28 18:14:02 +00:00
mpodolian 672a32a18b Removed fly-back animation after a taskbar item drop on the bubble bar
Added logic to track whether the drop target handled the app icon drop,
in order to prevent the fly-back animation in those cases.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Drop a taskbar icon onto the bubble bar. Observe that no
fly-back animation is performed for the dropped icon.

Change-Id: If439d7280fe9f713c181531ac899ac8ad37ed481
2025-02-28 10:01:13 -08:00
Justin Yun c237929450 Merge "Launcher3 is in system_ext container" into main 2025-02-28 09:40:25 -08:00
Orhan Uysal a7cd4f21d3 Merge "Change the misused logic" into main 2025-02-28 09:37:20 -08:00
Orhan Uysal 5e99882d75 Change the misused logic
Refactor from ag/31915496 was wrong. We should skip the transparent
activity tiles when there is a visible task already found not when
visible tasks are not found.

Bug: 397190111
Test: Enter any app, trigger circle to search, see only one tile
produced.
Flag: EXEMPT Bug fix

Change-Id: Ic19710a7d1f5be78e96aa5ac25553358732acf3b
2025-02-28 15:42:37 +00:00
Sam Cackett e0cc96df62 Add TaskContentView parent to TaskThumbnailViewHeader and TTV
- Add TaskContentView parent view
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

Bug: 397889146
Flag: EXEMPT. Refactor
Test: Refactoring CL. Existing unit tests still pass.

Change-Id: Ie31f35c6617aab272f984a6beb3e4cb8f58e3ce9
2025-02-28 12:19:26 +00:00
Nicolo' Mazzucato 6bccfb49c2 Propagate the display id with SysUIState changes to launcher
This changes the ILauncherProxy.aidl interface to also allow propagating the display id from SysUI to launcher for each SysUIState update.

The SysUI part of filling SysUI state correctly has not been implemented yet. But for now, only default display flags are propagated anyway.

On the launcher side, the sysui state is propagated correctly to each taskbar instance (there is one for each display)

Bug: 362719719
Bug: 398011576
Bug: 399371607
Test: LauncherProxyServiceTest
Flag: com.android.systemui.shade_window_goes_around
Change-Id: Ic9fa55ca82e4fe395a915c4d611afc8835c5d65d
2025-02-28 10:34:55 +00:00
renovate[bot] 5cd252f404 fix(deps): update dependency androidx.datastore:datastore-preferences to v1.1.3 (#5306)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-28 10:59:08 +08:00
Jon Miranda 7b7a73a7b6 Add bugfix flag for enable_taskbar_behind_shade
Bug: 343194358
Test: n/a this is just adding a flag
Flag: EXEMPT adding the flag
Change-Id: I3f1b1f958427a22bbbaab95da362397c5f79f1cd
2025-02-27 17:58:26 -08:00
renovate[bot] 4b99be4e81 chore(deps): update plugin com.google.devtools.ksp to v2.1.10-1.0.31 (#5310)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-28 09:37:38 +08:00
Andy Wickham 8cbe719df7 Fix NPE from navbar touch cancel without down.
TouchInteractionService sends a touch cancel when the screen turns
off, for example. So we shouldn't assume there was a touch down.

Fix: 398855863
Test: NavHandleLongPressInputConsumerTest#testTouchCancelWithoutTouchDown
Flag: EXEMPT bugfix
Change-Id: Ic1b6e981fe183864663bd44e1488d6f6749183bc
2025-02-28 00:51:42 +00:00
Xin Li 3848c51edb [automerger skipped] Merge 25Q1 (ab/12770256) to aosp-main-future am: 2ba372343b -s ours
am skip reason: Merged-In Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5 with SHA-1 9c58954488 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/31817467

Change-Id: I5c003fb2be8a103ed646a4d78dd08ed3f2b97dbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-27 16:45:05 -08:00
Brian Isganitis 8bab8eb171 Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE.
The invisible proxy view was preventing anything below it from being
accessible.

Flag: EXEMPT bugfix
Fix: 377526512
Test: #14 in bug.
Change-Id: I9d4596ebbbc4317a9ff7ded37b43b5fa1885e6ea
2025-02-27 19:41:48 -05:00
Treehugger Robot 1e8125c76b Merge "Merging some notification dots implementation" into main 2025-02-27 16:08:10 -08:00
Treehugger Robot 029b6016d2 Merge "Fixing widgets broken during reconfiguration" into main 2025-02-27 15:59:30 -08:00
Jagrut Desai 2ac4d9c794 Merge "Update Taskbar Icon content description to include state description" into main 2025-02-27 15:47:09 -08:00
mpodolian c666b9587b Added BubbleBarLocation drop target.
A drop target for the BubbleBarLocation has been added. This
implementation enables the Launcher process to handle application
drag-and-drop actions onto the bubble bar.

Known issues:
1) Upon dropping, the dragged icon animates back to its original taskbar
position from the top-left corner.
2) The expanded view drop target is not presented.
3) When an icon is dropped on the opposite side of the bubble bar, the
resulting location does not change, even though the drop target is
correctly displayed.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Navigate to the overview screen, drag a taskbar icon to
the left or right side, targeting the bubble bar drop zone. Verify the
drop target's appearance. Then, drop the icon and observe that a new
application bubble is added.

Change-Id: I0f64a664620959f2503ac3fd711476b354a09348
2025-02-27 14:32:32 -08:00
Treehugger Robot 8459313c57 Merge "Converting LauncherBindableItemsContainer to kotlin" into main 2025-02-27 14:07:03 -08:00
Treehugger Robot a708bee45b Merge "Fix jumpcuts in folder background color when opening/closing" into main 2025-02-27 14:01:50 -08:00
Alex Chau ee1bae7d72 Merge "Multi property refactor" into main 2025-02-27 13:41:07 -08:00
Treehugger Robot 9a5cd11da5 Merge "Move MainThreadInitializedObject to Launcher3 Go." into main 2025-02-27 13:03:12 -08:00
Charlie Anderson f22128e5f4 Merge "Make ModelTestExtensions default to process userhandle for HSUM" into main 2025-02-27 12:59:26 -08:00
Treehugger Robot a557c6e9c4 Merge "Handle dismiss in land/seascape." into main 2025-02-27 12:58:25 -08:00
Sunny Goyal fc2735ed96 Fixing widgets broken during reconfiguration
Async widget inflation may complete after the updates have been deferred,
leading the widget to a broken state.
Reapply widget if its root content changed while deferred

Bug: 375442765
Bug: 327696338
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I78d0f4ce92ee9bd2ee001de3a0e181f2e727218c
2025-02-27 12:36:15 -08:00
Justin Yun 29b75b5249 Launcher3 is in system_ext container
As Launcher3 is installed in system_ext, com_android_launcher3_flags
is in the system_ext container. Aconfig flags must set the same
container with their declaration.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I433756dda120de253909db663a6ecfd47d26c65d
2025-02-28 05:29:09 +09:00
Shamali P 94e276c1c5 Fix home screen page description when removing an existing page.
When we remove an in-between or last empty page, we manually set the
current page but don't update the description that's set on the
accessibility view. Due to which, when talkback focuses on it, it sees
the stale page count in the description.

This fix ensures to keep the state updated during removal.

Bug: 390360063
Fix: 390360063
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: Idd9a54d3a1ee43e56f51db78e614776eca6a12f7
2025-02-27 12:16:23 -08:00
Charlie Anderson 4ac496c510 Merge "Make Folder preview items appear as square grid instead of circle" into main 2025-02-27 11:49:43 -08:00
Treehugger Robot 3bb5996590 Merge "Removing unnecessary isBindingItems method from ActivityContext" into main 2025-02-27 11:32:53 -08:00
David Saff b9fabb10dd Rename to uiautomatorhelpers
Bug: 376676853
Change-Id: I2d3f4e259da721336b0736abc45d393f0dd9145a
Test: AppWidgetsRestoredReceiverTest
Flag: TEST_ONLY
2025-02-27 11:26:52 -08:00
Sihua Ma 4160ad3967 Fix jumpcuts in folder background color when opening/closing
Background drawable is not associated with any folder view, and as a
result invalidating the drawable doesn't cause it to be redrawn on the
screen

Fix: 392617057
Bug: 399674389
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I6d2bd97f66b53cdbeb4a715e53ff89b3450546f0
2025-02-27 18:48:51 +00:00
Sunny Goyal d237c9587b Converting LauncherBindableItemsContainer to kotlin
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I4d2fa18b6b275742d84de16ed604987c2deee6e8
2025-02-27 10:34:37 -08:00
Alex Chau 9b1c812217 Remove commented block in testOverviewForTablet
- The block of code is no longer failing

Fix: 308841019
Test: testOverviewForTablet
Flag: EXEMPT TEST_ONLY
Change-Id: Ibf2bd7b5ff8c0814d803bc519814072fe1421540
2025-02-27 18:23:16 +00:00
Jagrut Desai 536097dec2 Update Taskbar Icon content description to include state description
This cl inlcudes: while user is in desktop mode, we will add state description(active, minimized) of each app icon to it's content description.

Test: Manual
Bug: 397555157
Flag: EXEMPT bugfix
Change-Id: Iaec18e7099108e8b076b76c637a41e29ed837265
2025-02-27 09:58:31 -08:00