Commit Graph
87505 Commits
Author SHA1 Message Date
Sam Cackett bca368924c Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit 1048b2711c.

Reason for revert: Reland CL with fix

Original message:
Inflate TaskThumbnailViewDeprecated as TaskContentView

If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Bug: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug

Change-Id: Ib43331023d99316c7b0c9de2ab81e379db58bb50
2025-03-19 10:05:25 -07:00
Sebastian Franco c7151f6559 Swap hotseat padding when LTR and in Fixed Landscape
Fix: 404421611
Test: DumptTests
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iba1a19f13d1e8ce164ca4f5b9306c7cdca369814
2025-03-19 09:52:04 -07:00
Uwais Ashraf 376885f8ba Merge "Remove BubbleBarViewAnimatorTest from deviceless suite." into main 2025-03-19 09:26:30 -07:00
Alex Chau ddc72547d4 Merge "Correct the call of getExpectedCurrentTask" into main 2025-03-19 07:55:32 -07:00
Pat Manning d6027ed5a6 Add debug logging for task view touch controllers.
Proguard should remove these logging paths from user builds.

Bug: 350398650
Test: Manual. Verify logs are present.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ie1d1532782c443672cde5c5dfe1ccaa49e100cd3
2025-03-19 14:32:56 +00:00
Jordan Silva e3437e4f12 Merge "Fix Chip menu expanding outside the screen" into main 2025-03-19 07:00:27 -07:00
Pat Manning 28b827b489 Add flag to gate checking last task visibility on dismiss.
Bug: 404203362
Test: Manual. Open 9 apps, dismiss all bottom grid tasks, dismiss first top task, observe no jump.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ie21d234f6a44c4566c4f73d4cc3c32f6a8375e6d
2025-03-19 13:44:56 +00:00
Will Osborn b307f55a19 Merge "Small fixes for per-display TaskAnimationManager" into main 2025-03-19 06:23:32 -07:00
Treehugger Robot 8b312ff5bb Merge "Refactor: Use AppChipStatus enum instead of isExpanded boolean" into main 2025-03-19 06:19:44 -07:00
Uwais Ashraf 6aa9820532 Remove BubbleBarViewAnimatorTest from deviceless suite.
This test is the leading cause of flakiness for the entire suite.

Bug: 404773413
Flag: EXEMPT test-only
Test: BubbleBarViewAnimatorTest
Change-Id: I7c5658ad55aa0e959e068e5979325d1c41d18310
2025-03-19 12:41:19 +00:00
Simon (Qiong) Sun a2aa9edc02 Update Split-Screen icons with new icons.
Bug: 379959026
Test: Check that Split and save Split-Screen icons.
Flag: EXEMPT icons change
Change-Id: Idbc9d391b99a4e9833fd9ced597be22e15a77768
2025-03-18 23:28:33 -07:00
Jaewan Kim 772267281e Merge "Declare android.intent.action.ALL_APPS explictly" into main 2025-03-18 22:24:04 -07:00
Toni Barzic c2cb80434f Hide scroll arrows from Alt+Tab UI
Recent recommendation from UX was to hide scroll arrows from
Alt+Tab UI, as the primary use case is keyboard focused.

Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Verify that arrows are visible when KQS is opened from taskbar
      overflow button (when there's enough items to make KQS
      scrollable), and invisible when triggered using Alt+Tab shortcut.
Change-Id: Iaab234aca94d262b8151a680a08d10d6b39054ed
2025-03-19 03:26:38 +00:00
Treehugger Robot 445e12fdb5 Merge "Update Workspace App Icon Long-Press Menu's Text to Google Sans Flex" into main 2025-03-18 15:38:27 -07:00
Brandon Dayauon 8af853ab60 Change A-Z font to GSF for app icons and PS header
Used com.android.launcher3.gsf_res flag to control font changes in
launcher. Tested font changes manually only to App icons, PS header, and
PS lock text.

bug:393609630
Test: manually:
AA and flag Off: https://hsv.googleplex.com/6005345892696064
AA and flag On: https://hsv.googleplex.com/5713302612082688
AA and flag Off w/ TwoLine: https://hsv.googleplex.com/6604407931142144
AA and flag On w/ TwoLine: https://hsv.googleplex.com/5006326877913088
PS and flag off: https://hsv.googleplex.com/6253491923189760
PS and flag on: https://hsv.googleplex.com/4909373317971968
Flag: com.android.launcher3.gsf_res

Change-Id: Icae71ae648340ac566a908648eae14985b6aa4d3
2025-03-18 22:24:48 +00:00
Saumya Prakash 272d624500 Shift to using SUW System property flag for expressive theme
This change migrates the gesture tutorial to use the SUW system property
for if the expressive theme is enabled. This way the SUW team can better
control the overall flow of SUW instead of changing our team flag.

Fix: 402386083
Test: Check that the new theme is only applied in SUW when the system
property is set.
Flag: com.android.wm.shell.enable_gsf

Change-Id: Ibec41fc3bde9466f0ba5c0fd40173a8956abbb73
2025-03-18 14:25:50 -07:00
Treehugger Robot 91a790754b Merge "Only accessing mListeningHolders on main thread" into main 2025-03-18 13:23:12 -07:00
Bill Yi d969740d16 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I450bc0c0695f48466f4b55ccb7a7bbc787a1fe99
2025-03-18 12:49:35 -07:00
Bill Yi 32620dc76e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia2840059c31992a7dd3cb99b06230db19bef83dc
2025-03-18 12:48:43 -07:00
Stefan Andonian 00cde3149b Fix PageIndicatorDots Outline
Invalidate the outline when a Folder or WidgetPicker's PageIndicatorDots
become visible with 0 scroll. Necessary to avoid stale Outlines which
appear as grey shadows.

Bug: 394355070
Test: Verified manually that this works well, and looks great in LTR mode and RTL mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I3e730b1109b9cd05e25454865f7e97df2078725b
2025-03-18 12:38:41 -07:00
Tony Wickham 1588bb1a57 Merge changes I1b67d065,Ib2e7f859 into main
* changes:
  Don't show hover tooltip while an app popup is open
  Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
2025-03-18 11:38:05 -07:00
Treehugger Robot 1c0d0fa376 Merge "Remove FLAG_SPLIT_TOUCH from launcher code" into main 2025-03-18 11:37:17 -07:00
Pat Manning 81b6d25bb8 Merge "Prevent jumping to last grid task when not visible." into main 2025-03-18 11:22:34 -07:00
Jordan Silva d2e930bbb7 Fix Chip menu expanding outside the screen
This CL removes isLandscape condition from menu translation that
prevents Comet to translate the menu with split app. The menu needs to
be translated when in split screen mode, regardless of orientation.

Fix: 404549940
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: I5e4d07a9f1d2e36b847808aec9ae348a7ef78f59
2025-03-18 11:18:55 -07:00
Pat Manning 337b3ea7b0 Merge "Play haptic after dismissal even if no neighbors spring into place." into main 2025-03-18 11:10:16 -07:00
Pat Manning f3ef4e9961 Merge "Prevent multiple competing dismissals." into main 2025-03-18 11:04:47 -07:00
Liana Kazanova (xWF) defa140c20 Merge "Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-18 10:04:13 -07:00
minch 683c68af39 Correct the call of getExpectedCurrentTask
Bug: 401582344
Flag: EXEMPT bug fix
Test: m
Change-Id: I683be73a6632ba719396d44454a8650bbee7267d
2025-03-18 09:57:52 -07:00
Liana Kazanova (xWF) 1048b2711c Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bba7e8af37.

Reason for revert: DroidMonitor: Potential culprit for http://b/404515699 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Iadb65f37b9712c3d6e5943847520ca3bd76624c7
2025-03-18 09:26:32 -07:00
Will Osborn 1f5a92ed1a Small fixes for per-display TaskAnimationManager
Test: locally tested on Tangor
Flag: EXEMPT bugfix
Bug: 402362875
Change-Id: I37d3f563c30b019de8b43896b94a599c836f0dac
2025-03-18 16:15:28 +00:00
Jordan Silva f41ec597ef Set the elevation for TaskMenuView when overview icon menu is enabled.
Bug: 317007147
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Change-Id: I7c8b0a181e39bdf2d2048b87d6ceecf2b95e3265
2025-03-18 15:13:38 +00:00
Pat Manning 9fdc7032ba Play haptic after dismissal even if no neighbors spring into place.
Currently haptics will play as the neighbors reflow into place, but if none reflow, we also want a haptic to fire.

Fix: 398198796
Test: Manual. Dismiss end task so none move, feel haptic play.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I467a45472992722bcd05ef31cbaeb157441c4931
2025-03-18 15:10:53 +00:00
Jordan Silva 6c25c4dce3 Refactor: Use AppChipStatus enum instead of isExpanded boolean
- Replaced the boolean `isExpanded` flag in `IconAppChipView` with an enum `AppChipStatus` for better state management.
- Added `AppChipStatus` enum with `Expanded` and `Collapsed` states.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ibbf8ccd963e540f5bd766569a1df01ad1bafd4c0
2025-03-18 14:51:45 +00:00
Treehugger Robot 99ef00bfb9 Merge "Launcher EditMode DropTargetButton Titles -> Google Sans Flex Font" into main 2025-03-18 07:22:53 -07:00
Treehugger Robot 1f500d3cd3 Merge "Inflate TaskThumbnailViewDeprecated as TaskContentView" into main 2025-03-18 05:35:14 -07:00
Pat Manning 832f178138 Prevent jumping to last grid task when not visible.
Fix: 404203362
Test: Manual. Open 9 apps, dismiss all bottom grid tasks, dismiss first top task, observe no jump.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I11058b90b7d8c90256329849554886d652624926
2025-03-18 12:26:41 +00:00
Treehugger Robot 2152c302fd Merge "Update HomeSettings Font to Google Sans Flex" into main 2025-03-17 19:53:32 -07:00
Treehugger Robot e5cebbd9ca Merge "Do not notify desk mode changes on visible desk tasks count changes" into main 2025-03-17 18:29:02 -07:00
Stefan Andonian 031188dd0a Update Workspace App Icon Long-Press Menu's Text to Google Sans Flex
Bug: 393615290
Test: Verified via hard-coding flag to be true that fonts were correctly updated.
Flag: com.android.wm.shell.enable_gsf
Change-Id: I9ff1405356a4ceb2930b09f27e973e4cacb72d2e
2025-03-17 17:56:31 -07:00
Tony Wickham 88a9e18f7c Don't show hover tooltip while an app popup is open
Flag: EXEMPT bugfix
Test: TaskbarHoverToolTipControllerTest
Fixes: 397243128
Change-Id: I1b67d065e9e79e13a5a341a5d133da700ef5f40c
2025-03-17 22:36:27 +00:00
Tony Wickham 131c68b11b Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
This means we are now testing real objects instead of mocks

Test: TaskbarHoverToolTipControllerTest
Fixes: 346394827
Flag: EXEMPT bugfix
Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
2025-03-17 22:34:32 +00:00
Stefan Andonian ab55ee3e7d Update HomeSettings Font to Google Sans Flex
This will update everything in Launcher Home Settings except the At a Glance Dialog. That will be updated in a different CL. Also, the At A glance and Notifications settings landing pages are not owned by HomeSettings. These will be updated when the Settings app updates their fonts to Google Sans Flex, if that has not happened already.

Bug: 393616497
Test: Verified via hard-coded colors and more obvious fonts that these updates actually change the correct text views.
Flag: com.android.launcher3.gsf_res
Change-Id: I74f66760f0fdb486681a2db55df578c9bf50ef47
2025-03-17 15:01:09 -07:00
Sebastián Franco 92330ddaf7 Merge "Removing ZipRule because it seems to break roboelectric tests" into main 2025-03-17 14:34:15 -07:00
Sebastian Franco a67e735606 Removing ZipRule because it seems to break roboelectric tests
Fix: 402136065
Test: DeviceProfileTest
Test: DeviceProfileDumpTest
Flag: TEST_ONLY
Change-Id: I7c3777ebd725e2acb2511aef3874b031a56bcf1a
2025-03-17 14:33:28 -07:00
Sunny Goyal ff41a8bf66 Only accessing mListeningHolders on main thread
Bug: 402648481
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I037fff805be0b52407ed020e33aeb9db45616dd9
2025-03-17 14:32:04 -07:00
Alex Chau 4a60b862e2 Merge "Update scale on TaskView instead for select mode" into main 2025-03-17 13:12:09 -07:00
Treehugger Robot ab933e6098 Merge "[CD Taskbar] Move DisplayController method calls to BaseTaskbarContext" into main 2025-03-17 12:11:06 -07:00
Siarhei Vishniakou 8dd9181a3d Remove FLAG_SPLIT_TOUCH from launcher code
The splitting behaviour is now permanent, so this flag is deprecated and
it's no longer necessary to set it.

Bug: 239934827
Test: TEST=inputflinger_tests; m $TEST && $ANDROID_HOST_OUT/nativetest64/$TEST/$TEST
Flag: NONE removing flag
Change-Id: Ie7dafaeffdb6f5854a61e6ece0217d8bf5e496af
2025-03-17 11:59:05 -07:00
Shamali Patwa fedb2319af Merge "Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call" into main 2025-03-17 11:19:13 -07:00
Sam Cackett bba7e8af37 Inflate TaskThumbnailViewDeprecated as TaskContentView
If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug
Change-Id: Ie62d4d83d0a16d965820d2a218a44478b660a806
2025-03-17 17:45:34 +00:00