Commit Graph
87505 Commits
Author SHA1 Message Date
Stefan Andonian c91b706df0 Merge "PageIndicatorDot Placement && Arrow Touchboxes." into main 2025-04-03 10:01:36 -07:00
Will Osborn 07f417eabb Merge "Fix for getting Display from ApplicationContext in RotationTouchHelper" into main 2025-04-03 09:38:50 -07:00
minch 38b14021a9 Do not add a stub TaskView unless there is no running TaskView
Do not add a stub TaskView unless there is no running TaskView.
And add the TaskView type checking while getting the running TaskView
from the given [GroupedTaskInfo].

Bug: 407120863
Test: 1. Change to a 3P launcher (e.g., Nova Launcher), clear recents
         task, then swipe up from home screen, verified that
         "No recent items" is shown without having a transparent
         home TaskView.
      2. Drag a window inside the desk to be a fullscreen one,
        then swipe up, verified that it works correctly.
      3. Swiping up from fullscreen or desk tasks works correctly.
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I73f8b3310b4c66fdd3dd9cc5cd95418196279893
2025-04-03 09:37:46 -07:00
Treehugger Robot e1ab1c6214 Merge "pin-shortcut: Move flag to lse" into main 2025-04-03 09:29:51 -07:00
Treehugger Robot 6db46cdf54 Merge "Update title font for single-app & pin widget pickers" into main 2025-04-03 09:25:16 -07:00
Randy Pfohl 0c4afa7542 Merge "Fixing crash when showing blocked by policy message without an activity" into main 2025-04-03 09:13:17 -07:00
Shamali P 14e8c650d5 Update title font for single-app & pin widget pickers
Similar to ag/32643952 (that applied it to main picker)

Bug: 393610557
Fix: 393610557
Flag: com.android.launcher3.gsf_res
Test: on device
Change-Id: Id46985652d16a5572907d051d7a4b47fa2763809
2025-04-03 07:05:28 -07:00
Will Osborn 6329ae849b Fix for getting Display from ApplicationContext in RotationTouchHelper
Bug: b/407878199
Test: local on Tangor + presubmit
Flag: EXEMPT bugfix
Change-Id: Id25b2c179398ff25d2607872d17f494621bfea2e
2025-04-03 13:55:20 +00:00
Ajinkya Chalke daf6fd534a Fix Alt+Tab KQS for projected mode
- Update to show Alt+Tab KQS for phones but only on CD.
- When user triggers Alt+Tab while phone display is in focus, overview
  is triggered - existing behaviour.
- Added back querying taskbar from TaskbarManager when Overview in
  window is disabled.

Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Bug: 407508421
Fix: 407508421
Test: manually ran CUJ
Change-Id: If601055b4dd16b12683c2a80065acf3aaaedd211
2025-04-03 11:26:34 +00:00
Alex Chau 191dda179e Merge "Avoid removing ClearAllButton in split select animation" into main 2025-04-03 02:32:14 -07:00
Vinit Nayak 59904c788e Fix app pair crash
* With the change made in ag/31615582, we assumed
that top level + stage level split roots would always be
included in the transition, that isn't the case when an app pair
is already showing and then we switch to another app pair (stage
roots aren't included since they aren't modified in that scenario)
* Now shell sends the entire tree. Also modified SplitScreenUtils
to consider TRANSIT_CHANGE changes as well for the scenario where
one app of an app pair is already full screen and then we launch an
app pair which has that same app, the stage root there undergoes a change
and not a open/close transition.
* One KI is that the animation doesn't fully work when launching a second
app pair from taskbar when split is already showing (though it is an
improvement from current behavior/animation). This is because when the second
app pair launches, the tasks' snapshot windows/leashes are passed back as
leafs, however these snapshots have not been parented to be under the stage roots.
So both snapshots are positioned at 0, 0 causing overlap. Will fix that in
a followup

Bug: 399037701
Test: Open app pairs from desktop windowing + normal taskbar
Flag: EXEMPT bugfix

Change-Id: I83adffd16fea98b8e877dfbe1ba1ef4a3d08fcb9
2025-04-03 01:00:56 -04:00
Treehugger Robot 343333ce8a Merge "Prefer launching desktop tasks on freeform display" into main 2025-04-02 16:54:41 -07:00
Android Build Coastguard Worker 4bad921a50 Snap for 13304896 from 9ab761e37c to 25Q3-release
Change-Id: I3d643224dce71be0595a350a0c952823ed0b266f
2025-04-02 16:24:32 -07:00
Stefan Andonian 8860d1eca9 PageIndicatorDot Placement && Arrow Touchboxes.
In the previous image tests, the page indicator placement within folders
was inconsistent depending on the number of pages in a folder. This change fixes that by removing the margin_End for the page indicator in folders, as well as fixing the onMeasure call in PageIndicatorDots to be the same as the legacy calculation, just with additional space for the arrows.

Previously, the touchboxes were very small, and difficult to use. To enlarge the touchbox, enlarged padding is used. This means when the indicator & arrows are visible, we need to remove the margin from the layout container and move it to padding for the indicator.

Bug: 394355070
Test: Tested folders with 2, 3, and 18 pages in both left to right
and right to left mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh

Change-Id: I3a5d9d6d77dec963865adede1c4bfe38890d608f
2025-04-02 22:35:35 +00:00
Vadim Tryshev 94a9dca7fc Revert "Demote unstable test testQuickSwitchFromApp from presubmit"
This reverts commit 67c85d8fc2.

Reason for revert: Test is stable

Change-Id: Ie76ff933c2871278ba0a86291ed73c118231cbdc
2025-04-02 14:30:58 -07:00
Treehugger Robot 243e95fd5f Merge "Don't report INSETS_ROUNDED_CORNER on phones" into main 2025-04-02 14:03:28 -07:00
Brian Isganitis c0af778af1 Disable LayoutTransitions for transient taskbar.
Taskbar stashes once an app is launched from taskbar, or remains stashed if you launch something from All Apps. The layout transitions therefore are unlikely to be seen by the user. Disabling them means when the user unstashes, they will see the end result of the transition immediately. The problem with them being enabled for transient taskbar is we set icon alpha to 0 if Taskbar is stashed, which conflicts with the alpha layout transition animation.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 406809935
Test: Manual
Change-Id: Ibcfc04e5c9af104725a69c8cceccef49544d7bd3
2025-04-02 13:21:54 -07:00
Matthew Mourgos df91b22fab Put EnableMouseInteractionChanges behind desktop form factor value
Ensure that the EnableMouseInteractionChanges feature only affects
desktop devices, by adding a check for the desktop_form_factor value.

Flag: com.android.launcher3.enable_mouse_interaction_changes
Bug: 388897603
Test: Manual
Change-Id: I483def8ca249a83e5d028e71db74ec85a700bfb4
2025-04-02 13:16:35 -07:00
Treehugger Robot 8310d2d219 Merge "Dispatch KeyEvents received by the RecentsWindowManager to the LauncherRootView" into main 2025-04-02 12:40:28 -07:00
Jordan Silva f99a50c2e4 Update Overview buttons styles and layout
This CL update the style of Overview Buttons to support Wallpaper Blur feature.
- Overview action button background, padding and spacing updated.
- Clear all button style updated to match action buttons.
- Select button drawable updated.

Bug: 404479758
Fix: 407665072
Flag: com.android.launcher3.enable_overview_desktop_tile_wallpaper_background
Test: OverviewImageTest
Change-Id: I89b781928c4b49155df9dfb5af5e81775ab5b87b
2025-04-02 11:59:25 -07:00
Tony Wickham fdd34cb24a Don't report INSETS_ROUNDED_CORNER on phones
Flag: EXEMPT bugfix
Fixes: 406689798
Test: none (we can add one once we add TaskbarInsetsControllerTest)
Change-Id: I0bba8f39104b7b6d6dbbc4029981fea2988dae50
2025-04-02 18:54:47 +00:00
Randy Pfohl 2638755462 Fixing crash when showing blocked by policy message without an activity
Flag: com.android.launcher3.enable_launcher_overview_in_window

Test: Built locally, no crash

Bug: None/Exempt found and fixed

Change-Id: Ia712c298ae498f34b8bf243d2e754db8339648f1
2025-04-02 17:39:52 +00:00
Sam Dubey 9ab761e37c Merge "Add alint hook to Launcher" into main 2025-04-02 10:05:11 -07:00
Jagrut Desai 1621848c58 Merge "Fix Taskbar offset in launcher" into main 2025-04-02 08:59:01 -07:00
Treehugger Robot 94469d7934 Merge "Change AppChip to work without TTV refactor flag" into main 2025-04-02 08:24:08 -07:00
Pat Manning 09b5b51fbb Merge "Fling cancel at same rate as fling so it is detected by touch controller." into main 2025-04-02 06:34:58 -07:00
Treehugger Robot 22a61d32ca Merge "Translate grid end for tasks after dismiss." into main 2025-04-02 06:08:07 -07:00
Jordan Silva c7006fe3a4 Change AppChip to work without TTV refactor flag
Update the flag condition to load the app chip when the TTV flag is off via `onIconLoaded`. It uses the `TaskViewModel` when TTV flag is on.

Fix: 407947426
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Disable com.android.launcher3.enable_refactor_task_thumbnail.
Change-Id: Ia240f614d1c18f2c32227ee06e82a3fb6b1e080d
2025-04-02 13:57:54 +01:00
My Name 9f97bd6d8f Add alint hook to Launcher
Onboarding the repo for local ayeaye checks via alint.
To enable this will require repo sync.

Test: Locally
Flag: NONE, repo hook change
Bug: 407716895
Change-Id: I2e5e55aec026dc7627aab9f79e468445399a1afb
2025-04-02 05:29:15 -07:00
Pat Manning 394ad82cf9 Translate grid end for tasks after dismiss.
Fix: 389084739
Test: TaplTestsQuickstep#testDismissLastGridRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I5f7785328d0b4b69d6f43cd8bfa68c1504f6ae21
2025-04-02 03:50:49 -07:00
Alex Chau d8f6e839b3 Avoid removing ClearAllButton in split select animation
- When ClearAllButton is removed, lastTaskScroll calculation (which is baserd on clearAllScroll) no longer works, and causes TaskView to snap to wrong position when there are < 5 tasks
- Also avoid showing empty Recents when rotating in split select without any TaskViews

Fix: 407462546
Test: manaul
Flag: EXEMPT bug fix
Change-Id: I4ffd3c43046ab3e11adc2e58b21b4256c4445757
2025-04-02 11:48:53 +01:00
Vinay Joglekar 9c69f3c279 Merge "Apply blur to blur surface only when live tile is drawing below recents." into main 2025-04-02 02:24:55 -07:00
Treehugger Robot 2c9a3508b8 Merge "Layout freeform display taskbar using actual icon sizes" into main 2025-04-02 00:03:22 -07:00
Goooler b1ff82dd73 Migrate deprecated stabilityConfigurationFile 2025-04-02 14:11:42 +08:00
Jeremy Sim 58dbc06b5f Merge "Increase threshhold for hiding one icon menu in Overview" into main 2025-04-01 20:33:49 -07:00
Jagrut Desai cef287164f Fix Taskbar offset in launcher
This cl includes: adding support to stash controller to get device locked state. Use different taskbar offset before and after lock screen.

Test: Manual
Bug: 407589216
Flag: EXEMPT bugfix
Change-Id: I55b27d39049458c741efc9bec365cdbc27d4e012
2025-04-01 17:37:59 -07:00
Android Build Coastguard Worker e1293da290 Snap for 13299163 from f0ab519440 to 25Q3-release
Change-Id: I6647789ab01202ad509c7a70136dab335810e5d7
2025-04-01 16:18:42 -07:00
Wen-Chien Wang 9d962c8c3e pin-shortcut: Move flag to lse
Bug: 375648361
Test: EXEMPT changing flag
Flag: EXEMPT moving flag
Change-Id: I13065db6dcf42e26e87aba27f395e4345c569d6f
2025-04-01 18:29:59 +00:00
Saumya Prakash f0ab519440 Merge "Ensure the back button is visible in SUW for simple view" into main 2025-04-01 10:28:55 -07:00
Andy Wickham 5994d29e20 Merge "Re-adds Workspace behind All Apps and ties to DepthController." into main 2025-04-01 09:59:56 -07:00
Uwais Ashraf bc67694c26 Revert "Also cancel TaskView collection Jobs when Overview is not on screen."
This reverts commit deefa3db71.

Reason for revert: b/406603025

Change-Id: Ifb770dd1e7e38946fe0ee02779dcb315023e392e
2025-04-01 09:39:34 -07:00
vinayjoglekar 8e82c8e354 Apply blur to blur surface only when live tile is drawing below recents.
We were applying blur to blur surface irrespective of whether live tile
is below or above recents. This was causing overhead of native calls due
 to additional reparenting and relayering. These calls are expensive and
  probably responsible for  jank.

Now we will apply blur behind base layer when live tile above recents
and swap surface to leash when below recents.

Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ia01e65253b3062ed2b597977bfd37a44d674e444
2025-04-01 17:34:54 +01:00
Pat Manning cb855eeeaf Fling cancel at same rate as fling so it is detected by touch controller.
Fix: 396447643
Test: TaplTestsQuickstep#testDismissCancel
Flag: EXEMPT bugfix
Change-Id: I1cf3ae6944d4765b54b78a86d4a81af1ed81e661
2025-04-01 09:33:49 -07:00
Pat Manning 8014b50abc Merge "Do not intercept touch on other actions if not enabled in ACTION_DOWN." into main 2025-04-01 09:07:18 -07:00
Eghosa Ewansiha-Vlachavas 34605d8575 [2/n] Isolate desktop entry point disabling from window exemptions
The windowing exemptions logic is used for both exempting apps from
opening in desktop but also hiding the entry point so apps cannot be
moved into desktop. However, disabling desktop entry points is not
constrained by the same security restrictions as exempting apps from
opening as freeform in desktop. Instead we should have a separate
heuristic for disabling entry points and forcing to fullscreen.

Flag: EXEMPT Refactoring
Fixes: 407704088
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest.kt,
      atest NexusLauncherTests:com.android.quickstep.DisplaySystemShortcutTest.kt

Change-Id: I268566072ca5fba090d05f0202468d086c41a66d
2025-04-01 15:24:11 +00:00
Schneider Victor-Tulias 9f75f51a2c Dispatch KeyEvents received by the RecentsWindowManager to the LauncherRootView
- TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey was failing because RecentsWindowManager didn't dispatch key events at all.
- Also moving all LauncherRootView setup to a one-time execution

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 368610710
Bug: 377678992
Test: TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey
Change-Id: I9d8e0c91a549ed08398b2c89b1e4d23561f95c62
2025-04-01 07:31:49 -07:00
Schneider Victor-tulias f311ff67ff Merge changes Ib386c3b8,I2315e0af into main
* changes:
  Fix broken uses of TISBinder.refreshOverviewTarget
  Fix missing TAPL test state checks
2025-04-01 07:26:27 -07:00
Treehugger Robot 181a4b1911 Merge "Initialise and retain TaskViewModel in TaskView's constructor." into main 2025-04-01 06:22:15 -07:00
Pat Manning 3980b03b32 Do not intercept touch on other actions if not enabled in ACTION_DOWN.
Fix: 406405786
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ibd03917a2109307921642a681747709f113e279d
2025-04-01 12:22:34 +01:00
Uwais Ashraf e65743b7de Initialise and retain TaskViewModel in TaskView's constructor.
This means that the VMs are created on the bg threads in the ViewPool setup stage rather than at critical points in CUJs.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I3aab5271d552e5f292533617a6842a046cb43bf1
2025-04-01 11:11:36 +00:00